Resolve -Wtautological-undefined-compare when building with clang

Comparing 'this' to 'nullptr' will always evaluate to false. clang and gcc optimize away the check entirely, removing the checks silences the warnings. https://clang.llvm.org/docs/DiagnosticsReference.html#wtautological-undefined-compare
This commit is contained in:
Elliot 2024-10-28 11:26:59 -04:00
parent e00c4a7c85
commit 5f826f3239

View File

@ -9312,11 +9312,6 @@ void Allocation::SetName(LPCWSTR Name)
void Allocation::ReleaseThis() void Allocation::ReleaseThis()
{ {
if (this == NULL)
{
return;
}
SAFE_RELEASE(m_Resource); SAFE_RELEASE(m_Resource);
switch (m_PackedData.GetType()) switch (m_PackedData.GetType())
@ -9461,11 +9456,6 @@ void DefragmentationContext::GetStats(DEFRAGMENTATION_STATS* pStats)
void DefragmentationContext::ReleaseThis() void DefragmentationContext::ReleaseThis()
{ {
if (this == NULL)
{
return;
}
D3D12MA_DELETE(m_Pimpl->GetAllocs(), this); D3D12MA_DELETE(m_Pimpl->GetAllocs(), this);
} }
@ -9526,11 +9516,6 @@ HRESULT Pool::BeginDefragmentation(const DEFRAGMENTATION_DESC* pDesc, Defragment
void Pool::ReleaseThis() void Pool::ReleaseThis()
{ {
if (this == NULL)
{
return;
}
D3D12MA_DELETE(m_Pimpl->GetAllocator()->GetAllocs(), this); D3D12MA_DELETE(m_Pimpl->GetAllocator()->GetAllocs(), this);
} }