AuroraMiddleware/D3D12MemoryAllocator
1
0
Fork 0
mirror of https://github.com/GPUOpen-LibrariesAndSDKs/D3D12MemoryAllocator.git synced 2024-11-21 19:50:05 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #18 from danielkrupinski/master

Browse Source 
Do not define empty non-virtual destructors
This commit is contained in:
Adam Sawicki 2021-09-16 19:22:53 +02:00 committed by GitHub
commit f50f65dcde
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/D3D12MemAlloc.cpp
View File

@ -1553,7 +1553,11 @@ public:
// allocationCallbacks externally owned, must outlive this object.
List(const ALLOCATION_CALLBACKS& allocationCallbacks);
~List();
// Intentionally not calling Clear, because that would be unnecessary
// computations to return all items to m_ItemAllocator as free.
// ~List() {}
void Clear();
size_t GetCount() const { return m_Count; }
@ -1776,13 +1780,6 @@ List<T>::List(const ALLOCATION_CALLBACKS& allocationCallbacks) :
{
}
template<typename T>
List<T>::~List()
{
// Intentionally not calling Clear, because that would be unnecessary
// computations to return all items to m_ItemAllocator as free.
}
template<typename T>
void List<T>::Clear()
{
@ -6002,11 +5999,6 @@ Allocation::Allocation(AllocatorPimpl* allocator, UINT64 size, BOOL wasZeroIniti
m_PackedData.SetWasZeroInitialized(wasZeroInitialized);
}
Allocation::~Allocation()
{
// Nothing here, everything already done in Release.
}
void Allocation::InitCommitted(CommittedAllocationList* list)
{
m_PackedData.SetType(TYPE_COMMITTED);
@ -6311,7 +6303,6 @@ public:
BlockMetadata_Generic m_Metadata;
VirtualBlockPimpl(const ALLOCATION_CALLBACKS& allocationCallbacks, UINT64 size);
~VirtualBlockPimpl();
};
VirtualBlockPimpl::VirtualBlockPimpl(const ALLOCATION_CALLBACKS& allocationCallbacks, UINT64 size) :
@ -6323,10 +6314,6 @@ VirtualBlockPimpl::VirtualBlockPimpl(const ALLOCATION_CALLBACKS& allocationCallb
m_Metadata.Init(m_Size);
}
VirtualBlockPimpl::~VirtualBlockPimpl()
{
}
////////////////////////////////////////////////////////////////////////////////
// Public class VirtualBlock implementation

4
src/D3D12MemAlloc.h
View File

@ -401,7 +401,9 @@ private:
} m_PackedData;
Allocation(AllocatorPimpl* allocator, UINT64 size, BOOL wasZeroInitialized);
~Allocation();
// Nothing here, everything already done in Release.
// ~Allocation() {}
void InitCommitted(CommittedAllocationList* list);
void InitPlaced(UINT64 offset, UINT64 alignment, NormalBlock* block);
void InitHeap(CommittedAllocationList* list, ID3D12Heap* heap);