From 5f826f3239344d4f0b61e3379aaa15c97dca7e67 Mon Sep 17 00:00:00 2001 From: Elliot Date: Mon, 28 Oct 2024 11:26:59 -0400 Subject: [PATCH] Resolve -Wtautological-undefined-compare when building with clang Comparing 'this' to 'nullptr' will always evaluate to false. clang and gcc optimize away the check entirely, removing the checks silences the warnings. https://clang.llvm.org/docs/DiagnosticsReference.html#wtautological-undefined-compare --- src/D3D12MemAlloc.cpp | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/src/D3D12MemAlloc.cpp b/src/D3D12MemAlloc.cpp index fecc28c..4b85b11 100644 --- a/src/D3D12MemAlloc.cpp +++ b/src/D3D12MemAlloc.cpp @@ -9312,11 +9312,6 @@ void Allocation::SetName(LPCWSTR Name) void Allocation::ReleaseThis() { - if (this == NULL) - { - return; - } - SAFE_RELEASE(m_Resource); switch (m_PackedData.GetType()) @@ -9461,11 +9456,6 @@ void DefragmentationContext::GetStats(DEFRAGMENTATION_STATS* pStats) void DefragmentationContext::ReleaseThis() { - if (this == NULL) - { - return; - } - D3D12MA_DELETE(m_Pimpl->GetAllocs(), this); } @@ -9526,11 +9516,6 @@ HRESULT Pool::BeginDefragmentation(const DEFRAGMENTATION_DESC* pDesc, Defragment void Pool::ReleaseThis() { - if (this == NULL) - { - return; - } - D3D12MA_DELETE(m_Pimpl->GetAllocator()->GetAllocs(), this); }