AuroraMiddleware/OpenSubdiv
1
0
Fork 0
mirror of https://github.com/PixarAnimationStudios/OpenSubdiv synced 2024-11-13 23:50:09 +00:00
Code Issues Releases Wiki Activity
1abe8a7087
OpenSubdiv/regression/hbr_regression/init_shapes.h

118 lines
6.7 KiB
C
Raw Normal View History

First pass at an hbr regression test : - generate baseline data with the new hbr_baseline tool - run the a regression of the current hbr code over the baseline data-set with hbr_regression There is still some cleanup to do to generalize some of the "shape" code as our intermediate obj-like file format is unfortunately entrenching itself (we should really be using RIB...) There is also a fair amounto f copy/pasted stuff in the regression code that needs to be refactored Closes #32
2012-08-17 23:58:01 +00:00
//
Amending Apache license language & file headers. New text: Copyright 2013 Pixar Licensed under the Apache License, Version 2.0 (the "Apache License") with the following modification; you may not use this file except in compliance with the Apache License and the following modification to it: Section 6. Trademarks. is deleted and replaced with: 6. Trademarks. This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor and its affiliates, except as required to comply with Section 4(c) of the License and to reproduce the content of the NOTICE file. You may obtain a copy of the Apache License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the Apache License with the above modification is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the Apache License for the specific language governing permissions and limitations under the Apache License.
2013-09-26 19:04:57 +00:00
// Copyright 2013 Pixar
First pass at an hbr regression test : - generate baseline data with the new hbr_baseline tool - run the a regression of the current hbr code over the baseline data-set with hbr_regression There is still some cleanup to do to generalize some of the "shape" code as our intermediate obj-like file format is unfortunately entrenching itself (we should really be using RIB...) There is also a fair amounto f copy/pasted stuff in the regression code that needs to be refactored Closes #32
2012-08-17 23:58:01 +00:00
//
Amending Apache license language & file headers. New text: Copyright 2013 Pixar Licensed under the Apache License, Version 2.0 (the "Apache License") with the following modification; you may not use this file except in compliance with the Apache License and the following modification to it: Section 6. Trademarks. is deleted and replaced with: 6. Trademarks. This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor and its affiliates, except as required to comply with Section 4(c) of the License and to reproduce the content of the NOTICE file. You may obtain a copy of the Apache License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the Apache License with the above modification is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the Apache License for the specific language governing permissions and limitations under the Apache License.
2013-09-26 19:04:57 +00:00
// Licensed under the Apache License, Version 2.0 (the "Apache License")
// with the following modification; you may not use this file except in
// compliance with the Apache License and the following modification to it:
// Section 6. Trademarks. is deleted and replaced with:
First pass at an hbr regression test : - generate baseline data with the new hbr_baseline tool - run the a regression of the current hbr code over the baseline data-set with hbr_regression There is still some cleanup to do to generalize some of the "shape" code as our intermediate obj-like file format is unfortunately entrenching itself (we should really be using RIB...) There is also a fair amounto f copy/pasted stuff in the regression code that needs to be refactored Closes #32
2012-08-17 23:58:01 +00:00
//
Amending Apache license language & file headers. New text: Copyright 2013 Pixar Licensed under the Apache License, Version 2.0 (the "Apache License") with the following modification; you may not use this file except in compliance with the Apache License and the following modification to it: Section 6. Trademarks. is deleted and replaced with: 6. Trademarks. This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor and its affiliates, except as required to comply with Section 4(c) of the License and to reproduce the content of the NOTICE file. You may obtain a copy of the Apache License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the Apache License with the above modification is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the Apache License for the specific language governing permissions and limitations under the Apache License.
2013-09-26 19:04:57 +00:00
// 6. Trademarks. This License does not grant permission to use the trade
// names, trademarks, service marks, or product names of the Licensor
// and its affiliates, except as required to comply with Section 4(c) of
// the License and to reproduce the content of the NOTICE file.
First pass at an hbr regression test : - generate baseline data with the new hbr_baseline tool - run the a regression of the current hbr code over the baseline data-set with hbr_regression There is still some cleanup to do to generalize some of the "shape" code as our intermediate obj-like file format is unfortunately entrenching itself (we should really be using RIB...) There is also a fair amounto f copy/pasted stuff in the regression code that needs to be refactored Closes #32
2012-08-17 23:58:01 +00:00
//
Amending Apache license language & file headers. New text: Copyright 2013 Pixar Licensed under the Apache License, Version 2.0 (the "Apache License") with the following modification; you may not use this file except in compliance with the Apache License and the following modification to it: Section 6. Trademarks. is deleted and replaced with: 6. Trademarks. This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor and its affiliates, except as required to comply with Section 4(c) of the License and to reproduce the content of the NOTICE file. You may obtain a copy of the Apache License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the Apache License with the above modification is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the Apache License for the specific language governing permissions and limitations under the Apache License.
2013-09-26 19:04:57 +00:00
// You may obtain a copy of the Apache License at
First pass at an hbr regression test : - generate baseline data with the new hbr_baseline tool - run the a regression of the current hbr code over the baseline data-set with hbr_regression There is still some cleanup to do to generalize some of the "shape" code as our intermediate obj-like file format is unfortunately entrenching itself (we should really be using RIB...) There is also a fair amounto f copy/pasted stuff in the regression code that needs to be refactored Closes #32
2012-08-17 23:58:01 +00:00
//
Amending Apache license language & file headers. New text: Copyright 2013 Pixar Licensed under the Apache License, Version 2.0 (the "Apache License") with the following modification; you may not use this file except in compliance with the Apache License and the following modification to it: Section 6. Trademarks. is deleted and replaced with: 6. Trademarks. This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor and its affiliates, except as required to comply with Section 4(c) of the License and to reproduce the content of the NOTICE file. You may obtain a copy of the Apache License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the Apache License with the above modification is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the Apache License for the specific language governing permissions and limitations under the Apache License.
2013-09-26 19:04:57 +00:00
// http://www.apache.org/licenses/LICENSE-2.0
Updating EULA
2013-07-18 21:19:50 +00:00
//
Amending Apache license language & file headers. New text: Copyright 2013 Pixar Licensed under the Apache License, Version 2.0 (the "Apache License") with the following modification; you may not use this file except in compliance with the Apache License and the following modification to it: Section 6. Trademarks. is deleted and replaced with: 6. Trademarks. This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor and its affiliates, except as required to comply with Section 4(c) of the License and to reproduce the content of the NOTICE file. You may obtain a copy of the Apache License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the Apache License with the above modification is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the Apache License for the specific language governing permissions and limitations under the Apache License.
2013-09-26 19:04:57 +00:00
// Unless required by applicable law or agreed to in writing, software
// distributed under the Apache License with the above modification is
// distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the Apache License for the specific
// language governing permissions and limitations under the Apache License.
First pass at an hbr regression test : - generate baseline data with the new hbr_baseline tool - run the a regression of the current hbr code over the baseline data-set with hbr_regression There is still some cleanup to do to generalize some of the "shape" code as our intermediate obj-like file format is unfortunately entrenching itself (we should really be using RIB...) There is also a fair amounto f copy/pasted stuff in the regression code that needs to be refactored Closes #32
2012-08-17 23:58:01 +00:00
//
Amending Apache license language & file headers. New text: Copyright 2013 Pixar Licensed under the Apache License, Version 2.0 (the "Apache License") with the following modification; you may not use this file except in compliance with the Apache License and the following modification to it: Section 6. Trademarks. is deleted and replaced with: 6. Trademarks. This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor and its affiliates, except as required to comply with Section 4(c) of the License and to reproduce the content of the NOTICE file. You may obtain a copy of the Apache License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the Apache License with the above modification is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the Apache License for the specific language governing permissions and limitations under the Apache License.
2013-09-26 19:04:57 +00:00
First pass at an hbr regression test : - generate baseline data with the new hbr_baseline tool - run the a regression of the current hbr code over the baseline data-set with hbr_regression There is still some cleanup to do to generalize some of the "shape" code as our intermediate obj-like file format is unfortunately entrenching itself (we should really be using RIB...) There is also a fair amounto f copy/pasted stuff in the regression code that needs to be refactored Closes #32
2012-08-17 23:58:01 +00:00
#include "../common/shape_utils.h"
struct shaperec {
use std::string instead of char* for regression shapes definition, to avoid MSVC's literal length limitation on some big shapes.
2013-03-19 21:41:49 +00:00
shaperec(char const * iname, std::string const & idata, Scheme ischeme) :
First pass at an hbr regression test : - generate baseline data with the new hbr_baseline tool - run the a regression of the current hbr code over the baseline data-set with hbr_regression There is still some cleanup to do to generalize some of the "shape" code as our intermediate obj-like file format is unfortunately entrenching itself (we should really be using RIB...) There is also a fair amounto f copy/pasted stuff in the regression code that needs to be refactored Closes #32
2012-08-17 23:58:01 +00:00
name(iname), data(idata), scheme(ischeme) { }
Landing 3.0.0.alpha Sync'ing the 'dev' branch with the 'feature_3.0dev' branch at commit 68c6d11fc36761ae1a5e6cdc3457be16f2e9704a The branch 'feature_3.0dev' is now locked and preserved for historical purposes.
2014-09-05 22:07:46 +00:00
First pass at an hbr regression test : - generate baseline data with the new hbr_baseline tool - run the a regression of the current hbr code over the baseline data-set with hbr_regression There is still some cleanup to do to generalize some of the "shape" code as our intermediate obj-like file format is unfortunately entrenching itself (we should really be using RIB...) There is also a fair amounto f copy/pasted stuff in the regression code that needs to be refactored Closes #32
2012-08-17 23:58:01 +00:00
std::string name,
data;
Scheme scheme;
};
static std::vector<shaperec> g_shapes;
#include "../shapes/bilinear_cube.h"
Fix Chaikin rule The Chaikin crease interpolation mode seems to be broken: - Catmark / Loop / Bilinear are passing the wrong halfedge vertex to the SubdivideCreaseWeight function which results in sub-edge crease weights being swapped - the loop that iterates over adjacent edges needs to check against both the original edge and its opposite, otherwise it may be incorrectly accumulated into summation of these adjacent edges (with a 0.25 weight) The proposed fix: - Swaps the Dest/Org vertex passed to the SubdivideCreaseWeight (and we probably want Julian to confirm that this the correct fix) - Checks against both the original edge and its opposite in the iteration over adjacent edges - Replaces the std::vector based query with an HbrHalfedgeOperator for better performance (hopefully) The similar fix to OpenSubdiv been reviewed by Tony DeRose. Also in the fix: - fix "obj" tag parsing of the smooth triangle tag that was incorrectly associated with the crease method (and reporting the wrong errors) - add regression shapes for both Loop & Catmark schemes to hbr_regression - add same shapes to the glViewer - improve hbr_regression output to be more readable - add command-line argument parsing to hbr_regression - add functionality to dump an obj file when regression fails for comparison fixes #235
2013-11-08 01:06:55 +00:00
#include "../shapes/catmark_chaikin0.h"
#include "../shapes/catmark_chaikin1.h"
First pass at an hbr regression test : - generate baseline data with the new hbr_baseline tool - run the a regression of the current hbr code over the baseline data-set with hbr_regression There is still some cleanup to do to generalize some of the "shape" code as our intermediate obj-like file format is unfortunately entrenching itself (we should really be using RIB...) There is also a fair amounto f copy/pasted stuff in the regression code that needs to be refactored Closes #32
2012-08-17 23:58:01 +00:00
#include "../shapes/catmark_cube_corner0.h"
#include "../shapes/catmark_cube_corner1.h"
#include "../shapes/catmark_cube_corner2.h"
#include "../shapes/catmark_cube_corner3.h"
#include "../shapes/catmark_cube_corner4.h"
#include "../shapes/catmark_cube_creases0.h"
#include "../shapes/catmark_cube_creases1.h"
#include "../shapes/catmark_cube.h"
#include "../shapes/catmark_dart_edgecorner.h"
#include "../shapes/catmark_dart_edgeonly.h"
#include "../shapes/catmark_edgecorner.h"
#include "../shapes/catmark_edgeonly.h"
A quad face with 2 non-consecutive boundary edges causes the 4 vertices of this quad to be tagged as boundary. These vertices will cause the feature adaptive pass to generate sub-faces where appropriate, however the face itself will not be identified as "non-patch", which causes the FarPatchTables factory to mis-identify it and fall-back on an assert. This fix flags these particular quad faces in the first adaptive pass. The particular shape that caused the crash has also been addded to our regression suite. fixes #159
2013-05-03 02:37:34 +00:00
#include "../shapes/catmark_flap.h"
fix incorrect patch generation for patches with 2 non-consecutive boundary edges add catmark_flap2 shape & baseline to regression suite fixes #188
2013-07-09 01:13:44 +00:00
#include "../shapes/catmark_flap2.h"
First pass at an hbr regression test : - generate baseline data with the new hbr_baseline tool - run the a regression of the current hbr code over the baseline data-set with hbr_regression There is still some cleanup to do to generalize some of the "shape" code as our intermediate obj-like file format is unfortunately entrenching itself (we should really be using RIB...) There is also a fair amounto f copy/pasted stuff in the regression code that needs to be refactored Closes #32
2012-08-17 23:58:01 +00:00
#include "../shapes/catmark_pyramid_creases0.h"
#include "../shapes/catmark_pyramid_creases1.h"
#include "../shapes/catmark_pyramid.h"
#include "../shapes/catmark_square_hedit0.h"
#include "../shapes/catmark_square_hedit1.h"
#include "../shapes/catmark_square_hedit2.h"
#include "../shapes/catmark_square_hedit3.h"
#include "../shapes/catmark_tent_creases0.h"
#include "../shapes/catmark_tent_creases1.h"
#include "../shapes/catmark_tent.h"
#include "../shapes/loop_cube_creases0.h"
#include "../shapes/loop_cube_creases1.h"
#include "../shapes/loop_cube.h"
#include "../shapes/loop_icosahedron.h"
#include "../shapes/loop_saddle_edgecorner.h"
#include "../shapes/loop_saddle_edgeonly.h"
#include "../shapes/loop_triangle_edgecorner.h"
#include "../shapes/loop_triangle_edgeonly.h"
Fix Chaikin rule The Chaikin crease interpolation mode seems to be broken: - Catmark / Loop / Bilinear are passing the wrong halfedge vertex to the SubdivideCreaseWeight function which results in sub-edge crease weights being swapped - the loop that iterates over adjacent edges needs to check against both the original edge and its opposite, otherwise it may be incorrectly accumulated into summation of these adjacent edges (with a 0.25 weight) The proposed fix: - Swaps the Dest/Org vertex passed to the SubdivideCreaseWeight (and we probably want Julian to confirm that this the correct fix) - Checks against both the original edge and its opposite in the iteration over adjacent edges - Replaces the std::vector based query with an HbrHalfedgeOperator for better performance (hopefully) The similar fix to OpenSubdiv been reviewed by Tony DeRose. Also in the fix: - fix "obj" tag parsing of the smooth triangle tag that was incorrectly associated with the crease method (and reporting the wrong errors) - add regression shapes for both Loop & Catmark schemes to hbr_regression - add same shapes to the glViewer - improve hbr_regression output to be more readable - add command-line argument parsing to hbr_regression - add functionality to dump an obj file when regression fails for comparison fixes #235
2013-11-08 01:06:55 +00:00
#include "../shapes/loop_chaikin0.h"
#include "../shapes/loop_chaikin1.h"
First pass at an hbr regression test : - generate baseline data with the new hbr_baseline tool - run the a regression of the current hbr code over the baseline data-set with hbr_regression There is still some cleanup to do to generalize some of the "shape" code as our intermediate obj-like file format is unfortunately entrenching itself (we should really be using RIB...) There is also a fair amounto f copy/pasted stuff in the regression code that needs to be refactored Closes #32
2012-08-17 23:58:01 +00:00
//------------------------------------------------------------------------------
static void initShapes() {
g_shapes.push_back( shaperec("bilinear_cube", bilinear_cube, kBilinear) );
Fix Chaikin rule The Chaikin crease interpolation mode seems to be broken: - Catmark / Loop / Bilinear are passing the wrong halfedge vertex to the SubdivideCreaseWeight function which results in sub-edge crease weights being swapped - the loop that iterates over adjacent edges needs to check against both the original edge and its opposite, otherwise it may be incorrectly accumulated into summation of these adjacent edges (with a 0.25 weight) The proposed fix: - Swaps the Dest/Org vertex passed to the SubdivideCreaseWeight (and we probably want Julian to confirm that this the correct fix) - Checks against both the original edge and its opposite in the iteration over adjacent edges - Replaces the std::vector based query with an HbrHalfedgeOperator for better performance (hopefully) The similar fix to OpenSubdiv been reviewed by Tony DeRose. Also in the fix: - fix "obj" tag parsing of the smooth triangle tag that was incorrectly associated with the crease method (and reporting the wrong errors) - add regression shapes for both Loop & Catmark schemes to hbr_regression - add same shapes to the glViewer - improve hbr_regression output to be more readable - add command-line argument parsing to hbr_regression - add functionality to dump an obj file when regression fails for comparison fixes #235
2013-11-08 01:06:55 +00:00
g_shapes.push_back( shaperec("catmark_chaikin0", catmark_chaikin0, kCatmark ) );
g_shapes.push_back( shaperec("catmark_chaikin1", catmark_chaikin1, kCatmark ) );
First pass at an hbr regression test : - generate baseline data with the new hbr_baseline tool - run the a regression of the current hbr code over the baseline data-set with hbr_regression There is still some cleanup to do to generalize some of the "shape" code as our intermediate obj-like file format is unfortunately entrenching itself (we should really be using RIB...) There is also a fair amounto f copy/pasted stuff in the regression code that needs to be refactored Closes #32
2012-08-17 23:58:01 +00:00
g_shapes.push_back( shaperec("catmark_cube_corner0", catmark_cube_corner0, kCatmark ) );
g_shapes.push_back( shaperec("catmark_cube_corner1", catmark_cube_corner1, kCatmark ) );
g_shapes.push_back( shaperec("catmark_cube_corner2", catmark_cube_corner2, kCatmark ) );
g_shapes.push_back( shaperec("catmark_cube_corner3", catmark_cube_corner3, kCatmark ) );
g_shapes.push_back( shaperec("catmark_cube_corner4", catmark_cube_corner4, kCatmark ) );
g_shapes.push_back( shaperec("catmark_cube_creases0", catmark_cube_creases0, kCatmark ) );
g_shapes.push_back( shaperec("catmark_cube_creases1", catmark_cube_creases1, kCatmark ) );
g_shapes.push_back( shaperec("catmark_cube", catmark_cube, kCatmark ) );
g_shapes.push_back( shaperec("catmark_dart_edgecorner", catmark_dart_edgecorner, kCatmark ) );
g_shapes.push_back( shaperec("catmark_dart_edgeonly", catmark_dart_edgeonly, kCatmark ) );
g_shapes.push_back( shaperec("catmark_edgecorner", catmark_edgecorner, kCatmark ) );
g_shapes.push_back( shaperec("catmark_edgeonly", catmark_edgeonly, kCatmark ) );
A quad face with 2 non-consecutive boundary edges causes the 4 vertices of this quad to be tagged as boundary. These vertices will cause the feature adaptive pass to generate sub-faces where appropriate, however the face itself will not be identified as "non-patch", which causes the FarPatchTables factory to mis-identify it and fall-back on an assert. This fix flags these particular quad faces in the first adaptive pass. The particular shape that caused the crash has also been addded to our regression suite. fixes #159
2013-05-03 02:37:34 +00:00
g_shapes.push_back( shaperec("catmark_flap", catmark_flap, kCatmark ) );
fix incorrect patch generation for patches with 2 non-consecutive boundary edges add catmark_flap2 shape & baseline to regression suite fixes #188
2013-07-09 01:13:44 +00:00
g_shapes.push_back( shaperec("catmark_flap2", catmark_flap2, kCatmark ) );
First pass at an hbr regression test : - generate baseline data with the new hbr_baseline tool - run the a regression of the current hbr code over the baseline data-set with hbr_regression There is still some cleanup to do to generalize some of the "shape" code as our intermediate obj-like file format is unfortunately entrenching itself (we should really be using RIB...) There is also a fair amounto f copy/pasted stuff in the regression code that needs to be refactored Closes #32
2012-08-17 23:58:01 +00:00
g_shapes.push_back( shaperec("catmark_pyramid_creases0", catmark_pyramid_creases0, kCatmark ) );
g_shapes.push_back( shaperec("catmark_pyramid_creases1", catmark_pyramid_creases1, kCatmark ) );
g_shapes.push_back( shaperec("catmark_pyramid", catmark_pyramid, kCatmark ) );
g_shapes.push_back( shaperec("catmark_square_hedit0", catmark_square_hedit0, kCatmark ) );
g_shapes.push_back( shaperec("catmark_square_hedit1", catmark_square_hedit1, kCatmark ) );
g_shapes.push_back( shaperec("catmark_square_hedit2", catmark_square_hedit2, kCatmark ) );
g_shapes.push_back( shaperec("catmark_square_hedit3", catmark_square_hedit3, kCatmark ) );
g_shapes.push_back( shaperec("catmark_tent_creases0", catmark_tent_creases0, kCatmark ) );
g_shapes.push_back( shaperec("catmark_tent_creases1", catmark_tent_creases1 , kCatmark ) );
g_shapes.push_back( shaperec("catmark_tent", catmark_tent, kCatmark ) );
g_shapes.push_back( shaperec("loop_cube_creases0", loop_cube_creases0, kLoop ) );
g_shapes.push_back( shaperec("loop_cube_creases1", loop_cube_creases1, kLoop ) );
g_shapes.push_back( shaperec("loop_cube", loop_cube, kLoop ) );
g_shapes.push_back( shaperec("loop_icosahedron", loop_icosahedron, kLoop ) );
g_shapes.push_back( shaperec("loop_saddle_edgecorner", loop_saddle_edgecorner, kLoop ) );
g_shapes.push_back( shaperec("loop_saddle_edgeonly", loop_saddle_edgeonly, kLoop ) );
g_shapes.push_back( shaperec("loop_triangle_edgecorner", loop_triangle_edgecorner, kLoop ) );
g_shapes.push_back( shaperec("loop_triangle_edgeonly", loop_triangle_edgeonly, kLoop ) );
Fix Chaikin rule The Chaikin crease interpolation mode seems to be broken: - Catmark / Loop / Bilinear are passing the wrong halfedge vertex to the SubdivideCreaseWeight function which results in sub-edge crease weights being swapped - the loop that iterates over adjacent edges needs to check against both the original edge and its opposite, otherwise it may be incorrectly accumulated into summation of these adjacent edges (with a 0.25 weight) The proposed fix: - Swaps the Dest/Org vertex passed to the SubdivideCreaseWeight (and we probably want Julian to confirm that this the correct fix) - Checks against both the original edge and its opposite in the iteration over adjacent edges - Replaces the std::vector based query with an HbrHalfedgeOperator for better performance (hopefully) The similar fix to OpenSubdiv been reviewed by Tony DeRose. Also in the fix: - fix "obj" tag parsing of the smooth triangle tag that was incorrectly associated with the crease method (and reporting the wrong errors) - add regression shapes for both Loop & Catmark schemes to hbr_regression - add same shapes to the glViewer - improve hbr_regression output to be more readable - add command-line argument parsing to hbr_regression - add functionality to dump an obj file when regression fails for comparison fixes #235
2013-11-08 01:06:55 +00:00
g_shapes.push_back( shaperec("loop_chaikin0", loop_chaikin0, kLoop ) );
g_shapes.push_back( shaperec("loop_chaikin1", loop_chaikin1, kLoop ) );
First pass at an hbr regression test : - generate baseline data with the new hbr_baseline tool - run the a regression of the current hbr code over the baseline data-set with hbr_regression There is still some cleanup to do to generalize some of the "shape" code as our intermediate obj-like file format is unfortunately entrenching itself (we should really be using RIB...) There is also a fair amounto f copy/pasted stuff in the regression code that needs to be refactored Closes #32
2012-08-17 23:58:01 +00:00
}
//------------------------------------------------------------------------------
Reference in New Issue Copy Permalink