AuroraMiddleware/OpenSubdiv
1
0
Fork 0
mirror of https://github.com/PixarAnimationStudios/OpenSubdiv synced 2025-01-03 05:31:12 +00:00
Code Issues Releases Wiki Activity

Fix address sanitizer warnings with stencil table casting

Browse Source 
For compatibility, StencilTableReal<float> is cast to StencilTable, which has
the same data layout but it's not actually an instance of that class. And so
using static_cast is not strictly correct. Use reinterpret_cast instead.
This commit is contained in:
Brecht Van Lommel 2024-12-13 02:31:45 +01:00
parent 7d0ab5530f
commit 2a1dd46bbd
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
opensubdiv/far/patchTable.h
View File

@ -777,19 +777,19 @@ PatchTable::LocalPointFaceVaryingStencilPrecisionMatchesType<double>() const {
inline StencilTable const *
PatchTable::GetLocalPointStencilTable() const {
assert(LocalPointStencilPrecisionMatchesType<float>());
return static_cast<StencilTable const *>(_localPointStencils.Get<float>());
return reinterpret_cast<StencilTable const *>(_localPointStencils.Get<float>());
}
inline StencilTable const *
PatchTable::GetLocalPointVaryingStencilTable() const {
assert(LocalPointVaryingStencilPrecisionMatchesType<float>());
return static_cast<StencilTable const *>(
return reinterpret_cast<StencilTable const *>(
_localPointVaryingStencils.Get<float>());
}
inline StencilTable const *
PatchTable::GetLocalPointFaceVaryingStencilTable(int channel) const {
assert(LocalPointFaceVaryingStencilPrecisionMatchesType<float>());
if (channel >= 0 && channel < (int)_localPointFaceVaryingStencils.size()) {
return static_cast<StencilTable const *>(
return reinterpret_cast<StencilTable const *>(
_localPointFaceVaryingStencils[channel].Get<float>());
}
return NULL;

12
opensubdiv/far/stencilTableFactory.h
View File

@ -293,14 +293,14 @@ public:
static StencilTable const * Create(
TopologyRefiner const & refiner, Options options = Options()) {
return static_cast<StencilTable const *>(
return reinterpret_cast<StencilTable const *>(
BaseFactory::Create(refiner, options));
}
static StencilTable const * Create(
int numTables, StencilTable const ** tables) {
return static_cast<StencilTable const *>(
return reinterpret_cast<StencilTable const *>(
BaseFactory::Create(numTables,
reinterpret_cast<BaseTable const **>(tables)));
}
@ -311,7 +311,7 @@ public:
StencilTable const *localPointStencilTable,
bool factorize = true) {
return static_cast<StencilTable const *>(
return reinterpret_cast<StencilTable const *>(
BaseFactory::AppendLocalPointStencilTable(refiner,
static_cast<BaseTable const *>(baseStencilTable),
static_cast<BaseTable const *>(localPointStencilTable),
@ -324,7 +324,7 @@ public:
StencilTable const *localPointStencilTable,
bool factorize = true) {
return static_cast<StencilTable const *>(
return reinterpret_cast<StencilTable const *>(
BaseFactory::AppendLocalPointStencilTableVarying(refiner,
static_cast<BaseTable const *>(baseStencilTable),
static_cast<BaseTable const *>(localPointStencilTable),
@ -338,7 +338,7 @@ public:
int channel = 0,
bool factorize = true) {
return static_cast<StencilTable const *>(
return reinterpret_cast<StencilTable const *>(
BaseFactory::AppendLocalPointStencilTableFaceVarying(refiner,
static_cast<BaseTable const *>(baseStencilTable),
static_cast<BaseTable const *>(localPointStencilTable),
@ -364,7 +364,7 @@ public:
PatchTable const * patchTable = 0,
Options options = Options()) {
return static_cast<LimitStencilTable const *>(
return reinterpret_cast<LimitStencilTable const *>(
BaseFactory::Create(
refiner,
locationArrays,