From a1f13b47677195aedf0afd4a8b07fead4ff66904 Mon Sep 17 00:00:00 2001
From: David G Yu <davidgyu@gmail.com>
Date: Fri, 25 Aug 2023 09:04:54 -0700
Subject: [PATCH] Fixed inconsistent warning levels for MSVC builds

The MSVC build has been setting /W3 as an override for /Wall but this
has been causing generator specfic build inconsistencies.

For examples, this override works when using the Visual Studio generators,
but not when using the Ninja generator. This causes Ninja to build using
/Wall instead of /W3.

This removes the initial setting of /Wall to avoid this inconsistency.

We plan to continue to address compiler warnings to allow us to raise
this warning level further but that is a separate task.
---
 CMakeLists.txt | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index a7da6b25..190e0685 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -242,9 +242,6 @@ if (CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_CLANGCC OR CMAKE_COMPILER_IS_IC
 
 elseif(MSVC)
 
-    # Turn on all warnings
-    list(APPEND OSD_COMPILER_FLAGS /Wall)
-
     list(APPEND OSD_COMPILER_FLAGS
                     /W3     # Use warning level recommended for production purposes.
                     /WX     # Treat all compiler warnings as errors.