From ad007c076afa041997069342f3c879df14078837 Mon Sep 17 00:00:00 2001 From: Thomas Thomassen Date: Tue, 29 Nov 2022 20:18:33 +0100 Subject: [PATCH] Corrections to allow for LLVM Clang builds on Windows. --- CMakeLists.txt | 9 +++++++++ examples/common/stopwatch.h | 6 +++--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 8616b2f2..223f347e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -171,6 +171,15 @@ if (CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_CLANGCC OR CMAKE_COMPILER_IS_IC list(APPEND OSD_COMPILER_FLAGS -Wall -Wextra) endif() + if(WIN32) + # Make sure the constants in / get defined. + list(APPEND OSD_COMPILER_FLAGS -D_USE_MATH_DEFINES) + + # Make sure WinDef.h does not define min and max macros which + # will conflict with std::min() and std::max(). + list(APPEND OSD_COMPILER_FLAGS -DNOMINMAX) + endif() + # HBR uses the offsetof macro on a templated struct, which appears # to spuriously set off this warning in both gcc and Clang list(APPEND OSD_COMPILER_FLAGS -Wno-invalid-offsetof) diff --git a/examples/common/stopwatch.h b/examples/common/stopwatch.h index ef797cc2..4c905ed3 100644 --- a/examples/common/stopwatch.h +++ b/examples/common/stopwatch.h @@ -25,7 +25,7 @@ #ifndef STOPWATCH_H #define STOPWATCH_H -#if (_WIN32 || _WIN64) +#if (_WIN32) #include #else #include @@ -37,7 +37,7 @@ class Stopwatch { public: -#ifndef _WINDOWS +#ifndef _WIN32 Stopwatch() : _totalElapsed(0) { } void Start() { @@ -91,7 +91,7 @@ public: private: -#ifndef _WINDOWS +#ifndef _WIN32 double _elapsed; double _totalElapsed; #else