AuroraMiddleware/OpenSubdiv
1
0
Fork 0
mirror of https://github.com/PixarAnimationStudios/OpenSubdiv synced 2025-01-04 06:00:17 +00:00
Code Issues Releases Wiki Activity

Fix Far::StencilTables batch evaluation bug

Browse Source 
Setting start/end values of UpdateValues() produced incorrect primvar interpolation
because the stencil sizes array was not shifted properly to the 'start' location of
the batch.
This commit is contained in:
manuelk 2014-10-29 15:52:07 -07:00
parent b3124649f8
commit af040c62cc
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
opensubdiv/far/stencilTables.h
View File

@ -337,11 +337,13 @@ template <class T> void
StencilTables::update(T const *controlValues, T *values,
std::vector<float> const &valueWeights, int start, int end) const {
unsigned char const * sizes = &_sizes.at(0);
Index const * indices = &_indices.at(0);
float const * weights = &valueWeights.at(0);
if (start>0) {
assert(start<(Index)_offsets.size());
sizes += start;
indices += _offsets[start];
weights += _offsets[start];
values += start;
@ -352,13 +354,13 @@ StencilTables::update(T const *controlValues, T *values,
}
int nstencils = end - std::max(0, start);
for (int i=0; i<nstencils; ++i) {
for (int i=0; i<nstencils; ++i, ++sizes) {
// Zero out the result accumulators
values[i].Clear();
// For each element in the array, add the coefs contribution
for (int j=0; j<_sizes[i]; ++j, ++indices, ++weights) {
for (int j=0; j<*sizes; ++j, ++indices, ++weights) {
values[i].AddWithWeight( controlValues[*indices], *weights );
}
}