mirror of
https://github.com/PixarAnimationStudios/OpenSubdiv
synced 2024-11-25 04:50:06 +00:00
Additional fix/cleanup for FindDocutils.cmake
Always call FindPackageHandleStandardArgs() and allow it to set DOCUTILS_FOUND appropriately. By marking DOCUTILS_VERSION as required we'll also get a useful error message if the version string from RST2HTML_EXECUTABLE could not be parsed correctly.
This commit is contained in:
parent
4425a4707d
commit
c53895310a
@ -58,13 +58,7 @@ if (RST2HTML_EXECUTABLE)
|
||||
# The above code may fail to find a version. Which will make the REGEX
|
||||
# REPLACE below fail and break the build. So we check for an empty
|
||||
# VERSION_STRING.
|
||||
if ("${VERSION_STRING}" STREQUAL "")
|
||||
|
||||
set(DOCUTILS_FOUND "NO")
|
||||
|
||||
else()
|
||||
|
||||
set(DOCUTILS_FOUND "YES")
|
||||
if (NOT "${VERSION_STRING}" STREQUAL "")
|
||||
|
||||
# find the version
|
||||
# ex : rst2html (Docutils 0.6 [release], Python 2.6.6, on linux2)
|
||||
@ -79,23 +73,20 @@ if (RST2HTML_EXECUTABLE)
|
||||
|
||||
set(DOCUTILS_VERSION ${VERSION_STRING})
|
||||
|
||||
include(FindPackageHandleStandardArgs)
|
||||
|
||||
find_package_handle_standard_args(Docutils
|
||||
REQUIRED_VARS
|
||||
RST2HTML_EXECUTABLE
|
||||
VERSION_VAR
|
||||
DOCUTILS_VERSION
|
||||
)
|
||||
|
||||
mark_as_advanced(
|
||||
RST2HTML_EXECUTABLE
|
||||
)
|
||||
|
||||
endif()
|
||||
|
||||
else()
|
||||
|
||||
set(DOCUTILS_FOUND "NO")
|
||||
|
||||
endif()
|
||||
|
||||
include(FindPackageHandleStandardArgs)
|
||||
|
||||
find_package_handle_standard_args(Docutils
|
||||
REQUIRED_VARS
|
||||
RST2HTML_EXECUTABLE
|
||||
DOCUTILS_VERSION
|
||||
VERSION_VAR
|
||||
DOCUTILS_VERSION
|
||||
)
|
||||
|
||||
mark_as_advanced(
|
||||
RST2HTML_EXECUTABLE
|
||||
)
|
||||
|
Loading…
Reference in New Issue
Block a user