Commit Graph

2895 Commits

Author SHA1 Message Date
barry
914cf98e60 Updates images for screen shots of all OpenGL examples other than glPtexViewer 2019-06-23 21:25:14 -07:00
Barry Fowler
48ecdb405b
Merge pull request #1137 from davidgyu/examples_build_fixes
Thanks
2019-06-21 11:38:47 -07:00
David G Yu
4160a248da Removed accidentally committed .swp file 2019-06-21 10:52:46 -07:00
David G Yu
daf4c6f489 Fixed uninitialized var warning 2019-06-21 10:51:26 -07:00
David G Yu
7dbcee64e6 Fixed int to bool conversion warning 2019-06-21 10:50:50 -07:00
David G Yu
980c303a6e
Merge pull request #1136 from barfowl/examples_glpainttest
Improved examples/glPaintTest with slider to modify brush size
2019-06-21 10:10:08 -07:00
barry
6ab31b9061 Improved examples/glPaintTest with slider to modify brush size:
- changed default brush size from 500 to 100 pixels
    - added slider to HUD to modify brush size interactively
2019-06-20 21:07:47 -07:00
David G Yu
8291df957c
Merge pull request #1135 from barfowl/far_api_doxygen
Minor improvements to Doxygen comments in Far header files
2019-06-20 18:31:31 -07:00
David G Yu
1ac3d98a3d
Merge pull request #1134 from barfowl/docs_examples
Added missing documentation pages and images for some of the examples
2019-06-20 17:47:36 -07:00
barry
3484311cc0 Fixed copyright date on recently added file 2019-06-20 17:17:02 -07:00
Barry Fowler
8270c77959
Merge pull request #1133 from davidgyu/hud_logo_update
Thanks, David -- that turned out to be more involved than expected!
2019-06-20 14:23:57 -07:00
barry
5e1a4b44be Minor improvements to Doxygen comments for Far header files:
- minor changes to Doxygen comments based on feedback
    - new description for PatchTableFactory::Options::EndCapType
    - fixed warnings related to Doxygen use of <REAL> in patchTable.h
2019-06-20 13:56:54 -07:00
David G Yu
64d366a145 Updated OpenSubdiv logo in examples HUD
Reorganized the character cells used for UI
elements and removed elements that were not
being used in order to provide more space
for the logo image and logo text.

Updated to the new OpenSubdiv logo and updated
the HUD drawing code used to display the logo
character cells.
2019-06-20 13:56:44 -07:00
barry
2fca20ed5f Minor improvements to documentation pages for DirectX examples:
- added missing image for the dxPtexViewer
    - updated command line usage to reflect updated DirectX examples
    - fixed other minor inconsistencies
2019-06-20 11:43:57 -07:00
barry
707e585ea2 Added new documentation pages for Metal examples:
- added new RST pages and images for the mtlViewer and mtlPtexViewer
    - added new table to the main Code Examples page for the Metal examples
2019-06-20 11:40:28 -07:00
Barry Fowler
fdd08b96f1
Merge pull request #1132 from davidgyu/mtl_ptexviewer_fix
Metal PtexViewer fixes and improvements
2019-06-18 19:22:09 -07:00
Barry Fowler
7e229cf095
Merge pull request #1131 from davidgyu/mtl_viewer_options
Thanks, David
2019-06-18 16:23:47 -07:00
Barry Fowler
c49a0c2e44
Merge pull request #1130 from davidgyu/mtl_viewer_tess_fix
Thanks, David
2019-06-18 16:23:31 -07:00
David G Yu
78113981e6 Updated mtlPtexViewer to match mtlViewer
These changes update the mtlPtexViewer implementation
to match recent changes to the mtlViewer including:
- improved shader organization
- correct screenspace tessellation
- support for common command line arguments and fit to frame
2019-06-18 15:32:07 -07:00
David G Yu
b4ace6791b Fixed mtlPtexMipmapTexture 3-component textures
Fixed the example mtlPtexMipmapTexture loader to support
the padAlpha option used when loading 3-component textures.
2019-06-18 15:30:43 -07:00
David G Yu
7794010e8f Removed unused shape list from mtlPtexViewer 2019-06-18 15:30:05 -07:00
David G Yu
317e242bee
Merge pull request #1129 from barfowl/far_fvar_corner_tags
Fixed cracks in face-varying Loop patches for lineaar-boundaries option
2019-06-18 15:10:41 -07:00
David G Yu
dc22a0cb1d Updated mtlViewer command line arguments
Updated the mtlViewer to make use of common/argOptions.h
like the other viewers and also implemented a "fit to frame"
hotkey. Both changes help improve manual testing.
2019-06-18 14:27:33 -07:00
David G Yu
cdbeac560f Fixed mtlViewer transition patch tessellation
Patches with transition edges were not being tessellated
correctly when drawing multiple patch types, e.g. with
Gregory or Legacy Gregory approximation at irregular features,
because the per-patch tess factors buffer was not being
offset correctly for the draw command for each patch type.

Fixed this to be consistent with other patch drawing by
recording and applying offsets when binding this buffer
for each patch type, and making sure that attributes for
the tess factors buffer are bound when drawing Legacy Gregory
patch types.
2019-06-18 13:36:49 -07:00
barry
6d3e1b02af Added condition to compensate for incorrect FVar corner tags:
- re-assess corner tags for irregular patches on FVar boundaries
2019-06-18 11:24:23 -07:00
George ElKoura
a001cfb440
Merge pull request #1128 from davidgyu/fvar_viewer_options
Update glFVarViewer option defaults
2019-06-18 10:49:49 -07:00
David G Yu
58a71672a7 Update glFVarViewer option defaults
Enabled smooth corner, inf sharp and single crease patch
options by default.
2019-06-18 10:28:54 -07:00
George ElKoura
3c4081aac3
Merge pull request #1126 from davidgyu/examples_shaders
Minor improvements to examples for Loop
2019-06-17 21:11:02 -07:00
George ElKoura
2d7919f3ee
Merge pull request #1127 from davidgyu/examples_options_and_shapes
Examples options and shapes
2019-06-17 20:33:53 -07:00
David G Yu
92a5d73913
Merge pull request #1125 from barfowl/regression_far_perf
Improvements to far_perf output and options
2019-06-17 18:13:23 -07:00
David G Yu
ed3fa312e5 Removed obsolete LOOP define from example shaders
Removed the use of the LOOP preprocessor symbol from
the remaining example shader code. The shader code is now
configured according to the types of the resulting patches
without depending on the subdivision scheme of the mesh
topology.
2019-06-17 17:59:15 -07:00
David G Yu
9fe1284ae3 improved glViewer shaders for Loop
Removed the use of the LOOP preprocessor symbol from
the glFVarViewer shaders code. The shader code is now
configured according to the types of the resulting patches
without depending on the subdivision scheme of the mesh
topology.

Improved the implementation of face-varying interpolation
similar to the glFVarViewer. Now the face-varying patch
type is obtained from the face-varying patch array
descriptor instead of being hard-coded by subdivison scheme.
2019-06-17 17:59:15 -07:00
David G Yu
5d33f7c28e Improved glFVarViewer shaders for Loop
Removed the use of the LOOP preprocessor symbol from
the glFVarViewer shaders code. The shader code is now
configured according to the types of the resulting patches
without depending on the subdivision scheme of the mesh
topology.

This allows the implementation of face-varying interpolation
to be improved and simplifies both the shader code and
application code.

Also, fixed a couple of incorrect buffer/texture bindings
that were raising GL errors.
2019-06-17 17:59:15 -07:00
David G Yu
d8abffc976 Updated more example viewer shape lists
Updated the shape lists in the glEvalLimit, glImaging,
and glStencilViewer examples to match recent updates
to the other example viewers.
2019-06-17 17:36:48 -07:00
David G Yu
62195753a9 Updated default options for examples
Changed several default options in the example viewers to the
preferred settings for improved shape fidelity and to improve
consistency between the different viewers:
 - enabled smooth corner, and inf sharp patch options by default
 - disabled screenspace tess and fractional tess by default
 - changed the default approximation to Gregory in the mtlViewer
2019-06-17 17:33:40 -07:00
David G Yu
973b7fe7a5 Fixed glViewer triangle normal calculation
The normal computed for primitive triangles had a flipped
orientation in the glViewer, This caused linear approximating
patches to be shaded incorrectly for adaptively refined Loop
meshes, and similarly triangles resulting from uniformly refined
Loop meshes.
2019-06-17 16:56:10 -07:00
barry
5fc51d87ca Improved flexibility and output for regression/far_perf:
- fixed memory leaks and added asserts and errors for bad input data
    - restructured the CSV output to a line per test and renamed flag to -csv
    - added options -nopatches, -nostencils and -total options to reduce output
2019-06-17 09:19:38 -07:00
David G Yu
db9c01e7e0
Merge pull request #1124 from barfowl/examples_loop_tet
Added simple tetrahedron to set of Loop test shapes
2019-06-14 17:37:32 -07:00
barry
4a198ace66 Added new Loop tetrahedron shape to main example viewers:
- added to the main geometry viewers: glViewer, dxViewer, mtlViewer
    - added to glFVarViewer for viewing face-varying UVs
2019-06-14 15:24:00 -07:00
barry
e8dcef6760 Added Loop tetrahedron to regression/shapes:
- added Loop tetrahedron shape with two UV sets
    - added the new shape to all.h
2019-06-14 15:20:29 -07:00
David G Yu
51d5ac4a49
Merge pull request #1123 from barfowl/far_loop_patch_bug
Fixed Loop patch creation bug with val-3 vertex at third corner
2019-06-14 12:48:10 -07:00
barry
3ea2f4caac Rotated faces in shapes for extra-ordinary vertices for better test coverage:
- rotated faces to place extra-ordinary vertex at each corner
    - updated both Catmark and Loop shapes for both boundary and interior
2019-06-14 11:32:59 -07:00
barry
69ab4d6170 Fixed Loop patch creation bug with val-3 interior vertex at third corner:
- adjusted point-sharing logic in PatchBuilder::SourcePatch to correct
2019-06-14 11:28:22 -07:00
David G Yu
001029f352 Release 3.4.0 RC1 2019-06-10 17:48:17 -07:00
Barry Fowler
ff9a3b4fcb
Merge pull request #1119 from davidgyu/far_perf_spreadsheet
Thanks, David
2019-06-10 17:44:41 -07:00
David G Yu
e64cc8d4b3
Merge pull request #1120 from barfowl/docs_release_34
Updated documentation for 3.4 release notes and past release dates
2019-06-10 17:06:26 -07:00
barry
0245184e11 Updated documentation for 3.4 release notes and past release dates:
- added new page and images for 3.4 release notes
    - updated Release Notes page with dates for all past releases
2019-06-10 16:33:41 -07:00
Pol
eff740d9f3
Merge pull request #1118 from davidgyu/osd_api_revisions
Minor revisions to some Osd deprecation notes
2019-06-10 15:42:27 -07:00
David G Yu
f881c49a5b Minor revisions to some Osd deprecation notes
Several of the methods in osd/patchBasisCommon.h were
never intended as public API, and several have been
deprecated in favor of the newer OsdEvaluatePatchBasis()
and OsdEvaluatePatchBasisNormalized() methods. These
obsolete methods have now all be marked as deprecated.

Also, fixed a minor spelling typo in glslPatchBasisCommon.glsl
2019-06-10 15:29:03 -07:00
David G Yu
e7cfe1188d Updated far_perf output and options
Added a -spreadsheet option to far_perf which outputs
result data as comma separated values (CSV) which can
be imported directly into spreadsheet applications for
further analysis and charting.

Also, updated the other far_perf options to be more consistent
with the other tutorials and examples, e.g. when specifying
scheme types, refinement options, etc.
2019-06-10 15:10:54 -07:00