AuroraMiddleware/SPIRV-Cross
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
acae607703
SPIRV-Cross/reference/shaders-hlsl/frag
History
Hans-Kristian Arntzen acae607703 Register implied expression reads in OpLoad/OpAccessChain. 
This is required to avoid relying on complex sub-expression elimination
in compilers, and generates cleaner code.

The problem case is if a complex expression is used in an access chain,
like:

Composite comp = buffer[texture(...)];
vec4 a = comp.a + comp.b + comp.c;

Before, we did not have common subexpression tracking for
OpLoad/OpAccessChain, so we easily ended up with code like:

vec4 a = buffer[texture(...)].a + buffer[texture(...)].b + buffer[texture(...)].c;

A good compiler will optimize this, but we should not rely on it, and
forcing texture(...) to a temporary also looks better.

The solution is to add a vector "implied_expression_reads", which works
similarly to expression_dependencies. We also need an extra mechanism in
to_expression which lets us skip expression read checking and do it
later. E.g. for expr -> access chain -> load, we should only trigger
a read of expr when using the loaded expression.
2019-01-04 14:56:12 +01:00
..
array-lut-no-loop-variable.frag Deduce constant LUTs from read-write variables. 2018-07-05 13:25:57 +02:00
basic-color-3comp.sm30.frag Add tests for previous fix 2018-09-11 20:57:56 +02:00
basic-color-3comp.sm50.frag Add tests for previous fix 2018-09-11 20:57:56 +02:00
basic.frag Add basic support for : register() declaration in HLSL. 2017-06-17 10:15:32 +02:00
bit-conversions.frag Add new HLSL tests 2017-03-24 15:41:20 +01:00
boolean-mix.frag Swizzle scalars when splatting in HLSL. 2017-12-12 12:52:45 +01:00
builtins.frag Update HLSL test output 2017-03-24 14:40:13 +01:00
bvec-operations.frag Add new HLSL tests 2017-03-24 15:41:20 +01:00
clip-cull-distance.frag Fix incorrect loop range. 2018-02-22 17:00:41 +01:00
combined-texture-sampler-parameter.frag Fix swizzling of integers. 2018-01-04 13:16:56 +01:00
combined-texture-sampler-shadow.frag Fix swizzling of integers. 2018-01-04 13:16:56 +01:00
complex-expression-in-access-chain.frag Register implied expression reads in OpLoad/OpAccessChain. 2019-01-04 14:56:12 +01:00
constant-buffer-array.invalid.sm51.frag HLSL: Use same logic as GLSL for picking cbuffer block name. 2018-10-22 09:50:04 +02:00
constant-composites.frag Add some tests for LUT promotion. 2018-07-05 14:14:18 +02:00
control-dependent-in-branch.desktop.frag Handle control-dependent temporaries. 2018-03-12 17:34:54 +01:00
depth-greater-than.frag Deal with depth_greater/depth_less qualifiers. 2018-11-12 10:35:36 +01:00
depth-less-than.frag Deal with depth_greater/depth_less qualifiers. 2018-11-12 10:35:36 +01:00
early-fragment-test.frag HLSL: Support early fragment tests attribute 2017-11-21 14:51:03 +01:00
fp16-packing.frag Implement FP16 unpack/pack on HLSL. 2017-11-27 14:24:30 +01:00
fp16.invalid.desktop.frag Update glslang and SPIRV-Tools. 2018-09-27 11:10:22 +02:00
front-facing.frag Add IsFrontFace support to HLSL. 2018-02-15 12:42:56 +01:00
image-query-selective.frag Swizzle scalars when splatting in HLSL. 2017-12-12 12:52:45 +01:00
image-query.frag Swizzle scalars when splatting in HLSL. 2017-12-12 12:52:45 +01:00
input-attachment-ms.frag Implement subpass input support in HLSL. 2018-02-10 10:54:42 +01:00
input-attachment.frag Implement subpass input support in HLSL. 2018-02-10 10:54:42 +01:00
io-block.frag Add test for input I/O blocks in fragment. 2017-03-21 13:48:50 +01:00
lut-promotion.frag Add some tests for LUT promotion. 2018-07-05 14:14:18 +02:00
matrix-input.frag Only unroll matrices for vertex input. 2017-10-05 16:31:52 +02:00
mod.frag Swizzle scalars when splatting in HLSL. 2017-12-12 12:52:45 +01:00
mrt.frag Fix swizzling of integers. 2018-01-04 13:16:56 +01:00
no-return2.frag Add some tests for no stage inputs or outputs in HLSL. 2017-03-21 13:48:50 +01:00
no-return.frag Add some tests for no stage inputs or outputs in HLSL. 2017-03-21 13:48:50 +01:00
partial-write-preserve.frag HLSL: Use same logic as GLSL for picking cbuffer block name. 2018-10-22 09:50:04 +02:00
point-coord-compat.frag Add workaround for PointCoord builtin on HLSL. 2018-02-23 15:58:35 +01:00
query-lod.desktop.frag Support textureQueryLod in HLSL. 2017-12-01 13:30:31 +01:00
resources.frag HLSL: Use same logic as GLSL for picking cbuffer block name. 2018-10-22 09:50:04 +02:00
row-major-layout-in-struct.frag HLSL: Use same logic as GLSL for picking cbuffer block name. 2018-10-22 09:50:04 +02:00
sample-cmp-level-zero.frag Test textureProjLodOffset with compare in HLSL as well. 2017-11-29 12:48:06 +01:00
sampler-array.frag Register implied expression reads in OpLoad/OpAccessChain. 2019-01-04 14:56:12 +01:00
sampler-image-arrays.frag Add test for sampler image arrays. 2018-04-04 09:41:20 +02:00
separate-combined-fake-overload.sm30.frag HLSL: Complete support for combined image samplers in legacy. 2018-11-12 09:59:39 +01:00
spec-constant-block-size.frag Update tests. 2018-11-01 11:23:48 +01:00
spec-constant-ternary.frag Update tests. 2018-11-01 11:23:48 +01:00
switch-unsigned-case.frag Fix unsigned switch case selectors. 2018-11-26 10:36:50 +01:00
swizzle-scalar.frag Fix swizzling of integers. 2018-01-04 13:16:56 +01:00
tex-sampling-ms.frag Deal with OpImageFetch without explicit LOD. 2018-04-30 10:54:44 +02:00
tex-sampling.frag Update tests for latest SPIRV-Tools and glslang. 2018-03-12 15:11:55 +01:00
texel-fetch-offset.frag MSL: Fix support for texelFetchOffset. 2018-08-07 15:28:04 +02:00
texture-proj-shadow.frag Fix textureProj with shadow on GLSL. 2017-07-31 10:05:32 +02:00
texture-size-combined-image-sampler.frag Fix OpImage on OpSampledImages in HLSL. 2018-02-01 09:22:16 +01:00
unary-enclose.frag Fix unary enclosures. 2017-07-24 10:17:19 +02:00
unorm-snorm-packing.frag Implement unorm16/snorm16 packing in HLSL. 2017-11-27 15:03:40 +01:00
various-glsl-ops.frag Fix swizzling of integers. 2018-01-04 13:16:56 +01:00