AuroraMiddleware/SPIRV-Tools
1
0
Fork 0
mirror of https://github.com/KhronosGroup/SPIRV-Tools synced 2024-11-25 21:10:04 +00:00
Code Issues Packages Projects Releases Wiki Activity
4451f6ab13
SPIRV-Tools/test/fuzz/transformation_move_block_down_test.cpp

727 lines
30 KiB
C++
Raw Normal View History

Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
// Copyright (c) 2019 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "source/fuzz/transformation_move_block_down.h"
spirv-fuzz: Move IRContext parameter into constructor (#3837) This PR converts IRContext parameter in fact managers into a class field. Part of #3698.
2020-09-24 11:27:59 +00:00
spirv-fuzz: Fix to TransformationInlineFunction (#3913) This fixes a problem where TransformationInlineFunction could lead to distinct instructions having identical unique ids. It adds a validity check to detect this problem in general. Fixes #3911.
2020-10-16 21:58:09 +00:00
#include "gtest/gtest.h"
#include "source/fuzz/fuzzer_util.h"
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
#include "test/fuzz/fuzz_test_util.h"
namespace spvtools {
namespace fuzz {
namespace {
TEST(TransformationMoveBlockDownTest, NoMovePossible1) {
// Block 11 cannot be moved down as it dominates block 12.
std::string shader = R"(
OpCapability Shader
%1 = OpExtInstImport "GLSL.std.450"
OpMemoryModel Logical GLSL450
OpEntryPoint Fragment %4 "main"
OpExecutionMode %4 OriginUpperLeft
OpSource ESSL 310
OpDecorate %8 RelaxedPrecision
%2 = OpTypeVoid
%3 = OpTypeFunction %2
%6 = OpTypeInt 32 1
%7 = OpTypePointer Function %6
%9 = OpConstant %6 1
%10 = OpConstant %6 2
%4 = OpFunction %2 None %3
%5 = OpLabel
%8 = OpVariable %7 Function
OpBranch %11
%11 = OpLabel
OpStore %8 %9
OpBranch %12
%12 = OpLabel
OpStore %8 %10
OpReturn
OpFunctionEnd
)";
const auto env = SPV_ENV_UNIVERSAL_1_3;
const auto consumer = nullptr;
const auto context = BuildModule(env, consumer, shader, kFuzzAssembleOption);
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
spvtools::ValidatorOptions validator_options;
spirv-fuzz: Use unique_ptr<FactManager> in TransformationContext (#3844) TransformationContext now holds a std::unique_ptr to a FactManager, rather than a plain pointer. This makes it easier for clients of TransformationContext to work with heap-allocated instances of TransformationContext, which is needed in some upcoming work.
2020-09-24 16:28:49 +00:00
TransformationContext transformation_context(
MakeUnique<FactManager>(context.get()), validator_options);
Refactor fuzzer transformations (#2694) Introduced abstract class for transformations, and refactored all transformations to inherit from this abstract class.
2019-06-25 19:49:46 +00:00
auto transformation = TransformationMoveBlockDown(11);
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(
transformation.IsApplicable(context.get(), transformation_context));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
}
TEST(TransformationMoveBlockDownTest, NoMovePossible2) {
// Block 5 cannot be moved down as it is the entry block.
std::string shader = R"(
OpCapability Shader
%1 = OpExtInstImport "GLSL.std.450"
OpMemoryModel Logical GLSL450
OpEntryPoint Fragment %4 "main"
OpExecutionMode %4 OriginUpperLeft
OpSource ESSL 310
OpDecorate %8 RelaxedPrecision
%2 = OpTypeVoid
%3 = OpTypeFunction %2
%6 = OpTypeInt 32 1
%7 = OpTypePointer Function %6
%9 = OpConstant %6 1
%10 = OpConstant %6 2
%4 = OpFunction %2 None %3
%5 = OpLabel
%8 = OpVariable %7 Function
OpStore %8 %9
OpStore %8 %10
OpReturn
%11 = OpLabel
OpReturn
OpFunctionEnd
)";
const auto env = SPV_ENV_UNIVERSAL_1_3;
const auto consumer = nullptr;
const auto context = BuildModule(env, consumer, shader, kFuzzAssembleOption);
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
spvtools::ValidatorOptions validator_options;
spirv-fuzz: Use unique_ptr<FactManager> in TransformationContext (#3844) TransformationContext now holds a std::unique_ptr to a FactManager, rather than a plain pointer. This makes it easier for clients of TransformationContext to work with heap-allocated instances of TransformationContext, which is needed in some upcoming work.
2020-09-24 16:28:49 +00:00
TransformationContext transformation_context(
MakeUnique<FactManager>(context.get()), validator_options);
Refactor fuzzer transformations (#2694) Introduced abstract class for transformations, and refactored all transformations to inherit from this abstract class.
2019-06-25 19:49:46 +00:00
auto transformation = TransformationMoveBlockDown(5);
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(
transformation.IsApplicable(context.get(), transformation_context));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
}
TEST(TransformationMoveBlockDownTest, NoMovePossible3) {
// Block 100 does not exist, so cannot be moved down.
std::string shader = R"(
OpCapability Shader
%1 = OpExtInstImport "GLSL.std.450"
OpMemoryModel Logical GLSL450
OpEntryPoint Fragment %4 "main"
OpExecutionMode %4 OriginUpperLeft
OpSource ESSL 310
OpDecorate %8 RelaxedPrecision
%2 = OpTypeVoid
%3 = OpTypeFunction %2
%6 = OpTypeInt 32 1
%7 = OpTypePointer Function %6
%9 = OpConstant %6 1
%10 = OpConstant %6 2
%4 = OpFunction %2 None %3
%5 = OpLabel
%8 = OpVariable %7 Function
OpBranch %11
%11 = OpLabel
OpStore %8 %9
OpBranch %12
%12 = OpLabel
OpStore %8 %10
OpReturn
OpFunctionEnd
)";
const auto env = SPV_ENV_UNIVERSAL_1_3;
const auto consumer = nullptr;
const auto context = BuildModule(env, consumer, shader, kFuzzAssembleOption);
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
spvtools::ValidatorOptions validator_options;
spirv-fuzz: Use unique_ptr<FactManager> in TransformationContext (#3844) TransformationContext now holds a std::unique_ptr to a FactManager, rather than a plain pointer. This makes it easier for clients of TransformationContext to work with heap-allocated instances of TransformationContext, which is needed in some upcoming work.
2020-09-24 16:28:49 +00:00
TransformationContext transformation_context(
MakeUnique<FactManager>(context.get()), validator_options);
Refactor fuzzer transformations (#2694) Introduced abstract class for transformations, and refactored all transformations to inherit from this abstract class.
2019-06-25 19:49:46 +00:00
auto transformation = TransformationMoveBlockDown(100);
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(
transformation.IsApplicable(context.get(), transformation_context));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
}
TEST(TransformationMoveBlockDownTest, NoMovePossible4) {
// Block 12 is the last block in its function, so cannot be moved down.
std::string shader = R"(
OpCapability Shader
%1 = OpExtInstImport "GLSL.std.450"
OpMemoryModel Logical GLSL450
OpEntryPoint Fragment %4 "main"
OpExecutionMode %4 OriginUpperLeft
OpSource ESSL 310
OpDecorate %8 RelaxedPrecision
%2 = OpTypeVoid
%3 = OpTypeFunction %2
%6 = OpTypeInt 32 1
%7 = OpTypePointer Function %6
%9 = OpConstant %6 1
%10 = OpConstant %6 2
%4 = OpFunction %2 None %3
%5 = OpLabel
%8 = OpVariable %7 Function
OpBranch %11
%11 = OpLabel
OpStore %8 %9
OpBranch %12
%12 = OpLabel
OpStore %8 %10
OpReturn
OpFunctionEnd
%13 = OpFunction %2 None %3
%14 = OpLabel
OpReturn
OpFunctionEnd
)";
const auto env = SPV_ENV_UNIVERSAL_1_3;
const auto consumer = nullptr;
const auto context = BuildModule(env, consumer, shader, kFuzzAssembleOption);
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
spvtools::ValidatorOptions validator_options;
spirv-fuzz: Use unique_ptr<FactManager> in TransformationContext (#3844) TransformationContext now holds a std::unique_ptr to a FactManager, rather than a plain pointer. This makes it easier for clients of TransformationContext to work with heap-allocated instances of TransformationContext, which is needed in some upcoming work.
2020-09-24 16:28:49 +00:00
TransformationContext transformation_context(
MakeUnique<FactManager>(context.get()), validator_options);
Refactor fuzzer transformations (#2694) Introduced abstract class for transformations, and refactored all transformations to inherit from this abstract class.
2019-06-25 19:49:46 +00:00
auto transformation = TransformationMoveBlockDown(12);
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(
transformation.IsApplicable(context.get(), transformation_context));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
}
TEST(TransformationMoveBlockDownTest, ManyMovesPossible) {
// The SPIR-V arising from this shader has lots of opportunities for moving
// blocks around.
//
// void main() {
// int x;
// int y;
// if (x < y) {
// x = 1;
// if (y == x) {
// x = 3;
// } else {
// x = 4;
// }
// } else {
// if (y < x) {
// x = 5;
// } else {
// x = 6;
// }
// }
// }
std::string before_transformation = R"(
OpCapability Shader
%1 = OpExtInstImport "GLSL.std.450"
OpMemoryModel Logical GLSL450
OpEntryPoint Fragment %4 "main"
OpExecutionMode %4 OriginUpperLeft
OpSource ESSL 310
OpName %4 "main"
OpName %8 "x"
OpName %10 "y"
OpDecorate %8 RelaxedPrecision
OpDecorate %9 RelaxedPrecision
OpDecorate %10 RelaxedPrecision
OpDecorate %11 RelaxedPrecision
OpDecorate %17 RelaxedPrecision
OpDecorate %18 RelaxedPrecision
OpDecorate %26 RelaxedPrecision
OpDecorate %27 RelaxedPrecision
%2 = OpTypeVoid
%3 = OpTypeFunction %2
%6 = OpTypeInt 32 1
%7 = OpTypePointer Function %6
%12 = OpTypeBool
%16 = OpConstant %6 1
%22 = OpConstant %6 3
%24 = OpConstant %6 4
%31 = OpConstant %6 5
%33 = OpConstant %6 6
%4 = OpFunction %2 None %3
%5 = OpLabel
%8 = OpVariable %7 Function
%10 = OpVariable %7 Function
%9 = OpLoad %6 %8
%11 = OpLoad %6 %10
%13 = OpSLessThan %12 %9 %11
OpSelectionMerge %15 None
OpBranchConditional %13 %14 %25
%14 = OpLabel
OpStore %8 %16
%17 = OpLoad %6 %10
%18 = OpLoad %6 %8
%19 = OpIEqual %12 %17 %18
OpSelectionMerge %21 None
OpBranchConditional %19 %20 %23
%20 = OpLabel
OpStore %8 %22
OpBranch %21
%23 = OpLabel
OpStore %8 %24
OpBranch %21
%21 = OpLabel
OpBranch %15
%25 = OpLabel
%26 = OpLoad %6 %10
%27 = OpLoad %6 %8
%28 = OpSLessThan %12 %26 %27
OpSelectionMerge %30 None
OpBranchConditional %28 %29 %32
%29 = OpLabel
OpStore %8 %31
OpBranch %30
%32 = OpLabel
OpStore %8 %33
OpBranch %30
%30 = OpLabel
OpBranch %15
%15 = OpLabel
OpReturn
OpFunctionEnd
)";
const auto env = SPV_ENV_UNIVERSAL_1_3;
const auto consumer = nullptr;
const auto context =
BuildModule(env, consumer, before_transformation, kFuzzAssembleOption);
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
spvtools::ValidatorOptions validator_options;
spirv-fuzz: Use unique_ptr<FactManager> in TransformationContext (#3844) TransformationContext now holds a std::unique_ptr to a FactManager, rather than a plain pointer. This makes it easier for clients of TransformationContext to work with heap-allocated instances of TransformationContext, which is needed in some upcoming work.
2020-09-24 16:28:49 +00:00
TransformationContext transformation_context(
MakeUnique<FactManager>(context.get()), validator_options);
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
// The block ids are: 5 14 20 23 21 25 29 32 30 15
// We make a transformation to move each of them down, plus a transformation
// to move a non-block, 27, down.
Refactor fuzzer transformations (#2694) Introduced abstract class for transformations, and refactored all transformations to inherit from this abstract class.
2019-06-25 19:49:46 +00:00
auto move_down_5 = TransformationMoveBlockDown(5);
auto move_down_14 = TransformationMoveBlockDown(14);
auto move_down_20 = TransformationMoveBlockDown(20);
auto move_down_23 = TransformationMoveBlockDown(23);
auto move_down_21 = TransformationMoveBlockDown(21);
auto move_down_25 = TransformationMoveBlockDown(25);
auto move_down_29 = TransformationMoveBlockDown(29);
auto move_down_32 = TransformationMoveBlockDown(32);
auto move_down_30 = TransformationMoveBlockDown(30);
auto move_down_15 = TransformationMoveBlockDown(15);
auto move_down_27 = TransformationMoveBlockDown(27);
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
// Dominance is as follows:
// 5 dominates everything else
// 14 dominates 20, 23, 21
// 20 dominates nothing
// 23 dominates nothing
// 21 dominates nothing
// 25 dominates 29, 32, 30
// 29 dominates nothing
// 32 dominates nothing
// 30 dominates nothing
// 15 dominates nothing
// Current ordering: 5 14 20 23 21 25 29 32 30 15
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(move_down_5.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_14.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_20.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_23.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_21.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_25.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_29.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_32.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_30.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_15.IsApplicable(context.get(), transformation_context));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
// Let's bubble 20 all the way down.
spirv-fuzz: Report fresh ids in transformations (#3856) Adds a virtual method, GetFreshIds(), to Transformation. Every transformation uses this to indicate which ids in its protobuf message are fresh ids. This means that when replaying a sequence of transformations the replayer can obtain a smallest id that is not in use by the module already and that will not be used by any transformation by necessity. Ids greater than or equal to this id can be used as overflow ids. Fixes #3851.
2020-09-29 21:12:49 +00:00
ApplyAndCheckFreshIds(move_down_20, context.get(), &transformation_context);
spirv-fuzz: Fix to TransformationInlineFunction (#3913) This fixes a problem where TransformationInlineFunction could lead to distinct instructions having identical unique ids. It adds a validity check to detect this problem in general. Fixes #3911.
2020-10-16 21:58:09 +00:00
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
kConsoleMessageConsumer));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
// Current ordering: 5 14 23 20 21 25 29 32 30 15
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(move_down_5.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_14.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_23.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_20.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_21.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_25.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_29.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_32.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_30.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_15.IsApplicable(context.get(), transformation_context));
spirv-fuzz: Report fresh ids in transformations (#3856) Adds a virtual method, GetFreshIds(), to Transformation. Every transformation uses this to indicate which ids in its protobuf message are fresh ids. This means that when replaying a sequence of transformations the replayer can obtain a smallest id that is not in use by the module already and that will not be used by any transformation by necessity. Ids greater than or equal to this id can be used as overflow ids. Fixes #3851.
2020-09-29 21:12:49 +00:00
ApplyAndCheckFreshIds(move_down_20, context.get(), &transformation_context);
spirv-fuzz: Fix to TransformationInlineFunction (#3913) This fixes a problem where TransformationInlineFunction could lead to distinct instructions having identical unique ids. It adds a validity check to detect this problem in general. Fixes #3911.
2020-10-16 21:58:09 +00:00
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
kConsoleMessageConsumer));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
// Current ordering: 5 14 23 21 20 25 29 32 30 15
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(move_down_5.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_14.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_23.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_21.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_20.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_25.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_29.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_32.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_30.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_15.IsApplicable(context.get(), transformation_context));
spirv-fuzz: Report fresh ids in transformations (#3856) Adds a virtual method, GetFreshIds(), to Transformation. Every transformation uses this to indicate which ids in its protobuf message are fresh ids. This means that when replaying a sequence of transformations the replayer can obtain a smallest id that is not in use by the module already and that will not be used by any transformation by necessity. Ids greater than or equal to this id can be used as overflow ids. Fixes #3851.
2020-09-29 21:12:49 +00:00
ApplyAndCheckFreshIds(move_down_20, context.get(), &transformation_context);
spirv-fuzz: Fix to TransformationInlineFunction (#3913) This fixes a problem where TransformationInlineFunction could lead to distinct instructions having identical unique ids. It adds a validity check to detect this problem in general. Fixes #3911.
2020-10-16 21:58:09 +00:00
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
kConsoleMessageConsumer));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
// Current ordering: 5 14 23 21 25 20 29 32 30 15
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(move_down_5.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_14.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_23.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_21.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_25.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_20.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_29.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_32.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_30.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_15.IsApplicable(context.get(), transformation_context));
spirv-fuzz: Report fresh ids in transformations (#3856) Adds a virtual method, GetFreshIds(), to Transformation. Every transformation uses this to indicate which ids in its protobuf message are fresh ids. This means that when replaying a sequence of transformations the replayer can obtain a smallest id that is not in use by the module already and that will not be used by any transformation by necessity. Ids greater than or equal to this id can be used as overflow ids. Fixes #3851.
2020-09-29 21:12:49 +00:00
ApplyAndCheckFreshIds(move_down_20, context.get(), &transformation_context);
spirv-fuzz: Fix to TransformationInlineFunction (#3913) This fixes a problem where TransformationInlineFunction could lead to distinct instructions having identical unique ids. It adds a validity check to detect this problem in general. Fixes #3911.
2020-10-16 21:58:09 +00:00
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
kConsoleMessageConsumer));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
// Current ordering: 5 14 23 21 25 29 20 32 30 15
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(move_down_5.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_14.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_23.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_21.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_25.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_29.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_20.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_32.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_30.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_15.IsApplicable(context.get(), transformation_context));
spirv-fuzz: Report fresh ids in transformations (#3856) Adds a virtual method, GetFreshIds(), to Transformation. Every transformation uses this to indicate which ids in its protobuf message are fresh ids. This means that when replaying a sequence of transformations the replayer can obtain a smallest id that is not in use by the module already and that will not be used by any transformation by necessity. Ids greater than or equal to this id can be used as overflow ids. Fixes #3851.
2020-09-29 21:12:49 +00:00
ApplyAndCheckFreshIds(move_down_20, context.get(), &transformation_context);
spirv-fuzz: Fix to TransformationInlineFunction (#3913) This fixes a problem where TransformationInlineFunction could lead to distinct instructions having identical unique ids. It adds a validity check to detect this problem in general. Fixes #3911.
2020-10-16 21:58:09 +00:00
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
kConsoleMessageConsumer));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
// Current ordering: 5 14 23 21 25 29 32 20 30 15
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(move_down_5.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_14.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_23.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_21.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_25.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_29.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_32.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_20.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_30.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_15.IsApplicable(context.get(), transformation_context));
spirv-fuzz: Report fresh ids in transformations (#3856) Adds a virtual method, GetFreshIds(), to Transformation. Every transformation uses this to indicate which ids in its protobuf message are fresh ids. This means that when replaying a sequence of transformations the replayer can obtain a smallest id that is not in use by the module already and that will not be used by any transformation by necessity. Ids greater than or equal to this id can be used as overflow ids. Fixes #3851.
2020-09-29 21:12:49 +00:00
ApplyAndCheckFreshIds(move_down_20, context.get(), &transformation_context);
spirv-fuzz: Fix to TransformationInlineFunction (#3913) This fixes a problem where TransformationInlineFunction could lead to distinct instructions having identical unique ids. It adds a validity check to detect this problem in general. Fixes #3911.
2020-10-16 21:58:09 +00:00
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
kConsoleMessageConsumer));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
// Current ordering: 5 14 23 21 25 29 32 30 20 15
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(move_down_5.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_14.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_23.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_21.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_25.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_29.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_32.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_30.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_20.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_15.IsApplicable(context.get(), transformation_context));
spirv-fuzz: Report fresh ids in transformations (#3856) Adds a virtual method, GetFreshIds(), to Transformation. Every transformation uses this to indicate which ids in its protobuf message are fresh ids. This means that when replaying a sequence of transformations the replayer can obtain a smallest id that is not in use by the module already and that will not be used by any transformation by necessity. Ids greater than or equal to this id can be used as overflow ids. Fixes #3851.
2020-09-29 21:12:49 +00:00
ApplyAndCheckFreshIds(move_down_20, context.get(), &transformation_context);
spirv-fuzz: Fix to TransformationInlineFunction (#3913) This fixes a problem where TransformationInlineFunction could lead to distinct instructions having identical unique ids. It adds a validity check to detect this problem in general. Fixes #3911.
2020-10-16 21:58:09 +00:00
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
kConsoleMessageConsumer));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
std::string after_bubbling_20_down = R"(
OpCapability Shader
%1 = OpExtInstImport "GLSL.std.450"
OpMemoryModel Logical GLSL450
OpEntryPoint Fragment %4 "main"
OpExecutionMode %4 OriginUpperLeft
OpSource ESSL 310
OpName %4 "main"
OpName %8 "x"
OpName %10 "y"
OpDecorate %8 RelaxedPrecision
OpDecorate %9 RelaxedPrecision
OpDecorate %10 RelaxedPrecision
OpDecorate %11 RelaxedPrecision
OpDecorate %17 RelaxedPrecision
OpDecorate %18 RelaxedPrecision
OpDecorate %26 RelaxedPrecision
OpDecorate %27 RelaxedPrecision
%2 = OpTypeVoid
%3 = OpTypeFunction %2
%6 = OpTypeInt 32 1
%7 = OpTypePointer Function %6
%12 = OpTypeBool
%16 = OpConstant %6 1
%22 = OpConstant %6 3
%24 = OpConstant %6 4
%31 = OpConstant %6 5
%33 = OpConstant %6 6
%4 = OpFunction %2 None %3
%5 = OpLabel
%8 = OpVariable %7 Function
%10 = OpVariable %7 Function
%9 = OpLoad %6 %8
%11 = OpLoad %6 %10
%13 = OpSLessThan %12 %9 %11
OpSelectionMerge %15 None
OpBranchConditional %13 %14 %25
%14 = OpLabel
OpStore %8 %16
%17 = OpLoad %6 %10
%18 = OpLoad %6 %8
%19 = OpIEqual %12 %17 %18
OpSelectionMerge %21 None
OpBranchConditional %19 %20 %23
%23 = OpLabel
OpStore %8 %24
OpBranch %21
%21 = OpLabel
OpBranch %15
%25 = OpLabel
%26 = OpLoad %6 %10
%27 = OpLoad %6 %8
%28 = OpSLessThan %12 %26 %27
OpSelectionMerge %30 None
OpBranchConditional %28 %29 %32
%29 = OpLabel
OpStore %8 %31
OpBranch %30
%32 = OpLabel
OpStore %8 %33
OpBranch %30
%30 = OpLabel
OpBranch %15
%15 = OpLabel
OpReturn
%20 = OpLabel
OpStore %8 %22
OpBranch %21
OpFunctionEnd
)";
ASSERT_TRUE(IsEqual(env, after_bubbling_20_down, context.get()));
// Current ordering: 5 14 23 21 25 29 32 30 15 20
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(move_down_5.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_14.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_23.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_21.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_25.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_29.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_32.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_30.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_15.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_20.IsApplicable(context.get(), transformation_context));
spirv-fuzz: Report fresh ids in transformations (#3856) Adds a virtual method, GetFreshIds(), to Transformation. Every transformation uses this to indicate which ids in its protobuf message are fresh ids. This means that when replaying a sequence of transformations the replayer can obtain a smallest id that is not in use by the module already and that will not be used by any transformation by necessity. Ids greater than or equal to this id can be used as overflow ids. Fixes #3851.
2020-09-29 21:12:49 +00:00
ApplyAndCheckFreshIds(move_down_23, context.get(), &transformation_context);
spirv-fuzz: Fix to TransformationInlineFunction (#3913) This fixes a problem where TransformationInlineFunction could lead to distinct instructions having identical unique ids. It adds a validity check to detect this problem in general. Fixes #3911.
2020-10-16 21:58:09 +00:00
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
kConsoleMessageConsumer));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
// Current ordering: 5 14 21 23 25 29 32 30 15 20
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(move_down_5.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_14.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_21.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_23.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_25.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_29.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_32.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_30.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_15.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_20.IsApplicable(context.get(), transformation_context));
spirv-fuzz: Report fresh ids in transformations (#3856) Adds a virtual method, GetFreshIds(), to Transformation. Every transformation uses this to indicate which ids in its protobuf message are fresh ids. This means that when replaying a sequence of transformations the replayer can obtain a smallest id that is not in use by the module already and that will not be used by any transformation by necessity. Ids greater than or equal to this id can be used as overflow ids. Fixes #3851.
2020-09-29 21:12:49 +00:00
ApplyAndCheckFreshIds(move_down_23, context.get(), &transformation_context);
spirv-fuzz: Fix to TransformationInlineFunction (#3913) This fixes a problem where TransformationInlineFunction could lead to distinct instructions having identical unique ids. It adds a validity check to detect this problem in general. Fixes #3911.
2020-10-16 21:58:09 +00:00
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
kConsoleMessageConsumer));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
// Current ordering: 5 14 21 25 23 29 32 30 15 20
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(move_down_5.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_14.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_21.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_25.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_23.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_29.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_32.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_30.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_15.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_20.IsApplicable(context.get(), transformation_context));
spirv-fuzz: Report fresh ids in transformations (#3856) Adds a virtual method, GetFreshIds(), to Transformation. Every transformation uses this to indicate which ids in its protobuf message are fresh ids. This means that when replaying a sequence of transformations the replayer can obtain a smallest id that is not in use by the module already and that will not be used by any transformation by necessity. Ids greater than or equal to this id can be used as overflow ids. Fixes #3851.
2020-09-29 21:12:49 +00:00
ApplyAndCheckFreshIds(move_down_21, context.get(), &transformation_context);
spirv-fuzz: Fix to TransformationInlineFunction (#3913) This fixes a problem where TransformationInlineFunction could lead to distinct instructions having identical unique ids. It adds a validity check to detect this problem in general. Fixes #3911.
2020-10-16 21:58:09 +00:00
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
kConsoleMessageConsumer));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
// Current ordering: 5 14 25 21 23 29 32 30 15 20
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(move_down_5.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_14.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_21.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_25.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_23.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_29.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_32.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_30.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_15.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_20.IsApplicable(context.get(), transformation_context));
spirv-fuzz: Report fresh ids in transformations (#3856) Adds a virtual method, GetFreshIds(), to Transformation. Every transformation uses this to indicate which ids in its protobuf message are fresh ids. This means that when replaying a sequence of transformations the replayer can obtain a smallest id that is not in use by the module already and that will not be used by any transformation by necessity. Ids greater than or equal to this id can be used as overflow ids. Fixes #3851.
2020-09-29 21:12:49 +00:00
ApplyAndCheckFreshIds(move_down_14, context.get(), &transformation_context);
spirv-fuzz: Fix to TransformationInlineFunction (#3913) This fixes a problem where TransformationInlineFunction could lead to distinct instructions having identical unique ids. It adds a validity check to detect this problem in general. Fixes #3911.
2020-10-16 21:58:09 +00:00
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
kConsoleMessageConsumer));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
std::string after_more_shuffling = R"(
OpCapability Shader
%1 = OpExtInstImport "GLSL.std.450"
OpMemoryModel Logical GLSL450
OpEntryPoint Fragment %4 "main"
OpExecutionMode %4 OriginUpperLeft
OpSource ESSL 310
OpName %4 "main"
OpName %8 "x"
OpName %10 "y"
OpDecorate %8 RelaxedPrecision
OpDecorate %9 RelaxedPrecision
OpDecorate %10 RelaxedPrecision
OpDecorate %11 RelaxedPrecision
OpDecorate %17 RelaxedPrecision
OpDecorate %18 RelaxedPrecision
OpDecorate %26 RelaxedPrecision
OpDecorate %27 RelaxedPrecision
%2 = OpTypeVoid
%3 = OpTypeFunction %2
%6 = OpTypeInt 32 1
%7 = OpTypePointer Function %6
%12 = OpTypeBool
%16 = OpConstant %6 1
%22 = OpConstant %6 3
%24 = OpConstant %6 4
%31 = OpConstant %6 5
%33 = OpConstant %6 6
%4 = OpFunction %2 None %3
%5 = OpLabel
%8 = OpVariable %7 Function
%10 = OpVariable %7 Function
%9 = OpLoad %6 %8
%11 = OpLoad %6 %10
%13 = OpSLessThan %12 %9 %11
OpSelectionMerge %15 None
OpBranchConditional %13 %14 %25
%25 = OpLabel
%26 = OpLoad %6 %10
%27 = OpLoad %6 %8
%28 = OpSLessThan %12 %26 %27
OpSelectionMerge %30 None
OpBranchConditional %28 %29 %32
%14 = OpLabel
OpStore %8 %16
%17 = OpLoad %6 %10
%18 = OpLoad %6 %8
%19 = OpIEqual %12 %17 %18
OpSelectionMerge %21 None
OpBranchConditional %19 %20 %23
%21 = OpLabel
OpBranch %15
%23 = OpLabel
OpStore %8 %24
OpBranch %21
%29 = OpLabel
OpStore %8 %31
OpBranch %30
%32 = OpLabel
OpStore %8 %33
OpBranch %30
%30 = OpLabel
OpBranch %15
%15 = OpLabel
OpReturn
%20 = OpLabel
OpStore %8 %22
OpBranch %21
OpFunctionEnd
)";
ASSERT_TRUE(IsEqual(env, after_more_shuffling, context.get()));
// Final ordering: 5 25 14 21 23 29 32 30 15 20
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(move_down_5.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_25.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_14.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_21.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_23.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_29.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_32.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_30.IsApplicable(context.get(), transformation_context));
ASSERT_TRUE(move_down_15.IsApplicable(context.get(), transformation_context));
ASSERT_FALSE(
move_down_20.IsApplicable(context.get(), transformation_context));
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
}
Disallow movement of unreachable blocks. (#2700) Fixes #2695. Allowing unreachable blocks to be moved can lead to an unreachable block A getting placed after an unreachable successor B, which is a problem if B uses ids that A generates.
2019-06-26 14:32:25 +00:00
TEST(TransformationMoveBlockDownTest, DoNotMoveUnreachable) {
// Block 6 is unreachable, so cannot be moved down.
std::string shader = R"(
OpCapability Shader
%1 = OpExtInstImport "GLSL.std.450"
OpMemoryModel Logical GLSL450
OpEntryPoint Fragment %4 "main"
OpExecutionMode %4 OriginUpperLeft
OpSource ESSL 310
OpName %4 "main"
%2 = OpTypeVoid
%3 = OpTypeFunction %2
%10 = OpTypeInt 32 1
%4 = OpFunction %2 None %3
%5 = OpLabel
OpReturn
%6 = OpLabel
%7 = OpUndef %10
OpBranch %8
%8 = OpLabel
%9 = OpCopyObject %10 %7
OpReturn
OpFunctionEnd
)";
const auto env = SPV_ENV_UNIVERSAL_1_3;
const auto consumer = nullptr;
const auto context = BuildModule(env, consumer, shader, kFuzzAssembleOption);
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
spvtools::ValidatorOptions validator_options;
spirv-fuzz: Fix to TransformationInlineFunction (#3913) This fixes a problem where TransformationInlineFunction could lead to distinct instructions having identical unique ids. It adds a validity check to detect this problem in general. Fixes #3911.
2020-10-16 21:58:09 +00:00
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
kConsoleMessageConsumer));
spirv-fuzz: Use unique_ptr<FactManager> in TransformationContext (#3844) TransformationContext now holds a std::unique_ptr to a FactManager, rather than a plain pointer. This makes it easier for clients of TransformationContext to work with heap-allocated instances of TransformationContext, which is needed in some upcoming work.
2020-09-24 16:28:49 +00:00
TransformationContext transformation_context(
MakeUnique<FactManager>(context.get()), validator_options);
Disallow movement of unreachable blocks. (#2700) Fixes #2695. Allowing unreachable blocks to be moved can lead to an unreachable block A getting placed after an unreachable successor B, which is a problem if B uses ids that A generates.
2019-06-26 14:32:25 +00:00
auto transformation = TransformationMoveBlockDown(6);
spirv-fuzz: Introduce TransformationContext (#3272) Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
2020-04-02 14:54:46 +00:00
ASSERT_FALSE(
transformation.IsApplicable(context.get(), transformation_context));
Disallow movement of unreachable blocks. (#2700) Fixes #2695. Allowing unreachable blocks to be moved can lead to an unreachable block A getting placed after an unreachable successor B, which is a problem if B uses ids that A generates.
2019-06-26 14:32:25 +00:00
}
Add spirv-fuzz pass to permute blocks. (#2642) The blocks within each function in the module will be permuted in a randomized manner that respects dominance.
2019-05-31 08:59:06 +00:00
} // namespace
} // namespace fuzz
} // namespace spvtools
Reference in New Issue Copy Permalink