SPIRV-Tools/test/opcode_require_capabilities_test.cpp

107 lines
4.7 KiB
C++
Raw Normal View History

2016-01-07 18:44:22 +00:00
// Copyright (c) 2015-2016 The Khronos Group Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "test/unit_spirv.h"
#include "source/enum_set.h"
Use opcode operand definitions from SPIR-V specification generator. The assembler and disassembler now use a dynamically adjusted sequence of expected operand types. (Internally, it is a deque, for readability.) Both parsers repeatedly pull an expected operand type from the left of this pattern list, and try to match the next input token against it. The expected pattern is adjusted during the parse to accommodate: - an extended instruction's expected operands, depending on the extended instruction's index. - when an operand itself has operands - to handle sequences of zero or more operands, or pairs of operands. These are expanded lazily during the parse. Adds spv::OperandClass from the SPIR-V specification generator. Modifies spv_operand_desc_t: - adds hasResult, hasType, and operandClass array to the opcode description type. - "wordCount" is replaced with "numTypes", which counts the number of entries in operandTypes. And each of those describes a *logical* operand, including the type id for the instruction, and the result id for the instruction. A logical operand could be variable-width, such as a literal string. Adds opcode.inc, an automatically-generated table of operation descriptions, with one line to describe each core instruction. Externally, we have modified the SPIR-V spec doc generator to emit this file. (We have hacked this copy to use the old semantics for OpLine.) Inside the assembler, parsing an operand may fail with new error code SPV_FAIL_MATCH. For an optional operand, this is not fatal, but should trigger backtracking at a higher level. The spvTextIsStartOfNewInst checks the case of the third letter of what might be an opcode. So now, "OpenCL" does not look like an opcode name. In assembly, the EntryPoint name field is mandatory, but can be an empty string. Adjust tests for changes to: - OpSampedImage - OpTypeSampler
2015-08-27 17:03:52 +00:00
namespace spvtools {
namespace {
2015-10-01 17:46:38 +00:00
using spvtest::ElementsIn;
2015-10-01 17:46:38 +00:00
// Capabilities required by an Opcode.
2015-10-01 13:43:05 +00:00
struct ExpectedOpCodeCapabilities {
spv::Op opcode;
CapabilitySet capabilities;
2015-10-01 13:43:05 +00:00
};
using OpcodeTableCapabilitiesTest =
::testing::TestWithParam<ExpectedOpCodeCapabilities>;
TEST_P(OpcodeTableCapabilitiesTest, TableEntryMatchesExpectedCapabilities) {
auto env = SPV_ENV_UNIVERSAL_1_1;
2015-10-01 13:43:05 +00:00
spv_opcode_table opcodeTable;
ASSERT_EQ(SPV_SUCCESS, spvOpcodeTableGet(&opcodeTable, env));
2015-10-01 13:43:05 +00:00
spv_opcode_desc entry;
ASSERT_EQ(SPV_SUCCESS, spvOpcodeTableValueLookup(env, opcodeTable,
GetParam().opcode, &entry));
EXPECT_EQ(
ElementsIn(GetParam().capabilities),
ElementsIn(CapabilitySet(entry->numCapabilities, entry->capabilities)));
2015-10-01 13:43:05 +00:00
}
INSTANTIATE_TEST_SUITE_P(
2015-10-01 13:43:05 +00:00
TableRowTest, OpcodeTableCapabilitiesTest,
// Spot-check a few opcodes.
::testing::Values(
ExpectedOpCodeCapabilities{spv::Op::OpImageQuerySize,
CapabilitySet{spv::Capability::Kernel,
spv::Capability::ImageQuery}},
ExpectedOpCodeCapabilities{spv::Op::OpImageQuerySizeLod,
CapabilitySet{spv::Capability::Kernel,
spv::Capability::ImageQuery}},
ExpectedOpCodeCapabilities{spv::Op::OpImageQueryLevels,
CapabilitySet{spv::Capability::Kernel,
spv::Capability::ImageQuery}},
ExpectedOpCodeCapabilities{spv::Op::OpImageQuerySamples,
CapabilitySet{spv::Capability::Kernel,
spv::Capability::ImageQuery}},
2015-10-01 13:43:05 +00:00
ExpectedOpCodeCapabilities{
spv::Op::OpImageSparseSampleImplicitLod,
CapabilitySet{spv::Capability::SparseResidency}},
Support SPV_KHR_untyped_pointers (#5736) * Support SPV_KHR_untyped_pointers Covers: - assembler - disassembler - validator fix copyright Validate OpTypeUntypedPointerKHR * Disallow an untyped pointer in a typed pointer * Validate capability requirements for untyped pointer * Allow duplicate untyped pointer declarations Add round trip tests Validate OpUntypedVariableKHR Validate untyped access chains * Add a test for opcodes that generate untyped pointers * simplify some checks for operands needing types * validate OpUnypedAccessChainKHR, OpUntypedInBoundsAccessChainKHR, OpUntypedPtrAccessChainKHR, OpUntypedInBoundsPtrAccessChainKHR Unify variable validation Validate OpCopyMemorySized * Fix some opcode tests to accound for untyped pointers * Add validation for OpCopyMemorySized for shaders and untyped pointers * fix up tests Validate pointer comparisons and bitcast * Update more helpers * Fix entry validation to allow OpUntypedVariableKHR * Validate OpPtrEqual, OpPtrNotEqual and OpPtrDiff * Validate OpBitcast Validate atomics and untyped pointers Make interface variable validation aware of untyped pointers * Check OpUntypedVariableKHR in interface validation More untyped pointer validation * Validate interfaces more thoroughly * Validate layouts for untyped pointer uses * Improve capability checks for vulkan with OpTypeUntypedPointerKHR * workgroup member explicit layout validation updates More validation * validate function arguments and parameters * handle untyped pointer and variable in more places Add a friendly assembly name for untyped pointers Update OpCopyMemory validation and tests Fix test for token update Fixes for validation * Allow typed pointers to contain untyped pointers * Fix decoration validation * add untyped pointer as a case for size and alignments Fix interface validation * Grabbed the wrong storage class operand for untyped variables * Add ability to specify assembler options in validation tests Add passthrough validation for OpUntypedArrayLengthKHR More validation of untyped pointers * Validate OpUntypedArrayLengthKHR * Validate layout for OpLoad, OpStore, and OpUntypedArrayLengthKHR Validation support for cooperative matrix and untyped pointers * Allow untyped pointers for cooperative matrix KHR load and store Updates to match spec * Remove extra capability references * Swap untyped variable data type and storage class operands * update validation of variables * update deps --------- Co-authored-by: David Neto <dneto@google.com>
2024-07-17 18:51:37 +00:00
ExpectedOpCodeCapabilities{
spv::Op::OpCopyMemorySized,
CapabilitySet{spv::Capability::Addresses,
spv::Capability::UntypedPointersKHR}},
ExpectedOpCodeCapabilities{spv::Op::OpArrayLength,
CapabilitySet{spv::Capability::Shader}},
ExpectedOpCodeCapabilities{spv::Op::OpFunction, CapabilitySet()},
ExpectedOpCodeCapabilities{spv::Op::OpConvertFToS, CapabilitySet()},
ExpectedOpCodeCapabilities{
spv::Op::OpEmitStreamVertex,
CapabilitySet{spv::Capability::GeometryStreams}},
ExpectedOpCodeCapabilities{
spv::Op::OpTypeNamedBarrier,
CapabilitySet{spv::Capability::NamedBarrier}},
ExpectedOpCodeCapabilities{
spv::Op::OpGetKernelMaxNumSubgroups,
CapabilitySet{spv::Capability::SubgroupDispatch}},
ExpectedOpCodeCapabilities{spv::Op::OpImageQuerySamples,
CapabilitySet{spv::Capability::Kernel,
spv::Capability::ImageQuery}},
ExpectedOpCodeCapabilities{
spv::Op::OpImageSparseSampleImplicitLod,
CapabilitySet{spv::Capability::SparseResidency}},
ExpectedOpCodeCapabilities{
spv::Op::OpCopyMemorySized,
CapabilitySet{spv::Capability::Addresses,
spv::Capability::UntypedPointersKHR}},
ExpectedOpCodeCapabilities{spv::Op::OpArrayLength,
CapabilitySet{spv::Capability::Shader}},
ExpectedOpCodeCapabilities{spv::Op::OpFunction, CapabilitySet()},
ExpectedOpCodeCapabilities{spv::Op::OpConvertFToS, CapabilitySet()},
2015-10-01 13:43:05 +00:00
ExpectedOpCodeCapabilities{
spv::Op::OpEmitStreamVertex,
CapabilitySet{spv::Capability::GeometryStreams}},
2015-10-01 13:43:05 +00:00
ExpectedOpCodeCapabilities{
spv::Op::OpTypeNamedBarrier,
CapabilitySet{spv::Capability::NamedBarrier}},
2015-10-01 13:43:05 +00:00
ExpectedOpCodeCapabilities{
spv::Op::OpGetKernelMaxNumSubgroups,
CapabilitySet{spv::Capability::SubgroupDispatch}}));
2015-10-01 13:43:05 +00:00
} // namespace
} // namespace spvtools