mirror of
https://github.com/KhronosGroup/SPIRV-Tools
synced 2024-10-19 03:20:14 +00:00
603 lines
24 KiB
C++
603 lines
24 KiB
C++
|
// Copyright (c) 2018 Google LLC
|
||
|
|
//
|
||
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
|
|
// you may not use this file except in compliance with the License.
|
||
|
|
// You may obtain a copy of the License at
|
||
|
|
//
|
||
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
||
|
|
//
|
||
|
|
// Unless required by applicable law or agreed to in writing, software
|
||
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
|
|
// See the License for the specific language governing permissions and
|
||
|
|
// limitations under the License.
|
||
|
|
|
||
|
|
#include <iostream>
|
||
|
|
|
||
|
|
#include <gmock/gmock.h>
|
||
|
|
|
||
|
|
#include "assembly_builder.h"
|
||
|
|
#include "pass_fixture.h"
|
||
|
|
|
||
|
|
namespace {
|
||
|
|
|
||
|
|
using namespace spvtools;
|
||
|
|
using ir::IRContext;
|
||
|
|
using ir::Instruction;
|
||
|
|
using opt::PassManager;
|
||
|
|
|
||
|
|
using CopyPropArrayPassTest = PassTest<::testing::Test>;
|
||
|
|
|
||
|
|
#ifdef SPIRV_EFFCEE
|
||
|
|
TEST_F(CopyPropArrayPassTest, BasicPropagateArray) {
|
||
|
|
const std::string before =
|
||
|
|
R"(
|
||
|
|
OpCapability Shader
|
||
|
|
OpMemoryModel Logical GLSL450
|
||
|
|
OpEntryPoint Fragment %main "main" %in_var_INDEX %out_var_SV_Target
|
||
|
|
OpExecutionMode %main OriginUpperLeft
|
||
|
|
OpSource HLSL 600
|
||
|
|
OpName %type_MyCBuffer "type.MyCBuffer"
|
||
|
|
OpMemberName %type_MyCBuffer 0 "Data"
|
||
|
|
OpName %MyCBuffer "MyCBuffer"
|
||
|
|
OpName %main "main"
|
||
|
|
OpName %in_var_INDEX "in.var.INDEX"
|
||
|
|
OpName %out_var_SV_Target "out.var.SV_Target"
|
||
|
|
OpDecorate %_arr_v4float_uint_8 ArrayStride 16
|
||
|
|
OpMemberDecorate %type_MyCBuffer 0 Offset 0
|
||
|
|
OpDecorate %type_MyCBuffer Block
|
||
|
|
OpDecorate %in_var_INDEX Flat
|
||
|
|
OpDecorate %in_var_INDEX Location 0
|
||
|
|
OpDecorate %out_var_SV_Target Location 0
|
||
|
|
OpDecorate %MyCBuffer DescriptorSet 0
|
||
|
|
OpDecorate %MyCBuffer Binding 0
|
||
|
|
%float = OpTypeFloat 32
|
||
|
|
%v4float = OpTypeVector %float 4
|
||
|
|
%uint = OpTypeInt 32 0
|
||
|
|
%uint_8 = OpConstant %uint 8
|
||
|
|
%_arr_v4float_uint_8 = OpTypeArray %v4float %uint_8
|
||
|
|
%type_MyCBuffer = OpTypeStruct %_arr_v4float_uint_8
|
||
|
|
%_ptr_Uniform_type_MyCBuffer = OpTypePointer Uniform %type_MyCBuffer
|
||
|
|
%void = OpTypeVoid
|
||
|
|
%13 = OpTypeFunction %void
|
||
|
|
%int = OpTypeInt 32 1
|
||
|
|
%_ptr_Input_int = OpTypePointer Input %int
|
||
|
|
%_ptr_Output_v4float = OpTypePointer Output %v4float
|
||
|
|
%_arr_v4float_uint_8_0 = OpTypeArray %v4float %uint_8
|
||
|
|
%_ptr_Function__arr_v4float_uint_8_0 = OpTypePointer Function %_arr_v4float_uint_8_0
|
||
|
|
%int_0 = OpConstant %int 0
|
||
|
|
%_ptr_Uniform__arr_v4float_uint_8 = OpTypePointer Uniform %_arr_v4float_uint_8
|
||
|
|
%_ptr_Function_v4float = OpTypePointer Function %v4float
|
||
|
|
%MyCBuffer = OpVariable %_ptr_Uniform_type_MyCBuffer Uniform
|
||
|
|
%in_var_INDEX = OpVariable %_ptr_Input_int Input
|
||
|
|
%out_var_SV_Target = OpVariable %_ptr_Output_v4float Output
|
||
|
|
; CHECK: OpFunction
|
||
|
|
; CHECK: OpLabel
|
||
|
|
; CHECK: OpVariable
|
||
|
|
; CHECK: [[new_address:%\w+]] = OpAccessChain %_ptr_Uniform__arr_v4float_uint_8 %MyCBuffer %uint_0
|
||
|
|
%main = OpFunction %void None %13
|
||
|
|
%22 = OpLabel
|
||
|
|
%23 = OpVariable %_ptr_Function__arr_v4float_uint_8_0 Function
|
||
|
|
%24 = OpLoad %int %in_var_INDEX
|
||
|
|
%25 = OpAccessChain %_ptr_Uniform__arr_v4float_uint_8 %MyCBuffer %int_0
|
||
|
|
%26 = OpLoad %_arr_v4float_uint_8 %25
|
||
|
|
%27 = OpCompositeExtract %v4float %26 0
|
||
|
|
%28 = OpCompositeExtract %v4float %26 1
|
||
|
|
%29 = OpCompositeExtract %v4float %26 2
|
||
|
|
%30 = OpCompositeExtract %v4float %26 3
|
||
|
|
%31 = OpCompositeExtract %v4float %26 4
|
||
|
|
%32 = OpCompositeExtract %v4float %26 5
|
||
|
|
%33 = OpCompositeExtract %v4float %26 6
|
||
|
|
%34 = OpCompositeExtract %v4float %26 7
|
||
|
|
%35 = OpCompositeConstruct %_arr_v4float_uint_8_0 %27 %28 %29 %30 %31 %32 %33 %34
|
||
|
|
OpStore %23 %35
|
||
|
|
%36 = OpAccessChain %_ptr_Function_v4float %23 %24
|
||
|
|
; CHECK %37 = OpLoad %v4float [[new_address]]
|
||
|
|
%37 = OpLoad %v4float %36
|
||
|
|
OpStore %out_var_SV_Target %37
|
||
|
|
OpReturn
|
||
|
|
OpFunctionEnd
|
||
|
|
)";
|
||
|
|
|
||
|
|
SetAssembleOptions(SPV_TEXT_TO_BINARY_OPTION_PRESERVE_NUMERIC_IDS);
|
||
|
|
SetDisassembleOptions(SPV_BINARY_TO_TEXT_OPTION_NO_HEADER |
|
||
|
|
SPV_BINARY_TO_TEXT_OPTION_FRIENDLY_NAMES);
|
||
|
|
SinglePassRunAndMatch<opt::CopyPropagateArrays>(before, false);
|
||
|
|
}
|
||
|
|
|
||
|
|
// Propagate 2d array. This test identifing a copy through multiple levels.
|
||
|
|
// Also has to traverse multiple OpAccessChains.
|
||
|
|
TEST_F(CopyPropArrayPassTest, Propagate2DArray) {
|
||
|
|
const std::string text =
|
||
|
|
R"(OpCapability Shader
|
||
|
|
OpMemoryModel Logical GLSL450
|
||
|
|
OpEntryPoint Fragment %main "main" %in_var_INDEX %out_var_SV_Target
|
||
|
|
OpExecutionMode %main OriginUpperLeft
|
||
|
|
OpSource HLSL 600
|
||
|
|
OpName %type_MyCBuffer "type.MyCBuffer"
|
||
|
|
OpMemberName %type_MyCBuffer 0 "Data"
|
||
|
|
OpName %MyCBuffer "MyCBuffer"
|
||
|
|
OpName %main "main"
|
||
|
|
OpName %in_var_INDEX "in.var.INDEX"
|
||
|
|
OpName %out_var_SV_Target "out.var.SV_Target"
|
||
|
|
OpDecorate %_arr_v4float_uint_2 ArrayStride 16
|
||
|
|
OpDecorate %_arr__arr_v4float_uint_2_uint_2 ArrayStride 32
|
||
|
|
OpMemberDecorate %type_MyCBuffer 0 Offset 0
|
||
|
|
OpDecorate %type_MyCBuffer Block
|
||
|
|
OpDecorate %in_var_INDEX Flat
|
||
|
|
OpDecorate %in_var_INDEX Location 0
|
||
|
|
OpDecorate %out_var_SV_Target Location 0
|
||
|
|
OpDecorate %MyCBuffer DescriptorSet 0
|
||
|
|
OpDecorate %MyCBuffer Binding 0
|
||
|
|
%float = OpTypeFloat 32
|
||
|
|
%v4float = OpTypeVector %float 4
|
||
|
|
%uint = OpTypeInt 32 0
|
||
|
|
%uint_2 = OpConstant %uint 2
|
||
|
|
%_arr_v4float_uint_2 = OpTypeArray %v4float %uint_2
|
||
|
|
%_arr__arr_v4float_uint_2_uint_2 = OpTypeArray %_arr_v4float_uint_2 %uint_2
|
||
|
|
%type_MyCBuffer = OpTypeStruct %_arr__arr_v4float_uint_2_uint_2
|
||
|
|
%_ptr_Uniform_type_MyCBuffer = OpTypePointer Uniform %type_MyCBuffer
|
||
|
|
%void = OpTypeVoid
|
||
|
|
%14 = OpTypeFunction %void
|
||
|
|
%int = OpTypeInt 32 1
|
||
|
|
%_ptr_Input_int = OpTypePointer Input %int
|
||
|
|
%_ptr_Output_v4float = OpTypePointer Output %v4float
|
||
|
|
%_arr_v4float_uint_2_0 = OpTypeArray %v4float %uint_2
|
||
|
|
%_arr__arr_v4float_uint_2_0_uint_2 = OpTypeArray %_arr_v4float_uint_2_0 %uint_2
|
||
|
|
%_ptr_Function__arr__arr_v4float_uint_2_0_uint_2 = OpTypePointer Function %_arr__arr_v4float_uint_2_0_uint_2
|
||
|
|
%int_0 = OpConstant %int 0
|
||
|
|
%_ptr_Uniform__arr__arr_v4float_uint_2_uint_2 = OpTypePointer Uniform %_arr__arr_v4float_uint_2_uint_2
|
||
|
|
%_ptr_Function__arr_v4float_uint_2_0 = OpTypePointer Function %_arr_v4float_uint_2_0
|
||
|
|
%_ptr_Function_v4float = OpTypePointer Function %v4float
|
||
|
|
%MyCBuffer = OpVariable %_ptr_Uniform_type_MyCBuffer Uniform
|
||
|
|
%in_var_INDEX = OpVariable %_ptr_Input_int Input
|
||
|
|
%out_var_SV_Target = OpVariable %_ptr_Output_v4float Output
|
||
|
|
; CHECK: OpFunction
|
||
|
|
; CHECK: OpLabel
|
||
|
|
; CHECK: OpVariable
|
||
|
|
; CHECK: OpVariable
|
||
|
|
; CHECK: [[new_address:%\w+]] = OpAccessChain %_ptr_Uniform__arr__arr_v4float_uint_2_uint_2 %MyCBuffer %uint_0
|
||
|
|
%main = OpFunction %void None %14
|
||
|
|
%25 = OpLabel
|
||
|
|
%26 = OpVariable %_ptr_Function__arr_v4float_uint_2_0 Function
|
||
|
|
%27 = OpVariable %_ptr_Function__arr__arr_v4float_uint_2_0_uint_2 Function
|
||
|
|
%28 = OpLoad %int %in_var_INDEX
|
||
|
|
%29 = OpAccessChain %_ptr_Uniform__arr__arr_v4float_uint_2_uint_2 %MyCBuffer %int_0
|
||
|
|
%30 = OpLoad %_arr__arr_v4float_uint_2_uint_2 %29
|
||
|
|
%31 = OpCompositeExtract %_arr_v4float_uint_2 %30 0
|
||
|
|
%32 = OpCompositeExtract %v4float %31 0
|
||
|
|
%33 = OpCompositeExtract %v4float %31 1
|
||
|
|
%34 = OpCompositeConstruct %_arr_v4float_uint_2_0 %32 %33
|
||
|
|
%35 = OpCompositeExtract %_arr_v4float_uint_2 %30 1
|
||
|
|
%36 = OpCompositeExtract %v4float %35 0
|
||
|
|
%37 = OpCompositeExtract %v4float %35 1
|
||
|
|
%38 = OpCompositeConstruct %_arr_v4float_uint_2_0 %36 %37
|
||
|
|
%39 = OpCompositeConstruct %_arr__arr_v4float_uint_2_0_uint_2 %34 %38
|
||
|
|
; CHECK: OpStore
|
||
|
|
; CHECK: [[ac1:%\w+]] = OpAccessChain %_ptr_Uniform__arr_v4float_uint_2 [[new_address]] %28
|
||
|
|
; CHECK: [[ac2:%\w+]] = OpAccessChain %_ptr_Uniform_v4float [[ac1]] %28
|
||
|
|
; CHECK: OpLoad %v4float [[ac2]]
|
||
|
|
OpStore %27 %39
|
||
|
|
%40 = OpAccessChain %_ptr_Function__arr_v4float_uint_2_0 %27 %28
|
||
|
|
%42 = OpAccessChain %_ptr_Function_v4float %40 %28
|
||
|
|
%43 = OpLoad %v4float %42
|
||
|
|
OpStore %out_var_SV_Target %43
|
||
|
|
OpReturn
|
||
|
|
OpFunctionEnd
|
||
|
|
)";
|
||
|
|
|
||
|
|
SetAssembleOptions(SPV_TEXT_TO_BINARY_OPTION_PRESERVE_NUMERIC_IDS);
|
||
|
|
SetDisassembleOptions(SPV_BINARY_TO_TEXT_OPTION_NO_HEADER |
|
||
|
|
SPV_BINARY_TO_TEXT_OPTION_FRIENDLY_NAMES);
|
||
|
|
SinglePassRunAndMatch<opt::CopyPropagateArrays>(text, false);
|
||
|
|
}
|
||
|
|
#endif // SPIRV_EFFCEE
|
||
|
|
|
||
|
|
// This test will place a load before the store. We cannot propagate in this
|
||
|
|
// case.
|
||
|
|
TEST_F(CopyPropArrayPassTest, LoadBeforeStore) {
|
||
|
|
const std::string text =
|
||
|
|
R"(
|
||
|
|
OpCapability Shader
|
||
|
|
OpMemoryModel Logical GLSL450
|
||
|
|
OpEntryPoint Fragment %main "main" %in_var_INDEX %out_var_SV_Target
|
||
|
|
OpExecutionMode %main OriginUpperLeft
|
||
|
|
OpSource HLSL 600
|
||
|
|
OpName %type_MyCBuffer "type.MyCBuffer"
|
||
|
|
OpMemberName %type_MyCBuffer 0 "Data"
|
||
|
|
OpName %MyCBuffer "MyCBuffer"
|
||
|
|
OpName %main "main"
|
||
|
|
OpName %in_var_INDEX "in.var.INDEX"
|
||
|
|
OpName %out_var_SV_Target "out.var.SV_Target"
|
||
|
|
OpDecorate %_arr_v4float_uint_8 ArrayStride 16
|
||
|
|
OpMemberDecorate %type_MyCBuffer 0 Offset 0
|
||
|
|
OpDecorate %type_MyCBuffer Block
|
||
|
|
OpDecorate %in_var_INDEX Flat
|
||
|
|
OpDecorate %in_var_INDEX Location 0
|
||
|
|
OpDecorate %out_var_SV_Target Location 0
|
||
|
|
OpDecorate %MyCBuffer DescriptorSet 0
|
||
|
|
OpDecorate %MyCBuffer Binding 0
|
||
|
|
%float = OpTypeFloat 32
|
||
|
|
%v4float = OpTypeVector %float 4
|
||
|
|
%uint = OpTypeInt 32 0
|
||
|
|
%uint_8 = OpConstant %uint 8
|
||
|
|
%_arr_v4float_uint_8 = OpTypeArray %v4float %uint_8
|
||
|
|
%type_MyCBuffer = OpTypeStruct %_arr_v4float_uint_8
|
||
|
|
%_ptr_Uniform_type_MyCBuffer = OpTypePointer Uniform %type_MyCBuffer
|
||
|
|
%void = OpTypeVoid
|
||
|
|
%13 = OpTypeFunction %void
|
||
|
|
%int = OpTypeInt 32 1
|
||
|
|
%_ptr_Input_int = OpTypePointer Input %int
|
||
|
|
%_ptr_Output_v4float = OpTypePointer Output %v4float
|
||
|
|
%_arr_v4float_uint_8_0 = OpTypeArray %v4float %uint_8
|
||
|
|
%_ptr_Function__arr_v4float_uint_8_0 = OpTypePointer Function %_arr_v4float_uint_8_0
|
||
|
|
%int_0 = OpConstant %int 0
|
||
|
|
%_ptr_Uniform__arr_v4float_uint_8 = OpTypePointer Uniform %_arr_v4float_uint_8
|
||
|
|
%_ptr_Function_v4float = OpTypePointer Function %v4float
|
||
|
|
%MyCBuffer = OpVariable %_ptr_Uniform_type_MyCBuffer Uniform
|
||
|
|
%in_var_INDEX = OpVariable %_ptr_Input_int Input
|
||
|
|
%out_var_SV_Target = OpVariable %_ptr_Output_v4float Output
|
||
|
|
%main = OpFunction %void None %13
|
||
|
|
%22 = OpLabel
|
||
|
|
%23 = OpVariable %_ptr_Function__arr_v4float_uint_8_0 Function
|
||
|
|
%38 = OpAccessChain %_ptr_Function_v4float %23 %24
|
||
|
|
%39 = OpLoad %v4float %36
|
||
|
|
%24 = OpLoad %int %in_var_INDEX
|
||
|
|
%25 = OpAccessChain %_ptr_Uniform__arr_v4float_uint_8 %MyCBuffer %int_0
|
||
|
|
%26 = OpLoad %_arr_v4float_uint_8 %25
|
||
|
|
%27 = OpCompositeExtract %v4float %26 0
|
||
|
|
%28 = OpCompositeExtract %v4float %26 1
|
||
|
|
%29 = OpCompositeExtract %v4float %26 2
|
||
|
|
%30 = OpCompositeExtract %v4float %26 3
|
||
|
|
%31 = OpCompositeExtract %v4float %26 4
|
||
|
|
%32 = OpCompositeExtract %v4float %26 5
|
||
|
|
%33 = OpCompositeExtract %v4float %26 6
|
||
|
|
%34 = OpCompositeExtract %v4float %26 7
|
||
|
|
%35 = OpCompositeConstruct %_arr_v4float_uint_8_0 %27 %28 %29 %30 %31 %32 %33 %34
|
||
|
|
OpStore %23 %35
|
||
|
|
%36 = OpAccessChain %_ptr_Function_v4float %23 %24
|
||
|
|
%37 = OpLoad %v4float %36
|
||
|
|
OpStore %out_var_SV_Target %37
|
||
|
|
OpReturn
|
||
|
|
OpFunctionEnd
|
||
|
|
)";
|
||
|
|
|
||
|
|
SetAssembleOptions(SPV_TEXT_TO_BINARY_OPTION_PRESERVE_NUMERIC_IDS);
|
||
|
|
SetDisassembleOptions(SPV_BINARY_TO_TEXT_OPTION_NO_HEADER |
|
||
|
|
SPV_BINARY_TO_TEXT_OPTION_FRIENDLY_NAMES);
|
||
|
|
auto result = SinglePassRunAndDisassemble<opt::CopyPropagateArrays>(
|
||
|
|
text, /* skip_nop = */ true, /* do_validation = */ false);
|
||
|
|
|
||
|
|
EXPECT_EQ(opt::Pass::Status::SuccessWithoutChange, std::get<1>(result));
|
||
|
|
}
|
||
|
|
|
||
|
|
// This test will place a load where it is not dominated by the store. We
|
||
|
|
// cannot propagate in this case.
|
||
|
|
TEST_F(CopyPropArrayPassTest, LoadNotDominated) {
|
||
|
|
const std::string text =
|
||
|
|
R"(
|
||
|
|
OpCapability Shader
|
||
|
|
OpMemoryModel Logical GLSL450
|
||
|
|
OpEntryPoint Fragment %main "main" %in_var_INDEX %out_var_SV_Target
|
||
|
|
OpExecutionMode %main OriginUpperLeft
|
||
|
|
OpSource HLSL 600
|
||
|
|
OpName %type_MyCBuffer "type.MyCBuffer"
|
||
|
|
OpMemberName %type_MyCBuffer 0 "Data"
|
||
|
|
OpName %MyCBuffer "MyCBuffer"
|
||
|
|
OpName %main "main"
|
||
|
|
OpName %in_var_INDEX "in.var.INDEX"
|
||
|
|
OpName %out_var_SV_Target "out.var.SV_Target"
|
||
|
|
OpDecorate %_arr_v4float_uint_8 ArrayStride 16
|
||
|
|
OpMemberDecorate %type_MyCBuffer 0 Offset 0
|
||
|
|
OpDecorate %type_MyCBuffer Block
|
||
|
|
OpDecorate %in_var_INDEX Flat
|
||
|
|
OpDecorate %in_var_INDEX Location 0
|
||
|
|
OpDecorate %out_var_SV_Target Location 0
|
||
|
|
OpDecorate %MyCBuffer DescriptorSet 0
|
||
|
|
OpDecorate %MyCBuffer Binding 0
|
||
|
|
%bool = OpTypeBool
|
||
|
|
%true = OpConstantTrue %bool
|
||
|
|
%float = OpTypeFloat 32
|
||
|
|
%v4float = OpTypeVector %float 4
|
||
|
|
%uint = OpTypeInt 32 0
|
||
|
|
%uint_8 = OpConstant %uint 8
|
||
|
|
%_arr_v4float_uint_8 = OpTypeArray %v4float %uint_8
|
||
|
|
%type_MyCBuffer = OpTypeStruct %_arr_v4float_uint_8
|
||
|
|
%_ptr_Uniform_type_MyCBuffer = OpTypePointer Uniform %type_MyCBuffer
|
||
|
|
%void = OpTypeVoid
|
||
|
|
%13 = OpTypeFunction %void
|
||
|
|
%int = OpTypeInt 32 1
|
||
|
|
%_ptr_Input_int = OpTypePointer Input %int
|
||
|
|
%_ptr_Output_v4float = OpTypePointer Output %v4float
|
||
|
|
%_arr_v4float_uint_8_0 = OpTypeArray %v4float %uint_8
|
||
|
|
%_ptr_Function__arr_v4float_uint_8_0 = OpTypePointer Function %_arr_v4float_uint_8_0
|
||
|
|
%int_0 = OpConstant %int 0
|
||
|
|
%_ptr_Uniform__arr_v4float_uint_8 = OpTypePointer Uniform %_arr_v4float_uint_8
|
||
|
|
%_ptr_Function_v4float = OpTypePointer Function %v4float
|
||
|
|
%MyCBuffer = OpVariable %_ptr_Uniform_type_MyCBuffer Uniform
|
||
|
|
%in_var_INDEX = OpVariable %_ptr_Input_int Input
|
||
|
|
%out_var_SV_Target = OpVariable %_ptr_Output_v4float Output
|
||
|
|
%main = OpFunction %void None %13
|
||
|
|
%22 = OpLabel
|
||
|
|
%23 = OpVariable %_ptr_Function__arr_v4float_uint_8_0 Function
|
||
|
|
OpSelectionMerge %merge None
|
||
|
|
OpBranchConditional %true %if %else
|
||
|
|
%if = OpLabel
|
||
|
|
%24 = OpLoad %int %in_var_INDEX
|
||
|
|
%25 = OpAccessChain %_ptr_Uniform__arr_v4float_uint_8 %MyCBuffer %int_0
|
||
|
|
%26 = OpLoad %_arr_v4float_uint_8 %25
|
||
|
|
%27 = OpCompositeExtract %v4float %26 0
|
||
|
|
%28 = OpCompositeExtract %v4float %26 1
|
||
|
|
%29 = OpCompositeExtract %v4float %26 2
|
||
|
|
%30 = OpCompositeExtract %v4float %26 3
|
||
|
|
%31 = OpCompositeExtract %v4float %26 4
|
||
|
|
%32 = OpCompositeExtract %v4float %26 5
|
||
|
|
%33 = OpCompositeExtract %v4float %26 6
|
||
|
|
%34 = OpCompositeExtract %v4float %26 7
|
||
|
|
%35 = OpCompositeConstruct %_arr_v4float_uint_8_0 %27 %28 %29 %30 %31 %32 %33 %34
|
||
|
|
OpStore %23 %35
|
||
|
|
%38 = OpAccessChain %_ptr_Function_v4float %23 %24
|
||
|
|
%39 = OpLoad %v4float %36
|
||
|
|
OpBranch %merge
|
||
|
|
%else = OpLabel
|
||
|
|
%36 = OpAccessChain %_ptr_Function_v4float %23 %24
|
||
|
|
%37 = OpLoad %v4float %36
|
||
|
|
OpBranch %merge
|
||
|
|
%merge = OpLabel
|
||
|
|
%phi = OpPhi %out_var_SV_Target %39 %if %37 %else
|
||
|
|
OpStore %out_var_SV_Target %phi
|
||
|
|
OpReturn
|
||
|
|
OpFunctionEnd
|
||
|
|
)";
|
||
|
|
|
||
|
|
SetAssembleOptions(SPV_TEXT_TO_BINARY_OPTION_PRESERVE_NUMERIC_IDS);
|
||
|
|
SetDisassembleOptions(SPV_BINARY_TO_TEXT_OPTION_NO_HEADER |
|
||
|
|
SPV_BINARY_TO_TEXT_OPTION_FRIENDLY_NAMES);
|
||
|
|
auto result = SinglePassRunAndDisassemble<opt::CopyPropagateArrays>(
|
||
|
|
text, /* skip_nop = */ true, /* do_validation = */ false);
|
||
|
|
|
||
|
|
EXPECT_EQ(opt::Pass::Status::SuccessWithoutChange, std::get<1>(result));
|
||
|
|
}
|
||
|
|
|
||
|
|
// This test has a partial store to the variable. We cannot propagate in this
|
||
|
|
// case.
|
||
|
|
TEST_F(CopyPropArrayPassTest, PartialStore) {
|
||
|
|
const std::string text =
|
||
|
|
R"(
|
||
|
|
OpCapability Shader
|
||
|
|
OpMemoryModel Logical GLSL450
|
||
|
|
OpEntryPoint Fragment %main "main" %in_var_INDEX %out_var_SV_Target
|
||
|
|
OpExecutionMode %main OriginUpperLeft
|
||
|
|
OpSource HLSL 600
|
||
|
|
OpName %type_MyCBuffer "type.MyCBuffer"
|
||
|
|
OpMemberName %type_MyCBuffer 0 "Data"
|
||
|
|
OpName %MyCBuffer "MyCBuffer"
|
||
|
|
OpName %main "main"
|
||
|
|
OpName %in_var_INDEX "in.var.INDEX"
|
||
|
|
OpName %out_var_SV_Target "out.var.SV_Target"
|
||
|
|
OpDecorate %_arr_v4float_uint_8 ArrayStride 16
|
||
|
|
OpMemberDecorate %type_MyCBuffer 0 Offset 0
|
||
|
|
OpDecorate %type_MyCBuffer Block
|
||
|
|
OpDecorate %in_var_INDEX Flat
|
||
|
|
OpDecorate %in_var_INDEX Location 0
|
||
|
|
OpDecorate %out_var_SV_Target Location 0
|
||
|
|
OpDecorate %MyCBuffer DescriptorSet 0
|
||
|
|
OpDecorate %MyCBuffer Binding 0
|
||
|
|
%float = OpTypeFloat 32
|
||
|
|
%v4float = OpTypeVector %float 4
|
||
|
|
%uint = OpTypeInt 32 0
|
||
|
|
%uint_8 = OpConstant %uint 8
|
||
|
|
%_arr_v4float_uint_8 = OpTypeArray %v4float %uint_8
|
||
|
|
%type_MyCBuffer = OpTypeStruct %_arr_v4float_uint_8
|
||
|
|
%_ptr_Uniform_type_MyCBuffer = OpTypePointer Uniform %type_MyCBuffer
|
||
|
|
%void = OpTypeVoid
|
||
|
|
%13 = OpTypeFunction %void
|
||
|
|
%int = OpTypeInt 32 1
|
||
|
|
%_ptr_Input_int = OpTypePointer Input %int
|
||
|
|
%_ptr_Output_v4float = OpTypePointer Output %v4float
|
||
|
|
%_arr_v4float_uint_8_0 = OpTypeArray %v4float %uint_8
|
||
|
|
%_ptr_Function__arr_v4float_uint_8_0 = OpTypePointer Function %_arr_v4float_uint_8_0
|
||
|
|
%int_0 = OpConstant %int 0
|
||
|
|
%f0 = OpConstant %float 0
|
||
|
|
%v4const = OpConstantComposite %v4float %f0 %f0 %f0 %f0
|
||
|
|
%_ptr_Uniform__arr_v4float_uint_8 = OpTypePointer Uniform %_arr_v4float_uint_8
|
||
|
|
%_ptr_Function_v4float = OpTypePointer Function %v4float
|
||
|
|
%MyCBuffer = OpVariable %_ptr_Uniform_type_MyCBuffer Uniform
|
||
|
|
%in_var_INDEX = OpVariable %_ptr_Input_int Input
|
||
|
|
%out_var_SV_Target = OpVariable %_ptr_Output_v4float Output
|
||
|
|
%main = OpFunction %void None %13
|
||
|
|
%22 = OpLabel
|
||
|
|
%23 = OpVariable %_ptr_Function__arr_v4float_uint_8_0 Function
|
||
|
|
%24 = OpLoad %int %in_var_INDEX
|
||
|
|
%25 = OpAccessChain %_ptr_Uniform__arr_v4float_uint_8 %MyCBuffer %int_0
|
||
|
|
%26 = OpLoad %_arr_v4float_uint_8 %25
|
||
|
|
%27 = OpCompositeExtract %v4float %26 0
|
||
|
|
%28 = OpCompositeExtract %v4float %26 1
|
||
|
|
%29 = OpCompositeExtract %v4float %26 2
|
||
|
|
%30 = OpCompositeExtract %v4float %26 3
|
||
|
|
%31 = OpCompositeExtract %v4float %26 4
|
||
|
|
%32 = OpCompositeExtract %v4float %26 5
|
||
|
|
%33 = OpCompositeExtract %v4float %26 6
|
||
|
|
%34 = OpCompositeExtract %v4float %26 7
|
||
|
|
%35 = OpCompositeConstruct %_arr_v4float_uint_8_0 %27 %28 %29 %30 %31 %32 %33 %34
|
||
|
|
OpStore %23 %35
|
||
|
|
%36 = OpAccessChain %_ptr_Function_v4float %23 %24
|
||
|
|
%37 = OpLoad %v4float %36
|
||
|
|
%39 = OpStore %36 %v4const
|
||
|
|
OpStore %out_var_SV_Target %37
|
||
|
|
OpReturn
|
||
|
|
OpFunctionEnd
|
||
|
|
)";
|
||
|
|
|
||
|
|
SetAssembleOptions(SPV_TEXT_TO_BINARY_OPTION_PRESERVE_NUMERIC_IDS);
|
||
|
|
SetDisassembleOptions(SPV_BINARY_TO_TEXT_OPTION_NO_HEADER |
|
||
|
|
SPV_BINARY_TO_TEXT_OPTION_FRIENDLY_NAMES);
|
||
|
|
auto result = SinglePassRunAndDisassemble<opt::CopyPropagateArrays>(
|
||
|
|
text, /* skip_nop = */ true, /* do_validation = */ false);
|
||
|
|
|
||
|
|
EXPECT_EQ(opt::Pass::Status::SuccessWithoutChange, std::get<1>(result));
|
||
|
|
}
|
||
|
|
|
||
|
|
// This test does not have a proper copy of an object. We cannot propagate in
|
||
|
|
// this case.
|
||
|
|
TEST_F(CopyPropArrayPassTest, NotACopy) {
|
||
|
|
const std::string text =
|
||
|
|
R"(
|
||
|
|
OpCapability Shader
|
||
|
|
OpMemoryModel Logical GLSL450
|
||
|
|
OpEntryPoint Fragment %main "main" %in_var_INDEX %out_var_SV_Target
|
||
|
|
OpExecutionMode %main OriginUpperLeft
|
||
|
|
OpSource HLSL 600
|
||
|
|
OpName %type_MyCBuffer "type.MyCBuffer"
|
||
|
|
OpMemberName %type_MyCBuffer 0 "Data"
|
||
|
|
OpName %MyCBuffer "MyCBuffer"
|
||
|
|
OpName %main "main"
|
||
|
|
OpName %in_var_INDEX "in.var.INDEX"
|
||
|
|
OpName %out_var_SV_Target "out.var.SV_Target"
|
||
|
|
OpDecorate %_arr_v4float_uint_8 ArrayStride 16
|
||
|
|
OpMemberDecorate %type_MyCBuffer 0 Offset 0
|
||
|
|
OpDecorate %type_MyCBuffer Block
|
||
|
|
OpDecorate %in_var_INDEX Flat
|
||
|
|
OpDecorate %in_var_INDEX Location 0
|
||
|
|
OpDecorate %out_var_SV_Target Location 0
|
||
|
|
OpDecorate %MyCBuffer DescriptorSet 0
|
||
|
|
OpDecorate %MyCBuffer Binding 0
|
||
|
|
%float = OpTypeFloat 32
|
||
|
|
%v4float = OpTypeVector %float 4
|
||
|
|
%uint = OpTypeInt 32 0
|
||
|
|
%uint_8 = OpConstant %uint 8
|
||
|
|
%_arr_v4float_uint_8 = OpTypeArray %v4float %uint_8
|
||
|
|
%type_MyCBuffer = OpTypeStruct %_arr_v4float_uint_8
|
||
|
|
%_ptr_Uniform_type_MyCBuffer = OpTypePointer Uniform %type_MyCBuffer
|
||
|
|
%void = OpTypeVoid
|
||
|
|
%13 = OpTypeFunction %void
|
||
|
|
%int = OpTypeInt 32 1
|
||
|
|
%_ptr_Input_int = OpTypePointer Input %int
|
||
|
|
%_ptr_Output_v4float = OpTypePointer Output %v4float
|
||
|
|
%_arr_v4float_uint_8_0 = OpTypeArray %v4float %uint_8
|
||
|
|
%_ptr_Function__arr_v4float_uint_8_0 = OpTypePointer Function %_arr_v4float_uint_8_0
|
||
|
|
%int_0 = OpConstant %int 0
|
||
|
|
%f0 = OpConstant %float 0
|
||
|
|
%v4const = OpConstantComposite %v4float %f0 %f0 %f0 %f0
|
||
|
|
%_ptr_Uniform__arr_v4float_uint_8 = OpTypePointer Uniform %_arr_v4float_uint_8
|
||
|
|
%_ptr_Function_v4float = OpTypePointer Function %v4float
|
||
|
|
%MyCBuffer = OpVariable %_ptr_Uniform_type_MyCBuffer Uniform
|
||
|
|
%in_var_INDEX = OpVariable %_ptr_Input_int Input
|
||
|
|
%out_var_SV_Target = OpVariable %_ptr_Output_v4float Output
|
||
|
|
%main = OpFunction %void None %13
|
||
|
|
%22 = OpLabel
|
||
|
|
%23 = OpVariable %_ptr_Function__arr_v4float_uint_8_0 Function
|
||
|
|
%24 = OpLoad %int %in_var_INDEX
|
||
|
|
%25 = OpAccessChain %_ptr_Uniform__arr_v4float_uint_8 %MyCBuffer %int_0
|
||
|
|
%26 = OpLoad %_arr_v4float_uint_8 %25
|
||
|
|
%27 = OpCompositeExtract %v4float %26 0
|
||
|
|
%28 = OpCompositeExtract %v4float %26 0
|
||
|
|
%29 = OpCompositeExtract %v4float %26 2
|
||
|
|
%30 = OpCompositeExtract %v4float %26 3
|
||
|
|
%31 = OpCompositeExtract %v4float %26 4
|
||
|
|
%32 = OpCompositeExtract %v4float %26 5
|
||
|
|
%33 = OpCompositeExtract %v4float %26 6
|
||
|
|
%34 = OpCompositeExtract %v4float %26 7
|
||
|
|
%35 = OpCompositeConstruct %_arr_v4float_uint_8_0 %27 %28 %29 %30 %31 %32 %33 %34
|
||
|
|
OpStore %23 %35
|
||
|
|
%36 = OpAccessChain %_ptr_Function_v4float %23 %24
|
||
|
|
%37 = OpLoad %v4float %36
|
||
|
|
OpStore %out_var_SV_Target %37
|
||
|
|
OpReturn
|
||
|
|
OpFunctionEnd
|
||
|
|
)";
|
||
|
|
|
||
|
|
SetAssembleOptions(SPV_TEXT_TO_BINARY_OPTION_PRESERVE_NUMERIC_IDS);
|
||
|
|
SetDisassembleOptions(SPV_BINARY_TO_TEXT_OPTION_NO_HEADER |
|
||
|
|
SPV_BINARY_TO_TEXT_OPTION_FRIENDLY_NAMES);
|
||
|
|
auto result = SinglePassRunAndDisassemble<opt::CopyPropagateArrays>(
|
||
|
|
text, /* skip_nop = */ true, /* do_validation = */ false);
|
||
|
|
|
||
|
|
EXPECT_EQ(opt::Pass::Status::SuccessWithoutChange, std::get<1>(result));
|
||
|
|
}
|
||
|
|
|
||
|
|
// This test is okay except that we would have to change type of the store
|
||
|
|
// "OpStore %26 %41". We don't handle this yet.
|
||
|
|
TEST_F(CopyPropArrayPassTest, CantRewriteStore) {
|
||
|
|
const std::string text =
|
||
|
|
R"( OpCapability Shader
|
||
|
|
OpMemoryModel Logical GLSL450
|
||
|
|
OpEntryPoint Fragment %main "main" %in_var_INDEX %out_var_SV_Target
|
||
|
|
OpExecutionMode %main OriginUpperLeft
|
||
|
|
OpSource HLSL 600
|
||
|
|
OpName %type_MyCBuffer "type.MyCBuffer"
|
||
|
|
OpMemberName %type_MyCBuffer 0 "Data"
|
||
|
|
OpName %MyCBuffer "MyCBuffer"
|
||
|
|
OpName %main "main"
|
||
|
|
OpName %in_var_INDEX "in.var.INDEX"
|
||
|
|
OpName %out_var_SV_Target "out.var.SV_Target"
|
||
|
|
OpDecorate %_arr_v4float_uint_2 ArrayStride 16
|
||
|
|
OpDecorate %_arr__arr_v4float_uint_2_uint_2 ArrayStride 32
|
||
|
|
OpMemberDecorate %type_MyCBuffer 0 Offset 0
|
||
|
|
OpDecorate %type_MyCBuffer Block
|
||
|
|
OpDecorate %in_var_INDEX Flat
|
||
|
|
OpDecorate %in_var_INDEX Location 0
|
||
|
|
OpDecorate %out_var_SV_Target Location 0
|
||
|
|
OpDecorate %MyCBuffer DescriptorSet 0
|
||
|
|
OpDecorate %MyCBuffer Binding 0
|
||
|
|
%float = OpTypeFloat 32
|
||
|
|
%v4float = OpTypeVector %float 4
|
||
|
|
%uint = OpTypeInt 32 0
|
||
|
|
%uint_2 = OpConstant %uint 2
|
||
|
|
%_arr_v4float_uint_2 = OpTypeArray %v4float %uint_2
|
||
|
|
%_arr__arr_v4float_uint_2_uint_2 = OpTypeArray %_arr_v4float_uint_2 %uint_2
|
||
|
|
%type_MyCBuffer = OpTypeStruct %_arr__arr_v4float_uint_2_uint_2
|
||
|
|
%_ptr_Uniform_type_MyCBuffer = OpTypePointer Uniform %type_MyCBuffer
|
||
|
|
%void = OpTypeVoid
|
||
|
|
%14 = OpTypeFunction %void
|
||
|
|
%int = OpTypeInt 32 1
|
||
|
|
%_ptr_Input_int = OpTypePointer Input %int
|
||
|
|
%_ptr_Output_v4float = OpTypePointer Output %v4float
|
||
|
|
%_arr_v4float_uint_2_0 = OpTypeArray %v4float %uint_2
|
||
|
|
%_arr__arr_v4float_uint_2_0_uint_2 = OpTypeArray %_arr_v4float_uint_2_0 %uint_2
|
||
|
|
%_ptr_Function__arr__arr_v4float_uint_2_0_uint_2 = OpTypePointer Function %_arr__arr_v4float_uint_2_0_uint_2
|
||
|
|
%int_0 = OpConstant %int 0
|
||
|
|
%_ptr_Uniform__arr__arr_v4float_uint_2_uint_2 = OpTypePointer Uniform %_arr__arr_v4float_uint_2_uint_2
|
||
|
|
%_ptr_Function__arr_v4float_uint_2_0 = OpTypePointer Function %_arr_v4float_uint_2_0
|
||
|
|
%_ptr_Function_v4float = OpTypePointer Function %v4float
|
||
|
|
%MyCBuffer = OpVariable %_ptr_Uniform_type_MyCBuffer Uniform
|
||
|
|
%in_var_INDEX = OpVariable %_ptr_Input_int Input
|
||
|
|
%out_var_SV_Target = OpVariable %_ptr_Output_v4float Output
|
||
|
|
%main = OpFunction %void None %14
|
||
|
|
%25 = OpLabel
|
||
|
|
%26 = OpVariable %_ptr_Function__arr_v4float_uint_2_0 Function
|
||
|
|
%27 = OpVariable %_ptr_Function__arr__arr_v4float_uint_2_0_uint_2 Function
|
||
|
|
%28 = OpLoad %int %in_var_INDEX
|
||
|
|
%29 = OpAccessChain %_ptr_Uniform__arr__arr_v4float_uint_2_uint_2 %MyCBuffer %int_0
|
||
|
|
%30 = OpLoad %_arr__arr_v4float_uint_2_uint_2 %29
|
||
|
|
%31 = OpCompositeExtract %_arr_v4float_uint_2 %30 0
|
||
|
|
%32 = OpCompositeExtract %v4float %31 0
|
||
|
|
%33 = OpCompositeExtract %v4float %31 1
|
||
|
|
%34 = OpCompositeConstruct %_arr_v4float_uint_2_0 %32 %33
|
||
|
|
%35 = OpCompositeExtract %_arr_v4float_uint_2 %30 1
|
||
|
|
%36 = OpCompositeExtract %v4float %35 0
|
||
|
|
%37 = OpCompositeExtract %v4float %35 1
|
||
|
|
%38 = OpCompositeConstruct %_arr_v4float_uint_2_0 %36 %37
|
||
|
|
%39 = OpCompositeConstruct %_arr__arr_v4float_uint_2_0_uint_2 %34 %38
|
||
|
|
OpStore %27 %39
|
||
|
|
%40 = OpAccessChain %_ptr_Function__arr_v4float_uint_2_0 %27 %28
|
||
|
|
%41 = OpLoad %_arr_v4float_uint_2_0 %40
|
||
|
|
OpStore %26 %41
|
||
|
|
%42 = OpAccessChain %_ptr_Function_v4float %26 %28
|
||
|
|
%43 = OpLoad %v4float %42
|
||
|
|
OpStore %out_var_SV_Target %43
|
||
|
|
OpReturn
|
||
|
|
OpFunctionEnd
|
||
|
|
)";
|
||
|
|
|
||
|
|
SetAssembleOptions(SPV_TEXT_TO_BINARY_OPTION_PRESERVE_NUMERIC_IDS);
|
||
|
|
SetDisassembleOptions(SPV_BINARY_TO_TEXT_OPTION_NO_HEADER |
|
||
|
|
SPV_BINARY_TO_TEXT_OPTION_FRIENDLY_NAMES);
|
||
|
|
auto result = SinglePassRunAndDisassemble<opt::CopyPropagateArrays>(
|
||
|
|
text, /* skip_nop = */ true, /* do_validation = */ false);
|
||
|
|
|
||
|
|
EXPECT_EQ(opt::Pass::Status::SuccessWithoutChange, std::get<1>(result));
|
||
|
|
}
|
||
|
|
|
||
|
|
} // namespace
|