AuroraMiddleware/SPIRV-Tools
1
0
Fork 0
mirror of https://github.com/KhronosGroup/SPIRV-Tools synced 2024-10-18 19:20:05 +00:00
Code Issues Packages Projects Releases Wiki Activity
d35a78db57
SPIRV-Tools/test/val/val_capability_test.cpp

2983 lines
111 KiB
C++
Raw Normal View History

Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
// Copyright (c) 2015-2016 The Khronos Group Inc.
//
Relicense SPIRV-Tools under Apache 2.0 Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/383 Finalize v2016.4
2016-09-01 19:33:59 +00:00
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
//
Relicense SPIRV-Tools under Apache 2.0 Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/383 Finalize v2016.4
2016-09-01 19:33:59 +00:00
// http://www.apache.org/licenses/LICENSE-2.0
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
//
Relicense SPIRV-Tools under Apache 2.0 Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/383 Finalize v2016.4
2016-09-01 19:33:59 +00:00
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
// Validation tests for Logical Layout
#include <sstream>
#include <string>
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
#include <tuple>
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
#include <utility>
Cleanup includes. (#1795) This Cl cleans up the include paths to be relative to the top level directory. Various include-what-you-use fixes have been added.
2018-08-03 19:06:09 +00:00
#include <vector>
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Cleanup includes. (#1795) This Cl cleans up the include paths to be relative to the top level directory. Various include-what-you-use fixes have been added.
2018-08-03 19:06:09 +00:00
#include "gmock/gmock.h"
Rename validation tests to comply with Google style guide.
2016-11-08 18:11:07 +00:00
#include "source/assembly_grammar.h"
Cleanup includes. (#1795) This Cl cleans up the include paths to be relative to the top level directory. Various include-what-you-use fixes have been added.
2018-08-03 19:06:09 +00:00
#include "source/spirv_target_env.h"
SPIRV-Tools support for SPIR-V 1.5 (#2865) * Ensure same enum values have consistent extension lists * val: fix checking of capabilities The operand for an OpCapability should only be checked for the extension or core version. The InstructionPass registers a capability, and all its implied sub-capabilities before actually checking the operand to an OpCapability. * Add basic support for SPIR-V 1.5 - Adds SPV_ENV_UNIVERSAL_1_5 - Command line tools default to spv1.5 environment - SPIR-V 1.5 incorporates several extensions. Now the disassembler prefers outputing the non-EXT or non-KHR names. This requires updates to many tests, to make strings match again. - Command line tests: Expect SPIR-V 1.5 by default * Test validation of SPIR-V 1.5 incorporated extensions Starting with 1.5, incorporated features no longer require the associated OpExtension instruction.
2019-09-13 18:59:02 +00:00
#include "spirv-tools/libspirv.h"
Cleanup includes. (#1795) This Cl cleans up the include paths to be relative to the top level directory. Various include-what-you-use fixes have been added.
2018-08-03 19:06:09 +00:00
#include "test/test_fixture.h"
#include "test/unit_spirv.h"
#include "test/val/val_fixtures.h"
Rename validation tests to comply with Google style guide.
2016-11-08 18:11:07 +00:00
Move tests into namespaces (#1689) This CL moves the test into namespaces based on their directories.
2018-07-11 13:24:49 +00:00
namespace spvtools {
namespace val {
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
namespace {
Add tests for SubgroupDispatch. Introduced in v1.1, SubgroupDispatch adds the following: - two new execution modes - one new capability - two new opcodes Extend ValidateBase methods to take a spv_target_env. Replace the context_ member with ScopedContext inside the said methods. Give ScopedContext wider visibility by moving it outside TextToBinaryTestBase.
2016-04-21 19:46:08 +00:00
using spvtest::ScopedContext;
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
using testing::Combine;
SPIRV-Tools support for SPIR-V 1.5 (#2865) * Ensure same enum values have consistent extension lists * val: fix checking of capabilities The operand for an OpCapability should only be checked for the extension or core version. The InstructionPass registers a capability, and all its implied sub-capabilities before actually checking the operand to an OpCapability. * Add basic support for SPIR-V 1.5 - Adds SPV_ENV_UNIVERSAL_1_5 - Command line tools default to spv1.5 environment - SPIR-V 1.5 incorporates several extensions. Now the disassembler prefers outputing the non-EXT or non-KHR names. This requires updates to many tests, to make strings match again. - Command line tests: Expect SPIR-V 1.5 by default * Test validation of SPIR-V 1.5 incorporated extensions Starting with 1.5, incorporated features no longer require the associated OpExtension instruction.
2019-09-13 18:59:02 +00:00
using testing::Eq;
The Signedness in OpTypeInt must always be 0. When Kernel capability is used, The Signedness in OpTypeInt must always be 0. Fixes issue #492.
2017-02-09 21:23:40 +00:00
using testing::HasSubstr;
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
using testing::Values;
using testing::ValuesIn;
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
// Parameter for validation test fixtures. The first std::string is a
// capability name that will begin the assembly under test, the second the
// remainder assembly, and the std::vector at the end determines whether the
// test expects success or failure. See below for details and convenience
// methods to access each one.
Add v1.1 capabilities validation. Refactor the ValidateCapability test fixture. Explain the meaning of test parameters. Factor out methods for convenience and readability. DRY v1.0 and v1.1 tests.
2016-04-29 17:40:01 +00:00
//
// The assembly to test is composed from a variable top line and a fixed
// remainder. The top line will be an OpCapability instruction, while the
// remainder will be some assembly text that succeeds or fails to assemble
// depending on which capability was chosen. For instance, the following will
// succeed:
//
// OpCapability Pipes ; implies Kernel
// OpLifetimeStop %1 0 ; requires Kernel
//
// and the following will fail:
//
// OpCapability Kernel
// %1 = OpTypeNamedBarrier ; requires NamedBarrier
//
// So how does the test parameter capture which capabilities should cause
// success and which shouldn't? The answer is in the last element: it's a
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
// std::vector of capabilities that make the remainder assembly succeed. So if
// the first-line capability exists in that std::vector, success is expected;
// otherwise, failure is expected in the tests.
Add v1.1 capabilities validation. Refactor the ValidateCapability test fixture. Explain the meaning of test parameters. Factor out methods for convenience and readability. DRY v1.0 and v1.1 tests.
2016-04-29 17:40:01 +00:00
//
// We will use testing::Combine() to vary the first line: when we combine
// AllCapabilities() with a single remainder assembly, we generate enough test
// cases to try the assembly with every possible capability that could be
// declared. However, Combine() only produces tuples -- it cannot produce, say,
// a struct. Therefore, this type must be a tuple.
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
using CapTestParameter =
std::tuple<std::string, std::pair<std::string, std::vector<std::string>>>;
Add v1.1 capabilities validation. Refactor the ValidateCapability test fixture. Explain the meaning of test parameters. Factor out methods for convenience and readability. DRY v1.0 and v1.1 tests.
2016-04-29 17:40:01 +00:00
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::string& Capability(const CapTestParameter& p) {
return std::get<0>(p);
}
const std::string& Remainder(const CapTestParameter& p) {
return std::get<1>(p).first;
}
const std::vector<std::string>& MustSucceed(const CapTestParameter& p) {
return std::get<1>(p).second;
Add v1.1 capabilities validation. Refactor the ValidateCapability test fixture. Explain the meaning of test parameters. Factor out methods for convenience and readability. DRY v1.0 and v1.1 tests.
2016-04-29 17:40:01 +00:00
}
// Creates assembly to test from p.
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string MakeAssembly(const CapTestParameter& p) {
std::ostringstream ss;
const std::string& capability = Capability(p);
Add v1.1 capabilities validation. Refactor the ValidateCapability test fixture. Explain the meaning of test parameters. Factor out methods for convenience and readability. DRY v1.0 and v1.1 tests.
2016-04-29 17:40:01 +00:00
if (!capability.empty()) {
ss << "OpCapability " << capability << "\n";
}
ss << Remainder(p);
return ss.str();
}
// Expected validation result for p.
spv_result_t ExpectedResult(const CapTestParameter& p) {
const auto& caps = MustSucceed(p);
auto found = find(begin(caps), end(caps), Capability(p));
return (found == end(caps)) ? SPV_ERROR_INVALID_CAPABILITY : SPV_SUCCESS;
}
// Assembles using v1.0, unless the parameter's capability requires v1.1.
using ValidateCapability = spvtest::ValidateBase<CapTestParameter>;
// Always assembles using v1.1.
using ValidateCapabilityV11 = spvtest::ValidateBase<CapTestParameter>;
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Turn off ClipDistance CullDistance cap checks for Vulkan Turn them off until resolution of the debate over how they should be checked. Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/261
2016-07-07 21:03:22 +00:00
// Always assembles using Vulkan 1.0.
// TODO(dneto): Refactor all these tests to scale better across environments.
using ValidateCapabilityVulkan10 = spvtest::ValidateBase<CapTestParameter>;
Relax ClipDistance, CullDistance capability check in all environments Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/365
2016-08-23 22:18:17 +00:00
// Always assembles using OpenGL 4.0.
using ValidateCapabilityOpenGL40 = spvtest::ValidateBase<CapTestParameter>;
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
// Always assembles using Vulkan 1.1.
using ValidateCapabilityVulkan11 = spvtest::ValidateBase<CapTestParameter>;
Validate Vulkan 1.2 capabilities
2019-09-04 15:51:18 +00:00
// Always assembles using Vulkan 1.2.
using ValidateCapabilityVulkan12 = spvtest::ValidateBase<CapTestParameter>;
Turn off ClipDistance CullDistance cap checks for Vulkan Turn them off until resolution of the debate over how they should be checked. Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/261
2016-07-07 21:03:22 +00:00
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
TEST_F(ValidateCapability, Default) {
Add tests for SubgroupDispatch. Introduced in v1.1, SubgroupDispatch adds the following: - two new execution modes - one new capability - two new opcodes Extend ValidateBase methods to take a spv_target_env. Replace the context_ member with ScopedContext inside the said methods. Give ScopedContext wider visibility by moving it outside TextToBinaryTestBase.
2016-04-21 19:46:08 +00:00
const char str[] = R"(
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
OpCapability Kernel
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
OpCapability Linkage
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
OpCapability Matrix
OpMemoryModel Logical OpenCL
Adding validation code for more data rules. These rules are under "Data Rules" in 2.16.1 (Universal Validation Rules) part of the SPIR-V 1.1 Specification document: * Scalar floating-point types can be parameterized only as 32 bit, plus any additional sizes enabled by capabilities. * Scalar integer types can be parameterized only as 32 bit, plus any additional sizes enabled by capabilities. * Vector types can only be parameterized with numerical types or the OpTypeBool type. * Matrix types can only be parameterized with floating-point types. * Matrix types can only be parameterized as having only 2, 3, or 4 columns. * Specialization constants (see Specialization) are limited to integers, Booleans, floating-point numbers, and vectors of these.
2016-11-10 20:12:26 +00:00
%f32 = OpTypeFloat 32
%vec3 = OpTypeVector %f32 3
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
%mat33 = OpTypeMatrix %vec3 3
)";
CompileSuccessfully(str);
ASSERT_EQ(SPV_SUCCESS, ValidateInstructions());
}
// clang-format off
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::vector<std::string>& AllCapabilities() {
static const auto r = new std::vector<std::string>{
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
"",
"Matrix",
"Shader",
"Geometry",
"Tessellation",
"Addresses",
"Linkage",
"Kernel",
"Vector16",
"Float16Buffer",
"Float16",
"Float64",
"Int64",
"Int64Atomics",
"ImageBasic",
"ImageReadWrite",
"ImageMipmap",
"Pipes",
"Groups",
"DeviceEnqueue",
"LiteralSampler",
"AtomicStorage",
"Int16",
"TessellationPointSize",
"GeometryPointSize",
"ImageGatherExtended",
"StorageImageMultisample",
"UniformBufferArrayDynamicIndexing",
"SampledImageArrayDynamicIndexing",
"StorageBufferArrayDynamicIndexing",
"StorageImageArrayDynamicIndexing",
"ClipDistance",
"CullDistance",
"ImageCubeArray",
"SampleRateShading",
"ImageRect",
"SampledRect",
"GenericPointer",
"Int8",
"InputAttachment",
"SparseResidency",
"MinLod",
"Sampled1D",
"Image1D",
"SampledCubeArray",
"SampledBuffer",
"ImageBuffer",
"ImageMSArray",
"StorageImageExtendedFormats",
"ImageQuery",
"DerivativeControl",
"InterpolationFunction",
"TransformFeedback",
"GeometryStreams",
"StorageImageReadWithoutFormat",
Add MultiViewport capability, new in 1.0.3 Fix typos in previous tests with MultiViewport.
2016-02-17 17:12:45 +00:00
"StorageImageWriteWithoutFormat",
Add tests for SubgroupDispatch. Introduced in v1.1, SubgroupDispatch adds the following: - two new execution modes - one new capability - two new opcodes Extend ValidateBase methods to take a spv_target_env. Replace the context_ member with ScopedContext inside the said methods. Give ScopedContext wider visibility by moving it outside TextToBinaryTestBase.
2016-04-21 19:46:08 +00:00
"MultiViewport",
Add v1.1 capabilities validation. Refactor the ValidateCapability test fixture. Explain the meaning of test parameters. Factor out methods for convenience and readability. DRY v1.0 and v1.1 tests.
2016-04-29 17:40:01 +00:00
"SubgroupDispatch",
"NamedBarrier",
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
"PipeStorage",
"GroupNonUniform",
"GroupNonUniformVote",
"GroupNonUniformArithmetic",
"GroupNonUniformBallot",
"GroupNonUniformShuffle",
"GroupNonUniformShuffleRelative",
"GroupNonUniformClustered",
"GroupNonUniformQuad",
"DrawParameters",
"StorageBuffer16BitAccess",
"StorageUniformBufferBlock16",
"UniformAndStorageBuffer16BitAccess",
"StorageUniform16",
"StoragePushConstant16",
"StorageInputOutput16",
"DeviceGroup",
"MultiView",
"VariablePointersStorageBuffer",
"VariablePointers"};
Initialize vector<string>s on first use, not statically.
2016-01-28 18:18:00 +00:00
return *r;
}
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Validate Vulkan 1.2 capabilities
2019-09-04 15:51:18 +00:00
const std::vector<std::string>& AllSpirV15Capabilities() {
static const auto r = new std::vector<std::string>{
"",
"Matrix",
"Shader",
"Geometry",
"Tessellation",
"Addresses",
"Linkage",
"Kernel",
"Vector16",
"Float16Buffer",
"Float16",
"Float64",
"Int64",
"Int64Atomics",
"ImageBasic",
"ImageReadWrite",
"ImageMipmap",
"Pipes",
"Groups",
"DeviceEnqueue",
"LiteralSampler",
"AtomicStorage",
"Int16",
"TessellationPointSize",
"GeometryPointSize",
"ImageGatherExtended",
"StorageImageMultisample",
"UniformBufferArrayDynamicIndexing",
"SampledImageArrayDynamicIndexing",
"StorageBufferArrayDynamicIndexing",
"StorageImageArrayDynamicIndexing",
"ClipDistance",
"CullDistance",
"ImageCubeArray",
"SampleRateShading",
"ImageRect",
"SampledRect",
"GenericPointer",
"Int8",
"InputAttachment",
"SparseResidency",
"MinLod",
"Sampled1D",
"Image1D",
"SampledCubeArray",
"SampledBuffer",
"ImageBuffer",
"ImageMSArray",
"StorageImageExtendedFormats",
"ImageQuery",
"DerivativeControl",
"InterpolationFunction",
"TransformFeedback",
"GeometryStreams",
"StorageImageReadWithoutFormat",
"StorageImageWriteWithoutFormat",
"MultiViewport",
"SubgroupDispatch",
"NamedBarrier",
"PipeStorage",
"GroupNonUniform",
"GroupNonUniformVote",
"GroupNonUniformArithmetic",
"GroupNonUniformBallot",
"GroupNonUniformShuffle",
"GroupNonUniformShuffleRelative",
"GroupNonUniformClustered",
"GroupNonUniformQuad",
"DrawParameters",
"StorageBuffer16BitAccess",
"StorageUniformBufferBlock16",
"UniformAndStorageBuffer16BitAccess",
"StorageUniform16",
"StoragePushConstant16",
"StorageInputOutput16",
"DeviceGroup",
"MultiView",
"VariablePointersStorageBuffer",
"VariablePointers",
"DenormPreserve",
"DenormFlushToZero",
"SignedZeroInfNanPreserve",
"RoundingModeRTE",
"RoundingModeRTZ",
// Omitted due to extra validation requirements on memory model.
//"VulkanMemoryModel",
//"VulkanMemoryModelDeviceScope",
"StorageBuffer8BitAccess",
"UniformAndStorageBuffer8BitAccess",
"StoragePushConstant8",
"ShaderViewportIndex",
"ShaderLayer",
"PhysicalStorageBufferAddresses",
"RuntimeDescriptorArray",
"UniformTexelBufferArrayDynamicIndexing",
"StorageTexelBufferArrayDynamicIndexing",
"UniformBufferArrayNonUniformIndexing",
"SampledImageArrayNonUniformIndexing",
"StorageBufferArrayNonUniformIndexing",
"StorageImageArrayNonUniformIndexing",
"InputAttachmentArrayNonUniformIndexing",
"UniformTexelBufferArrayNonUniformIndexing",
"StorageTexelBufferArrayNonUniformIndexing"};
return *r;
}
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::vector<std::string>& AllSpirV10Capabilities() {
static const auto r = new std::vector<std::string>{
Test SpecId validation.
2016-05-10 21:02:41 +00:00
"",
"Matrix",
"Shader",
"Geometry",
"Tessellation",
"Addresses",
"Linkage",
"Kernel",
"Vector16",
"Float16Buffer",
"Float16",
"Float64",
"Int64",
"Int64Atomics",
"ImageBasic",
"ImageReadWrite",
"ImageMipmap",
"Pipes",
"Groups",
"DeviceEnqueue",
"LiteralSampler",
"AtomicStorage",
"Int16",
"TessellationPointSize",
"GeometryPointSize",
"ImageGatherExtended",
"StorageImageMultisample",
"UniformBufferArrayDynamicIndexing",
"SampledImageArrayDynamicIndexing",
"StorageBufferArrayDynamicIndexing",
"StorageImageArrayDynamicIndexing",
"ClipDistance",
"CullDistance",
"ImageCubeArray",
"SampleRateShading",
"ImageRect",
"SampledRect",
"GenericPointer",
"Int8",
"InputAttachment",
"SparseResidency",
"MinLod",
"Sampled1D",
"Image1D",
"SampledCubeArray",
"SampledBuffer",
"ImageBuffer",
"ImageMSArray",
"StorageImageExtendedFormats",
"ImageQuery",
"DerivativeControl",
"InterpolationFunction",
"TransformFeedback",
"GeometryStreams",
"StorageImageReadWithoutFormat",
"StorageImageWriteWithoutFormat",
"MultiViewport"};
return *r;
}
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::vector<std::string>& AllVulkan10Capabilities() {
static const auto r = new std::vector<std::string>{
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
"",
"Matrix",
"Shader",
"InputAttachment",
"Sampled1D",
"Image1D",
"SampledBuffer",
"ImageBuffer",
"ImageQuery",
"DerivativeControl",
"Geometry",
"Tessellation",
Allow Float16/Int8 for Vulkan 1.0 (#2153)
2018-12-03 17:50:12 +00:00
"Float16",
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
"Float64",
"Int64",
Add support for VK_KHR_shader_atomic_int64 in validator
2018-09-14 18:07:25 +00:00
"Int64Atomics",
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
"Int16",
"TessellationPointSize",
"GeometryPointSize",
"ImageGatherExtended",
"StorageImageMultisample",
"UniformBufferArrayDynamicIndexing",
"SampledImageArrayDynamicIndexing",
"StorageBufferArrayDynamicIndexing",
"StorageImageArrayDynamicIndexing",
"ClipDistance",
"CullDistance",
"ImageCubeArray",
"SampleRateShading",
Allow Float16/Int8 for Vulkan 1.0 (#2153)
2018-12-03 17:50:12 +00:00
"Int8",
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
"SparseResidency",
"MinLod",
"SampledCubeArray",
"ImageMSArray",
"StorageImageExtendedFormats",
"InterpolationFunction",
"StorageImageReadWithoutFormat",
"StorageImageWriteWithoutFormat",
Add support for VK_EXT_Transform_feedback capabilities (#2088) * Added support for Transform Feedback capabilities. * Fix tests
2018-11-20 17:41:03 +00:00
"MultiViewport",
"TransformFeedback",
"GeometryStreams"};
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
return *r;
}
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::vector<std::string>& AllVulkan11Capabilities() {
static const auto r = new std::vector<std::string>{
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
"",
"Matrix",
"Shader",
"InputAttachment",
"Sampled1D",
"Image1D",
"SampledBuffer",
"ImageBuffer",
"ImageQuery",
"DerivativeControl",
"Geometry",
"Tessellation",
Allow Float16/Int8 for Vulkan 1.0 (#2153)
2018-12-03 17:50:12 +00:00
"Float16",
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
"Float64",
"Int64",
Add support for VK_KHR_shader_atomic_int64 in validator
2018-09-14 18:07:25 +00:00
"Int64Atomics",
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
"Int16",
"TessellationPointSize",
"GeometryPointSize",
"ImageGatherExtended",
"StorageImageMultisample",
"UniformBufferArrayDynamicIndexing",
"SampledImageArrayDynamicIndexing",
"StorageBufferArrayDynamicIndexing",
"StorageImageArrayDynamicIndexing",
"ClipDistance",
"CullDistance",
"ImageCubeArray",
"SampleRateShading",
Allow Float16/Int8 for Vulkan 1.0 (#2153)
2018-12-03 17:50:12 +00:00
"Int8",
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
"SparseResidency",
"MinLod",
"SampledCubeArray",
"ImageMSArray",
"StorageImageExtendedFormats",
"InterpolationFunction",
"StorageImageReadWithoutFormat",
"StorageImageWriteWithoutFormat",
"MultiViewport",
"GroupNonUniform",
"GroupNonUniformVote",
"GroupNonUniformArithmetic",
"GroupNonUniformBallot",
"GroupNonUniformShuffle",
"GroupNonUniformShuffleRelative",
"GroupNonUniformClustered",
"GroupNonUniformQuad",
"DrawParameters",
"StorageBuffer16BitAccess",
"StorageUniformBufferBlock16",
"UniformAndStorageBuffer16BitAccess",
"StorageUniform16",
"StoragePushConstant16",
"StorageInputOutput16",
"DeviceGroup",
"MultiView",
"VariablePointersStorageBuffer",
Add support for VK_EXT_Transform_feedback capabilities (#2088) * Added support for Transform Feedback capabilities. * Fix tests
2018-11-20 17:41:03 +00:00
"VariablePointers",
"TransformFeedback",
"GeometryStreams"};
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
return *r;
}
Validate Vulkan 1.2 capabilities
2019-09-04 15:51:18 +00:00
const std::vector<std::string>& AllVulkan12Capabilities() {
static const auto r = new std::vector<std::string>{
"",
"Matrix",
"Shader",
"InputAttachment",
"Sampled1D",
"Image1D",
"SampledBuffer",
"ImageBuffer",
"ImageQuery",
"DerivativeControl",
"Geometry",
"Tessellation",
"Float16",
"Float64",
"Int64",
"Int64Atomics",
"Int16",
"TessellationPointSize",
"GeometryPointSize",
"ImageGatherExtended",
"StorageImageMultisample",
"UniformBufferArrayDynamicIndexing",
"SampledImageArrayDynamicIndexing",
"StorageBufferArrayDynamicIndexing",
"StorageImageArrayDynamicIndexing",
"ClipDistance",
"CullDistance",
"ImageCubeArray",
"SampleRateShading",
"Int8",
"SparseResidency",
"MinLod",
"SampledCubeArray",
"ImageMSArray",
"StorageImageExtendedFormats",
"InterpolationFunction",
"StorageImageReadWithoutFormat",
"StorageImageWriteWithoutFormat",
"MultiViewport",
"GroupNonUniform",
"GroupNonUniformVote",
"GroupNonUniformArithmetic",
"GroupNonUniformBallot",
"GroupNonUniformShuffle",
"GroupNonUniformShuffleRelative",
"GroupNonUniformClustered",
"GroupNonUniformQuad",
"DrawParameters",
"StorageBuffer16BitAccess",
"StorageUniformBufferBlock16",
"UniformAndStorageBuffer16BitAccess",
"StorageUniform16",
"StoragePushConstant16",
"StorageInputOutput16",
"DeviceGroup",
"MultiView",
"VariablePointersStorageBuffer",
"VariablePointers",
"TransformFeedback",
"GeometryStreams",
"DenormPreserve",
"DenormFlushToZero",
"SignedZeroInfNanPreserve",
"RoundingModeRTE",
"RoundingModeRTZ",
"VulkanMemoryModel",
"VulkanMemoryModelDeviceScope",
"StorageBuffer8BitAccess",
"UniformAndStorageBuffer8BitAccess",
"StoragePushConstant8",
"ShaderViewportIndex",
"ShaderLayer",
"PhysicalStorageBufferAddresses",
"RuntimeDescriptorArray",
"UniformTexelBufferArrayDynamicIndexing",
"StorageTexelBufferArrayDynamicIndexing",
"UniformBufferArrayNonUniformIndexing",
"SampledImageArrayNonUniformIndexing",
"StorageBufferArrayNonUniformIndexing",
"StorageImageArrayNonUniformIndexing",
"InputAttachmentArrayNonUniformIndexing",
"UniformTexelBufferArrayNonUniformIndexing",
"StorageTexelBufferArrayNonUniformIndexing"};
return *r;
}
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::vector<std::string>& MatrixDependencies() {
static const auto r = new std::vector<std::string>{
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
"Matrix",
"Shader",
"Geometry",
"Tessellation",
"AtomicStorage",
"TessellationPointSize",
"GeometryPointSize",
"ImageGatherExtended",
"StorageImageMultisample",
"UniformBufferArrayDynamicIndexing",
"SampledImageArrayDynamicIndexing",
"StorageBufferArrayDynamicIndexing",
"StorageImageArrayDynamicIndexing",
"ClipDistance",
"CullDistance",
"ImageCubeArray",
"SampleRateShading",
"ImageRect",
"SampledRect",
"InputAttachment",
"SparseResidency",
"MinLod",
"SampledCubeArray",
"ImageMSArray",
"StorageImageExtendedFormats",
"ImageQuery",
"DerivativeControl",
"InterpolationFunction",
"TransformFeedback",
"GeometryStreams",
"StorageImageReadWithoutFormat",
Add MultiViewport capability, new in 1.0.3 Fix typos in previous tests with MultiViewport.
2016-02-17 17:12:45 +00:00
"StorageImageWriteWithoutFormat",
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
"MultiViewport",
"DrawParameters",
"MultiView",
"VariablePointersStorageBuffer",
"VariablePointers"};
Initialize vector<string>s on first use, not statically.
2016-01-28 18:18:00 +00:00
return *r;
}
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::vector<std::string>& ShaderDependencies() {
static const auto r = new std::vector<std::string>{
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
"Shader",
"Geometry",
"Tessellation",
"AtomicStorage",
"TessellationPointSize",
"GeometryPointSize",
"ImageGatherExtended",
"StorageImageMultisample",
"UniformBufferArrayDynamicIndexing",
"SampledImageArrayDynamicIndexing",
"StorageBufferArrayDynamicIndexing",
"StorageImageArrayDynamicIndexing",
"ClipDistance",
"CullDistance",
"ImageCubeArray",
"SampleRateShading",
"ImageRect",
"SampledRect",
"InputAttachment",
"SparseResidency",
"MinLod",
"SampledCubeArray",
"ImageMSArray",
"StorageImageExtendedFormats",
"ImageQuery",
"DerivativeControl",
"InterpolationFunction",
"TransformFeedback",
"GeometryStreams",
"StorageImageReadWithoutFormat",
Add MultiViewport capability, new in 1.0.3 Fix typos in previous tests with MultiViewport.
2016-02-17 17:12:45 +00:00
"StorageImageWriteWithoutFormat",
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
"MultiViewport",
"DrawParameters",
"MultiView",
"VariablePointersStorageBuffer",
"VariablePointers"};
Initialize vector<string>s on first use, not statically.
2016-01-28 18:18:00 +00:00
return *r;
}
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::vector<std::string>& TessellationDependencies() {
static const auto r = new std::vector<std::string>{
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
"Tessellation",
Initialize vector<string>s on first use, not statically.
2016-01-28 18:18:00 +00:00
"TessellationPointSize"};
return *r;
}
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::vector<std::string>& GeometryDependencies() {
static const auto r = new std::vector<std::string>{
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
"Geometry",
"GeometryPointSize",
Update capabilities for 1.0 Rev3
2016-02-14 18:55:50 +00:00
"GeometryStreams",
Add MultiViewport capability, new in 1.0.3 Fix typos in previous tests with MultiViewport.
2016-02-17 17:12:45 +00:00
"MultiViewport"};
Initialize vector<string>s on first use, not statically.
2016-01-28 18:18:00 +00:00
return *r;
}
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::vector<std::string>& GeometryTessellationDependencies() {
static const auto r = new std::vector<std::string>{
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
"Tessellation",
"TessellationPointSize",
"Geometry",
"GeometryPointSize",
Add MultiViewport capability, new in 1.0.3 Fix typos in previous tests with MultiViewport.
2016-02-17 17:12:45 +00:00
"GeometryStreams",
"MultiViewport"};
Initialize vector<string>s on first use, not statically.
2016-01-28 18:18:00 +00:00
return *r;
}
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Update capabilities for 1.0 Rev3
2016-02-14 18:55:50 +00:00
// Returns the names of capabilities that directly depend on Kernel,
// plus itself.
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::vector<std::string>& KernelDependencies() {
static const auto r = new std::vector<std::string>{
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
"Kernel",
"Vector16",
"Float16Buffer",
"ImageBasic",
"ImageReadWrite",
"ImageMipmap",
"Pipes",
"DeviceEnqueue",
"LiteralSampler",
Add v1.1 capabilities validation. Refactor the ValidateCapability test fixture. Explain the meaning of test parameters. Factor out methods for convenience and readability. DRY v1.0 and v1.1 tests.
2016-04-29 17:40:01 +00:00
"SubgroupDispatch",
"NamedBarrier",
"PipeStorage"};
Initialize vector<string>s on first use, not statically.
2016-01-28 18:18:00 +00:00
return *r;
}
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::vector<std::string>& KernelAndGroupNonUniformDependencies() {
static const auto r = new std::vector<std::string>{
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
"Kernel",
"Vector16",
"Float16Buffer",
"ImageBasic",
"ImageReadWrite",
"ImageMipmap",
"Pipes",
"DeviceEnqueue",
"LiteralSampler",
"SubgroupDispatch",
"NamedBarrier",
"PipeStorage",
"GroupNonUniform",
"GroupNonUniformVote",
"GroupNonUniformArithmetic",
"GroupNonUniformBallot",
"GroupNonUniformShuffle",
"GroupNonUniformShuffleRelative",
"GroupNonUniformClustered",
"GroupNonUniformQuad"};
return *r;
}
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::vector<std::string>& AddressesDependencies() {
static const auto r = new std::vector<std::string>{
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
"Addresses",
Initialize vector<string>s on first use, not statically.
2016-01-28 18:18:00 +00:00
"GenericPointer"};
return *r;
}
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::vector<std::string>& Sampled1DDependencies() {
static const auto r = new std::vector<std::string>{
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
"Sampled1D",
Initialize vector<string>s on first use, not statically.
2016-01-28 18:18:00 +00:00
"Image1D"};
return *r;
}
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::vector<std::string>& SampledRectDependencies() {
static const auto r = new std::vector<std::string>{
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
"SampledRect",
Initialize vector<string>s on first use, not statically.
2016-01-28 18:18:00 +00:00
"ImageRect"};
return *r;
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
}
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::vector<std::string>& SampledBufferDependencies() {
static const auto r = new std::vector<std::string>{
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
"SampledBuffer",
Initialize vector<string>s on first use, not statically.
2016-01-28 18:18:00 +00:00
"ImageBuffer"};
return *r;
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
}
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
const char kOpenCLMemoryModel[] = \
" OpCapability Kernel"
" OpMemoryModel Logical OpenCL ";
const char kGLSL450MemoryModel[] = \
" OpCapability Shader"
" OpMemoryModel Logical GLSL450 ";
const char kVoidFVoid[] = \
" %void = OpTypeVoid"
" %void_f = OpTypeFunction %void"
" %func = OpFunction %void None %void_f"
" %label = OpLabel"
" OpReturn"
" OpFunctionEnd ";
Issue 559: check type declaration uniqueness Adds PassTypeUnique to the validator. Disallows repeated declarations of all types except for aggregates.
2017-02-23 21:07:52 +00:00
const char kVoidFVoid2[] = \
" %void_f = OpTypeFunction %voidt"
" %func = OpFunction %voidt None %void_f"
" %label = OpLabel"
" OpReturn"
" OpFunctionEnd ";
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
INSTANTIATE_TEST_SUITE_P(ExecutionModel, ValidateCapability,
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
Combine(
ValuesIn(AllCapabilities()),
Values(
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" OpEntryPoint Vertex %func \"shader\"" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), ShaderDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" OpEntryPoint TessellationControl %func \"shader\"" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), TessellationDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" OpEntryPoint TessellationEvaluation %func \"shader\"" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), TessellationDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" OpEntryPoint Geometry %func \"shader\"" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func InputPoints" +
" OpExecutionMode %func OutputPoints" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), GeometryDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" OpEntryPoint Fragment %func \"shader\"" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func OriginUpperLeft" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), ShaderDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" OpEntryPoint GLCompute %func \"shader\"" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), ShaderDependencies()),
std::make_pair(std::string(kGLSL450MemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" OpEntryPoint Kernel %func \"shader\"" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), KernelDependencies())
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
)));
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
INSTANTIATE_TEST_SUITE_P(AddressingAndMemoryModel, ValidateCapability,
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
Combine(
ValuesIn(AllCapabilities()),
Values(
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(" OpCapability Shader"
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpMemoryModel Logical Simple"
" OpEntryPoint Vertex %func \"shader\"" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), AllCapabilities()),
std::make_pair(" OpCapability Shader"
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpMemoryModel Logical GLSL450"
" OpEntryPoint Vertex %func \"shader\"" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), AllCapabilities()),
std::make_pair(" OpCapability Kernel"
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpMemoryModel Logical OpenCL"
" OpEntryPoint Kernel %func \"compute\"" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), AllCapabilities()),
std::make_pair(" OpCapability Shader"
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpMemoryModel Physical32 Simple"
" OpEntryPoint Vertex %func \"shader\"" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), AddressesDependencies()),
std::make_pair(" OpCapability Shader"
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpMemoryModel Physical32 GLSL450"
" OpEntryPoint Vertex %func \"shader\"" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), AddressesDependencies()),
std::make_pair(" OpCapability Kernel"
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpMemoryModel Physical32 OpenCL"
" OpEntryPoint Kernel %func \"compute\"" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), AddressesDependencies()),
std::make_pair(" OpCapability Shader"
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpMemoryModel Physical64 Simple"
" OpEntryPoint Vertex %func \"shader\"" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), AddressesDependencies()),
std::make_pair(" OpCapability Shader"
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpMemoryModel Physical64 GLSL450"
" OpEntryPoint Vertex %func \"shader\"" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), AddressesDependencies()),
std::make_pair(" OpCapability Kernel"
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpMemoryModel Physical64 OpenCL"
" OpEntryPoint Kernel %func \"compute\"" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), AddressesDependencies())
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
)));
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
INSTANTIATE_TEST_SUITE_P(ExecutionMode, ValidateCapability,
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
Combine(
ValuesIn(AllCapabilities()),
Values(
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint Geometry %func \"shader\" "
"OpExecutionMode %func Invocations 42" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func InputPoints" +
" OpExecutionMode %func OutputPoints" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), GeometryDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint TessellationControl %func \"shader\" "
"OpExecutionMode %func SpacingEqual" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), TessellationDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint TessellationControl %func \"shader\" "
"OpExecutionMode %func SpacingFractionalEven" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), TessellationDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint TessellationControl %func \"shader\" "
"OpExecutionMode %func SpacingFractionalOdd" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), TessellationDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint TessellationControl %func \"shader\" "
"OpExecutionMode %func VertexOrderCw" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), TessellationDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint TessellationControl %func \"shader\" "
"OpExecutionMode %func VertexOrderCcw" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), TessellationDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
"OpEntryPoint Fragment %func \"shader\" "
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpExecutionMode %func PixelCenterInteger" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func OriginUpperLeft" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), ShaderDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
"OpEntryPoint Fragment %func \"shader\" "
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpExecutionMode %func OriginUpperLeft" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), ShaderDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
"OpEntryPoint Fragment %func \"shader\" "
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpExecutionMode %func OriginLowerLeft" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), ShaderDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
"OpEntryPoint Fragment %func \"shader\" "
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpExecutionMode %func EarlyFragmentTests" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func OriginUpperLeft" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), ShaderDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint TessellationControl %func \"shader\" "
"OpExecutionMode %func PointMode" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), TessellationDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint Vertex %func \"shader\" "
"OpExecutionMode %func Xfb" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), std::vector<std::string>{"TransformFeedback"}),
std::make_pair(std::string(kOpenCLMemoryModel) +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
"OpEntryPoint Fragment %func \"shader\" "
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpExecutionMode %func DepthReplacing" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func OriginUpperLeft" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), ShaderDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
"OpEntryPoint Fragment %func \"shader\" "
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpExecutionMode %func DepthGreater" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func OriginUpperLeft" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), ShaderDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
"OpEntryPoint Fragment %func \"shader\" "
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpExecutionMode %func DepthLess" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func OriginUpperLeft" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), ShaderDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
"OpEntryPoint Fragment %func \"shader\" "
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpExecutionMode %func DepthUnchanged" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func OriginUpperLeft" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), ShaderDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint Kernel %func \"shader\" "
"OpExecutionMode %func LocalSize 42 42 42" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), AllCapabilities()),
std::make_pair(std::string(kGLSL450MemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint Kernel %func \"shader\" "
"OpExecutionMode %func LocalSizeHint 42 42 42" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), KernelDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint Geometry %func \"shader\" "
"OpExecutionMode %func InputPoints" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func OutputPoints" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), GeometryDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint Geometry %func \"shader\" "
"OpExecutionMode %func InputLines" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func OutputLineStrip" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), GeometryDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint Geometry %func \"shader\" "
"OpExecutionMode %func InputLinesAdjacency" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func OutputLineStrip" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), GeometryDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint Geometry %func \"shader\" "
"OpExecutionMode %func Triangles" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func OutputTriangleStrip" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), GeometryDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint TessellationControl %func \"shader\" "
"OpExecutionMode %func Triangles" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), TessellationDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint Geometry %func \"shader\" "
"OpExecutionMode %func InputTrianglesAdjacency" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func OutputTriangleStrip" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), GeometryDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint TessellationControl %func \"shader\" "
"OpExecutionMode %func Quads" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), TessellationDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint TessellationControl %func \"shader\" "
"OpExecutionMode %func Isolines" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), TessellationDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint Geometry %func \"shader\" "
"OpExecutionMode %func OutputVertices 42" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func OutputPoints" +
" OpExecutionMode %func InputPoints" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), GeometryDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint TessellationControl %func \"shader\" "
"OpExecutionMode %func OutputVertices 42" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), TessellationDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint Geometry %func \"shader\" "
"OpExecutionMode %func OutputPoints" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func InputPoints" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), GeometryDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint Geometry %func \"shader\" "
"OpExecutionMode %func OutputLineStrip" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func InputLines" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), GeometryDependencies()),
std::make_pair(std::string(kOpenCLMemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint Geometry %func \"shader\" "
"OpExecutionMode %func OutputTriangleStrip" +
Add validation for execution modes * Check rules from Execution Mode tables, 2.16.2 and the Vulkan environment spec * Allows MeshNV execution model with the following execution modes * LocalSize, LocalSizeId, OutputPoints and OutputVertices * Done to not break their validation
2018-09-28 20:41:56 +00:00
" OpExecutionMode %func Triangles" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), GeometryDependencies()),
std::make_pair(std::string(kGLSL450MemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint Kernel %func \"shader\" "
"OpExecutionMode %func VecTypeHint 2" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid), KernelDependencies()),
std::make_pair(std::string(kGLSL450MemoryModel) +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpEntryPoint Kernel %func \"shader\" "
"OpExecutionMode %func ContractionOff" +
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
std::string(kVoidFVoid), KernelDependencies()))));
Add v1.1 capabilities validation. Refactor the ValidateCapability test fixture. Explain the meaning of test parameters. Factor out methods for convenience and readability. DRY v1.0 and v1.1 tests.
2016-04-29 17:40:01 +00:00
// clang-format on
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
INSTANTIATE_TEST_SUITE_P(
Add v1.1 capabilities validation. Refactor the ValidateCapability test fixture. Explain the meaning of test parameters. Factor out methods for convenience and readability. DRY v1.0 and v1.1 tests.
2016-04-29 17:40:01 +00:00
ExecutionModeV11, ValidateCapabilityV11,
Combine(ValuesIn(AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
Values(std::make_pair(std::string(kOpenCLMemoryModel) +
"OpEntryPoint Kernel %func \"shader\" "
"OpExecutionMode %func SubgroupSize 1" +
std::string(kVoidFVoid),
std::vector<std::string>{"SubgroupDispatch"}),
std::make_pair(
std::string(kOpenCLMemoryModel) +
Add v1.1 capabilities validation. Refactor the ValidateCapability test fixture. Explain the meaning of test parameters. Factor out methods for convenience and readability. DRY v1.0 and v1.1 tests.
2016-04-29 17:40:01 +00:00
"OpEntryPoint Kernel %func \"shader\" "
"OpExecutionMode %func SubgroupsPerWorkgroup 65535" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid),
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
std::vector<std::string>{"SubgroupDispatch"}))));
Add v1.1 capabilities validation. Refactor the ValidateCapability test fixture. Explain the meaning of test parameters. Factor out methods for convenience and readability. DRY v1.0 and v1.1 tests.
2016-04-29 17:40:01 +00:00
// clang-format off
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
INSTANTIATE_TEST_SUITE_P(StorageClass, ValidateCapability,
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
Combine(
ValuesIn(AllCapabilities()),
Values(
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpEntryPoint Vertex %func \"shader\"" +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" %intt = OpTypeInt 32 0\n"
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %ptrt = OpTypePointer UniformConstant %intt\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %var = OpVariable %ptrt UniformConstant\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpEntryPoint Kernel %func \"compute\"" +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" %intt = OpTypeInt 32 0\n"
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %ptrt = OpTypePointer Input %intt"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %var = OpVariable %ptrt Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpEntryPoint Vertex %func \"shader\"" +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" %intt = OpTypeInt 32 0\n"
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %ptrt = OpTypePointer Uniform %intt\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %var = OpVariable %ptrt Uniform\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpEntryPoint Vertex %func \"shader\"" +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" %intt = OpTypeInt 32 0\n"
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %ptrt = OpTypePointer Output %intt\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %var = OpVariable %ptrt Output\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpEntryPoint Vertex %func \"shader\"" +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" %intt = OpTypeInt 32 0\n"
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %ptrt = OpTypePointer Workgroup %intt\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %var = OpVariable %ptrt Workgroup\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpEntryPoint Vertex %func \"shader\"" +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" %intt = OpTypeInt 32 0\n"
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %ptrt = OpTypePointer CrossWorkgroup %intt\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %var = OpVariable %ptrt CrossWorkgroup\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpEntryPoint Kernel %func \"compute\"" +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" %intt = OpTypeInt 32 0\n"
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %ptrt = OpTypePointer Private %intt\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %var = OpVariable %ptrt Private\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpEntryPoint Kernel %func \"compute\"" +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" %intt = OpTypeInt 32 0\n"
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %ptrt = OpTypePointer PushConstant %intt\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %var = OpVariable %ptrt PushConstant\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpEntryPoint Vertex %func \"shader\"" +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" %intt = OpTypeInt 32 0\n"
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %ptrt = OpTypePointer AtomicCounter %intt\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %var = OpVariable %ptrt AtomicCounter\n" + std::string(kVoidFVoid),
std::vector<std::string>{"AtomicStorage"}),
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpEntryPoint Vertex %func \"shader\"" +
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" %intt = OpTypeInt 32 0\n"
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %ptrt = OpTypePointer Image %intt\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %var = OpVariable %ptrt Image\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities())
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
)));
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
INSTANTIATE_TEST_SUITE_P(Dim, ValidateCapability,
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
Combine(
ValuesIn(AllCapabilities()),
Values(
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(" OpCapability ImageBasic" +
std::string(kOpenCLMemoryModel) +
std::string(" OpEntryPoint Kernel %func \"compute\"") +
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %voidt = OpTypeVoid"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %imgt = OpTypeImage %voidt 1D 0 0 0 0 Unknown" + std::string(kVoidFVoid2),
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
Sampled1DDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(" OpCapability ImageBasic" +
std::string(kOpenCLMemoryModel) +
std::string(" OpEntryPoint Kernel %func \"compute\"") +
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %voidt = OpTypeVoid"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %imgt = OpTypeImage %voidt 2D 0 0 0 0 Unknown" + std::string(kVoidFVoid2),
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(" OpCapability ImageBasic" +
std::string(kOpenCLMemoryModel) +
std::string(" OpEntryPoint Kernel %func \"compute\"") +
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %voidt = OpTypeVoid"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %imgt = OpTypeImage %voidt 3D 0 0 0 0 Unknown" + std::string(kVoidFVoid2),
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(" OpCapability ImageBasic" +
std::string(kOpenCLMemoryModel) +
std::string(" OpEntryPoint Kernel %func \"compute\"") +
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %voidt = OpTypeVoid"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %imgt = OpTypeImage %voidt Cube 0 0 0 0 Unknown" + std::string(kVoidFVoid2),
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(" OpCapability ImageBasic" +
std::string(kOpenCLMemoryModel) +
std::string(" OpEntryPoint Kernel %func \"compute\"") +
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %voidt = OpTypeVoid"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %imgt = OpTypeImage %voidt Rect 0 0 0 0 Unknown" + std::string(kVoidFVoid2),
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
SampledRectDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(" OpCapability ImageBasic" +
std::string(kOpenCLMemoryModel) +
std::string(" OpEntryPoint Kernel %func \"compute\"") +
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %voidt = OpTypeVoid"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %imgt = OpTypeImage %voidt Buffer 0 0 0 0 Unknown" + std::string(kVoidFVoid2),
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
SampledBufferDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(" OpCapability ImageBasic" +
std::string(kOpenCLMemoryModel) +
std::string(" OpEntryPoint Kernel %func \"compute\"") +
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
" %voidt = OpTypeVoid"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
" %imgt = OpTypeImage %voidt SubpassData 0 0 0 2 Unknown" + std::string(kVoidFVoid2),
std::vector<std::string>{"InputAttachment"})
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
)));
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
// NOTE: All Sampler Address Modes require kernel capabilities but the
// OpConstantSampler requires LiteralSampler which depends on Kernel
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
INSTANTIATE_TEST_SUITE_P(SamplerAddressingMode, ValidateCapability,
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
Combine(
ValuesIn(AllCapabilities()),
Values(
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpEntryPoint Vertex %func \"shader\""
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" %samplert = OpTypeSampler"
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" %sampler = OpConstantSampler %samplert None 1 Nearest" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid),
std::vector<std::string>{"LiteralSampler"}),
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpEntryPoint Vertex %func \"shader\""
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" %samplert = OpTypeSampler"
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" %sampler = OpConstantSampler %samplert ClampToEdge 1 Nearest" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid),
std::vector<std::string>{"LiteralSampler"}),
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpEntryPoint Vertex %func \"shader\""
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" %samplert = OpTypeSampler"
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" %sampler = OpConstantSampler %samplert Clamp 1 Nearest" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid),
std::vector<std::string>{"LiteralSampler"}),
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpEntryPoint Vertex %func \"shader\""
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" %samplert = OpTypeSampler"
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" %sampler = OpConstantSampler %samplert Repeat 1 Nearest" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid),
std::vector<std::string>{"LiteralSampler"}),
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" OpEntryPoint Vertex %func \"shader\""
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
" %samplert = OpTypeSampler"
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
" %sampler = OpConstantSampler %samplert RepeatMirrored 1 Nearest" +
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::string(kVoidFVoid),
std::vector<std::string>{"LiteralSampler"})
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
)));
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Cleanup whitespace lint warnings. (#1690) This CL cleans up the whitespace warnings and enables the check when running 'git cl presubmit --all -uf'.
2018-07-10 17:09:46 +00:00
// TODO(umar): Sampler Filter Mode
// TODO(umar): Image Format
// TODO(umar): Image Channel Order
// TODO(umar): Image Channel Data Type
// TODO(umar): Image Operands
// TODO(umar): FP Fast Math Mode
// TODO(umar): FP Rounding Mode
// TODO(umar): Linkage Type
// TODO(umar): Access Qualifier
// TODO(umar): Function Parameter Attribute
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
INSTANTIATE_TEST_SUITE_P(Decoration, ValidateCapability,
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
Combine(
ValuesIn(AllCapabilities()),
Values(
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var RelaxedPrecision\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Private %intt\n"
"%var = OpVariable %ptr Private\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validate Buffer and BufferBlock apply only to struct types (#3259)
2020-03-31 14:06:29 +00:00
// Block applies to struct type.
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Validate Buffer and BufferBlock apply only to struct types (#3259)
2020-03-31 14:06:29 +00:00
"OpDecorate %block Block\n"
"%intt = OpTypeInt 32 0\n"
"%block = OpTypeStruct %intt\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validate Buffer and BufferBlock apply only to struct types (#3259)
2020-03-31 14:06:29 +00:00
// BufferBlock applies to struct type.
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Validate Buffer and BufferBlock apply only to struct types (#3259)
2020-03-31 14:06:29 +00:00
"OpDecorate %block BufferBlock\n"
"%intt = OpTypeInt 32 0\n"
"%block = OpTypeStruct %intt\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpMemberDecorate %structt 0 RowMajor\n"
"%floatt = OpTypeFloat 32\n"
"%float2 = OpTypeVector %floatt 2\n"
"%mat2x2 = OpTypeMatrix %float2 2\n"
"%structt = OpTypeStruct %mat2x2\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
MatrixDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpMemberDecorate %structt 0 ColMajor\n"
"%floatt = OpTypeFloat 32\n"
"%float2 = OpTypeVector %floatt 2\n"
"%mat2x2 = OpTypeMatrix %float2 2\n"
"%structt = OpTypeStruct %mat2x2\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
MatrixDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %array ArrayStride 4\n"
"%intt = OpTypeInt 32 0\n"
"%array = OpTypeRuntimeArray %intt\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpMemberDecorate %structt 0 MatrixStride 8\n"
"%floatt = OpTypeFloat 32\n"
"%float2 = OpTypeVector %floatt 2\n"
"%mat2x2 = OpTypeMatrix %float2 2\n"
"%structt = OpTypeStruct %mat2x2\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
MatrixDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %struct GLSLShared\n"
"%struct = OpTypeStruct\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %struct GLSLPacked\n"
"%struct = OpTypeStruct\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %struct CPacked\n"
"%struct = OpTypeStruct\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
KernelDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var NoPerspective\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var Flat\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var Patch\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
TessellationDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var Centroid\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var Sample\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::vector<std::string>{"SampleRateShading"}),
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var Invariant\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var Restrict\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var Aliased\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var Volatile\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var Constant\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
KernelDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var Coherent\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validate NonWritable decoration (#2263) Also permit NonWritable on members of structs used for UBO and SSBO. (That seems inadvertently removed in recent revisions of the spec.)
2019-01-28 20:44:13 +00:00
// NonWritable must target something valid, such as a storage image.
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Validate NonWritable decoration (#2263) Also permit NonWritable on members of structs used for UBO and SSBO. (That seems inadvertently removed in recent revisions of the spec.)
2019-01-28 20:44:13 +00:00
"OpDecorate %var NonWritable "
"%float = OpTypeFloat 32 "
"%imstor = OpTypeImage %float 2D 0 0 0 2 Unknown "
"%ptr = OpTypePointer UniformConstant %imstor "
"%var = OpVariable %ptr UniformConstant "
+ std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var NonReadable "
"%float = OpTypeFloat 32 "
"%imstor = OpTypeImage %float 2D 0 0 0 2 Unknown "
"%ptr = OpTypePointer UniformConstant %imstor "
"%var = OpVariable %ptr UniformConstant "
+ std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validate Uniform decoration (#2181)
2018-12-07 14:32:57 +00:00
// Uniform must target a non-void value.
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Validate Uniform decoration (#2181)
2018-12-07 14:32:57 +00:00
"OpDecorate %int0 Uniform\n"
"%intt = OpTypeInt 32 0\n" +
"%int0 = OpConstantNull %intt"
+ std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n"
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpDecorate %intt SaturatedConversion\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
"%intt = OpTypeInt 32 0\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
KernelDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var Stream 0\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Output %intt\n"
"%var = OpVariable %ptr Output\n" + std::string(kVoidFVoid),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::vector<std::string>{"GeometryStreams"}),
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Validate location assignments (#3308) * Add validation that input/output locations are assigned correctly * Account for component assignment * Account for 4 components per location and track the combined coordinate * Account for multiple output indexes * handle specifically arrayed variables * Arrayed variables that specify a component get locations determined per index of the array for the sub type * Added tests that check locations and components can be assigned to interleave an array's locations and components * Fix up which interfaces are allowed to be arrayed for various shader stages based on glslang
2020-06-25 17:22:45 +00:00
"OpMemberDecorate %struct 0 Location 0\n"
"%intt = OpTypeInt 32 0\n"
"%struct = OpTypeStruct %intt\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Basic validation for Component decorations (#2679) * Add basic validation for Component decoration * Add validator tests for Component decoration
2019-06-20 22:16:12 +00:00
"OpDecorate %var Component 0\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var Index 0\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var Binding 0\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Uniform %intt\n"
"%var = OpVariable %ptr Uniform\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var DescriptorSet 0\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Uniform %intt\n"
"%var = OpVariable %ptr Uniform\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpMemberDecorate %structt 0 Offset 0\n"
"%intt = OpTypeInt 32 0\n"
"%structt = OpTypeStruct %intt\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var XfbBuffer 0\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Uniform %intt\n"
"%var = OpVariable %ptr Uniform\n" + std::string(kVoidFVoid),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::vector<std::string>{"TransformFeedback"}),
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var XfbStride 0\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer Uniform %intt\n"
"%var = OpVariable %ptr Uniform\n" + std::string(kVoidFVoid),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::vector<std::string>{"TransformFeedback"}),
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n"
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpDecorate %intt FuncParamAttr Zext\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
"%intt = OpTypeInt 32 0\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
KernelDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n"
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpDecorate %intt FPFastMathMode Fast\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
"%intt = OpTypeInt 32 0\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
KernelDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpDecorate %intt LinkageAttributes \"other\" Import\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
"%intt = OpTypeInt 32 0\n" + std::string(kVoidFVoid),
std::vector<std::string>{"Linkage"}),
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpDecorate %intt NoContraction\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
"%intt = OpTypeInt 32 0\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var InputAttachmentIndex 0\n"
"%intt = OpTypeInt 32 0\n"
"%ptr = OpTypePointer UniformConstant %intt\n"
"%var = OpVariable %ptr UniformConstant\n" + std::string(kVoidFVoid),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::vector<std::string>{"InputAttachment"}),
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n"
Remove spv_validate_options_t and change tests accrodingly. Users always want to run all the checks. The spv_validate_options_t mechanism, which provides little benefits to users, complicates the internal implementation and also makes the tests exercise different paths as users do. Right now the tests are more like integration tests instead of unit tests, which should be our next refactoring aim.
2016-02-22 20:25:50 +00:00
"OpDecorate %intt Alignment 4\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
"%intt = OpTypeInt 32 0\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
KernelDependencies())
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
)));
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Add tests for MaxByteOffset.
2016-05-10 03:15:46 +00:00
// clang-format on
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
INSTANTIATE_TEST_SUITE_P(
Test SpecId validation.
2016-05-10 21:02:41 +00:00
DecorationSpecId, ValidateCapability,
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
Combine(
ValuesIn(AllSpirV10Capabilities()),
Values(std::make_pair(std::string(kOpenCLMemoryModel) +
"OpEntryPoint Vertex %func \"shader\" \n" +
"OpDecorate %1 SpecId 1\n"
"%intt = OpTypeInt 32 0\n"
"%1 = OpSpecConstant %intt 0\n" +
std::string(kVoidFVoid),
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
ShaderDependencies()))));
Test SpecId validation.
2016-05-10 21:02:41 +00:00
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
INSTANTIATE_TEST_SUITE_P(
Add tests for MaxByteOffset.
2016-05-10 03:15:46 +00:00
DecorationV11, ValidateCapabilityV11,
Combine(ValuesIn(AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
Values(std::make_pair(std::string(kOpenCLMemoryModel) +
"OpEntryPoint Kernel %func \"compute\" \n"
"OpDecorate %p MaxByteOffset 0 "
"%i32 = OpTypeInt 32 0 "
"%pi32 = OpTypePointer Workgroup %i32 "
"%p = OpVariable %pi32 Workgroup " +
std::string(kVoidFVoid),
AddressesDependencies()),
Test SpecId validation.
2016-05-10 21:02:41 +00:00
// Trying to test OpDecorate here, but if this fails due to
// incorrect OpMemoryModel validation, that must also be
// fixed.
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(
std::string("OpMemoryModel Logical OpenCL "
"OpEntryPoint Kernel %func \"compute\" \n"
"OpDecorate %1 SpecId 1 "
"%intt = OpTypeInt 32 0 "
"%1 = OpSpecConstant %intt 0") +
std::string(kVoidFVoid),
KernelDependencies()),
std::make_pair(
std::string("OpMemoryModel Logical Simple "
"OpEntryPoint Vertex %func \"shader\" \n"
"OpDecorate %1 SpecId 1 "
"%intt = OpTypeInt 32 0 "
"%1 = OpSpecConstant %intt 0") +
std::string(kVoidFVoid),
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
ShaderDependencies()))));
Add tests for MaxByteOffset.
2016-05-10 03:15:46 +00:00
// clang-format off
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
INSTANTIATE_TEST_SUITE_P(BuiltIn, ValidateCapability,
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
Combine(
ValuesIn(AllCapabilities()),
Values(
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn Position\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Mere mention of PointSize BuiltIn does not require Shader capability Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/365 which was reopened for this.
2016-08-24 13:47:49 +00:00
// Just mentioning PointSize, ClipDistance, or CullDistance as a BuiltIn does
Relax ClipDistance, CullDistance capability check in all environments Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/365
2016-08-23 22:18:17 +00:00
// not trigger the requirement for the associated capability.
// See https://github.com/KhronosGroup/SPIRV-Tools/issues/365
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn PointSize\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn ClipDistance\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn CullDistance\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn VertexId\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn InstanceId\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn PrimitiveId\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
GeometryTessellationDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn InvocationId\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
GeometryTessellationDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn Layer\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
GeometryDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn ViewportIndex\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::vector<std::string>{"MultiViewport"}),
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn TessLevelOuter\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
TessellationDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn TessLevelInner\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
TessellationDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn TessCoord\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
TessellationDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn PatchVertices\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
TessellationDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn FragCoord\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn PointCoord\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn FrontFacing\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn SampleId\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::vector<std::string>{"SampleRateShading"}),
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn SamplePosition\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::vector<std::string>{"SampleRateShading"}),
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn SampleMask\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Updated capabilites for SampleMask SPIRV-Headers recently fixed the capability dependency for SampleMask. It depends on Shader, not SampleRateShading
2017-08-23 17:28:48 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn FragDepth\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn HelperInvocation\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn VertexIndex\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn InstanceIndex\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn NumWorkgroups\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn WorkgroupId\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn LocalInvocationId\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn GlobalInvocationId\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn LocalInvocationIndex\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn WorkDim\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
KernelDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn GlobalSize\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
KernelDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn EnqueuedWorkgroupSize\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
KernelDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn GlobalOffset\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
KernelDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn GlobalLinearId\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
KernelDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn SubgroupSize\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
KernelAndGroupNonUniformDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn SubgroupMaxSize\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
KernelDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn NumSubgroups\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
KernelAndGroupNonUniformDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn NumEnqueuedSubgroups\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
KernelDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn SubgroupId\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
KernelAndGroupNonUniformDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Vertex %func \"shader\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn SubgroupLocalInvocationId\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
KernelAndGroupNonUniformDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn VertexIndex\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpDecorate %var BuiltIn InstanceIndex\n"
Add generic builtin validation of target (#2843) * Validate the target's opcode is acceptable * Update tests * New tests * move early exit for builtins a bit later in the pass
2019-09-09 18:53:30 +00:00
"%intt = OpTypeInt 32 0\n"
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"%ptr = OpTypePointer Input %intt\n"
"%var = OpVariable %ptr Input\n" + std::string(kVoidFVoid),
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
ShaderDependencies())
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
)));
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
Mere mention of PointSize BuiltIn does not require Shader capability Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/365 which was reopened for this.
2016-08-24 13:47:49 +00:00
// Ensure that mere mention of PointSize, ClipDistance, or CullDistance as
Relax ClipDistance, CullDistance capability check in all environments Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/365
2016-08-23 22:18:17 +00:00
// BuiltIns does not trigger the requirement for the associated
// capability.
// See https://github.com/KhronosGroup/SPIRV-Tools/issues/365
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
INSTANTIATE_TEST_SUITE_P(BuiltIn, ValidateCapabilityVulkan10,
Turn off ClipDistance CullDistance cap checks for Vulkan Turn them off until resolution of the debate over how they should be checked. Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/261
2016-07-07 21:03:22 +00:00
Combine(
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
// All capabilities to try.
ValuesIn(AllSpirV10Capabilities()),
Turn off ClipDistance CullDistance cap checks for Vulkan Turn them off until resolution of the debate over how they should be checked. Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/261
2016-07-07 21:03:22 +00:00
Values(
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpEntryPoint Vertex %func \"shader\" %var\n" +
"OpDecorate %var BuiltIn PointSize\n"
"%float = OpTypeFloat 32\n"
"%ptr_output_float = OpTypePointer Output %float\n"
"%var = OpVariable %ptr_output_float Output\n" + std::string(kVoidFVoid),
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
// Capabilities which should succeed.
AllVulkan10Capabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Add Vulkan validation rules for BuiltIn variables Added a framework for validation of BuiltIn variables. The framework allows implementation of flexible abstract rules which are required for built-ins as the information (decoration, definition, reference) is not in one place, but is scattered all over the module. Validation rules are implemented as a map id -> list<functor(instrution)> Ids which are dependent on built-in types or objects receive a task list, such as "this id cannot be referenced from function which is called from entry point with execution model X; propagate this rule to your descendants in the global scope". Also refactored test/val/val_fixtures. All built-ins covered by tests
2018-02-07 16:50:26 +00:00
"OpEntryPoint Vertex %func \"shader\" \n"
"OpMemberDecorate %block 0 BuiltIn ClipDistance\n"
"%f32 = OpTypeFloat 32\n"
"%intt = OpTypeInt 32 0\n"
"%intt_4 = OpConstant %intt 4\n"
"%f32arr4 = OpTypeArray %f32 %intt_4\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
"%block = OpTypeStruct %f32arr4\n" + std::string(kVoidFVoid),
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
AllVulkan10Capabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Add Vulkan validation rules for BuiltIn variables Added a framework for validation of BuiltIn variables. The framework allows implementation of flexible abstract rules which are required for built-ins as the information (decoration, definition, reference) is not in one place, but is scattered all over the module. Validation rules are implemented as a map id -> list<functor(instrution)> Ids which are dependent on built-in types or objects receive a task list, such as "this id cannot be referenced from function which is called from entry point with execution model X; propagate this rule to your descendants in the global scope". Also refactored test/val/val_fixtures. All built-ins covered by tests
2018-02-07 16:50:26 +00:00
"OpEntryPoint Vertex %func \"shader\" \n"
"OpMemberDecorate %block 0 BuiltIn CullDistance\n"
"%f32 = OpTypeFloat 32\n"
"%intt = OpTypeInt 32 0\n"
"%intt_4 = OpConstant %intt 4\n"
"%f32arr4 = OpTypeArray %f32 %intt_4\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
"%block = OpTypeStruct %f32arr4\n" + std::string(kVoidFVoid),
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
AllVulkan10Capabilities())
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
)));
Turn off ClipDistance CullDistance cap checks for Vulkan Turn them off until resolution of the debate over how they should be checked. Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/261
2016-07-07 21:03:22 +00:00
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
INSTANTIATE_TEST_SUITE_P(BuiltIn, ValidateCapabilityOpenGL40,
Relax ClipDistance, CullDistance capability check in all environments Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/365
2016-08-23 22:18:17 +00:00
Combine(
// OpenGL 4.0 is based on SPIR-V 1.0
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
ValuesIn(AllSpirV10Capabilities()),
Relax ClipDistance, CullDistance capability check in all environments Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/365
2016-08-23 22:18:17 +00:00
Values(
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpEntryPoint Vertex %func \"shader\" %var\n" +
"OpDecorate %var BuiltIn PointSize\n"
"%float = OpTypeFloat 32\n"
"%ptr_output_float = OpTypePointer Output %float\n"
"%var = OpVariable %ptr_output_float Output\n" + std::string(kVoidFVoid),
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
AllSpirV10Capabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpEntryPoint Vertex %func \"shader\" %var\n" +
"OpDecorate %var BuiltIn ClipDistance\n"
"%float = OpTypeFloat 32\n"
"%int = OpTypeInt 32 0\n"
"%int_1 = OpConstant %int 1\n"
"%array = OpTypeArray %float %int_1\n"
"%ptr = OpTypePointer Output %array\n"
"%var = OpVariable %ptr Output\n" + std::string(kVoidFVoid),
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
AllSpirV10Capabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpEntryPoint Vertex %func \"shader\" %var\n" +
"OpDecorate %var BuiltIn CullDistance\n"
"%float = OpTypeFloat 32\n"
"%int = OpTypeInt 32 0\n"
"%int_1 = OpConstant %int 1\n"
"%array = OpTypeArray %float %int_1\n"
"%ptr = OpTypePointer Output %array\n"
"%var = OpVariable %ptr Output\n" + std::string(kVoidFVoid),
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
AllSpirV10Capabilities())
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
)));
Relax ClipDistance, CullDistance capability check in all environments Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/365
2016-08-23 22:18:17 +00:00
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
INSTANTIATE_TEST_SUITE_P(Capabilities, ValidateCapabilityVulkan11,
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
Combine(
// All capabilities to try.
ValuesIn(AllCapabilities()),
Values(
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpEntryPoint Vertex %func \"shader\" %var\n" +
"OpDecorate %var BuiltIn PointSize\n"
"%float = OpTypeFloat 32\n"
"%ptr_output_float = OpTypePointer Output %float\n"
"%var = OpVariable %ptr_output_float Output\n" + std::string(kVoidFVoid),
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
AllVulkan11Capabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kGLSL450MemoryModel) +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpEntryPoint Vertex %func \"shader\" %var\n" +
"OpDecorate %var BuiltIn CullDistance\n"
"%float = OpTypeFloat 32\n"
"%int = OpTypeInt 32 0\n"
"%int_1 = OpConstant %int 1\n"
"%array = OpTypeArray %float %int_1\n"
"%ptr = OpTypePointer Output %array\n"
"%var = OpVariable %ptr Output\n" + std::string(kVoidFVoid),
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
AllVulkan11Capabilities())
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
)));
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
Validate Vulkan 1.2 capabilities
2019-09-04 15:51:18 +00:00
INSTANTIATE_TEST_SUITE_P(Capabilities, ValidateCapabilityVulkan12,
Combine(
// All capabilities to try.
ValuesIn(AllSpirV15Capabilities()),
Values(
std::make_pair(std::string(kGLSL450MemoryModel) +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpEntryPoint Vertex %func \"shader\" %var\n" +
"OpDecorate %var BuiltIn PointSize\n"
"%float = OpTypeFloat 32\n"
"%ptr_output_float = OpTypePointer Output %float\n"
"%var = OpVariable %ptr_output_float Output\n" + std::string(kVoidFVoid),
Validate Vulkan 1.2 capabilities
2019-09-04 15:51:18 +00:00
AllVulkan12Capabilities()),
std::make_pair(std::string(kGLSL450MemoryModel) +
Improve decoration validation (#4490) Fixes #4469 * Checks that decorations only usable with structure members are not used by OpDecorate or OpDecorateId * Checks that decorations not allowed on structure members are not used with OpMemberDecorate * Checks decoration targets for most core decorations * Performs some Vulkan specific validation on deorations
2021-11-05 17:18:19 +00:00
"OpEntryPoint Vertex %func \"shader\" %var\n" +
"OpDecorate %var BuiltIn CullDistance\n"
"%float = OpTypeFloat 32\n"
"%int = OpTypeInt 32 0\n"
"%int_1 = OpConstant %int 1\n"
"%array = OpTypeArray %float %int_1\n"
"%ptr = OpTypePointer Output %array\n"
"%var = OpVariable %ptr Output\n" + std::string(kVoidFVoid),
Validate Vulkan 1.2 capabilities
2019-09-04 15:51:18 +00:00
AllVulkan12Capabilities())
)));
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
// TODO(umar): Selection Control
// TODO(umar): Loop Control
// TODO(umar): Function Control
// TODO(umar): Memory Semantics
// TODO(umar): Memory Access
// TODO(umar): Scope
// TODO(umar): Group Operation
// TODO(umar): Kernel Enqueue Flags
// TODO(umar): Kernel Profiling Flags
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
INSTANTIATE_TEST_SUITE_P(MatrixOp, ValidateCapability,
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
Combine(
ValuesIn(AllCapabilities()),
Values(
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(std::string(kOpenCLMemoryModel) +
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
"OpEntryPoint Kernel %func \"compute\" \n" +
Adding validation code for more data rules. These rules are under "Data Rules" in 2.16.1 (Universal Validation Rules) part of the SPIR-V 1.1 Specification document: * Scalar floating-point types can be parameterized only as 32 bit, plus any additional sizes enabled by capabilities. * Scalar integer types can be parameterized only as 32 bit, plus any additional sizes enabled by capabilities. * Vector types can only be parameterized with numerical types or the OpTypeBool type. * Matrix types can only be parameterized with floating-point types. * Matrix types can only be parameterized as having only 2, 3, or 4 columns. * Specialization constants (see Specialization) are limited to integers, Booleans, floating-point numbers, and vectors of these.
2016-11-10 20:12:26 +00:00
"%f32 = OpTypeFloat 32\n"
"%vec3 = OpTypeVector %f32 3\n"
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
"%mat33 = OpTypeMatrix %vec3 3\n" + std::string(kVoidFVoid),
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
MatrixDependencies()))));
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
// clang-format on
Validator pass for image instructions Includes validation rules for OpImageXXX and ImageOperand. Doesn't include OpTypeImage and OpImageSparseXXX. Disabled an invalid test.
2017-10-26 19:30:23 +00:00
#if 0
// TODO(atgoo@github.com) The following test is not valid as it generates
// invalid combinations of images, instructions and image operands.
//
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
// Creates assembly containing an OpImageFetch instruction using operands for
// the image-operands part. The assembly defines constants %fzero and %izero
// that can be used for operands where IDs are required. The assembly is valid,
// apart from not declaring any capabilities required by the operands.
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
string ImageOperandsTemplate(const std::string& operands) {
Add v1.1 capabilities validation. Refactor the ValidateCapability test fixture. Explain the meaning of test parameters. Factor out methods for convenience and readability. DRY v1.0 and v1.1 tests.
2016-04-29 17:40:01 +00:00
ostringstream ss;
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
// clang-format off
ss << R"(
OpCapability Kernel
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
OpCapability Linkage
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
OpMemoryModel Logical OpenCL
The Signedness in OpTypeInt must always be 0. When Kernel capability is used, The Signedness in OpTypeInt must always be 0. Fixes issue #492.
2017-02-09 21:23:40 +00:00
%i32 = OpTypeInt 32 0
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
%f32 = OpTypeFloat 32
%v4i32 = OpTypeVector %i32 4
%timg = OpTypeImage %i32 2D 0 0 0 0 Unknown
%pimg = OpTypePointer UniformConstant %timg
%tfun = OpTypeFunction %i32
%vimg = OpVariable %pimg UniformConstant
%izero = OpConstant %i32 0
%fzero = OpConstant %f32 0.
%main = OpFunction %i32 None %tfun
%lbl = OpLabel
%img = OpLoad %timg %vimg
%r1 = OpImageFetch %v4i32 %img %izero )" << operands << R"(
OpReturnValue %izero
OpFunctionEnd
)";
// clang-format on
return ss.str();
}
Remove use of deprecated googletest macro (#2286) * Remove use of deprecated googletest macro INSTANTIATE_TEST_CASE_P has been deprecated. We need to use INSTANTIATE_TEST_SUITE_P instead. * Remove extra commas from test suites.
2019-01-29 23:56:52 +00:00
INSTANTIATE_TEST_SUITE_P(
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
TwoImageOperandsMask, ValidateCapability,
Combine(
ValuesIn(AllCapabilities()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
Values(std::make_pair(ImageOperandsTemplate("Bias|Lod %fzero %fzero"),
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
ShaderDependencies()),
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
std::make_pair(ImageOperandsTemplate("Lod|Offset %fzero %izero"),
std::vector<std::string>{"ImageGatherExtended"}),
std::make_pair(ImageOperandsTemplate("Sample|MinLod %izero %fzero"),
std::vector<std::string>{"MinLod"}),
std::make_pair(ImageOperandsTemplate("Lod|Sample %fzero %izero"),
Add tests for SubgroupDispatch. Introduced in v1.1, SubgroupDispatch adds the following: - two new execution modes - one new capability - two new opcodes Extend ValidateBase methods to take a spv_target_env. Replace the context_ member with ScopedContext inside the said methods. Give ScopedContext wider visibility by moving it outside TextToBinaryTestBase.
2016-04-21 19:46:08 +00:00
AllCapabilities()))), );
Validator pass for image instructions Includes validation rules for OpImageXXX and ImageOperand. Doesn't include OpTypeImage and OpImageSparseXXX. Disabled an invalid test.
2017-10-26 19:30:23 +00:00
#endif
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
// TODO(umar): Instruction capability checks
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
spv_result_t spvCoreOperandTableNameLookup(spv_target_env env,
const spv_operand_table table,
const spv_operand_type_t type,
const char* name,
const size_t nameLength) {
if (!table) return SPV_ERROR_INVALID_TABLE;
if (!name) return SPV_ERROR_INVALID_POINTER;
for (uint64_t typeIndex = 0; typeIndex < table->count; ++typeIndex) {
const auto& group = table->types[typeIndex];
if (type != group.type) continue;
for (uint64_t index = 0; index < group.count; ++index) {
const auto& entry = group.entries[index];
// Check for min version only.
if (spvVersionForTargetEnv(env) >= entry.minVersion &&
nameLength == strlen(entry.name) &&
!strncmp(entry.name, name, nameLength)) {
return SPV_SUCCESS;
}
}
}
return SPV_ERROR_INVALID_LOOKUP;
}
// True if capability exists in core spec of env.
Add tests for SubgroupDispatch. Introduced in v1.1, SubgroupDispatch adds the following: - two new execution modes - one new capability - two new opcodes Extend ValidateBase methods to take a spv_target_env. Replace the context_ member with ScopedContext inside the said methods. Give ScopedContext wider visibility by moving it outside TextToBinaryTestBase.
2016-04-21 19:46:08 +00:00
bool Exists(const std::string& capability, spv_target_env env) {
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
ScopedContext sc(env);
return SPV_SUCCESS ==
spvCoreOperandTableNameLookup(env, sc.context->operand_table,
SPV_OPERAND_TYPE_CAPABILITY,
capability.c_str(), capability.size());
Add tests for SubgroupDispatch. Introduced in v1.1, SubgroupDispatch adds the following: - two new execution modes - one new capability - two new opcodes Extend ValidateBase methods to take a spv_target_env. Replace the context_ member with ScopedContext inside the said methods. Give ScopedContext wider visibility by moving it outside TextToBinaryTestBase.
2016-04-21 19:46:08 +00:00
}
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
TEST_P(ValidateCapability, Capability) {
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::string capability = Capability(GetParam());
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
spv_target_env env = SPV_ENV_UNIVERSAL_1_0;
if (!capability.empty()) {
if (Exists(capability, SPV_ENV_UNIVERSAL_1_0))
env = SPV_ENV_UNIVERSAL_1_0;
else if (Exists(capability, SPV_ENV_UNIVERSAL_1_1))
env = SPV_ENV_UNIVERSAL_1_1;
else if (Exists(capability, SPV_ENV_UNIVERSAL_1_2))
env = SPV_ENV_UNIVERSAL_1_2;
else
env = SPV_ENV_UNIVERSAL_1_3;
}
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::string test_code = MakeAssembly(GetParam());
Add v1.1 capabilities validation. Refactor the ValidateCapability test fixture. Explain the meaning of test parameters. Factor out methods for convenience and readability. DRY v1.0 and v1.1 tests.
2016-04-29 17:40:01 +00:00
CompileSuccessfully(test_code, env);
Migrate to use unified grammar tables Previously we keep a separate static grammar table for opcodes/ operands per SPIR-V version. This commit changes that to use a single unified static grammar table for opcodes/operands. This essentially changes how grammar facts are queried against a certain target environment. There are only limited filtering according to the desired target environment; a symbol is considered as available as long as: 1. The target environment satisfies the minimal requirement of the symbol; or 2. There is at least one extension enabling this symbol. Note that the second rule assumes the extension enabling the symbol is indeed requested in the SPIR-V code; checking that should be the validator's work. Also fixed a few grammar related issues: * Rounding mode capability requirements are moved to client APIs. * Reserved symbols not available in any extension is no longer recognized by assembler.
2018-03-14 17:06:18 +00:00
ASSERT_EQ(ExpectedResult(GetParam()), ValidateInstructions(env))
<< "target env: " << spvTargetEnvDescription(env) << "\ntest code:\n"
<< test_code;
Add v1.1 capabilities validation. Refactor the ValidateCapability test fixture. Explain the meaning of test parameters. Factor out methods for convenience and readability. DRY v1.0 and v1.1 tests.
2016-04-29 17:40:01 +00:00
}
TEST_P(ValidateCapabilityV11, Capability) {
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::string capability = Capability(GetParam());
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
if (Exists(capability, SPV_ENV_UNIVERSAL_1_1)) {
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::string test_code = MakeAssembly(GetParam());
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
CompileSuccessfully(test_code, SPV_ENV_UNIVERSAL_1_1);
ASSERT_EQ(ExpectedResult(GetParam()),
ValidateInstructions(SPV_ENV_UNIVERSAL_1_1))
<< test_code;
}
Initial capability implementation and unit tests * Register capabilility and checks * Add validate storage class capabilities checks and tests * Instruction pass refactor - More generic form of capability checking by checking operands instead of instructions * Execution Model capabilities checks * Decorate BuiltIn capability checks * Addressing Model capability checks * Memory Model capability checks * Execution Mode capability checks * Dim capability checks * SamplerAddressingMode capability checks
2016-01-23 19:14:32 +00:00
}
Use AssemblyGrammar for capability validation. Also: - ForEach() for spv_capability_mask_t. - Add capability min/max constants. - Move max definition from validate_types.cpp to spirv_definition.h.
2016-01-31 04:32:09 +00:00
Turn off ClipDistance CullDistance cap checks for Vulkan Turn them off until resolution of the debate over how they should be checked. Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/261
2016-07-07 21:03:22 +00:00
TEST_P(ValidateCapabilityVulkan10, Capability) {
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::string capability = Capability(GetParam());
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
if (Exists(capability, SPV_ENV_VULKAN_1_0)) {
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::string test_code = MakeAssembly(GetParam());
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
CompileSuccessfully(test_code, SPV_ENV_VULKAN_1_0);
ASSERT_EQ(ExpectedResult(GetParam()),
ValidateInstructions(SPV_ENV_VULKAN_1_0))
<< test_code;
}
}
TEST_P(ValidateCapabilityVulkan11, Capability) {
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::string capability = Capability(GetParam());
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
if (Exists(capability, SPV_ENV_VULKAN_1_1)) {
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::string test_code = MakeAssembly(GetParam());
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
CompileSuccessfully(test_code, SPV_ENV_VULKAN_1_1);
ASSERT_EQ(ExpectedResult(GetParam()),
ValidateInstructions(SPV_ENV_VULKAN_1_1))
<< test_code;
}
Turn off ClipDistance CullDistance cap checks for Vulkan Turn them off until resolution of the debate over how they should be checked. Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/261
2016-07-07 21:03:22 +00:00
}
Validate Vulkan 1.2 capabilities
2019-09-04 15:51:18 +00:00
TEST_P(ValidateCapabilityVulkan12, Capability) {
const std::string capability = Capability(GetParam());
if (Exists(capability, SPV_ENV_VULKAN_1_2)) {
const std::string test_code = MakeAssembly(GetParam());
CompileSuccessfully(test_code, SPV_ENV_VULKAN_1_2);
ASSERT_EQ(ExpectedResult(GetParam()),
ValidateInstructions(SPV_ENV_VULKAN_1_2))
<< test_code;
}
}
Relax ClipDistance, CullDistance capability check in all environments Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/365
2016-08-23 22:18:17 +00:00
TEST_P(ValidateCapabilityOpenGL40, Capability) {
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::string capability = Capability(GetParam());
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
if (Exists(capability, SPV_ENV_OPENGL_4_0)) {
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
const std::string test_code = MakeAssembly(GetParam());
Add Vulkan 1.1 capability sets Fixes #1597 * Classifies useable capabilities for Vulkan 1.1 * Updates tests
2018-06-20 18:35:09 +00:00
CompileSuccessfully(test_code, SPV_ENV_OPENGL_4_0);
ASSERT_EQ(ExpectedResult(GetParam()),
ValidateInstructions(SPV_ENV_OPENGL_4_0))
<< test_code;
}
Relax ClipDistance, CullDistance capability check in all environments Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/365
2016-08-23 22:18:17 +00:00
}
Avoid capability checks on ID values. They are not literals Works around issue 248 by weakening the test: https://github.com/KhronosGroup/SPIRV-Tools/issues/248 The validator should try to track (32-bit) constant values, and then for capability checks on IDs, check the referenced value, not the raw ID number.
2016-06-28 21:25:28 +00:00
TEST_F(ValidateCapability, SemanticsIdIsAnIdNotALiteral) {
// From https://github.com/KhronosGroup/SPIRV-Tools/issues/248
// The validator was interpreting the memory semantics ID number
// as the value to be checked rather than an ID that references
// another value to be checked.
// In this case a raw ID of 64 was mistaken to mean a literal
// semantic value of UniformMemory, which would require the Shader
// capability.
const char str[] = R"(
OpCapability Kernel
Validation of OpEntryPoint usage. According to the SPIRV Spec (2.16.1): * There is at least one OpEntryPoint instruction, unless the Linkage capability is being used. * No function can be targeted by both an OpEntryPoint instruction and an OpFunctionCall instruction. Also updated unit tests to includ OpEntryPoint.
2017-01-09 16:10:52 +00:00
OpCapability Linkage
Avoid capability checks on ID values. They are not literals Works around issue 248 by weakening the test: https://github.com/KhronosGroup/SPIRV-Tools/issues/248 The validator should try to track (32-bit) constant values, and then for capability checks on IDs, check the referenced value, not the raw ID number.
2016-06-28 21:25:28 +00:00
OpMemoryModel Logical OpenCL
; %i32 has ID 1
The Signedness in OpTypeInt must always be 0. When Kernel capability is used, The Signedness in OpTypeInt must always be 0. Fixes issue #492.
2017-02-09 21:23:40 +00:00
%i32 = OpTypeInt 32 0
Avoid capability checks on ID values. They are not literals Works around issue 248 by weakening the test: https://github.com/KhronosGroup/SPIRV-Tools/issues/248 The validator should try to track (32-bit) constant values, and then for capability checks on IDs, check the referenced value, not the raw ID number.
2016-06-28 21:25:28 +00:00
%tf = OpTypeFunction %i32
%pi32 = OpTypePointer CrossWorkgroup %i32
%var = OpVariable %pi32 CrossWorkgroup
%c = OpConstant %i32 100
%scope = OpConstant %i32 1 ; Device scope
; Fake an instruction with 64 as the result id.
; !64 = OpConstantNull %i32
!0x3002e !1 !64
%f = OpFunction %i32 None %tf
%l = OpLabel
%result = OpAtomicIAdd %i32 %var %scope !64 %c
OpReturnValue %result
OpFunctionEnd
)";
CompileSuccessfully(str);
Checks that result IDs are within the ID bound specified in the SPIR-V header This is described in Section 2.17 of the SPIR-V Spec. * Updated existing unit test 'SemanticsIdIsAnIdNotALiteral' to pass by manipulating the ID bound in its binary header. * Fixed boundary check in the code. * Added unit test to check the case that the largest ID is equal to the ID bound.
2016-11-24 20:37:22 +00:00
// Since we are forcing usage of <id> 64, the "id bound" in the binary header
// must be overwritten so that <id> 64 is considered within bound.
// ID Bound is at index 3 of the binary. Set it to 65.
OverwriteAssembledBinary(3, 65);
Avoid capability checks on ID values. They are not literals Works around issue 248 by weakening the test: https://github.com/KhronosGroup/SPIRV-Tools/issues/248 The validator should try to track (32-bit) constant values, and then for capability checks on IDs, check the referenced value, not the raw ID number.
2016-06-28 21:25:28 +00:00
ASSERT_EQ(SPV_SUCCESS, ValidateInstructions());
}
The Signedness in OpTypeInt must always be 0. When Kernel capability is used, The Signedness in OpTypeInt must always be 0. Fixes issue #492.
2017-02-09 21:23:40 +00:00
TEST_F(ValidateCapability, IntSignednessKernelGood) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Linkage
OpMemoryModel Logical OpenCL
%i32 = OpTypeInt 32 0
)";
CompileSuccessfully(spirv);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions());
}
TEST_F(ValidateCapability, IntSignednessKernelBad) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Linkage
OpMemoryModel Logical OpenCL
%i32 = OpTypeInt 32 1
)";
CompileSuccessfully(spirv);
EXPECT_EQ(SPV_ERROR_INVALID_BINARY, ValidateInstructions());
EXPECT_THAT(getDiagnosticString(),
HasSubstr("The Signedness in OpTypeInt must always be 0 when "
"Kernel capability is used."));
}
TEST_F(ValidateCapability, IntSignednessShaderGood) {
const std::string spirv = R"(
OpCapability Shader
OpCapability Linkage
OpMemoryModel Logical GLSL450
%u32 = OpTypeInt 32 0
%i32 = OpTypeInt 32 1
)";
CompileSuccessfully(spirv);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions());
}
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
TEST_F(ValidateCapability, NonVulkan10Capability) {
const std::string spirv = R"(
OpCapability Shader
OpCapability Linkage
OpMemoryModel Logical GLSL450
%u32 = OpTypeInt 32 0
%i32 = OpTypeInt 32 1
)";
CompileSuccessfully(spirv, SPV_ENV_VULKAN_1_0);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_VULKAN_1_0));
EXPECT_THAT(getDiagnosticString(),
Improved error message in val capabilities
2018-01-26 16:29:15 +00:00
HasSubstr("Capability Linkage is not allowed by Vulkan 1.0"));
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
}
TEST_F(ValidateCapability, Vulkan10EnabledByExtension) {
const std::string spirv = R"(
OpCapability Shader
OpCapability DrawParameters
OpExtension "SPV_KHR_shader_draw_parameters"
OpMemoryModel Logical GLSL450
OpEntryPoint Vertex %func "shader"
Add Vulkan validation rules for BuiltIn variables Added a framework for validation of BuiltIn variables. The framework allows implementation of flexible abstract rules which are required for built-ins as the information (decoration, definition, reference) is not in one place, but is scattered all over the module. Validation rules are implemented as a map id -> list<functor(instrution)> Ids which are dependent on built-in types or objects receive a task list, such as "this id cannot be referenced from function which is called from entry point with execution model X; propagate this rule to your descendants in the global scope". Also refactored test/val/val_fixtures. All built-ins covered by tests
2018-02-07 16:50:26 +00:00
OpMemberDecorate %block 0 BuiltIn PointSize
%f32 = OpTypeFloat 32
%block = OpTypeStruct %f32
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
)" + std::string(kVoidFVoid);
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
CompileSuccessfully(spirv, SPV_ENV_VULKAN_1_0);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_VULKAN_1_0));
}
TEST_F(ValidateCapability, Vulkan10NotEnabledByExtension) {
const std::string spirv = R"(
OpCapability Shader
OpCapability DrawParameters
OpMemoryModel Logical GLSL450
OpEntryPoint Vertex %func "shader"
OpDecorate %intt BuiltIn PointSize
%intt = OpTypeInt 32 0
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
)" + std::string(kVoidFVoid);
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
CompileSuccessfully(spirv, SPV_ENV_VULKAN_1_0);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_VULKAN_1_0));
Improved error message in val capabilities
2018-01-26 16:29:15 +00:00
EXPECT_THAT(
getDiagnosticString(),
HasSubstr("Capability DrawParameters is not allowed by Vulkan 1.0"));
Validator dissallows unsupported Vulkan capability If environment is SPV_ENV_VULKAN_1_0, disallow OpCapability operands which are not supported by Vulkan 1.0. See https://github.com/KhronosGroup/SPIRV-Tools/issues/572
2017-03-06 22:21:25 +00:00
}
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
TEST_F(ValidateCapability, NonOpenCL12FullCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability Pipes
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
)";
CompileSuccessfully(spirv, SPV_ENV_OPENCL_1_2);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_OPENCL_1_2));
EXPECT_THAT(
getDiagnosticString(),
Improved error message in val capabilities
2018-01-26 16:29:15 +00:00
HasSubstr("Capability Pipes is not allowed by OpenCL 1.2 Full Profile"));
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
}
TEST_F(ValidateCapability, OpenCL12FullEnabledByCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability ImageBasic
OpCapability Sampled1D
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
)" + std::string(kVoidFVoid);
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
CompileSuccessfully(spirv, SPV_ENV_OPENCL_1_2);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_OPENCL_1_2));
}
TEST_F(ValidateCapability, OpenCL12FullNotEnabledByCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability Sampled1D
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
)" + std::string(kVoidFVoid);
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
CompileSuccessfully(spirv, SPV_ENV_OPENCL_1_2);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_OPENCL_1_2));
EXPECT_THAT(
getDiagnosticString(),
HasSubstr(
Improved error message in val capabilities
2018-01-26 16:29:15 +00:00
"Capability Sampled1D is not allowed by OpenCL 1.2 Full Profile"));
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
}
TEST_F(ValidateCapability, NonOpenCL12EmbeddedCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability Int64
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
)";
CompileSuccessfully(spirv, SPV_ENV_OPENCL_EMBEDDED_1_2);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_OPENCL_EMBEDDED_1_2));
EXPECT_THAT(
getDiagnosticString(),
HasSubstr(
Improved error message in val capabilities
2018-01-26 16:29:15 +00:00
"Capability Int64 is not allowed by OpenCL 1.2 Embedded Profile"));
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
}
TEST_F(ValidateCapability, OpenCL12EmbeddedEnabledByCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability ImageBasic
OpCapability Sampled1D
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
)" + std::string(kVoidFVoid);
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
CompileSuccessfully(spirv, SPV_ENV_OPENCL_EMBEDDED_1_2);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_OPENCL_EMBEDDED_1_2));
}
TEST_F(ValidateCapability, OpenCL12EmbeddedNotEnabledByCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability Sampled1D
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
)" + std::string(kVoidFVoid);
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
CompileSuccessfully(spirv, SPV_ENV_OPENCL_EMBEDDED_1_2);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_OPENCL_EMBEDDED_1_2));
Improved error message in val capabilities
2018-01-26 16:29:15 +00:00
EXPECT_THAT(getDiagnosticString(),
HasSubstr("Capability Sampled1D is not allowed by OpenCL 1.2 "
"Embedded Profile"));
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
}
Update OpenCL capabilities validation (#3149) * spirv-val: Pipes are no longer required for OpenCL 1.2 EP This was removed from the OpenCL SPIR-V Environment Specification via https://github.com/KhronosGroup/OpenCL-Docs/pull/56. * spirv-val: Sort headers according to clang-format * spirv-val: Groups capability is required since OpenCL 2.0
2020-07-27 17:01:45 +00:00
TEST_F(ValidateCapability, OpenCL12EmbeddedNoLongerEnabledByCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability Pipes
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
)" + std::string(kVoidFVoid);
CompileSuccessfully(spirv, SPV_ENV_OPENCL_EMBEDDED_1_2);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_OPENCL_EMBEDDED_1_2));
EXPECT_THAT(getDiagnosticString(),
HasSubstr("Capability Pipes is not allowed by OpenCL 1.2 "
"Embedded Profile"));
}
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
TEST_F(ValidateCapability, OpenCL20FullCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
Update OpenCL capabilities validation (#3149) * spirv-val: Pipes are no longer required for OpenCL 1.2 EP This was removed from the OpenCL SPIR-V Environment Specification via https://github.com/KhronosGroup/OpenCL-Docs/pull/56. * spirv-val: Sort headers according to clang-format * spirv-val: Groups capability is required since OpenCL 2.0
2020-07-27 17:01:45 +00:00
OpCapability Groups
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
OpCapability Pipes
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
)";
CompileSuccessfully(spirv, SPV_ENV_OPENCL_2_0);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_OPENCL_2_0));
}
TEST_F(ValidateCapability, NonOpenCL20FullCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability Matrix
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
)";
CompileSuccessfully(spirv, SPV_ENV_OPENCL_2_0);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_OPENCL_2_0));
EXPECT_THAT(
getDiagnosticString(),
HasSubstr(
Improved error message in val capabilities
2018-01-26 16:29:15 +00:00
"Capability Matrix is not allowed by OpenCL 2.0/2.1 Full Profile"));
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
}
TEST_F(ValidateCapability, OpenCL20FullEnabledByCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability ImageBasic
OpCapability Sampled1D
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
)" + std::string(kVoidFVoid);
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
CompileSuccessfully(spirv, SPV_ENV_OPENCL_2_0);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_OPENCL_2_0));
}
TEST_F(ValidateCapability, OpenCL20FullNotEnabledByCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability Sampled1D
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
)" + std::string(kVoidFVoid);
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
CompileSuccessfully(spirv, SPV_ENV_OPENCL_2_0);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_OPENCL_2_0));
Improved error message in val capabilities
2018-01-26 16:29:15 +00:00
EXPECT_THAT(getDiagnosticString(),
HasSubstr("Capability Sampled1D is not allowed by OpenCL 2.0/2.1 "
"Full Profile"));
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
}
TEST_F(ValidateCapability, NonOpenCL20EmbeddedCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability Int64
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
)";
CompileSuccessfully(spirv, SPV_ENV_OPENCL_EMBEDDED_2_0);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_OPENCL_EMBEDDED_2_0));
EXPECT_THAT(getDiagnosticString(),
Improved error message in val capabilities
2018-01-26 16:29:15 +00:00
HasSubstr("Capability Int64 is not allowed by OpenCL 2.0/2.1 "
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
"Embedded Profile"));
}
TEST_F(ValidateCapability, OpenCL20EmbeddedEnabledByCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability ImageBasic
OpCapability Sampled1D
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
)" + std::string(kVoidFVoid);
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
CompileSuccessfully(spirv, SPV_ENV_OPENCL_EMBEDDED_2_0);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_OPENCL_EMBEDDED_2_0));
}
TEST_F(ValidateCapability, OpenCL20EmbeddedNotEnabledByCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability Sampled1D
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
)" + std::string(kVoidFVoid);
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
CompileSuccessfully(spirv, SPV_ENV_OPENCL_EMBEDDED_2_0);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_OPENCL_EMBEDDED_2_0));
EXPECT_THAT(getDiagnosticString(),
Improved error message in val capabilities
2018-01-26 16:29:15 +00:00
HasSubstr("Capability Sampled1D is not allowed by OpenCL 2.0/2.1 "
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
"Embedded Profile"));
}
TEST_F(ValidateCapability, OpenCL22FullCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability PipeStorage
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
)";
CompileSuccessfully(spirv, SPV_ENV_OPENCL_2_2);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_OPENCL_2_2));
}
TEST_F(ValidateCapability, NonOpenCL22FullCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability Matrix
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
)";
CompileSuccessfully(spirv, SPV_ENV_OPENCL_2_2);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_OPENCL_2_2));
EXPECT_THAT(
getDiagnosticString(),
Improved error message in val capabilities
2018-01-26 16:29:15 +00:00
HasSubstr("Capability Matrix is not allowed by OpenCL 2.2 Full Profile"));
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
}
TEST_F(ValidateCapability, OpenCL22FullEnabledByCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability ImageBasic
OpCapability Sampled1D
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
)" + std::string(kVoidFVoid);
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
CompileSuccessfully(spirv, SPV_ENV_OPENCL_2_2);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_OPENCL_2_2));
}
TEST_F(ValidateCapability, OpenCL22FullNotEnabledByCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability Sampled1D
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
)" + std::string(kVoidFVoid);
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
CompileSuccessfully(spirv, SPV_ENV_OPENCL_2_2);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_OPENCL_2_2));
EXPECT_THAT(
getDiagnosticString(),
HasSubstr(
Improved error message in val capabilities
2018-01-26 16:29:15 +00:00
"Capability Sampled1D is not allowed by OpenCL 2.2 Full Profile"));
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
}
TEST_F(ValidateCapability, NonOpenCL22EmbeddedCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability Int64
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
)";
CompileSuccessfully(spirv, SPV_ENV_OPENCL_EMBEDDED_2_2);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_OPENCL_EMBEDDED_2_2));
EXPECT_THAT(
getDiagnosticString(),
HasSubstr(
Improved error message in val capabilities
2018-01-26 16:29:15 +00:00
"Capability Int64 is not allowed by OpenCL 2.2 Embedded Profile"));
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
}
TEST_F(ValidateCapability, OpenCL22EmbeddedEnabledByCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability ImageBasic
OpCapability Sampled1D
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
)" + std::string(kVoidFVoid);
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
CompileSuccessfully(spirv, SPV_ENV_OPENCL_EMBEDDED_2_2);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_OPENCL_EMBEDDED_2_2));
}
TEST_F(ValidateCapability, OpenCL22EmbeddedNotEnabledByCapability) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability Linkage
OpCapability Sampled1D
OpMemoryModel Physical64 OpenCL
%u32 = OpTypeInt 32 0
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
)" + std::string(kVoidFVoid);
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
CompileSuccessfully(spirv, SPV_ENV_OPENCL_EMBEDDED_2_2);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_OPENCL_EMBEDDED_2_2));
Improved error message in val capabilities
2018-01-26 16:29:15 +00:00
EXPECT_THAT(getDiagnosticString(),
HasSubstr("Capability Sampled1D is not allowed by OpenCL 2.2 "
"Embedded Profile"));
Support OpenCL 1.2 and 2.0 target environments include: Add target environment enums for OpenCL 1.2 and 2.0 Validator: Validate OpenCL capabilities Update validate capabilities to handle embedded profiles Add test for OpenCL capabilities validation Update messages to mention the OpenCL profile used Re-format val_capability_test.cpp
2017-11-29 23:49:23 +00:00
}
Instruction lookup succeeds if it's enabled by a capability Also add a corresponding check for capabilities in the validator. Update previously existing test cases where an instruction used to fail assembling because of a version check, but now they succeed because the instruction is also guarded by a capability. Now it should assemble. Add tests to ensure that capabilities are checked appropriately. The explicitly reserved instructions OpImageSparseSampleProj* now assemble, but they fail validation. Fixes #1624
2018-06-19 13:54:33 +00:00
// Three tests to check enablement of an enum (a decoration) which is not
// in core, and is directly enabled by a capability, but not directly enabled
// by an extension. See https://github.com/KhronosGroup/SPIRV-Tools/issues/1596
Operand lookup succeeds if it's enabled by a capability - Fix tests for basic group operations (e.g. Reduce) to allow for new capabilities in SPIR-V 1.3 that enable them. - Refactor operand capability check to avoid code duplication and to put all checks that don't need table lookup before any table lookup. - Test round trip assembly/disassembly support for extension SPV_NV_viewport_array2 - Test assembly and validation of decoration ViewportRelativeNV Fixes #1596
2018-06-06 06:07:51 +00:00
TEST_F(ValidateCapability, DecorationFromExtensionMissingEnabledByCapability) {
// Decoration ViewportRelativeNV is enabled by ShaderViewportMaskNV, which in
// turn is enabled by SPV_NV_viewport_array2.
const std::string spirv = R"(
OpCapability Shader
OpMemoryModel Logical Simple
OpDecorate %void ViewportRelativeNV
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
)" + std::string(kVoidFVoid);
Operand lookup succeeds if it's enabled by a capability - Fix tests for basic group operations (e.g. Reduce) to allow for new capabilities in SPIR-V 1.3 that enable them. - Refactor operand capability check to avoid code duplication and to put all checks that don't need table lookup before any table lookup. - Test round trip assembly/disassembly support for extension SPV_NV_viewport_array2 - Test assembly and validation of decoration ViewportRelativeNV Fixes #1596
2018-06-06 06:07:51 +00:00
CompileSuccessfully(spirv, SPV_ENV_UNIVERSAL_1_0);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_UNIVERSAL_1_0));
EXPECT_THAT(getDiagnosticString(),
HasSubstr("Operand 2 of Decorate requires one of these "
"capabilities: ShaderViewportMaskNV"));
}
TEST_F(ValidateCapability, CapabilityEnabledByMissingExtension) {
// Capability ShaderViewportMaskNV is enabled by SPV_NV_viewport_array2.
const std::string spirv = R"(
OpCapability Shader
OpCapability ShaderViewportMaskNV
OpMemoryModel Logical Simple
Remove using std::<foo> statements. (#1756) Many of the files have using std::<foo> statements in them, but then the use of <foo> will be inconsistently std::<foo> or <foo> scattered through the file. This CL removes all of the using statements and updates the code to have the required std:: prefix.
2018-08-01 18:58:12 +00:00
)" + std::string(kVoidFVoid);
Operand lookup succeeds if it's enabled by a capability - Fix tests for basic group operations (e.g. Reduce) to allow for new capabilities in SPIR-V 1.3 that enable them. - Refactor operand capability check to avoid code duplication and to put all checks that don't need table lookup before any table lookup. - Test round trip assembly/disassembly support for extension SPV_NV_viewport_array2 - Test assembly and validation of decoration ViewportRelativeNV Fixes #1596
2018-06-06 06:07:51 +00:00
CompileSuccessfully(spirv, SPV_ENV_UNIVERSAL_1_0);
EXPECT_EQ(SPV_ERROR_MISSING_EXTENSION,
ValidateInstructions(SPV_ENV_UNIVERSAL_1_0));
EXPECT_THAT(getDiagnosticString(),
Support SPIR-V 1.4 (#2550) * SPIR-V 1.4 headers, add SPV_ENV_UNIVERSAL_1_4 * Support --target-env spv1.4 in help for command line tools * Support asm/dis of UniformId decoration * Validate UniformId decoration * Fix version check on instructions and operands Also register decorations used with OpDecorateId * Extension lists can differ between enums that match Example: SubgroupMaskEq vs SubgroupMaskEqKHR * Validate scope value for Uniform decoration, for SPIR-V 1.4 * More unioning of exts * Preserve grammar order within an enum value * 1.4: Validate OpSelect over composites * Tools default to 1.4 * Add asm/dis test for OpCopyLogical * 1.4: asm/dis tests for PtrEqual, PtrNotEqual, PtrDiff * Basic asm/Dis test for OpCopyMemory * Test asm/dis OpCopyMemory with 2-memory access Add asm/dis tests for OpCopyMemorySized Requires grammar update to add second optional memory access operand to OpCopyMemory and OpCopyMemorySized * Validate one or two memory accesses on OpCopyMemory* * Check av/vis on CopyMemory source and target memory access This is a proposed rule. See https://gitlab.khronos.org/spirv/SPIR-V/issues/413 * Validate operation for OpSpecConstantOp * Validate NonWritable decoration Also permit NonWritable on members of UBO and SSBO. * SPIR-V 1.4: NonWrtiable can decorate Function and Private vars * Update optimizer CLI tests for SPIR-V 1.4 * Testing tools: Give expected SPIR-V version in message * SPIR-V 1.4 validation for entry point interfaces * Allow only unique interfaces * Allow all global variables * Check that all statically used global variables are listed * new tests * Add validation fixture CompileFailure * Add 1.4 validation for pointer comparisons * New tests * Validate with image operands SignExtend, ZeroExtend Since we don't actually know the image texel format, we can't fully validate. We need more context. But we can make sure we allow the new image operands in known-good cases. * Validate OpCopyLogical * Recursively checks subtypes * new tests * Add SPIR-V 1.4 tests for NoSignedWrap, NoUnsignedWrap * Allow scalar conditions in 1.4 with OpSelect * Allows scalar conditions with vector operands * new tests * Validate uniform id scope as an execution scope * Validate the values of memory and execution scopes are valid scope values * new test * Remove SPIR-V 1.4 Vulkan 1.0 environment * SPIR-V 1.4 requires Vulkan 1.1 * FIX: include string for spvLog * FIX: validate nonwritable * FIX: test case suite for member decorate string * FIX: test case for hlsl functionality1 * Validation test fixture: ease debugging * Use binary version for SPIR-V 1.4 specific features * Switch checks based on the SPIR-V version from the target environment to instead use the version from the binary * Moved header parsing into the ValidationState_t constructor (where version based features are set) * Added new versions of tests that assemble a 1.3 binary and validate a 1.4 environment * Fix test for update to SPIR-V 1.4 headers * Fix formatting * Ext inst lookup: Add Vulkan 1.1 env with SPIR-V 1.4 * Update spirv-val help * Operand version checks should use module version Use the module version instead of the target environment version. * Fix comment about two-access form of OpCopyMemory
2019-05-07 16:27:18 +00:00
HasSubstr("operand ShaderViewportMaskNV(5255) requires one of "
"these extensions: SPV_NV_viewport_array2"));
Operand lookup succeeds if it's enabled by a capability - Fix tests for basic group operations (e.g. Reduce) to allow for new capabilities in SPIR-V 1.3 that enable them. - Refactor operand capability check to avoid code duplication and to put all checks that don't need table lookup before any table lookup. - Test round trip assembly/disassembly support for extension SPV_NV_viewport_array2 - Test assembly and validation of decoration ViewportRelativeNV Fixes #1596
2018-06-06 06:07:51 +00:00
}
TEST_F(ValidateCapability,
DecorationEnabledByCapabilityEnabledByPresentExtension) {
// Decoration ViewportRelativeNV is enabled by ShaderViewportMaskNV, which in
// turn is enabled by SPV_NV_viewport_array2.
const std::string spirv = R"(
OpCapability Shader
OpCapability Linkage
OpCapability ShaderViewportMaskNV
OpExtension "SPV_NV_viewport_array2"
OpMemoryModel Logical Simple
OpDecorate %void ViewportRelativeNV
%void = OpTypeVoid
)";
CompileSuccessfully(spirv, SPV_ENV_UNIVERSAL_1_0);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_UNIVERSAL_1_0))
<< getDiagnosticString();
}
Instruction lookup succeeds if it's enabled by a capability Also add a corresponding check for capabilities in the validator. Update previously existing test cases where an instruction used to fail assembling because of a version check, but now they succeed because the instruction is also guarded by a capability. Now it should assemble. Add tests to ensure that capabilities are checked appropriately. The explicitly reserved instructions OpImageSparseSampleProj* now assemble, but they fail validation. Fixes #1624
2018-06-19 13:54:33 +00:00
// Three tests to check enablement of an instruction which is not in core, and
// is directly enabled by a capability, but not directly enabled by an
// extension. See https://github.com/KhronosGroup/SPIRV-Tools/issues/1624
// Instruction OpSubgroupShuffleINTEL is enabled by SubgroupShuffleINTEL, which
// in turn is enabled by SPV_INTEL_subgroups.
TEST_F(ValidateCapability, InstructionFromExtensionMissingEnabledByCapability) {
// Decoration ViewportRelativeNV is enabled by ShaderViewportMaskNV, which in
// turn is enabled by SPV_NV_viewport_array2.
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
; OpCapability SubgroupShuffleINTEL
OpExtension "SPV_INTEL_subgroups"
OpMemoryModel Physical32 OpenCL
OpEntryPoint Kernel %main "main"
%void = OpTypeVoid
%uint = OpTypeInt 32 0
%voidfn = OpTypeFunction %void
%zero = OpConstant %uint 0
%main = OpFunction %void None %voidfn
%entry = OpLabel
%foo = OpSubgroupShuffleINTEL %uint %zero %zero
OpReturn
OpFunctionEnd
)";
CompileSuccessfully(spirv, SPV_ENV_UNIVERSAL_1_0);
EXPECT_EQ(SPV_ERROR_INVALID_CAPABILITY,
ValidateInstructions(SPV_ENV_UNIVERSAL_1_0));
EXPECT_THAT(getDiagnosticString(),
HasSubstr("Opcode SubgroupShuffleINTEL requires one of these "
"capabilities: SubgroupShuffleINTEL"));
}
TEST_F(ValidateCapability,
InstructionEnablingCapabilityEnabledByMissingExtension) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability SubgroupShuffleINTEL
; OpExtension "SPV_INTEL_subgroups"
OpMemoryModel Physical32 OpenCL
OpEntryPoint Kernel %main "main"
%void = OpTypeVoid
%uint = OpTypeInt 32 0
%voidfn = OpTypeFunction %void
%zero = OpConstant %uint 0
%main = OpFunction %void None %voidfn
%entry = OpLabel
%foo = OpSubgroupShuffleINTEL %uint %zero %zero
OpReturn
OpFunctionEnd
)";
CompileSuccessfully(spirv, SPV_ENV_UNIVERSAL_1_0);
EXPECT_EQ(SPV_ERROR_MISSING_EXTENSION,
ValidateInstructions(SPV_ENV_UNIVERSAL_1_0));
EXPECT_THAT(getDiagnosticString(),
Support SPIR-V 1.4 (#2550) * SPIR-V 1.4 headers, add SPV_ENV_UNIVERSAL_1_4 * Support --target-env spv1.4 in help for command line tools * Support asm/dis of UniformId decoration * Validate UniformId decoration * Fix version check on instructions and operands Also register decorations used with OpDecorateId * Extension lists can differ between enums that match Example: SubgroupMaskEq vs SubgroupMaskEqKHR * Validate scope value for Uniform decoration, for SPIR-V 1.4 * More unioning of exts * Preserve grammar order within an enum value * 1.4: Validate OpSelect over composites * Tools default to 1.4 * Add asm/dis test for OpCopyLogical * 1.4: asm/dis tests for PtrEqual, PtrNotEqual, PtrDiff * Basic asm/Dis test for OpCopyMemory * Test asm/dis OpCopyMemory with 2-memory access Add asm/dis tests for OpCopyMemorySized Requires grammar update to add second optional memory access operand to OpCopyMemory and OpCopyMemorySized * Validate one or two memory accesses on OpCopyMemory* * Check av/vis on CopyMemory source and target memory access This is a proposed rule. See https://gitlab.khronos.org/spirv/SPIR-V/issues/413 * Validate operation for OpSpecConstantOp * Validate NonWritable decoration Also permit NonWritable on members of UBO and SSBO. * SPIR-V 1.4: NonWrtiable can decorate Function and Private vars * Update optimizer CLI tests for SPIR-V 1.4 * Testing tools: Give expected SPIR-V version in message * SPIR-V 1.4 validation for entry point interfaces * Allow only unique interfaces * Allow all global variables * Check that all statically used global variables are listed * new tests * Add validation fixture CompileFailure * Add 1.4 validation for pointer comparisons * New tests * Validate with image operands SignExtend, ZeroExtend Since we don't actually know the image texel format, we can't fully validate. We need more context. But we can make sure we allow the new image operands in known-good cases. * Validate OpCopyLogical * Recursively checks subtypes * new tests * Add SPIR-V 1.4 tests for NoSignedWrap, NoUnsignedWrap * Allow scalar conditions in 1.4 with OpSelect * Allows scalar conditions with vector operands * new tests * Validate uniform id scope as an execution scope * Validate the values of memory and execution scopes are valid scope values * new test * Remove SPIR-V 1.4 Vulkan 1.0 environment * SPIR-V 1.4 requires Vulkan 1.1 * FIX: include string for spvLog * FIX: validate nonwritable * FIX: test case suite for member decorate string * FIX: test case for hlsl functionality1 * Validation test fixture: ease debugging * Use binary version for SPIR-V 1.4 specific features * Switch checks based on the SPIR-V version from the target environment to instead use the version from the binary * Moved header parsing into the ValidationState_t constructor (where version based features are set) * Added new versions of tests that assemble a 1.3 binary and validate a 1.4 environment * Fix test for update to SPIR-V 1.4 headers * Fix formatting * Ext inst lookup: Add Vulkan 1.1 env with SPIR-V 1.4 * Update spirv-val help * Operand version checks should use module version Use the module version instead of the target environment version. * Fix comment about two-access form of OpCopyMemory
2019-05-07 16:27:18 +00:00
HasSubstr("operand SubgroupShuffleINTEL(5568) requires one of "
"these extensions: SPV_INTEL_subgroups"));
Instruction lookup succeeds if it's enabled by a capability Also add a corresponding check for capabilities in the validator. Update previously existing test cases where an instruction used to fail assembling because of a version check, but now they succeed because the instruction is also guarded by a capability. Now it should assemble. Add tests to ensure that capabilities are checked appropriately. The explicitly reserved instructions OpImageSparseSampleProj* now assemble, but they fail validation. Fixes #1624
2018-06-19 13:54:33 +00:00
}
TEST_F(ValidateCapability,
InstructionEnabledByCapabilityEnabledByPresentExtension) {
const std::string spirv = R"(
OpCapability Kernel
OpCapability Addresses
OpCapability SubgroupShuffleINTEL
OpExtension "SPV_INTEL_subgroups"
OpMemoryModel Physical32 OpenCL
OpEntryPoint Kernel %main "main"
%void = OpTypeVoid
%uint = OpTypeInt 32 0
%voidfn = OpTypeFunction %void
%zero = OpConstant %uint 0
%main = OpFunction %void None %voidfn
%entry = OpLabel
%foo = OpSubgroupShuffleINTEL %uint %zero %zero
OpReturn
OpFunctionEnd
)";
CompileSuccessfully(spirv, SPV_ENV_UNIVERSAL_1_0);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_UNIVERSAL_1_0))
<< getDiagnosticString();
}
Validate vulkan mem model capabilty * Check that if the VulkanMemoryModelKHR capability is specified that the memory model must be VulkanKHR * added tests
2018-07-26 12:43:46 +00:00
TEST_F(ValidateCapability, VulkanMemoryModelWithVulkanKHR) {
const std::string spirv = R"(
OpCapability Shader
OpCapability VulkanMemoryModelKHR
OpCapability Linkage
OpExtension "SPV_KHR_vulkan_memory_model"
OpMemoryModel Logical VulkanKHR
)";
CompileSuccessfully(spirv, SPV_ENV_UNIVERSAL_1_3);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_UNIVERSAL_1_3))
<< getDiagnosticString();
}
TEST_F(ValidateCapability, VulkanMemoryModelWithGLSL450) {
const std::string spirv = R"(
OpCapability Shader
OpCapability VulkanMemoryModelKHR
OpCapability Linkage
OpExtension "SPV_KHR_vulkan_memory_model"
OpMemoryModel Logical GLSL450
)";
CompileSuccessfully(spirv, SPV_ENV_UNIVERSAL_1_3);
EXPECT_EQ(SPV_ERROR_INVALID_DATA,
ValidateInstructions(SPV_ENV_UNIVERSAL_1_3));
EXPECT_THAT(getDiagnosticString(),
HasSubstr("VulkanMemoryModelKHR capability must only be "
"specified if the VulkanKHR memory model is used"));
}
Support SPIR-V 1.4 (#2550) * SPIR-V 1.4 headers, add SPV_ENV_UNIVERSAL_1_4 * Support --target-env spv1.4 in help for command line tools * Support asm/dis of UniformId decoration * Validate UniformId decoration * Fix version check on instructions and operands Also register decorations used with OpDecorateId * Extension lists can differ between enums that match Example: SubgroupMaskEq vs SubgroupMaskEqKHR * Validate scope value for Uniform decoration, for SPIR-V 1.4 * More unioning of exts * Preserve grammar order within an enum value * 1.4: Validate OpSelect over composites * Tools default to 1.4 * Add asm/dis test for OpCopyLogical * 1.4: asm/dis tests for PtrEqual, PtrNotEqual, PtrDiff * Basic asm/Dis test for OpCopyMemory * Test asm/dis OpCopyMemory with 2-memory access Add asm/dis tests for OpCopyMemorySized Requires grammar update to add second optional memory access operand to OpCopyMemory and OpCopyMemorySized * Validate one or two memory accesses on OpCopyMemory* * Check av/vis on CopyMemory source and target memory access This is a proposed rule. See https://gitlab.khronos.org/spirv/SPIR-V/issues/413 * Validate operation for OpSpecConstantOp * Validate NonWritable decoration Also permit NonWritable on members of UBO and SSBO. * SPIR-V 1.4: NonWrtiable can decorate Function and Private vars * Update optimizer CLI tests for SPIR-V 1.4 * Testing tools: Give expected SPIR-V version in message * SPIR-V 1.4 validation for entry point interfaces * Allow only unique interfaces * Allow all global variables * Check that all statically used global variables are listed * new tests * Add validation fixture CompileFailure * Add 1.4 validation for pointer comparisons * New tests * Validate with image operands SignExtend, ZeroExtend Since we don't actually know the image texel format, we can't fully validate. We need more context. But we can make sure we allow the new image operands in known-good cases. * Validate OpCopyLogical * Recursively checks subtypes * new tests * Add SPIR-V 1.4 tests for NoSignedWrap, NoUnsignedWrap * Allow scalar conditions in 1.4 with OpSelect * Allows scalar conditions with vector operands * new tests * Validate uniform id scope as an execution scope * Validate the values of memory and execution scopes are valid scope values * new test * Remove SPIR-V 1.4 Vulkan 1.0 environment * SPIR-V 1.4 requires Vulkan 1.1 * FIX: include string for spvLog * FIX: validate nonwritable * FIX: test case suite for member decorate string * FIX: test case for hlsl functionality1 * Validation test fixture: ease debugging * Use binary version for SPIR-V 1.4 specific features * Switch checks based on the SPIR-V version from the target environment to instead use the version from the binary * Moved header parsing into the ValidationState_t constructor (where version based features are set) * Added new versions of tests that assemble a 1.3 binary and validate a 1.4 environment * Fix test for update to SPIR-V 1.4 headers * Fix formatting * Ext inst lookup: Add Vulkan 1.1 env with SPIR-V 1.4 * Update spirv-val help * Operand version checks should use module version Use the module version instead of the target environment version. * Fix comment about two-access form of OpCopyMemory
2019-05-07 16:27:18 +00:00
// In the grammar, SubgroupEqMask and SubgroupMaskKHR have different enabling
// lists of extensions.
TEST_F(ValidateCapability, SubgroupEqMaskEnabledByExtension) {
const std::string spirv = R"(
OpCapability Shader
OpCapability SubgroupBallotKHR
OpExtension "SPV_KHR_shader_ballot"
OpMemoryModel Logical Simple
OpEntryPoint GLCompute %main "main"
OpDecorate %var BuiltIn SubgroupEqMask
%void = OpTypeVoid
%uint = OpTypeInt 32 0
%ptr_uint = OpTypePointer Private %uint
%var = OpVariable %ptr_uint Private
%fn = OpTypeFunction %void
%main = OpFunction %void None %fn
%entry = OpLabel
%val = OpLoad %uint %var
OpReturn
OpFunctionEnd
)";
CompileSuccessfully(spirv, SPV_ENV_UNIVERSAL_1_0);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_UNIVERSAL_1_0))
<< getDiagnosticString();
}
SPIRV-Tools support for SPIR-V 1.5 (#2865) * Ensure same enum values have consistent extension lists * val: fix checking of capabilities The operand for an OpCapability should only be checked for the extension or core version. The InstructionPass registers a capability, and all its implied sub-capabilities before actually checking the operand to an OpCapability. * Add basic support for SPIR-V 1.5 - Adds SPV_ENV_UNIVERSAL_1_5 - Command line tools default to spv1.5 environment - SPIR-V 1.5 incorporates several extensions. Now the disassembler prefers outputing the non-EXT or non-KHR names. This requires updates to many tests, to make strings match again. - Command line tests: Expect SPIR-V 1.5 by default * Test validation of SPIR-V 1.5 incorporated extensions Starting with 1.5, incorporated features no longer require the associated OpExtension instruction.
2019-09-13 18:59:02 +00:00
// Test that extensions incorporated into SPIR-V 1.5 no longer require
// the associated OpExtension instruction. Test one capability per extension.
struct CapabilityExtensionVersionCase {
std::string capability;
std::string capability_new_name;
std::string extension;
spv_target_env last_version_requiring_extension;
spv_target_env first_version_in_core;
};
using ValidateCapabilityExtensionVersionTest =
spvtest::ValidateBase<CapabilityExtensionVersionCase>;
// Returns a minimal shader module with the given capability instruction.
std::string MinimalShaderModuleWithCapability(std::string cap) {
std::string mem_model =
(cap.find("VulkanMemory") == 0) ? "VulkanKHR" : "GLSL450";
std::string extra_cap = (cap.find("VulkanMemoryModelDeviceScope") == 0)
? "\nOpCapability VulkanMemoryModelKHR\n"
: "";
return std::string("OpCapability ") + cap + extra_cap + R"(
OpCapability Shader
OpMemoryModel Logical )" + mem_model + R"(
OpEntryPoint Vertex %main "main"
%void = OpTypeVoid
%void_fn = OpTypeFunction %void
%main = OpFunction %void None %void_fn
%entry = OpLabel
OpReturn
OpFunctionEnd
)";
}
TEST_P(ValidateCapabilityExtensionVersionTest, FailsInOlderSpirvVersion) {
const auto spirv = MinimalShaderModuleWithCapability(GetParam().capability);
CompileSuccessfully(spirv, GetParam().last_version_requiring_extension);
EXPECT_EQ(SPV_ERROR_MISSING_EXTENSION,
ValidateInstructions(GetParam().last_version_requiring_extension));
EXPECT_THAT(getDiagnosticString(),
HasSubstr(std::string("1st operand of Capability: operand ") +
GetParam().capability_new_name))
<< spirv << "\n";
EXPECT_THAT(getDiagnosticString(),
HasSubstr(std::string("requires one of these extensions: ") +
GetParam().extension));
}
TEST_P(ValidateCapabilityExtensionVersionTest,
SucceedsInNewerSpirvVersionWithOldName) {
const auto spirv = MinimalShaderModuleWithCapability(GetParam().capability);
CompileSuccessfully(spirv, GetParam().first_version_in_core);
EXPECT_EQ(SPV_SUCCESS,
ValidateInstructions(GetParam().first_version_in_core));
EXPECT_THAT(getDiagnosticString(), Eq("")) << spirv << "\n";
}
TEST_P(ValidateCapabilityExtensionVersionTest,
SucceedsInNewerSpirvVersionWithNewName) {
const auto spirv =
MinimalShaderModuleWithCapability(GetParam().capability_new_name);
CompileSuccessfully(spirv, GetParam().first_version_in_core);
EXPECT_EQ(SPV_SUCCESS,
ValidateInstructions(GetParam().first_version_in_core));
EXPECT_THAT(getDiagnosticString(), Eq("")) << spirv << "\n";
}
std::vector<CapabilityExtensionVersionCase> CapVersionCases1_5() {
#define IN15NOSUFFIX(C, E) \
{ C, C, E, SPV_ENV_UNIVERSAL_1_4, SPV_ENV_UNIVERSAL_1_5 }
#define IN15(C, C_WITHOUT_SUFFIX, E) \
{ C, C_WITHOUT_SUFFIX, E, SPV_ENV_UNIVERSAL_1_4, SPV_ENV_UNIVERSAL_1_5 }
return std::vector<CapabilityExtensionVersionCase>{
// SPV_KHR_8bit_storage
IN15NOSUFFIX("StorageBuffer8BitAccess", "SPV_KHR_8bit_storage"),
IN15NOSUFFIX("UniformAndStorageBuffer8BitAccess", "SPV_KHR_8bit_storage"),
IN15NOSUFFIX("StoragePushConstant8", "SPV_KHR_8bit_storage"),
// SPV_EXT_descriptor_indexing
IN15("ShaderNonUniformEXT", "ShaderNonUniform",
"SPV_EXT_descriptor_indexing"),
IN15("RuntimeDescriptorArrayEXT", "RuntimeDescriptorArray",
"SPV_EXT_descriptor_indexing"),
IN15("InputAttachmentArrayDynamicIndexingEXT",
"InputAttachmentArrayDynamicIndexing",
"SPV_EXT_descriptor_indexing"),
IN15("UniformTexelBufferArrayDynamicIndexingEXT",
"UniformTexelBufferArrayDynamicIndexing",
"SPV_EXT_descriptor_indexing"),
IN15("StorageTexelBufferArrayDynamicIndexingEXT",
"StorageTexelBufferArrayDynamicIndexing",
"SPV_EXT_descriptor_indexing"),
IN15("UniformBufferArrayNonUniformIndexingEXT",
"UniformBufferArrayNonUniformIndexing",
"SPV_EXT_descriptor_indexing"),
IN15("SampledImageArrayNonUniformIndexingEXT",
"SampledImageArrayNonUniformIndexing",
"SPV_EXT_descriptor_indexing"),
IN15("StorageBufferArrayNonUniformIndexingEXT",
"StorageBufferArrayNonUniformIndexing",
"SPV_EXT_descriptor_indexing"),
IN15("StorageImageArrayNonUniformIndexingEXT",
"StorageImageArrayNonUniformIndexing",
"SPV_EXT_descriptor_indexing"),
IN15("InputAttachmentArrayNonUniformIndexingEXT",
"InputAttachmentArrayNonUniformIndexing",
"SPV_EXT_descriptor_indexing"),
IN15("UniformTexelBufferArrayNonUniformIndexingEXT",
"UniformTexelBufferArrayNonUniformIndexing",
"SPV_EXT_descriptor_indexing"),
IN15("StorageTexelBufferArrayNonUniformIndexingEXT",
"StorageTexelBufferArrayNonUniformIndexing",
"SPV_EXT_descriptor_indexing"),
// SPV_EXT_physical_storage_buffer
spirv-val: Label and add test for PSB Aligned (#4756)
2022-03-23 15:08:21 +00:00
IN15("PhysicalStorageBufferAddresses", "PhysicalStorageBufferAddresses",
"SPV_EXT_physical_storage_buffer"),
SPIRV-Tools support for SPIR-V 1.5 (#2865) * Ensure same enum values have consistent extension lists * val: fix checking of capabilities The operand for an OpCapability should only be checked for the extension or core version. The InstructionPass registers a capability, and all its implied sub-capabilities before actually checking the operand to an OpCapability. * Add basic support for SPIR-V 1.5 - Adds SPV_ENV_UNIVERSAL_1_5 - Command line tools default to spv1.5 environment - SPIR-V 1.5 incorporates several extensions. Now the disassembler prefers outputing the non-EXT or non-KHR names. This requires updates to many tests, to make strings match again. - Command line tests: Expect SPIR-V 1.5 by default * Test validation of SPIR-V 1.5 incorporated extensions Starting with 1.5, incorporated features no longer require the associated OpExtension instruction.
2019-09-13 18:59:02 +00:00
// SPV_KHR_vulkan_memory_model
IN15("VulkanMemoryModelKHR", "VulkanMemoryModel",
"SPV_KHR_vulkan_memory_model"),
IN15("VulkanMemoryModelDeviceScopeKHR", "VulkanMemoryModelDeviceScope",
"SPV_KHR_vulkan_memory_model"),
};
#undef IN15
}
INSTANTIATE_TEST_SUITE_P(NewInSpirv1_5, ValidateCapabilityExtensionVersionTest,
ValuesIn(CapVersionCases1_5()));
TEST_P(ValidateCapability,
CapShaderViewportIndexLayerFailsInOlderSpirvVersion) {
const auto spirv =
MinimalShaderModuleWithCapability("ShaderViewportIndexLayerEXT");
CompileSuccessfully(spirv, SPV_ENV_UNIVERSAL_1_4);
EXPECT_EQ(SPV_ERROR_MISSING_EXTENSION,
ValidateInstructions(SPV_ENV_UNIVERSAL_1_4));
EXPECT_THAT(
getDiagnosticString(),
HasSubstr(
"1st operand of Capability: operand ShaderViewportIndexLayerEXT"));
EXPECT_THAT(getDiagnosticString(),
HasSubstr("requires one of these extensions: "
"SPV_EXT_shader_viewport_index_layer"));
}
TEST_P(ValidateCapability, CapShaderViewportIndexLayerFailsInNewSpirvVersion) {
const auto spirv =
MinimalShaderModuleWithCapability("ShaderViewportIndexLayerEXT");
CompileSuccessfully(spirv, SPV_ENV_UNIVERSAL_1_5);
EXPECT_EQ(SPV_ERROR_MISSING_EXTENSION,
ValidateInstructions(SPV_ENV_UNIVERSAL_1_5));
EXPECT_THAT(
getDiagnosticString(),
HasSubstr(
"1st operand of Capability: operand ShaderViewportIndexLayerEXT"));
EXPECT_THAT(getDiagnosticString(),
HasSubstr("requires one of these extensions: "
"SPV_EXT_shader_viewport_index_layer"));
}
TEST_F(ValidateCapability, CapShaderViewportIndexSucceedsInNewSpirvVersion) {
const auto spirv = MinimalShaderModuleWithCapability("ShaderViewportIndex");
CompileSuccessfully(spirv, SPV_ENV_UNIVERSAL_1_5);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_UNIVERSAL_1_5));
EXPECT_THAT(getDiagnosticString(), Eq(""));
}
TEST_F(ValidateCapability, CapShaderLayerSucceedsInNewSpirvVersion) {
const auto spirv = MinimalShaderModuleWithCapability("ShaderLayer");
CompileSuccessfully(spirv, SPV_ENV_UNIVERSAL_1_5);
EXPECT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_UNIVERSAL_1_5));
EXPECT_THAT(getDiagnosticString(), Eq(""));
}
Re-format source tree - NFC. Re-formatted the source tree with the command: $ /usr/bin/clang-format -style=file -i \ $(find include source tools test utils -name '*.cpp' -or -name '*.h') This required a fix to source/val/decoration.h. It was not including spirv.h, which broke builds when the #include headers were re-ordered by clang-format.
2017-11-27 15:16:41 +00:00
} // namespace
Move tests into namespaces (#1689) This CL moves the test into namespaces based on their directories.
2018-07-11 13:24:49 +00:00
} // namespace val
} // namespace spvtools
Reference in New Issue Copy Permalink