2015-05-22 17:26:19 +00:00
|
|
|
// Copyright (c) 2015 The Khronos Group Inc.
|
|
|
|
//
|
|
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
|
|
// copy of this software and/or associated documentation files (the
|
|
|
|
// "Materials"), to deal in the Materials without restriction, including
|
|
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
|
|
// distribute, sublicense, and/or sell copies of the Materials, and to
|
|
|
|
// permit persons to whom the Materials are furnished to do so, subject to
|
|
|
|
// the following conditions:
|
|
|
|
//
|
|
|
|
// The above copyright notice and this permission notice shall be included
|
|
|
|
// in all copies or substantial portions of the Materials.
|
|
|
|
//
|
|
|
|
// MODIFICATIONS TO THIS FILE MAY MEAN IT NO LONGER ACCURATELY REFLECTS
|
|
|
|
// KHRONOS STANDARDS. THE UNMODIFIED, NORMATIVE VERSIONS OF KHRONOS
|
|
|
|
// SPECIFICATIONS AND HEADER INFORMATION ARE LOCATED AT
|
|
|
|
// https://www.khronos.org/registry/
|
|
|
|
//
|
|
|
|
// THE MATERIALS ARE PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
|
|
// EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
|
|
|
|
// IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
|
|
|
|
// CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
|
|
|
|
// TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
|
|
|
|
// MATERIALS OR THE USE OR OTHER DEALINGS IN THE MATERIALS.
|
|
|
|
|
|
|
|
#include "UnitSPIRV.h"
|
|
|
|
|
|
|
|
// NOTE: The tests in this file are ONLY testing ID usage, there for the input
|
|
|
|
// SPIR-V does not follow the logical layout rules from the spec in all cases in
|
|
|
|
// order to makes the tests smaller. Validation of the whole module is handled
|
|
|
|
// in stages, ID validation is only one of these stages. All validation stages
|
|
|
|
// are stand alone.
|
|
|
|
|
2015-08-31 19:24:32 +00:00
|
|
|
namespace {
|
|
|
|
|
2015-05-22 17:26:19 +00:00
|
|
|
class ValidateID : public ::testing::Test {
|
|
|
|
public:
|
|
|
|
ValidateID() : opcodeTable(nullptr), operandTable(nullptr), binary() {}
|
|
|
|
|
|
|
|
virtual void SetUp() {
|
|
|
|
ASSERT_EQ(SPV_SUCCESS, spvOpcodeTableGet(&opcodeTable));
|
|
|
|
ASSERT_EQ(SPV_SUCCESS, spvOperandTableGet(&operandTable));
|
|
|
|
ASSERT_EQ(SPV_SUCCESS, spvExtInstTableGet(&extInstTable));
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual void TearDown() { spvBinaryDestroy(binary); }
|
|
|
|
|
|
|
|
spv_opcode_table opcodeTable;
|
|
|
|
spv_operand_table operandTable;
|
|
|
|
spv_ext_inst_table extInstTable;
|
|
|
|
spv_binary binary;
|
|
|
|
};
|
|
|
|
|
2015-09-10 21:07:21 +00:00
|
|
|
#define CHECK(str, expected) \
|
|
|
|
spv_diagnostic diagnostic; \
|
|
|
|
spv_result_t error = \
|
|
|
|
spvTextToBinary(str, strlen(str), opcodeTable, operandTable, \
|
|
|
|
extInstTable, &binary, &diagnostic); \
|
|
|
|
if (error) { \
|
|
|
|
spvDiagnosticPrint(diagnostic); \
|
|
|
|
spvDiagnosticDestroy(diagnostic); \
|
|
|
|
ASSERT_EQ(SPV_SUCCESS, error); \
|
|
|
|
} \
|
|
|
|
spv_result_t result = \
|
|
|
|
spvValidate(binary, opcodeTable, operandTable, extInstTable, \
|
|
|
|
SPV_VALIDATE_ID_BIT, &diagnostic); \
|
|
|
|
if (SPV_SUCCESS != result) { \
|
|
|
|
spvDiagnosticPrint(diagnostic); \
|
|
|
|
spvDiagnosticDestroy(diagnostic); \
|
|
|
|
} \
|
2015-05-22 17:26:19 +00:00
|
|
|
ASSERT_EQ(expected, result);
|
|
|
|
|
|
|
|
// TODO: OpUndef
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpName) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
OpName %2 "name"
|
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpTypePointer UniformConstant %1
|
|
|
|
%3 = OpVariable %2 UniformConstant)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpMemberNameGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
OpMemberName %2 0 "foo"
|
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpTypeStruct %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpMemberNameTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
OpMemberName %1 0 "foo"
|
|
|
|
%1 = OpTypeInt 32 0)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpMemberNameMemberBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
OpMemberName %2 1 "foo"
|
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpTypeStruct %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpLineGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpString "/path/to/source.file"
|
2015-09-24 19:45:59 +00:00
|
|
|
OpLine %1 0 0
|
2015-08-21 15:52:29 +00:00
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypePointer Generic %2
|
|
|
|
%4 = OpVariable %3 Generic)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpLineFileBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-09-24 19:45:59 +00:00
|
|
|
OpLine %2 0 0
|
2015-08-21 15:52:29 +00:00
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypePointer Generic %2
|
|
|
|
%4 = OpVariable %3 Generic)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpDecorateGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
OpDecorate %2 GLSLShared
|
|
|
|
%1 = OpTypeInt 64 0
|
|
|
|
%2 = OpTypeStruct %1 %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpDecorateBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
OpDecorate %1 GLSLShared)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpMemberDecorateGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
OpMemberDecorate %2 0 Uniform
|
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpTypeStruct %1 %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpMemberDecorateBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
OpMemberDecorate %1 0 Uniform
|
|
|
|
%1 = OpTypeInt 32 0)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpMemberDecorateMemberBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
OpMemberDecorate %2 3 Uniform
|
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpTypeStruct %1 %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpGroupDecorateGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpDecorationGroup
|
|
|
|
OpDecorate %1 Uniform
|
|
|
|
OpDecorate %1 GLSLShared
|
|
|
|
OpGroupDecorate %1 %3 %4
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpConstant %2 42
|
|
|
|
%4 = OpConstant %2 23)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpGroupDecorateDecorationGroupBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
OpGroupDecorate %2 %3 %4
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpConstant %2 42
|
|
|
|
%4 = OpConstant %2 23)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpGroupDecorateTargetBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpDecorationGroup
|
|
|
|
OpDecorate %1 Uniform
|
|
|
|
OpDecorate %1 GLSLShared
|
|
|
|
OpGroupDecorate %1 %3
|
|
|
|
%2 = OpTypeInt 32 0)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
// TODO: OpGroupMemberDecorate
|
|
|
|
// TODO: OpExtInst
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpEntryPointGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
Use opcode operand definitions from SPIR-V specification generator.
The assembler and disassembler now use a dynamically adjusted
sequence of expected operand types. (Internally, it is a deque,
for readability.) Both parsers repeatedly pull an expected operand
type from the left of this pattern list, and try to match the next
input token against it.
The expected pattern is adjusted during the parse to accommodate:
- an extended instruction's expected operands, depending on the
extended instruction's index.
- when an operand itself has operands
- to handle sequences of zero or more operands, or pairs of
operands. These are expanded lazily during the parse.
Adds spv::OperandClass from the SPIR-V specification generator.
Modifies spv_operand_desc_t:
- adds hasResult, hasType, and operandClass array to the opcode
description type.
- "wordCount" is replaced with "numTypes", which counts the number
of entries in operandTypes. And each of those describes a
*logical* operand, including the type id for the instruction,
and the result id for the instruction. A logical operand could be
variable-width, such as a literal string.
Adds opcode.inc, an automatically-generated table of operation
descriptions, with one line to describe each core instruction.
Externally, we have modified the SPIR-V spec doc generator to
emit this file.
(We have hacked this copy to use the old semantics for OpLine.)
Inside the assembler, parsing an operand may fail with new
error code SPV_FAIL_MATCH. For an optional operand, this is not
fatal, but should trigger backtracking at a higher level.
The spvTextIsStartOfNewInst checks the case of the third letter
of what might be an opcode. So now, "OpenCL" does not look like
an opcode name.
In assembly, the EntryPoint name field is mandatory, but can be
an empty string.
Adjust tests for changes to:
- OpSampedImage
- OpTypeSampler
2015-08-27 17:03:52 +00:00
|
|
|
OpEntryPoint GLCompute %3 ""
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeFunction %1
|
|
|
|
%3 = OpFunction %1 None %2
|
|
|
|
%4 = OpLabel
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd
|
2015-05-22 17:26:19 +00:00
|
|
|
)";
|
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpEntryPointFunctionBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
Use opcode operand definitions from SPIR-V specification generator.
The assembler and disassembler now use a dynamically adjusted
sequence of expected operand types. (Internally, it is a deque,
for readability.) Both parsers repeatedly pull an expected operand
type from the left of this pattern list, and try to match the next
input token against it.
The expected pattern is adjusted during the parse to accommodate:
- an extended instruction's expected operands, depending on the
extended instruction's index.
- when an operand itself has operands
- to handle sequences of zero or more operands, or pairs of
operands. These are expanded lazily during the parse.
Adds spv::OperandClass from the SPIR-V specification generator.
Modifies spv_operand_desc_t:
- adds hasResult, hasType, and operandClass array to the opcode
description type.
- "wordCount" is replaced with "numTypes", which counts the number
of entries in operandTypes. And each of those describes a
*logical* operand, including the type id for the instruction,
and the result id for the instruction. A logical operand could be
variable-width, such as a literal string.
Adds opcode.inc, an automatically-generated table of operation
descriptions, with one line to describe each core instruction.
Externally, we have modified the SPIR-V spec doc generator to
emit this file.
(We have hacked this copy to use the old semantics for OpLine.)
Inside the assembler, parsing an operand may fail with new
error code SPV_FAIL_MATCH. For an optional operand, this is not
fatal, but should trigger backtracking at a higher level.
The spvTextIsStartOfNewInst checks the case of the third letter
of what might be an opcode. So now, "OpenCL" does not look like
an opcode name.
In assembly, the EntryPoint name field is mandatory, but can be
an empty string.
Adjust tests for changes to:
- OpSampedImage
- OpTypeSampler
2015-08-27 17:03:52 +00:00
|
|
|
OpEntryPoint GLCompute %1 ""
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpEntryPointParameterCountBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
Use opcode operand definitions from SPIR-V specification generator.
The assembler and disassembler now use a dynamically adjusted
sequence of expected operand types. (Internally, it is a deque,
for readability.) Both parsers repeatedly pull an expected operand
type from the left of this pattern list, and try to match the next
input token against it.
The expected pattern is adjusted during the parse to accommodate:
- an extended instruction's expected operands, depending on the
extended instruction's index.
- when an operand itself has operands
- to handle sequences of zero or more operands, or pairs of
operands. These are expanded lazily during the parse.
Adds spv::OperandClass from the SPIR-V specification generator.
Modifies spv_operand_desc_t:
- adds hasResult, hasType, and operandClass array to the opcode
description type.
- "wordCount" is replaced with "numTypes", which counts the number
of entries in operandTypes. And each of those describes a
*logical* operand, including the type id for the instruction,
and the result id for the instruction. A logical operand could be
variable-width, such as a literal string.
Adds opcode.inc, an automatically-generated table of operation
descriptions, with one line to describe each core instruction.
Externally, we have modified the SPIR-V spec doc generator to
emit this file.
(We have hacked this copy to use the old semantics for OpLine.)
Inside the assembler, parsing an operand may fail with new
error code SPV_FAIL_MATCH. For an optional operand, this is not
fatal, but should trigger backtracking at a higher level.
The spvTextIsStartOfNewInst checks the case of the third letter
of what might be an opcode. So now, "OpenCL" does not look like
an opcode name.
In assembly, the EntryPoint name field is mandatory, but can be
an empty string.
Adjust tests for changes to:
- OpSampedImage
- OpTypeSampler
2015-08-27 17:03:52 +00:00
|
|
|
OpEntryPoint GLCompute %3 ""
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeFunction %1 %1
|
|
|
|
%3 = OpFunction %1 None %2
|
|
|
|
%4 = OpLabel
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpEntryPointReturnTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
Use opcode operand definitions from SPIR-V specification generator.
The assembler and disassembler now use a dynamically adjusted
sequence of expected operand types. (Internally, it is a deque,
for readability.) Both parsers repeatedly pull an expected operand
type from the left of this pattern list, and try to match the next
input token against it.
The expected pattern is adjusted during the parse to accommodate:
- an extended instruction's expected operands, depending on the
extended instruction's index.
- when an operand itself has operands
- to handle sequences of zero or more operands, or pairs of
operands. These are expanded lazily during the parse.
Adds spv::OperandClass from the SPIR-V specification generator.
Modifies spv_operand_desc_t:
- adds hasResult, hasType, and operandClass array to the opcode
description type.
- "wordCount" is replaced with "numTypes", which counts the number
of entries in operandTypes. And each of those describes a
*logical* operand, including the type id for the instruction,
and the result id for the instruction. A logical operand could be
variable-width, such as a literal string.
Adds opcode.inc, an automatically-generated table of operation
descriptions, with one line to describe each core instruction.
Externally, we have modified the SPIR-V spec doc generator to
emit this file.
(We have hacked this copy to use the old semantics for OpLine.)
Inside the assembler, parsing an operand may fail with new
error code SPV_FAIL_MATCH. For an optional operand, this is not
fatal, but should trigger backtracking at a higher level.
The spvTextIsStartOfNewInst checks the case of the third letter
of what might be an opcode. So now, "OpenCL" does not look like
an opcode name.
In assembly, the EntryPoint name field is mandatory, but can be
an empty string.
Adjust tests for changes to:
- OpSampedImage
- OpTypeSampler
2015-08-27 17:03:52 +00:00
|
|
|
OpEntryPoint GLCompute %3 ""
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpTypeFunction %1
|
|
|
|
%3 = OpFunction %1 None %2
|
|
|
|
%4 = OpLabel
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpExecutionModeGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
Use opcode operand definitions from SPIR-V specification generator.
The assembler and disassembler now use a dynamically adjusted
sequence of expected operand types. (Internally, it is a deque,
for readability.) Both parsers repeatedly pull an expected operand
type from the left of this pattern list, and try to match the next
input token against it.
The expected pattern is adjusted during the parse to accommodate:
- an extended instruction's expected operands, depending on the
extended instruction's index.
- when an operand itself has operands
- to handle sequences of zero or more operands, or pairs of
operands. These are expanded lazily during the parse.
Adds spv::OperandClass from the SPIR-V specification generator.
Modifies spv_operand_desc_t:
- adds hasResult, hasType, and operandClass array to the opcode
description type.
- "wordCount" is replaced with "numTypes", which counts the number
of entries in operandTypes. And each of those describes a
*logical* operand, including the type id for the instruction,
and the result id for the instruction. A logical operand could be
variable-width, such as a literal string.
Adds opcode.inc, an automatically-generated table of operation
descriptions, with one line to describe each core instruction.
Externally, we have modified the SPIR-V spec doc generator to
emit this file.
(We have hacked this copy to use the old semantics for OpLine.)
Inside the assembler, parsing an operand may fail with new
error code SPV_FAIL_MATCH. For an optional operand, this is not
fatal, but should trigger backtracking at a higher level.
The spvTextIsStartOfNewInst checks the case of the third letter
of what might be an opcode. So now, "OpenCL" does not look like
an opcode name.
In assembly, the EntryPoint name field is mandatory, but can be
an empty string.
Adjust tests for changes to:
- OpSampedImage
- OpTypeSampler
2015-08-27 17:03:52 +00:00
|
|
|
OpEntryPoint GLCompute %3 ""
|
2015-08-21 15:52:29 +00:00
|
|
|
OpExecutionMode %3 LocalSize 1 1 1
|
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeFunction %1
|
|
|
|
%3 = OpFunction %1 None %2
|
|
|
|
%4 = OpLabel
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpExecutionModeEntryPointBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
OpExecutionMode %3 LocalSize 1 1 1
|
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeFunction %1
|
|
|
|
%3 = OpFunction %1 None %2
|
|
|
|
%4 = OpLabel
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpTypeVectorGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeFloat 32
|
|
|
|
%2 = OpTypeVector %1 4)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpTypeVectorComponentTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeFloat 32
|
|
|
|
%2 = OpTypePointer UniformConstant %1
|
|
|
|
%3 = OpTypeVector %2 4)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpTypeMatrixGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpTypeVector %1 2
|
|
|
|
%3 = OpTypeMatrix %2 3)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpTypeMatrixColumnTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpTypeMatrix %1 3)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpTypeSamplerGood) {
|
Use opcode operand definitions from SPIR-V specification generator.
The assembler and disassembler now use a dynamically adjusted
sequence of expected operand types. (Internally, it is a deque,
for readability.) Both parsers repeatedly pull an expected operand
type from the left of this pattern list, and try to match the next
input token against it.
The expected pattern is adjusted during the parse to accommodate:
- an extended instruction's expected operands, depending on the
extended instruction's index.
- when an operand itself has operands
- to handle sequences of zero or more operands, or pairs of
operands. These are expanded lazily during the parse.
Adds spv::OperandClass from the SPIR-V specification generator.
Modifies spv_operand_desc_t:
- adds hasResult, hasType, and operandClass array to the opcode
description type.
- "wordCount" is replaced with "numTypes", which counts the number
of entries in operandTypes. And each of those describes a
*logical* operand, including the type id for the instruction,
and the result id for the instruction. A logical operand could be
variable-width, such as a literal string.
Adds opcode.inc, an automatically-generated table of operation
descriptions, with one line to describe each core instruction.
Externally, we have modified the SPIR-V spec doc generator to
emit this file.
(We have hacked this copy to use the old semantics for OpLine.)
Inside the assembler, parsing an operand may fail with new
error code SPV_FAIL_MATCH. For an optional operand, this is not
fatal, but should trigger backtracking at a higher level.
The spvTextIsStartOfNewInst checks the case of the third letter
of what might be an opcode. So now, "OpenCL" does not look like
an opcode name.
In assembly, the EntryPoint name field is mandatory, but can be
an empty string.
Adjust tests for changes to:
- OpSampedImage
- OpTypeSampler
2015-08-27 17:03:52 +00:00
|
|
|
// In Rev31, OpTypeSampler takes no arguments.
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
Use opcode operand definitions from SPIR-V specification generator.
The assembler and disassembler now use a dynamically adjusted
sequence of expected operand types. (Internally, it is a deque,
for readability.) Both parsers repeatedly pull an expected operand
type from the left of this pattern list, and try to match the next
input token against it.
The expected pattern is adjusted during the parse to accommodate:
- an extended instruction's expected operands, depending on the
extended instruction's index.
- when an operand itself has operands
- to handle sequences of zero or more operands, or pairs of
operands. These are expanded lazily during the parse.
Adds spv::OperandClass from the SPIR-V specification generator.
Modifies spv_operand_desc_t:
- adds hasResult, hasType, and operandClass array to the opcode
description type.
- "wordCount" is replaced with "numTypes", which counts the number
of entries in operandTypes. And each of those describes a
*logical* operand, including the type id for the instruction,
and the result id for the instruction. A logical operand could be
variable-width, such as a literal string.
Adds opcode.inc, an automatically-generated table of operation
descriptions, with one line to describe each core instruction.
Externally, we have modified the SPIR-V spec doc generator to
emit this file.
(We have hacked this copy to use the old semantics for OpLine.)
Inside the assembler, parsing an operand may fail with new
error code SPV_FAIL_MATCH. For an optional operand, this is not
fatal, but should trigger backtracking at a higher level.
The spvTextIsStartOfNewInst checks the case of the third letter
of what might be an opcode. So now, "OpenCL" does not look like
an opcode name.
In assembly, the EntryPoint name field is mandatory, but can be
an empty string.
Adjust tests for changes to:
- OpSampedImage
- OpTypeSampler
2015-08-27 17:03:52 +00:00
|
|
|
%s = OpTypeSampler)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpTypeArrayGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpConstant %1 1
|
|
|
|
%3 = OpTypeArray %1 %2)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpTypeArrayElementTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpConstant %1 1
|
|
|
|
%3 = OpTypeArray %2 %2)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpTypeArrayLengthBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpConstant %1 0
|
|
|
|
%3 = OpTypeArray %1 %2)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpTypeRuntimeArrayGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpTypeRuntimeArray %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpTypeRuntimeArrayBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpConstant %1 0
|
|
|
|
%3 = OpTypeRuntimeArray %2)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
// TODO: Object of this type can only be created with OpVariable using the
|
|
|
|
// Unifrom Storage Class
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpTypeStructGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpTypeFloat 64
|
|
|
|
%3 = OpTypePointer Generic %1
|
|
|
|
%4 = OpTypeStruct %1 %2 %3)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpTypeStructMemberTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpTypeFloat 64
|
|
|
|
%3 = OpConstant %2 0.0
|
|
|
|
%4 = OpTypeStruct %1 %2 %3)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpTypePointerGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpTypePointer Generic %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpTypePointerBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpConstant %1 0
|
|
|
|
%3 = OpTypePointer Generic %2)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpTypeFunctionGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeFunction %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpTypeFunctionReturnTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpConstant %1 0
|
|
|
|
%3 = OpTypeFunction %2)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpTypeFunctionParameterBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpConstant %2 0
|
|
|
|
%4 = OpTypeFunction %1 %2 %3)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpTypePipeGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeFloat 32
|
|
|
|
%2 = OpTypeVector %1 16
|
2015-09-24 19:45:59 +00:00
|
|
|
%3 = OpTypePipe ReadOnly)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpConstantTrueGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeBool
|
|
|
|
%2 = OpConstantTrue %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantTrueBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpConstantTrue %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpConstantFalseGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-09-10 18:00:00 +00:00
|
|
|
%1 = OpTypeBool
|
2015-08-21 15:52:29 +00:00
|
|
|
%2 = OpConstantTrue %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantFalseBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpConstantFalse %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpConstantGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpConstant %1 1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
2015-09-29 15:28:34 +00:00
|
|
|
%2 = OpConstant !1 !0)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpConstantCompositeVectorGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeFloat 32
|
|
|
|
%2 = OpTypeVector %1 4
|
|
|
|
%3 = OpConstant %1 3.14
|
|
|
|
%4 = OpConstantComposite %2 %3 %3 %3 %3)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantCompositeVectorResultTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeFloat 32
|
|
|
|
%2 = OpTypeVector %1 4
|
|
|
|
%3 = OpConstant %1 3.14
|
|
|
|
%4 = OpConstantComposite %1 %3 %3 %3 %3)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantCompositeVectorConstituentBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeFloat 32
|
|
|
|
%2 = OpTypeVector %1 4
|
|
|
|
%4 = OpTypeInt 32 0
|
|
|
|
%3 = OpConstant %1 3.14
|
|
|
|
%5 = OpConstant %4 42
|
|
|
|
%6 = OpConstantComposite %2 %3 %5 %3 %3)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantCompositeMatrixGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeFloat 32
|
|
|
|
%2 = OpTypeVector %1 4
|
|
|
|
%3 = OpTypeMatrix %2 4
|
|
|
|
%4 = OpConstant %1 1.0
|
2015-08-24 20:27:02 +00:00
|
|
|
%5 = OpConstant %1 0.0
|
2015-08-21 15:52:29 +00:00
|
|
|
%6 = OpConstantComposite %2 %4 %5 %5 %5
|
|
|
|
%7 = OpConstantComposite %2 %5 %4 %5 %5
|
|
|
|
%8 = OpConstantComposite %2 %5 %5 %4 %5
|
|
|
|
%9 = OpConstantComposite %2 %5 %5 %5 %4
|
|
|
|
%10 = OpConstantComposite %3 %6 %7 %8 %9)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantCompositeMatrixConstituentBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeFloat 32
|
|
|
|
%2 = OpTypeVector %1 4
|
|
|
|
%11 = OpTypeVector %1 3
|
|
|
|
%3 = OpTypeMatrix %2 4
|
|
|
|
%4 = OpConstant %1 1.0
|
|
|
|
%5 = OpConstant %1 0.0
|
|
|
|
%6 = OpConstantComposite %2 %4 %5 %5 %5
|
|
|
|
%7 = OpConstantComposite %2 %5 %4 %5 %5
|
|
|
|
%8 = OpConstantComposite %2 %5 %5 %4 %5
|
|
|
|
%9 = OpConstantComposite %11 %5 %5 %5
|
|
|
|
%10 = OpConstantComposite %3 %6 %7 %8 %9)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantCompositeMatrixColumnTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpTypeFloat 32
|
|
|
|
%3 = OpTypeVector %1 2
|
|
|
|
%4 = OpTypeVector %3 2
|
|
|
|
%5 = OpTypeMatrix %2 2
|
|
|
|
%6 = OpConstant %1 42
|
|
|
|
%7 = OpConstant %2 3.14
|
|
|
|
%8 = OpConstantComposite %3 %6 %6
|
|
|
|
%9 = OpConstantComposite %4 %7 %7
|
|
|
|
%10 = OpConstantComposite %5 %8 %9)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantCompositeArrayGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpConstant %1 4
|
|
|
|
%3 = OpTypeArray %1 %2
|
|
|
|
%4 = OpConstantComposite %3 %2 %2 %2 %2)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantCompositeArrayConstConstituentBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpConstant %1 4
|
|
|
|
%3 = OpTypeArray %1 %2
|
|
|
|
%4 = OpConstantComposite %3 %2 %2 %2 %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantCompositeArrayConstituentBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpConstant %1 4
|
|
|
|
%3 = OpTypeArray %1 %2
|
|
|
|
%5 = OpTypeFloat 32
|
|
|
|
%6 = OpConstant %5 3.14
|
|
|
|
%4 = OpConstantComposite %3 %2 %2 %2 %6)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantCompositeStructGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpTypeInt 64 1
|
|
|
|
%3 = OpTypeStruct %1 %1 %2
|
|
|
|
%4 = OpConstant %1 42
|
|
|
|
%5 = OpConstant %2 4300000000
|
|
|
|
%6 = OpConstantComposite %3 %4 %4 %5)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantCompositeStructMemberBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 0
|
|
|
|
%2 = OpTypeInt 64 1
|
|
|
|
%3 = OpTypeStruct %1 %1 %2
|
|
|
|
%4 = OpConstant %1 42
|
|
|
|
%5 = OpConstant %2 4300000000
|
|
|
|
%6 = OpConstantComposite %3 %4 %5 %4)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpConstantSamplerGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
Use opcode operand definitions from SPIR-V specification generator.
The assembler and disassembler now use a dynamically adjusted
sequence of expected operand types. (Internally, it is a deque,
for readability.) Both parsers repeatedly pull an expected operand
type from the left of this pattern list, and try to match the next
input token against it.
The expected pattern is adjusted during the parse to accommodate:
- an extended instruction's expected operands, depending on the
extended instruction's index.
- when an operand itself has operands
- to handle sequences of zero or more operands, or pairs of
operands. These are expanded lazily during the parse.
Adds spv::OperandClass from the SPIR-V specification generator.
Modifies spv_operand_desc_t:
- adds hasResult, hasType, and operandClass array to the opcode
description type.
- "wordCount" is replaced with "numTypes", which counts the number
of entries in operandTypes. And each of those describes a
*logical* operand, including the type id for the instruction,
and the result id for the instruction. A logical operand could be
variable-width, such as a literal string.
Adds opcode.inc, an automatically-generated table of operation
descriptions, with one line to describe each core instruction.
Externally, we have modified the SPIR-V spec doc generator to
emit this file.
(We have hacked this copy to use the old semantics for OpLine.)
Inside the assembler, parsing an operand may fail with new
error code SPV_FAIL_MATCH. For an optional operand, this is not
fatal, but should trigger backtracking at a higher level.
The spvTextIsStartOfNewInst checks the case of the third letter
of what might be an opcode. So now, "OpenCL" does not look like
an opcode name.
In assembly, the EntryPoint name field is mandatory, but can be
an empty string.
Adjust tests for changes to:
- OpSampedImage
- OpTypeSampler
2015-08-27 17:03:52 +00:00
|
|
|
%float = OpTypeFloat 32
|
|
|
|
%samplerType = OpTypeSampler
|
|
|
|
%3 = OpConstantSampler %samplerType ClampToEdge 0 Nearest)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantSamplerResultTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeFloat 32
|
|
|
|
%2 = OpConstantSampler %1 Clamp 0 Nearest)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpConstantNullGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeBool
|
|
|
|
%2 = OpConstantNull %1
|
|
|
|
%3 = OpTypeInt 32 0
|
|
|
|
%4 = OpConstantNull %3
|
|
|
|
%5 = OpTypeFloat 32
|
|
|
|
%6 = OpConstantNull %5
|
|
|
|
%7 = OpTypePointer UniformConstant %3
|
|
|
|
%8 = OpConstantNull %7
|
|
|
|
%9 = OpTypeEvent
|
|
|
|
%10 = OpConstantNull %9
|
|
|
|
%11 = OpTypeDeviceEvent
|
|
|
|
%12 = OpConstantNull %11
|
|
|
|
%13 = OpTypeReserveId
|
|
|
|
%14 = OpConstantNull %13
|
|
|
|
%15 = OpTypeQueue
|
|
|
|
%16 = OpConstantNull %15
|
|
|
|
%17 = OpTypeVector %3 2
|
|
|
|
%18 = OpConstantNull %17
|
|
|
|
%19 = OpTypeMatrix %17 2
|
|
|
|
%20 = OpConstantNull %19
|
|
|
|
%25 = OpConstant %3 8
|
|
|
|
%21 = OpTypeArray %3 %25
|
|
|
|
%22 = OpConstantNull %21
|
|
|
|
%23 = OpTypeStruct %3 %5 %1
|
|
|
|
%24 = OpConstantNull %23
|
2015-05-22 17:26:19 +00:00
|
|
|
)";
|
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantNullBasicBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpConstantNull %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantNullArrayBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%2 = OpTypeInt 32 0
|
Use opcode operand definitions from SPIR-V specification generator.
The assembler and disassembler now use a dynamically adjusted
sequence of expected operand types. (Internally, it is a deque,
for readability.) Both parsers repeatedly pull an expected operand
type from the left of this pattern list, and try to match the next
input token against it.
The expected pattern is adjusted during the parse to accommodate:
- an extended instruction's expected operands, depending on the
extended instruction's index.
- when an operand itself has operands
- to handle sequences of zero or more operands, or pairs of
operands. These are expanded lazily during the parse.
Adds spv::OperandClass from the SPIR-V specification generator.
Modifies spv_operand_desc_t:
- adds hasResult, hasType, and operandClass array to the opcode
description type.
- "wordCount" is replaced with "numTypes", which counts the number
of entries in operandTypes. And each of those describes a
*logical* operand, including the type id for the instruction,
and the result id for the instruction. A logical operand could be
variable-width, such as a literal string.
Adds opcode.inc, an automatically-generated table of operation
descriptions, with one line to describe each core instruction.
Externally, we have modified the SPIR-V spec doc generator to
emit this file.
(We have hacked this copy to use the old semantics for OpLine.)
Inside the assembler, parsing an operand may fail with new
error code SPV_FAIL_MATCH. For an optional operand, this is not
fatal, but should trigger backtracking at a higher level.
The spvTextIsStartOfNewInst checks the case of the third letter
of what might be an opcode. So now, "OpenCL" does not look like
an opcode name.
In assembly, the EntryPoint name field is mandatory, but can be
an empty string.
Adjust tests for changes to:
- OpSampedImage
- OpTypeSampler
2015-08-27 17:03:52 +00:00
|
|
|
%3 = OpTypeSampler
|
2015-08-21 15:52:29 +00:00
|
|
|
%4 = OpConstant %2 4
|
|
|
|
%5 = OpTypeArray %3 %4
|
|
|
|
%6 = OpConstantNull %5)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpConstantNullStructBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
Use opcode operand definitions from SPIR-V specification generator.
The assembler and disassembler now use a dynamically adjusted
sequence of expected operand types. (Internally, it is a deque,
for readability.) Both parsers repeatedly pull an expected operand
type from the left of this pattern list, and try to match the next
input token against it.
The expected pattern is adjusted during the parse to accommodate:
- an extended instruction's expected operands, depending on the
extended instruction's index.
- when an operand itself has operands
- to handle sequences of zero or more operands, or pairs of
operands. These are expanded lazily during the parse.
Adds spv::OperandClass from the SPIR-V specification generator.
Modifies spv_operand_desc_t:
- adds hasResult, hasType, and operandClass array to the opcode
description type.
- "wordCount" is replaced with "numTypes", which counts the number
of entries in operandTypes. And each of those describes a
*logical* operand, including the type id for the instruction,
and the result id for the instruction. A logical operand could be
variable-width, such as a literal string.
Adds opcode.inc, an automatically-generated table of operation
descriptions, with one line to describe each core instruction.
Externally, we have modified the SPIR-V spec doc generator to
emit this file.
(We have hacked this copy to use the old semantics for OpLine.)
Inside the assembler, parsing an operand may fail with new
error code SPV_FAIL_MATCH. For an optional operand, this is not
fatal, but should trigger backtracking at a higher level.
The spvTextIsStartOfNewInst checks the case of the third letter
of what might be an opcode. So now, "OpenCL" does not look like
an opcode name.
In assembly, the EntryPoint name field is mandatory, but can be
an empty string.
Adjust tests for changes to:
- OpSampedImage
- OpTypeSampler
2015-08-27 17:03:52 +00:00
|
|
|
%2 = OpTypeSampler
|
2015-08-21 15:52:29 +00:00
|
|
|
%3 = OpTypeStruct %2 %2
|
|
|
|
%4 = OpConstantNull %3)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpSpecConstantTrueGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeBool
|
|
|
|
%2 = OpSpecConstantTrue %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpSpecConstantTrueBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpSpecConstantTrue %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpSpecConstantFalseGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeBool
|
|
|
|
%2 = OpSpecConstantFalse %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpSpecConstantFalseBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpSpecConstantFalse %1)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpSpecConstantGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeFloat 32
|
|
|
|
%2 = OpSpecConstant %1 42)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpSpecConstantBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
2015-09-29 15:28:34 +00:00
|
|
|
%2 = OpSpecConstant !1 !4)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
// TODO: OpSpecConstantComposite
|
|
|
|
// TODO: OpSpecConstantOp
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpVariableGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 1
|
|
|
|
%2 = OpTypePointer Generic %1
|
|
|
|
%3 = OpVariable %2 Generic)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpVariableInitializerGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 1
|
|
|
|
%2 = OpTypePointer Generic %1
|
|
|
|
%3 = OpConstant %1 42
|
|
|
|
%4 = OpVariable %2 Generic %3)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
// TODO: Positive test OpVariable with OpConstantNull of OpTypePointer
|
|
|
|
TEST_F(ValidateID, OpVariableResultTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 1
|
|
|
|
%2 = OpVariable %1 Generic)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpVariableInitializerBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeInt 32 1
|
|
|
|
%2 = OpTypePointer Generic %1
|
|
|
|
%3 = OpVariable %2 Generic %2)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpLoadGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 1
|
|
|
|
%3 = OpTypePointer UniformConstant %2
|
|
|
|
%4 = OpTypeFunction %1
|
|
|
|
%5 = OpVariable %3 UniformConstant
|
|
|
|
%6 = OpFunction %1 None %4
|
|
|
|
%7 = OpLabel
|
|
|
|
%8 = OpLoad %3 %5
|
|
|
|
%9 = OpReturn
|
|
|
|
%10 = OpFunctionEnd
|
2015-05-22 17:26:19 +00:00
|
|
|
)";
|
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpLoadResultTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 1
|
|
|
|
%3 = OpTypePointer UniformConstant %2
|
|
|
|
%4 = OpTypeFunction %1
|
|
|
|
%5 = OpVariable %3 UniformConstant
|
|
|
|
%6 = OpFunction %1 None %4
|
|
|
|
%7 = OpLabel
|
|
|
|
%8 = OpLoad %2 %5
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd
|
2015-05-22 17:26:19 +00:00
|
|
|
)";
|
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpLoadPointerBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 1
|
|
|
|
%9 = OpTypeFloat 32
|
|
|
|
%3 = OpTypePointer UniformConstant %2
|
|
|
|
%4 = OpTypeFunction %1
|
|
|
|
%6 = OpFunction %1 None %4
|
|
|
|
%7 = OpLabel
|
|
|
|
%8 = OpLoad %9 %3
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd
|
2015-05-22 17:26:19 +00:00
|
|
|
)";
|
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpStoreGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 1
|
|
|
|
%3 = OpTypePointer UniformConstant %2
|
|
|
|
%4 = OpTypeFunction %1
|
|
|
|
%5 = OpConstant %2 42
|
|
|
|
%6 = OpVariable %3 UniformConstant
|
|
|
|
%7 = OpFunction %1 None %4
|
|
|
|
%8 = OpLabel
|
|
|
|
OpStore %6 %5
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpStorePointerBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 1
|
|
|
|
%3 = OpTypePointer UniformConstant %2
|
|
|
|
%4 = OpTypeFunction %1
|
|
|
|
%5 = OpConstant %2 42
|
|
|
|
%6 = OpVariable %3 UniformConstant
|
|
|
|
%7 = OpFunction %1 None %4
|
|
|
|
%8 = OpLabel
|
|
|
|
OpStore %3 %5
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpStoreObjectGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 1
|
|
|
|
%3 = OpTypePointer UniformConstant %2
|
|
|
|
%4 = OpTypeFunction %1
|
|
|
|
%5 = OpConstant %2 42
|
|
|
|
%6 = OpVariable %3 UniformConstant
|
|
|
|
%7 = OpFunction %1 None %4
|
|
|
|
%8 = OpLabel
|
|
|
|
OpStore %6 %7
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpStoreTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 1
|
|
|
|
%9 = OpTypeFloat 32
|
|
|
|
%3 = OpTypePointer UniformConstant %2
|
|
|
|
%4 = OpTypeFunction %1
|
|
|
|
%5 = OpConstant %9 3.14
|
|
|
|
%6 = OpVariable %3 UniformConstant
|
|
|
|
%7 = OpFunction %1 None %4
|
|
|
|
%8 = OpLabel
|
|
|
|
OpStore %6 %5
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpCopyMemoryGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypePointer UniformConstant %2
|
|
|
|
%4 = OpConstant %2 42
|
|
|
|
%5 = OpVariable %3 UniformConstant %4
|
|
|
|
%6 = OpTypePointer Function %2
|
|
|
|
%7 = OpTypeFunction %1
|
|
|
|
%8 = OpFunction %1 None %7
|
|
|
|
%9 = OpLabel
|
|
|
|
%10 = OpVariable %6 Function
|
|
|
|
OpCopyMemory %10 %5 None
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd
|
2015-05-22 17:26:19 +00:00
|
|
|
)";
|
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpCopyMemoryBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypePointer UniformConstant %2
|
|
|
|
%4 = OpConstant %2 42
|
|
|
|
%5 = OpVariable %3 UniformConstant %4
|
|
|
|
%11 = OpTypeFloat 32
|
|
|
|
%6 = OpTypePointer Function %11
|
|
|
|
%7 = OpTypeFunction %1
|
|
|
|
%8 = OpFunction %1 None %7
|
|
|
|
%9 = OpLabel
|
|
|
|
%10 = OpVariable %6 Function
|
|
|
|
OpCopyMemory %10 %5 None
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd
|
2015-05-22 17:26:19 +00:00
|
|
|
)";
|
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
// TODO: OpCopyMemorySized
|
|
|
|
TEST_F(ValidateID, OpCopyMemorySizedGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypePointer UniformConstant %2
|
|
|
|
%4 = OpTypePointer Function %2
|
|
|
|
%5 = OpConstant %2 4
|
|
|
|
%6 = OpVariable %3 UniformConstant %5
|
|
|
|
%7 = OpTypeFunction %1
|
|
|
|
%8 = OpFunction %1 None %7
|
|
|
|
%9 = OpLabel
|
|
|
|
%10 = OpVariable %4 Function
|
|
|
|
OpCopyMemorySized %10 %6 %5 None
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpCopyMemorySizedTargetBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypePointer UniformConstant %2
|
|
|
|
%4 = OpTypePointer Function %2
|
|
|
|
%5 = OpConstant %2 4
|
|
|
|
%6 = OpVariable %3 UniformConstant %5
|
|
|
|
%7 = OpTypeFunction %1
|
|
|
|
%8 = OpFunction %1 None %7
|
|
|
|
%9 = OpLabel
|
|
|
|
OpCopyMemorySized %9 %6 %5 None
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpCopyMemorySizedSourceBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypePointer UniformConstant %2
|
|
|
|
%4 = OpTypePointer Function %2
|
|
|
|
%5 = OpConstant %2 4
|
|
|
|
%6 = OpTypeFunction %1
|
|
|
|
%7 = OpFunction %1 None %6
|
|
|
|
%8 = OpLabel
|
|
|
|
%9 = OpVariable %4 Function
|
|
|
|
OpCopyMemorySized %9 %6 %5 None
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpCopyMemorySizedSizeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypePointer UniformConstant %2
|
|
|
|
%4 = OpTypePointer Function %2
|
|
|
|
%5 = OpConstant %2 4
|
|
|
|
%6 = OpVariable %3 UniformConstant %5
|
|
|
|
%7 = OpTypeFunction %1
|
|
|
|
%8 = OpFunction %1 None %7
|
|
|
|
%9 = OpLabel
|
|
|
|
%10 = OpVariable %4 Function
|
|
|
|
OpCopyMemorySized %10 %6 %6 None
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpCopyMemorySizedSizeTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypePointer UniformConstant %2
|
|
|
|
%4 = OpTypePointer Function %2
|
|
|
|
%5 = OpConstant %2 4
|
|
|
|
%6 = OpVariable %3 UniformConstant %5
|
|
|
|
%7 = OpTypeFunction %1
|
|
|
|
%11 = OpTypeFloat 32
|
|
|
|
%12 = OpConstant %11 1.0
|
|
|
|
%8 = OpFunction %1 None %7
|
|
|
|
%9 = OpLabel
|
|
|
|
%10 = OpVariable %4 Function
|
|
|
|
OpCopyMemorySized %10 %6 %12 None
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
// TODO: OpAccessChain
|
|
|
|
// TODO: OpInBoundsAccessChain
|
|
|
|
// TODO: OpArrayLength
|
|
|
|
// TODO: OpImagePointer
|
|
|
|
// TODO: OpGenericPtrMemSemantics
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpFunctionGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 1
|
|
|
|
%3 = OpTypeFunction %1 %2 %2
|
|
|
|
%4 = OpFunction %1 None %3
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpFunctionResultTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 1
|
|
|
|
%5 = OpConstant %2 42
|
|
|
|
%3 = OpTypeFunction %1 %2 %2
|
|
|
|
%4 = OpFunction %2 None %3
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpFunctionFunctionTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 1
|
|
|
|
%4 = OpFunction %1 None %2
|
2015-05-22 17:26:19 +00:00
|
|
|
OpFunctionEnd)";
|
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpFunctionParameterGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypeFunction %1 %2
|
|
|
|
%4 = OpFunction %1 None %3
|
|
|
|
%5 = OpFunctionParameter %2
|
|
|
|
%6 = OpLabel
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpFunctionParameterResultTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypeFunction %1 %2
|
|
|
|
%4 = OpFunction %1 None %3
|
|
|
|
%5 = OpFunctionParameter %1
|
|
|
|
%6 = OpLabel
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpFunctionParameterOrderBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypeFunction %1 %2
|
|
|
|
%7 = OpTypePointer Function %2
|
|
|
|
%4 = OpFunction %1 None %3
|
|
|
|
%8 = OpVariable %7 Function
|
|
|
|
%5 = OpFunctionParameter %2
|
|
|
|
%6 = OpLabel
|
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpFunctionCallGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypeFunction %2 %2
|
|
|
|
%4 = OpTypeFunction %1
|
|
|
|
%5 = OpConstant %2 42 ;21
|
2015-05-22 17:26:19 +00:00
|
|
|
|
2015-08-21 15:52:29 +00:00
|
|
|
%6 = OpFunction %2 None %3
|
|
|
|
%7 = OpFunctionParameter %2
|
|
|
|
%8 = OpLabel
|
|
|
|
%9 = OpLoad %2 %7
|
|
|
|
OpReturnValue %9
|
|
|
|
OpFunctionEnd
|
2015-05-22 17:26:19 +00:00
|
|
|
|
2015-08-21 15:52:29 +00:00
|
|
|
%10 = OpFunction %1 None %4
|
|
|
|
%11 = OpLabel
|
|
|
|
OpReturn
|
|
|
|
%12 = OpFunctionCall %2 %6 %5
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpFunctionCallResultTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypeFunction %2 %2
|
|
|
|
%4 = OpTypeFunction %1
|
|
|
|
%5 = OpConstant %2 42 ;21
|
2015-05-22 17:26:19 +00:00
|
|
|
|
2015-08-21 15:52:29 +00:00
|
|
|
%6 = OpFunction %2 None %3
|
|
|
|
%7 = OpFunctionParameter %2
|
|
|
|
%8 = OpLabel
|
|
|
|
%9 = OpLoad %2 %7
|
|
|
|
OpReturnValue %9
|
|
|
|
OpFunctionEnd
|
2015-05-22 17:26:19 +00:00
|
|
|
|
2015-08-21 15:52:29 +00:00
|
|
|
%10 = OpFunction %1 None %4
|
|
|
|
%11 = OpLabel
|
|
|
|
OpReturn
|
|
|
|
%12 = OpFunctionCall %1 %6 %5
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpFunctionCallFunctionBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypeFunction %2 %2
|
|
|
|
%4 = OpTypeFunction %1
|
|
|
|
%5 = OpConstant %2 42 ;21
|
2015-05-22 17:26:19 +00:00
|
|
|
|
2015-08-21 15:52:29 +00:00
|
|
|
%10 = OpFunction %1 None %4
|
|
|
|
%11 = OpLabel
|
|
|
|
OpReturn
|
|
|
|
%12 = OpFunctionCall %2 %5 %5
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpFunctionCallArgumentTypeBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypeFunction %2 %2
|
|
|
|
%4 = OpTypeFunction %1
|
|
|
|
%5 = OpConstant %2 42
|
2015-05-22 17:26:19 +00:00
|
|
|
|
2015-08-21 15:52:29 +00:00
|
|
|
%13 = OpTypeFloat 32
|
|
|
|
%14 = OpConstant %13 3.14
|
2015-05-22 17:26:19 +00:00
|
|
|
|
2015-08-21 15:52:29 +00:00
|
|
|
%6 = OpFunction %2 None %3
|
|
|
|
%7 = OpFunctionParameter %2
|
|
|
|
%8 = OpLabel
|
|
|
|
%9 = OpLoad %2 %7
|
|
|
|
OpReturnValue %9
|
|
|
|
OpFunctionEnd
|
2015-05-22 17:26:19 +00:00
|
|
|
|
2015-08-21 15:52:29 +00:00
|
|
|
%10 = OpFunction %1 None %4
|
|
|
|
%11 = OpLabel
|
|
|
|
OpReturn
|
|
|
|
%12 = OpFunctionCall %2 %6 %14
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
#if 0
|
|
|
|
TEST_F(ValidateID, OpFunctionCallArgumentCountBar) {
|
|
|
|
const char *spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypeFunction %2 %2
|
|
|
|
%4 = OpTypeFunction %1
|
|
|
|
%5 = OpConstant %2 42 ;21
|
2015-05-22 17:26:19 +00:00
|
|
|
|
2015-08-21 15:52:29 +00:00
|
|
|
%6 = OpFunction %2 None %3
|
|
|
|
%7 = OpFunctionParameter %2
|
|
|
|
%8 = OpLabel
|
|
|
|
%9 = OpLoad %2 %7
|
|
|
|
OpReturnValue %9
|
|
|
|
OpFunctionEnd
|
2015-05-22 17:26:19 +00:00
|
|
|
|
2015-08-21 15:52:29 +00:00
|
|
|
%10 = OpFunction %1 None %4
|
|
|
|
%11 = OpLabel
|
|
|
|
OpReturn
|
|
|
|
%12 = OpFunctionCall %2 %6 %5
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
Use opcode operand definitions from SPIR-V specification generator.
The assembler and disassembler now use a dynamically adjusted
sequence of expected operand types. (Internally, it is a deque,
for readability.) Both parsers repeatedly pull an expected operand
type from the left of this pattern list, and try to match the next
input token against it.
The expected pattern is adjusted during the parse to accommodate:
- an extended instruction's expected operands, depending on the
extended instruction's index.
- when an operand itself has operands
- to handle sequences of zero or more operands, or pairs of
operands. These are expanded lazily during the parse.
Adds spv::OperandClass from the SPIR-V specification generator.
Modifies spv_operand_desc_t:
- adds hasResult, hasType, and operandClass array to the opcode
description type.
- "wordCount" is replaced with "numTypes", which counts the number
of entries in operandTypes. And each of those describes a
*logical* operand, including the type id for the instruction,
and the result id for the instruction. A logical operand could be
variable-width, such as a literal string.
Adds opcode.inc, an automatically-generated table of operation
descriptions, with one line to describe each core instruction.
Externally, we have modified the SPIR-V spec doc generator to
emit this file.
(We have hacked this copy to use the old semantics for OpLine.)
Inside the assembler, parsing an operand may fail with new
error code SPV_FAIL_MATCH. For an optional operand, this is not
fatal, but should trigger backtracking at a higher level.
The spvTextIsStartOfNewInst checks the case of the third letter
of what might be an opcode. So now, "OpenCL" does not look like
an opcode name.
In assembly, the EntryPoint name field is mandatory, but can be
an empty string.
Adjust tests for changes to:
- OpSampedImage
- OpTypeSampler
2015-08-27 17:03:52 +00:00
|
|
|
// TODO: OpSampledImage
|
|
|
|
// TODO: The many things that changed with how images are used.
|
2015-05-22 17:26:19 +00:00
|
|
|
// TODO: OpTextureSample
|
|
|
|
// TODO: OpTextureSampleDref
|
|
|
|
// TODO: OpTextureSampleLod
|
|
|
|
// TODO: OpTextureSampleProj
|
|
|
|
// TODO: OpTextureSampleGrad
|
|
|
|
// TODO: OpTextureSampleOffset
|
|
|
|
// TODO: OpTextureSampleProjLod
|
|
|
|
// TODO: OpTextureSampleProjGrad
|
|
|
|
// TODO: OpTextureSampleLodOffset
|
|
|
|
// TODO: OpTextureSampleProjOffset
|
|
|
|
// TODO: OpTextureSampleGradOffset
|
|
|
|
// TODO: OpTextureSampleProjLodOffset
|
|
|
|
// TODO: OpTextureSampleProjGradOffset
|
|
|
|
// TODO: OpTextureFetchTexelLod
|
|
|
|
// TODO: OpTextureFetchTexelOffset
|
|
|
|
// TODO: OpTextureFetchSample
|
|
|
|
// TODO: OpTextureFetchTexel
|
|
|
|
// TODO: OpTextureGather
|
|
|
|
// TODO: OpTextureGatherOffset
|
|
|
|
// TODO: OpTextureGatherOffsets
|
|
|
|
// TODO: OpTextureQuerySizeLod
|
|
|
|
// TODO: OpTextureQuerySize
|
|
|
|
// TODO: OpTextureQueryLevels
|
|
|
|
// TODO: OpTextureQuerySamples
|
|
|
|
// TODO: OpConvertUToF
|
|
|
|
// TODO: OpConvertFToS
|
|
|
|
// TODO: OpConvertSToF
|
|
|
|
// TODO: OpConvertUToF
|
|
|
|
// TODO: OpUConvert
|
|
|
|
// TODO: OpSConvert
|
|
|
|
// TODO: OpFConvert
|
|
|
|
// TODO: OpConvertPtrToU
|
|
|
|
// TODO: OpConvertUToPtr
|
|
|
|
// TODO: OpPtrCastToGeneric
|
|
|
|
// TODO: OpGenericCastToPtr
|
|
|
|
// TODO: OpBitcast
|
|
|
|
// TODO: OpGenericCastToPtrExplicit
|
|
|
|
// TODO: OpSatConvertSToU
|
|
|
|
// TODO: OpSatConvertUToS
|
|
|
|
// TODO: OpVectorExtractDynamic
|
|
|
|
// TODO: OpVectorInsertDynamic
|
|
|
|
// TODO: OpVectorShuffle
|
|
|
|
// TODO: OpCompositeConstruct
|
|
|
|
// TODO: OpCompositeExtract
|
|
|
|
// TODO: OpCompositeInsert
|
|
|
|
// TODO: OpCopyObject
|
|
|
|
// TODO: OpTranspose
|
|
|
|
// TODO: OpSNegate
|
|
|
|
// TODO: OpFNegate
|
|
|
|
// TODO: OpNot
|
|
|
|
// TODO: OpIAdd
|
|
|
|
// TODO: OpFAdd
|
|
|
|
// TODO: OpISub
|
|
|
|
// TODO: OpFSub
|
|
|
|
// TODO: OpIMul
|
|
|
|
// TODO: OpFMul
|
|
|
|
// TODO: OpUDiv
|
|
|
|
// TODO: OpSDiv
|
|
|
|
// TODO: OpFDiv
|
|
|
|
// TODO: OpUMod
|
|
|
|
// TODO: OpSRem
|
|
|
|
// TODO: OpSMod
|
|
|
|
// TODO: OpFRem
|
|
|
|
// TODO: OpFMod
|
|
|
|
// TODO: OpVectorTimesScalar
|
|
|
|
// TODO: OpMatrixTimesScalar
|
|
|
|
// TODO: OpVectorTimesMatrix
|
|
|
|
// TODO: OpMatrixTimesVector
|
|
|
|
// TODO: OpMatrixTimesMatrix
|
|
|
|
// TODO: OpOuterProduct
|
|
|
|
// TODO: OpDot
|
|
|
|
// TODO: OpShiftRightLogical
|
|
|
|
// TODO: OpShiftRightArithmetic
|
|
|
|
// TODO: OpShiftLeftLogical
|
|
|
|
// TODO: OpBitwiseOr
|
|
|
|
// TODO: OpBitwiseXor
|
|
|
|
// TODO: OpBitwiseAnd
|
|
|
|
// TODO: OpAny
|
|
|
|
// TODO: OpAll
|
|
|
|
// TODO: OpIsNan
|
|
|
|
// TODO: OpIsInf
|
|
|
|
// TODO: OpIsFinite
|
|
|
|
// TODO: OpIsNormal
|
|
|
|
// TODO: OpSignBitSet
|
|
|
|
// TODO: OpLessOrGreater
|
|
|
|
// TODO: OpOrdered
|
|
|
|
// TODO: OpUnordered
|
|
|
|
// TODO: OpLogicalOr
|
|
|
|
// TODO: OpLogicalXor
|
|
|
|
// TODO: OpLogicalAnd
|
|
|
|
// TODO: OpSelect
|
|
|
|
// TODO: OpIEqual
|
|
|
|
// TODO: OpFOrdEqual
|
|
|
|
// TODO: OpFUnordEqual
|
|
|
|
// TODO: OpINotEqual
|
|
|
|
// TODO: OpFOrdNotEqual
|
|
|
|
// TODO: OpFUnordNotEqual
|
|
|
|
// TODO: OpULessThan
|
|
|
|
// TODO: OpSLessThan
|
|
|
|
// TODO: OpFOrdLessThan
|
|
|
|
// TODO: OpFUnordLessThan
|
|
|
|
// TODO: OpUGreaterThan
|
|
|
|
// TODO: OpSGreaterThan
|
|
|
|
// TODO: OpFOrdGreaterThan
|
|
|
|
// TODO: OpFUnordGreaterThan
|
|
|
|
// TODO: OpULessThanEqual
|
|
|
|
// TODO: OpSLessThanEqual
|
|
|
|
// TODO: OpFOrdLessThanEqual
|
|
|
|
// TODO: OpFUnordLessThanEqual
|
|
|
|
// TODO: OpUGreaterThanEqual
|
|
|
|
// TODO: OpSGreaterThanEqual
|
|
|
|
// TODO: OpFOrdGreaterThanEqual
|
|
|
|
// TODO: OpFUnordGreaterThanEqual
|
|
|
|
// TODO: OpDPdx
|
|
|
|
// TODO: OpDPdy
|
|
|
|
// TODO: OpFWidth
|
|
|
|
// TODO: OpDPdxFine
|
|
|
|
// TODO: OpDPdyFine
|
|
|
|
// TODO: OpFwidthFine
|
|
|
|
// TODO: OpDPdxCoarse
|
|
|
|
// TODO: OpDPdyCoarse
|
|
|
|
// TODO: OpFwidthCoarse
|
|
|
|
// TODO: OpPhi
|
|
|
|
// TODO: OpLoopMerge
|
|
|
|
// TODO: OpSelectionMerge
|
|
|
|
// TODO: OpBranch
|
|
|
|
// TODO: OpBranchConditional
|
|
|
|
// TODO: OpSwitch
|
|
|
|
|
|
|
|
TEST_F(ValidateID, OpReturnValueConstantGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypeFunction %2 %2
|
|
|
|
%4 = OpConstant %2 42
|
|
|
|
%5 = OpFunction %2 None %3
|
|
|
|
%6 = OpLabel
|
|
|
|
OpReturnValue %4
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpReturnValueVariableGood) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0 ;10
|
|
|
|
%3 = OpTypeFunction %2 %2 ;14
|
|
|
|
%8 = OpTypePointer Function %2 ;18
|
|
|
|
%4 = OpConstant %2 42 ;22
|
|
|
|
%5 = OpFunction %2 None %3 ;27
|
|
|
|
%6 = OpLabel ;29
|
|
|
|
%7 = OpVariable %8 Function %4 ;34
|
|
|
|
OpReturnValue %7 ;36
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_SUCCESS);
|
|
|
|
}
|
|
|
|
TEST_F(ValidateID, OpReturnValueBad) {
|
2015-11-02 14:41:20 +00:00
|
|
|
const char* spirv = R"(
|
2015-08-21 15:52:29 +00:00
|
|
|
%1 = OpTypeVoid
|
|
|
|
%2 = OpTypeInt 32 0
|
|
|
|
%3 = OpTypeFunction %2 %2
|
|
|
|
%4 = OpConstant %2 42
|
|
|
|
%5 = OpFunction %2 None %3
|
|
|
|
%6 = OpLabel
|
|
|
|
OpReturnValue %1
|
|
|
|
OpFunctionEnd)";
|
2015-05-22 17:26:19 +00:00
|
|
|
CHECK(spirv, SPV_ERROR_INVALID_ID);
|
|
|
|
}
|
|
|
|
|
|
|
|
// TODO: OpLifetimeStart
|
|
|
|
// TODO: OpLifetimeStop
|
|
|
|
// TODO: OpAtomicInit
|
|
|
|
// TODO: OpAtomicLoad
|
|
|
|
// TODO: OpAtomicStore
|
|
|
|
// TODO: OpAtomicExchange
|
|
|
|
// TODO: OpAtomicCompareExchange
|
|
|
|
// TODO: OpAtomicCompareExchangeWeak
|
|
|
|
// TODO: OpAtomicIIncrement
|
|
|
|
// TODO: OpAtomicIDecrement
|
|
|
|
// TODO: OpAtomicIAdd
|
|
|
|
// TODO: OpAtomicISub
|
|
|
|
// TODO: OpAtomicUMin
|
|
|
|
// TODO: OpAtomicUMax
|
|
|
|
// TODO: OpAtomicAnd
|
|
|
|
// TODO: OpAtomicOr
|
|
|
|
// TODO: OpAtomicXor
|
|
|
|
// TODO: OpAtomicIMin
|
|
|
|
// TODO: OpAtomicIMax
|
|
|
|
// TODO: OpEmitStreamVertex
|
|
|
|
// TODO: OpEndStreamPrimitive
|
|
|
|
// TODO: OpAsyncGroupCopy
|
|
|
|
// TODO: OpWaitGroupEvents
|
|
|
|
// TODO: OpGroupAll
|
|
|
|
// TODO: OpGroupAny
|
|
|
|
// TODO: OpGroupBroadcast
|
|
|
|
// TODO: OpGroupIAdd
|
|
|
|
// TODO: OpGroupFAdd
|
|
|
|
// TODO: OpGroupFMin
|
|
|
|
// TODO: OpGroupUMin
|
|
|
|
// TODO: OpGroupSMin
|
|
|
|
// TODO: OpGroupFMax
|
|
|
|
// TODO: OpGroupUMax
|
|
|
|
// TODO: OpGroupSMax
|
|
|
|
// TODO: OpEnqueueMarker
|
|
|
|
// TODO: OpEnqueueKernel
|
|
|
|
// TODO: OpGetKernelNDrangeSubGroupCount
|
|
|
|
// TODO: OpGetKernelNDrangeMaxSubGroupSize
|
|
|
|
// TODO: OpGetKernelWorkGroupSize
|
|
|
|
// TODO: OpGetKernelPreferredWorkGroupSizeMultiple
|
|
|
|
// TODO: OpRetainEvent
|
|
|
|
// TODO: OpReleaseEvent
|
|
|
|
// TODO: OpCreateUserEvent
|
|
|
|
// TODO: OpIsValidEvent
|
|
|
|
// TODO: OpSetUserEventStatus
|
|
|
|
// TODO: OpCaptureEventProfilingInfo
|
|
|
|
// TODO: OpGetDefaultQueue
|
|
|
|
// TODO: OpBuildNDRange
|
|
|
|
// TODO: OpReadPipe
|
|
|
|
// TODO: OpWritePipe
|
|
|
|
// TODO: OpReservedReadPipe
|
|
|
|
// TODO: OpReservedWritePipe
|
|
|
|
// TODO: OpReserveReadPipePackets
|
|
|
|
// TODO: OpReserveWritePipePackets
|
|
|
|
// TODO: OpCommitReadPipe
|
|
|
|
// TODO: OpCommitWritePipe
|
|
|
|
// TODO: OpIsValidReserveId
|
|
|
|
// TODO: OpGetNumPipePackets
|
|
|
|
// TODO: OpGetMaxPipePackets
|
|
|
|
// TODO: OpGroupReserveReadPipePackets
|
|
|
|
// TODO: OpGroupReserveWritePipePackets
|
|
|
|
// TODO: OpGroupCommitReadPipe
|
|
|
|
// TODO: OpGroupCommitWritePipe
|
2015-08-31 19:24:32 +00:00
|
|
|
|
|
|
|
} // anonymous namespace
|