AuroraMiddleware/SPIRV-Tools
1
0
Fork 0
mirror of https://github.com/KhronosGroup/SPIRV-Tools synced 2024-10-18 11:10:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix public deps on generated headers (#4386)

Browse Source 
Some generated headers are exposed by headers in the spvtools_opt
target, but its dependency on them is private. This can result in build
flake, since the headers don't need to be generated before compiling
any spvtools_opt dependents.

This fixes the build flake by correctly expressing these as public
dependencies.
This commit is contained in:
krockot 2021-07-26 11:27:25 -07:00 committed by GitHub
parent b2db20a7e8
commit 4376a10c1d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
BUILD.gn
View File

@ -786,12 +786,14 @@ static_library("spvtools_opt") {
deps = [ deps = [
":spvtools", ":spvtools",
":spvtools_language_header_cldebuginfo100",
":spvtools_language_header_debuginfo", ":spvtools_language_header_debuginfo",
":spvtools_language_header_vkdebuginfo100",
":spvtools_vendor_tables_spv-amd-shader-ballot", ":spvtools_vendor_tables_spv-amd-shader-ballot",
] ]
public_deps = [ ":spvtools_headers" ] public_deps = [
":spvtools_headers",
":spvtools_language_header_cldebuginfo100",
":spvtools_language_header_vkdebuginfo100",
]
if (build_with_chromium) { if (build_with_chromium) {
configs -= [ "//build/config/compiler:chromium_code" ] configs -= [ "//build/config/compiler:chromium_code" ]