AuroraMiddleware/SPIRV-Tools
1
0
Fork 0
mirror of https://github.com/KhronosGroup/SPIRV-Tools synced 2024-12-26 17:51:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable long-running fuzzer tests by default (#2887)

Browse Source 
spirv-fuzz has useful tests that run the fuzzer and shrinker, to give
the whole tool a good shake up, effectively "fuzzing the fuzzer".  The
problems that this detects are sensitive to the source of randomness
that is used, which can change from test platform to test platform.
It is thus not a good idea to run these tests by default during
continuous integration - they may end up failing due to environtal
factors, making it look like an unrelated change has broken the fuzzer
when really the fuzzer has revealed an already-existing bug in itself.

This change makes the tests disabled by default; they can enabled
during dedicated testing of the fuzzer.
This commit is contained in:
Alastair Donaldson 2019-09-20 09:43:26 +01:00 committed by GitHub
parent 61edde52a0
commit 4eee71e78f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
test/fuzz/CMakeLists.txt
View File

@ -17,8 +17,6 @@ if (${SPIRV_BUILD_FUZZER})
set(SOURCES
fuzz_test_util.h
fuzzer_replayer_test.cpp
fuzzer_shrinker_test.cpp
fact_manager_test.cpp
fuzz_test_util.cpp
fuzzer_pass_add_useful_constructs_test.cpp
@ -38,6 +36,17 @@ if (${SPIRV_BUILD_FUZZER})
transformation_split_block_test.cpp
uniform_buffer_element_descriptor_test.cpp)
if (${SPIRV_ENABLE_LONG_FUZZER_TESTS})
# These are long-running tests that depend on random seeds. We do not want
# to run them during regular whole-project CI because they may reveal
# spirv-fuzz bugs in changes that are totally unrelated to spirv-fuzz,
# which would be counfounding. Instead, they should be run regularly but
# separately.
set(SOURCES
fuzzer_replayer_test.cpp
fuzzer_shrinker_test.cpp)
endif()
add_spvtools_unittest(TARGET fuzz
SRCS ${SOURCES}
LIBS SPIRV-Tools-fuzz