AuroraMiddleware/SPIRV-Tools
1
0
Fork 0
mirror of https://github.com/KhronosGroup/SPIRV-Tools synced 2024-10-18 11:10:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Assembler test for LinkageAttributes decorations

Browse Source
This commit is contained in:
David Neto 2015-09-10 15:51:57 -04:00
parent 37547b2304
commit 55bdfcb0bc
3 changed files with 40 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
readme.md
View File

@ -32,6 +32,7 @@ The validator is incomplete. See the Future Work section for more information.
* Values: Fixes values for some decorations: BuiltIn LocalInvocationId, and BuiltIn
SubgroupId
* All handling of FPFastMathMode masks.
* LinkageAttributes now requires the literal string operand.
2015-09-09
* Avoid confusion about ownership of storage:

2
source/operand.cpp
View File

@ -751,7 +751,7 @@ static const spv_operand_desc_t decorationEntries[] = {
DecorationLinkageAttributes,
SPV_OPCODE_FLAGS_CAPABILITIES,
CapabilityLinkage,
{SPV_OPERAND_TYPE_LINKAGE_TYPE, SPV_OPERAND_TYPE_NONE}},
{SPV_OPERAND_TYPE_LITERAL_STRING, SPV_OPERAND_TYPE_LINKAGE_TYPE, SPV_OPERAND_TYPE_NONE}},
};
static const spv_operand_desc_t builtInEntries[] = {

39
test/TextToBinary.Annotation.cpp
View File

@ -236,7 +236,44 @@ INSTANTIATE_TEST_CASE_P(TextToBinaryDecorateFPFastMathMode, OpDecorateEnumTest,
#undef CASE
// clang-format on
// TODO(dneto): OpDecorate with Linkage attributes
// Test OpDecorate Linkage
// A single test case for a linkage
struct DecorateLinkageCase {
const uint32_t linkage_type_value;
const std::string linkage_type_name;
const std::string external_name;
};
using OpDecorateLinkageTest = test_fixture::TextToBinaryTestBase<
::testing::TestWithParam<DecorateLinkageCase>>;
TEST_P(OpDecorateLinkageTest, AnyLinkageDecoration) {
// This string should assemble, but should not validate.
std::string input = "OpDecorate %1 LinkageAttributes \"" + GetParam().external_name +
"\" " + GetParam().linkage_type_name;
std::vector<uint32_t> expected_operands{1, spv::DecorationLinkageAttributes};
std::vector<uint32_t> encoded_external_name =
MakeVector(GetParam().external_name);
expected_operands.insert(expected_operands.end(),
encoded_external_name.begin(),
encoded_external_name.end());
expected_operands.push_back(GetParam().linkage_type_value);
EXPECT_THAT(CompiledInstructions(input),
Eq(MakeInstruction(spv::OpDecorate, expected_operands)));
}
// clang-format off
#define CASE(ENUM) spv::LinkageType##ENUM, #ENUM
INSTANTIATE_TEST_CASE_P(TextToBinaryDecorateLinkage, OpDecorateLinkageTest,
::testing::ValuesIn(std::vector<DecorateLinkageCase>{
{ CASE(Import), "a" },
{ CASE(Export), "foo" },
{ CASE(Import), "some kind of long name with spaces etc." },
// TODO(dneto): utf-8, escaping, quoting cases.
}));
#undef CASE
// clang-format on
// TODO(dneto): OpMemberDecorate
// TODO(dneto): OpDecorationGroup