AuroraMiddleware/SPIRV-Tools
1
0
Fork 0
mirror of https://github.com/KhronosGroup/SPIRV-Tools synced 2024-11-22 03:30:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix array removal for task/mesh in interface validation

Browse Source
This commit is contained in:
Rua 2023-12-03 11:29:34 +01:00
parent 0d87845532
commit 8dfdbf0446
1 changed files with 23 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
source/val/validate_interfaces.cpp
View File

@ -311,9 +311,15 @@ spv_result_t GetLocationsForVariable(
}
}
// Vulkan 14.1.3: Tessellation control and mesh per-vertex outputs and
// tessellation control, evaluation and geometry per-vertex inputs have a
// layer of arraying that is not included in interface matching.
// Vulkan 14.1.3: Some interfaces have a layer of arraying
// that is not included in interface matching:
// - Tessellation control input and output, except Patch decoration
// - Tessellation evaluation input, except Patch decoration
// - Geometry input
// - Fragment input with PerVertexKHR decoration
// - Task output, except PerTaskNV decoration
// - Mesh input, except PerTaskNV decoration
// - Mesh output
bool is_arrayed = false;
switch (entry_point->GetOperandAs<spv::ExecutionModel>(0)) {
case spv::ExecutionModel::TessellationControl:
@ -336,11 +342,24 @@ spv_result_t GetLocationsForVariable(
is_arrayed = true;
}
break;
case spv::ExecutionModel::MeshNV:
case spv::ExecutionModel::TaskNV:
if (is_output && !has_per_task_nv) {
is_arrayed = true;
}
break;
case spv::ExecutionModel::TaskEXT:
if (is_output) {
is_arrayed = true;
}
break;
case spv::ExecutionModel::MeshNV:
if (is_output || !has_per_task_nv) {
is_arrayed = true;
}
break;
case spv::ExecutionModel::MeshEXT:
is_arrayed = true;
break;
default:
break;
}