AuroraMiddleware/SPIRV-Tools
1
0
Fork 0
mirror of https://github.com/KhronosGroup/SPIRV-Tools synced 2024-10-18 11:10:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable scope validation for OpReadClockKHR (#2953)

Browse Source 
See #2952

Disabled until specification is clarified
This commit is contained in:
alan-baker 2019-10-09 15:02:07 -04:00 committed by GitHub
parent df15a4a3cb
commit c1d42038f7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
source/val/validate_misc.cpp
View File

@ -42,10 +42,13 @@ spv_result_t ValidateUndef(ValidationState_t& _, const Instruction* inst) {
spv_result_t ValidateShaderClock(ValidationState_t& _,
const Instruction* inst) {
// #2952: disabled until scope discussion is resolved.
#if 0
const uint32_t execution_scope = inst->word(3);
if (auto error = ValidateExecutionScope(_, inst, execution_scope)) {
return error;
}
#endif
// Result Type must be a 64 - bit unsigned integer type or
// a vector of two - components of 32 -

3
test/val/val_misc_test.cpp
View File

@ -144,7 +144,8 @@ OpFunctionEnd)";
EXPECT_THAT(getDiagnosticString(), HasSubstr("vector of two components"));
}
TEST_F(ValidateMisc, ShaderClockExecutionScope) {
// #2952: disabled until scope discussion is resolved.
TEST_F(ValidateMisc, DISABLED_ShaderClockExecutionScope) {
const std::string spirv = ShaderClockSpriv + R"(
%3 = OpTypeFunction %void
%ulong = OpTypeInt 64 0