diff --git a/DEPS b/DEPS index 788017ac8..606eb60e5 100644 --- a/DEPS +++ b/DEPS @@ -5,14 +5,14 @@ vars = { 'abseil_revision': '79ca5d7aad63973c83a4962a66ab07cd623131ea', - 'effcee_revision': '66edefd2bb641de8a2f46b476de21f227fc03a28', + 'effcee_revision': 'ef0a5c1528fe9850b65c6b8e6a3ab9039b92b685', 'googletest_revision': '45804691223635953f311cf31a10c632553bbfc3', # Use protobufs before they gained the dependency on abseil 'protobuf_revision': 'v21.12', - 're2_revision': 'c9cba76063cf4235c1a15dd14a24a4ef8d623761', + 're2_revision': '03da4fc0857c285e3a26782f6bc8931c4c950df4', 'spirv_headers_revision': '69155b22b3b1f2d0cfed48f59167d9792de1fd79', } diff --git a/WORKSPACE b/WORKSPACE index 5abfc98bc..589dc1220 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -1,3 +1,11 @@ +load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") + +http_archive( + name = "bazel_skylib", + strip_prefix = "bazel-skylib-main", + urls = ["https://github.com/bazelbuild/bazel-skylib/archive/main.zip"], +) + local_repository( name = "spirv_headers", path = "external/spirv-headers", @@ -17,3 +25,8 @@ local_repository( name = "com_google_effcee", path = "external/effcee", ) + +local_repository( + name = "com_google_absl", + path = "external/abseil_cpp", +) diff --git a/kokoro/scripts/windows/build.bat b/kokoro/scripts/windows/build.bat index bb14da3dc..fe15f2d79 100644 --- a/kokoro/scripts/windows/build.bat +++ b/kokoro/scripts/windows/build.bat @@ -30,6 +30,9 @@ set PATH=C:\python36;"C:\Program Files\cmake-3.23.1-windows-x86_64\bin";%PATH% if %VS_VERSION% == 2017 ( call "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\vcvarsall.bat" x64 echo "Using VS 2017..." + + :: RE2 does not support VS2017, we we must disable tests. + set BUILD_TESTS=NO ) else if %VS_VERSION% == 2019 ( call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvarsall.bat" x64 echo "Using VS 2019..." @@ -56,6 +59,10 @@ set CMAKE_FLAGS=-DCMAKE_INSTALL_PREFIX=%KOKORO_ARTIFACTS_DIR%\install -GNinja -D :: Build spirv-fuzz set CMAKE_FLAGS=%CMAKE_FLAGS% -DSPIRV_BUILD_FUZZER=ON +if "%BUILD_TESTS%" == "NO" ( + set CMAKE_FLAGS=-DSPIRV_SKIP_TESTS=ON %CMAKE_FLAGS% +) + cmake %CMAKE_FLAGS% .. if %ERRORLEVEL% NEQ 0 exit /b %ERRORLEVEL% @@ -71,10 +78,12 @@ setlocal ENABLEDELAYEDEXPANSION :: ################################################ :: Run the tests :: ################################################ -echo "Running Tests... %DATE% %TIME%" -ctest -C %BUILD_TYPE% --output-on-failure --timeout 300 -if !ERRORLEVEL! NEQ 0 exit /b !ERRORLEVEL! -echo "Tests Completed %DATE% %TIME%" +if "%BUILD_TESTS%" NEQ "NO" ( + echo "Running Tests... %DATE% %TIME%" + ctest -C %BUILD_TYPE% --output-on-failure --timeout 300 + if !ERRORLEVEL! NEQ 0 exit /b !ERRORLEVEL! + echo "Tests Completed %DATE% %TIME%" +) :: ################################################ :: Install and package.