AuroraMiddleware/SPIRV-Tools
1
0
Fork 0
mirror of https://github.com/KhronosGroup/SPIRV-Tools synced 2024-10-18 11:10:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Validator] AMD_gpu_shader_half_float_fetch allow float16 (#1393)

Browse Source 
SPV_AMD_gpu_shader_half_float_fetch extension should implicitly
allow declaring 16bit float.
This commit is contained in:
Jaebaek Seo 2018-09-20 13:50:34 -04:00
parent 37c99ab7e5
commit d73b9d8dfb
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
source/val/validation_state.cpp
View File

@ -390,6 +390,7 @@ void ValidationState_t::RegisterExtension(Extension ext) {
switch (ext) {
case kSPV_AMD_gpu_shader_half_float:
case kSPV_AMD_gpu_shader_half_float_fetch:
// SPV_AMD_gpu_shader_half_float enables float16 type.
// https://github.com/KhronosGroup/SPIRV-Tools/issues/1375
features_.declare_float16_type = true;

11
test/val/val_data_test.cpp
View File

@ -290,6 +290,17 @@ TEST_F(ValidateData, storage_input_output_16_good) {
ASSERT_EQ(SPV_SUCCESS, ValidateInstructions());
}
TEST_F(ValidateData, amd_gpu_shader_half_float_fetch_16_good) {
std::string str = R"(
OpCapability Shader
OpCapability Linkage
OpExtension "SPV_AMD_gpu_shader_half_float_fetch"
OpMemoryModel Logical GLSL450
%2 = OpTypeFloat 16)";
CompileSuccessfully(str.c_str());
ASSERT_EQ(SPV_SUCCESS, ValidateInstructions());
}
TEST_F(ValidateData, int16_bad) {
std::string str = header + "%2 = OpTypeInt 16 1";
CompileSuccessfully(str.c_str());