AuroraMiddleware/SPIRV-Tools
1
0
Fork 0
mirror of https://github.com/KhronosGroup/SPIRV-Tools synced 2024-11-29 22:41:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add invalid-operand tests for !<integer>.

Browse Source
This commit is contained in:
Dejan Mircevski 2015-09-08 14:17:14 -04:00 committed by David Neto
parent a4b834e456
commit ea5a2a5242
2 changed files with 25 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
test/ImmediateInt.cpp
View File

@ -33,6 +33,7 @@
namespace {
using ::testing::HasSubstr;
using ::testing::ElementsAre;
using test_fixture::TextToBinaryTest;
@ -73,7 +74,8 @@ TEST_F(ImmediateIntTest, AnyWordInSimpleStatement) {
}
TEST_F(ImmediateIntTest, AnyWordInAssignmentStatement) {
const SpirvVector original = CompileSuccessfully("%2 = OpArrayLength %12 %1 123");
const SpirvVector original =
CompileSuccessfully("%2 = OpArrayLength %12 %1 123");
// TODO(deki): uncomment assertions below and make them pass.
// EXPECT_EQ(original, CompileSuccessfully("!2 = OpArrayLength %12 %1 123"));
// EXPECT_EQ(original, CompileSuccessfully("%2 = !0x00040044 %12 %1 123"));
@ -222,10 +224,18 @@ OpFRem %11 %4 %3 %2
#endif
}
// TODO(deki): implement all tests below.
// !<integer> followed by, eg, an enum or '=' or a random bareword.
TEST_F(ImmediateIntTest, ForbiddenOperands) {
// !<integer> followed by, eg, an enum or '=' or a random bareword.
// TODO(deki): uncomment assertions below and make them pass.
#if 0
EXPECT_THAT(CompileFailure("OpMemoryModel !0 OpenCL"), HasSubstr("OpenCL"));
EXPECT_THAT(CompileFailure("!1 %0 = !2"), HasSubstr("="));
// Immediate integers longer than one 32-bit word.
EXPECT_THAT(CompileFailure("!5000000000"), HasSubstr("5000000000"));
EXPECT_THAT(CompileFailure("!0x00020049 !5000000000"), HasSubstr("5000000000"));
#endif
EXPECT_THAT(CompileFailure("OpMemoryModel !0 random_bareword"),
HasSubstr("random_bareword"));
}
} // anonymous namespace

11
test/TestFixture.h
View File

@ -82,6 +82,17 @@ class TextToBinaryTestBase : public T {
return code_copy;
}
// Compiles SPIR-V text, asserting compilation failure. Returns the error
// message(s).
std::string CompileFailure(const std::string& text) {
SetText(text);
EXPECT_NE(SPV_SUCCESS,
spvTextToBinary(&this->text, opcodeTable, operandTable,
extInstTable, &binary, &diagnostic))
<< text;
return diagnostic->error;
}
void SetText(const std::string& code) {
textString = code;
text.str = textString.c_str();