AuroraMiddleware/SPIRV-Tools
1
0
Fork 0
mirror of https://github.com/KhronosGroup/SPIRV-Tools synced 2024-12-31 20:21:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add comments to explain why calling decode().

Browse Source
This commit is contained in:
Lei Zhang 2016-03-07 13:44:09 -05:00
parent c15683906c
commit f7e63786a9
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
utils/update_build_version.py
View File

@ -71,6 +71,11 @@ def main():
sys.exit(1) sys.exit(1)
new_content = '"spirv-tools {}\\n"\n'.format( new_content = '"spirv-tools {}\\n"\n'.format(
# decode() is needed here for Python3 compatibility. In Python2,
# str and bytes are the same type, but not in Python3.
# Popen.communicate() returns a bytes instance, which needs to be
# decoded into text data first in Python3. And this decode() won't
# hurt Python2.
describe(sys.argv[1]).decode('ascii').replace('"', '\\"')) describe(sys.argv[1]).decode('ascii').replace('"', '\\"'))
if os.path.isfile(OUTFILE) and new_content == open(OUTFILE, 'r').read(): if os.path.isfile(OUTFILE) and new_content == open(OUTFILE, 'r').read():
sys.exit(0) sys.exit(0)