Vasyl Teliman
e2ac64bdf0
spirv-fuzz: Move ApplyTransformation to .cpp file ( #4258 )
...
Sometimes, you need to change these functions during debugging (e.g.,
figure out why the transformation is inapplicable). When that happens,
you need to recompile the whole fuzzer just because these functions
are in the header file. This PR fixes the situation.
2021-05-26 00:39:51 +01:00
Mostafa Ashraf
91931ffcd2
spirv-fuzz: Enhance test to improve lines covered ( #4289 )
...
Fixes #4287 by enhancing the test to get 100% of lines covered.
2021-05-24 14:24:11 +01:00
Alastair Donaldson
0afe1f2b3f
spirv-fuzz: Cover protobuf message creation in tests ( #4285 )
...
The Transformation class tests did not cover the (trivial) ToMessage
methods of each transformation, nor the constructors that take a
protobuf message. This lac of coverage makes it hard to see which more
interesting pieces of code are not covered when looking at coverage
percentages. This change adapts the helper function for applying a
transformation and checking fresh ids so that it turns a
transformation into a protobuf message and back, thus covering
ToMessage and the protobuf constructor for every transformation. The
runtime overhead of doing this is very small.
2021-05-22 17:45:09 +01:00
Vasyl Teliman
f0d110e305
Invalidate analyses ( #4260 )
...
Some reduction opportunities don't invalidate all analyses. This PR
fixes the situation (although we might invalidate more analyses than
required).
2021-05-14 15:00:51 +01:00
Greg Fischer
18d45142e7
Fix crash when optimizing shaders with DebugPrintf ( #4280 )
...
Fixes #4219
2021-05-13 13:19:56 -04:00
alan-baker
010cd289db
Fix continue construct for single block loops ( #4277 )
...
Fixes https://crbug.com/tint/793
* When a loop has an empty loop construct, the loop construct and
continue construct share the same header so don't disallow the loop
header for the continue construct
2021-05-12 13:01:32 -04:00
Alastair Donaldson
f6b59599ae
spirv-fuzz: Respect control flow rules when merging returns ( #4279 )
...
Fixes #4278 .
Some minor code cleanup is incorporated.
2021-05-12 10:45:58 -04:00
David Neto
de1cae069c
val test: Update capability dependency ( #4268 )
...
Private storage class is now also enabled by VectorComputeINTEL
This should fix the CI bots
2021-05-11 10:40:45 -04:00
Shiyu Liu
1020e394cb
spirv-fuzz: Fix underflow problem in fuzzer_pass_swap_two_functions ( #4253 )
...
Addresses a comment mentioned in #4236 .
Simplifies implementation of GetFunctionIterator().
2021-05-04 09:40:55 +01:00
Steven Perron
8ec9f456e6
Fix export symbol test. ( #4254 )
...
* Fix export symbol test.
The symbol export test does not check weak symbols, even though they are
possibly exported. It also does not allow functions in the standard
namespace even though it allows symbols on other namespaces.
I've modified the check to look at the name of weakly defined function,
and I've allowed functions in the standard namespace, functions in a local scope, and
weak definitions of new and delete operators.
Fixes #4250
2021-04-29 14:27:16 -04:00
ncesario-lunarg
f30465d2b5
build: Fix Android build ( #4157 )
2021-04-29 09:10:32 -04:00
Ben Clayton
f8c78cc534
Updates to the vscode SPIR-V extension ( #4246 )
...
* utils/vscode: Allow running install.sh from any CWD
* utils/vscode: Update schema to latest
* utils/vscode: Don't keep on adding trailing newlines
Repeatedly formatting the file will keep on appending newlines to the end of the file.
Don't do that.
2021-04-29 08:58:55 -04:00
Vasyl Teliman
f82f5af5e2
Invalidate DefUse analysis ( #4255 )
...
Fixes #4252 .
2021-04-29 09:44:59 +01:00
Jaebaek Seo
089d716d25
Fix dangling phi bug from loop-unroll ( #4239 )
...
Fix dangling phi bug from loop-unroll
When unrolling the following loop:
```
%const0 = OpConstant ...
%const1 = OpConstant ...
...
%LoopHeader = OpLabel
%phi0 = OpPhi %float %const0 %PreHeader %phi1 %Latch
%phi1 = OpPhi %float %const1 %PreHeader %x %Latch
...
%LoopBody = OpLabel
%x = OpFSub %float %phi1 %phi0
...
```
the loop-unroll pass sets the value of `%phi0` as `%phi1` for the second
copy of the loop body. For example, the second copy of
`%x = OpFSub %float %phi1 %phi0` will be
`%y = OpFSub %float %x %phi1`.
Since all phi instructions for inductions will are removed after the
loop unrolling, `%phi1` will be a dead dangling phi.
It happens only for the phi values of the first loop iteration. Replacing those
dangling phis with their initial values fixes this issue.
For example, the second copy of `%x = OpFSub %float %phi1 %phi0` should be
`%y = OpFSub %float %x %const1` because the value of `%phi1` from the
first loop iteration is `%const1`.
2021-04-27 16:27:09 -04:00
Jaebaek Seo
07ec4f83c5
Support folding OpBitcast with numeric constants ( #4247 )
...
Add constant folding rule for OpBitcast with numeric scalar or vector
constants.
2021-04-27 14:24:46 -04:00
Shiyu Liu
6cdf07d2b3
spirv-fuzz: Swap positions of two functions in a module ( #4236 )
...
Adds a new transformation class that swaps the syntactic position of
two functions in the module, and a fuzzer pass to apply it.
Fixes #4026 .
2021-04-27 12:33:08 +01:00
Steven Perron
1b8341b8b1
Fix warning in python script. ( #4251 )
2021-04-26 15:37:38 -04:00
Ben Clayton
9f23457eef
GraphicsRobustAccessPass: Set module_status_.modified ( #4167 )
...
When calling `replace_index`.
Fixes : #4166
2021-04-26 17:14:35 +01:00
Mostafa Ashraf
8fe39ad581
spirv-fuzz: Permute the order of variables at function scope issue ( #4248 )
...
Fixes #4194 .
2021-04-26 16:53:55 +01:00
Jakub Kuderski
22b82872b4
Start SPIRV-Tools v2021.2
2021-04-21 10:16:06 -04:00
Jakub Kuderski
c2d5375fa7
Finalize SPIRV-Tools v2021.1
2021-04-21 10:13:07 -04:00
Jakub Kuderski
dc72924cb3
Update CHANGES
2021-04-19 11:06:09 -04:00
sfricke-samsung
693d564db4
spriv-val: Fix clang-format bug for VUID string ( #4238 )
2021-04-16 08:52:48 -04:00
Alastair Donaldson
a02a9205ff
spirv-fuzz: Accept limitations in AddFunction ( #4226 )
...
There are some edge cases where adding livesafe functions does not
succeed, due to loop limiter edges breaking SPIR-V dominance rules. As
these edge cases are rare it does not seem worth implementing complex
additional logic to handle all cases. This change accepts that trying
to add a function in a livesafe manner may not succeed.
2021-04-13 09:45:30 +01:00
Shahbaz Youssefi
ae6a1e1d2f
Fix UWP build ( #4235 )
...
UWP doesn't support system(), so skip building spirv-reduce on it
similarly to iOS.
2021-04-12 13:17:44 -04:00
Paul Thomson
6210375e13
Fix clang-format-diff.py URL ( #4233 )
...
Also add the --fail flag so that kokoro/check-format/build.sh fails when it cannot download the clang-format-diff.py script.
2021-04-09 23:36:36 +01:00
Alastair Donaldson
8da800c4cb
spirv-reduce: Remove redundant r-value references ( #4232 )
2021-04-09 13:55:51 +01:00
Alastair Donaldson
212895d4c2
Typo fix ( #4225 )
2021-04-02 09:59:35 +01:00
Greg Fischer
48007a5c7f
Add interpolate legalization pass ( #4220 )
...
This pass converts an internal form of GLSLstd450 Interpolate ops
to the externally valid form. The external form takes the lvalue
of the interpolant. The internal form can do a load of the interpolant.
The pass replaces the load with its pointer. The internal form is
generated by glslang and possibly other frontends for HLSL shaders.
The new pass is called as part of HLSL legalization after all
propagation is complete.
Also adds internal interpolate form to pre-legalization validation
2021-03-31 14:26:36 -04:00
Alastair Donaldson
61e256c9c4
spirv-fuzz: Efficiency improvements to fuzzer pass ( #4188 )
...
FuzzerPassConstructComposites is adapted to use AvailableInstructions
to manage available instructions, and to use zero constants when
trying to construct a composite for which not all fields can otherwise
be constructed. The change uncovered some cases where we create
structs and arrays with struct fields or components that are
block-decorated; these possibilities have been eliminated.
2021-03-27 12:15:59 +00:00
Alastair Donaldson
2ee21fbdee
spirv-fuzz: Avoid invalidating analyses when splitting blocks ( #4218 )
...
It is easy to avoid the need to invalidate the def-use analysis and
instruction to block mapping when splitting blocks, and profiling has
revealed that invalidation of def-use in particular is expensive when
splitting many blocks. This change avoids these invalidations.
2021-03-27 12:13:23 +00:00
Alastair Donaldson
22eb528f17
spirv-fuzz: Do not add too many dead blocks ( #4217 )
...
Profiling has shown that adding large numbers of dead block
transformations can be expensive because each on requires dominator
analysis information, and each one invalidates this information. There
is currently no obvious mechanism for incrementally updating the
dominator analysis. This change restricts the number of these
transformations that a single fuzzer pass will apply, to restrict this
performance bottleneck.
2021-03-27 10:30:23 +00:00
Alastair Donaldson
d0c73fcee1
spirv-fuzz: Optimize transformations ( #4216 )
...
Avoids blanket invalidation of analyses in several transformations,
instead updating the def-use manager and instruction to block mapping.
2021-03-26 10:22:06 +00:00
Vasyl Teliman
f227930153
spirv-fuzz: Fix comments #4215
...
Related to #4214 .
2021-03-25 17:20:45 +00:00
Jason Ekstrand
ecc840d30b
Add validation for SPV_EXT_shader_atomic_float_min_max ( #4105 )
...
* Add an "extra_defs" parameter to GenerateShaderCode in atomics_test
* Add validation for SPV_EXT_shader_atomic_float_min_max
2021-03-24 08:49:21 -04:00
David Neto
d20c9c2cf3
Make spirv-tools-build-version a common dependency ( #4210 )
...
Required to support latest Xcode
Fixes #4109
2021-03-23 16:55:56 -04:00
Alastair Donaldson
bed84792f9
spirv-fuzz: Call by value and move in transformations ( #4208 )
...
Adapts all transformation classes so that their protobuf message is
passed by value and then moved into the message_ field.
2021-03-23 13:31:44 +00:00
Alastair Donaldson
c0833ce620
spirv-fuzz: Remove destructors from FuzzerPass subclasses ( #4209 )
...
Subclasses of FuzzerPass no longer needlessly override the default
destructor of FuzzerPass.
2021-03-23 13:31:27 +00:00
Alastair Donaldson
3d39517961
spirv-fuzz: Improve transformation test oracles ( #4207 )
...
To help ensure that optimizations that do less cautious invalidation
of analyses are implemented correctly, this change adds checks to the
tests of various transformations to ensure that analyses such as
def-use are up to date.
2021-03-23 13:31:14 +00:00
Vasyl Teliman
edb8399b0f
spirv-fuzz: Add WGSL compatibility flag to context ( #4193 )
...
The new flags allows transformations and fuzzer passes to be enabled
and applied in a WGSL-compatible fashion.
2021-03-21 09:10:15 +00:00
Alastair Donaldson
6382cbb497
spirv-fuzz: Avoid invalidating analyses in various transformations ( #4205 )
...
Avoids invalidating all analyses in transformations that add
constants, OpUndef and global and local variables.
2021-03-20 22:48:02 +00:00
Alastair Donaldson
6578899781
spirv-fuzz: Manage available instructions efficiently ( #4177 )
...
Introduces a data structure for efficient management of available
instructions in the fuzzer.
2021-03-20 18:51:18 +00:00
Alastair Donaldson
75d7c14cfb
spirv-fuzz: Remove AddType methods from fuzzerutil ( #4204 )
...
Types should only be added to the module by spirv-fuzz via
transformations, so this change removes the AddType methods from
fuzzerutil, which were only called once each from the appropriate
transformation.
The transformations have been adapted so that they avoid redundantly
invalidating all analyses - they now update the def-use manager and
invalidate only the type manager.
2021-03-20 08:54:51 +00:00
sfricke-samsung
f2a19b0150
spirv-val: Refactor of atomic pass ( #4200 )
2021-03-19 09:23:02 -04:00
sfricke-samsung
8f421ced3e
spirv-val: Label VUID 04643 ( #4202 )
2021-03-19 09:02:48 -04:00
sfricke-samsung
2b0d16a059
spirv-val: Label VUID 04667 ( #4201 )
2021-03-19 08:57:36 -04:00
Alastair Donaldson
a732e4c03c
spirv-fuzz: Apply fuzzer pass before checking exit conditions ( #4199 )
...
Fixes #4198 .
2021-03-19 05:32:54 +00:00
sfricke-samsung
a611be7782
spirv-val: Fix Int64Atomics check ( #4192 )
2021-03-18 10:50:16 -04:00
timvpGoogle
4f498774db
Roll deps ( #4185 )
...
* Roll external/googletest/ 3af06fe16..b7d472f12 (177 commits)
3af06fe166...b7d472f122ca11026a03...f8e389f3acfaa570afbc...bcf55210f1
2021-03-17 10:22:50 -04:00
sfricke-samsung
c040bd3ae5
spirv-val: Add Vulkan Execution Scope checks ( #4183 )
...
* spirv-val: Add Vulkan Execution Scope checks
2021-03-17 10:00:11 -04:00
