Nathan Gauër
c91e9d09b5
opt: add StorageImageReadWithoutFormat to cap trim ( #5475 )
...
The StorageImageReadWithoutFormat capability is only required when
an image type with the format set to Unknown is used with some specific
OpImageRead or OpImageSparseRead instructions.
This patch adds the required code to the capability trimming pass to
remove the StorageImageReadWithoutFormat capability when not required.
Signed-off-by: Nathan Gauër <brioche@google.com>
2023-11-14 09:29:31 -05:00
sethp
d88742fbd8
fix(build): git describe all tagged versions ( #5447 )
...
Previously, the version string would include `v2022.4-N-...` indicating N commits since the last annotated tag (`v2022.4`).
This change broadens the search from just annotated tags to all tags that match `v*`, including the latest version `v2023.4.rc2`.
See also: https://github.com/KhronosGroup/SPIRV-Tools/pull/5417#issuecomment-1764772856
2023-11-13 17:28:30 +01:00
Natalie Chouinard
6b1e609ef1
Support missing git in update_build_version.py ( #5473 )
...
Return False instead of raising an exception when running git commands
fail, which allows the script to fallback to alternative options.
Fixes #5469
2023-11-10 15:43:11 -08:00
github-actions[bot]
fbf047cc8b
Roll external/re2/ 24d460a9d..974f44c8d (4 commits) ( #5470 )
...
* Roll external/re2/ 24d460a9d..974f44c8d (4 commits)
24d460a9db...974f44c8d488bc5e321c...38f39dae5b#388 )
Created with:
roll-dep external/spirv-headers
---------
Co-authored-by: GitHub Actions[bot] <>
2023-11-09 20:35:08 +00:00
Steven Perron
9e7a1f2ddd
Fix array size calculation ( #5463 )
...
The function that get the number of elements in a composite variable
returns an incorrect values for the arrays. This is fixed, so that it
returns the correct number of elements for arrays where the number of
elements is represented as a 32-bit integer and is known at compile
time.
Fixes #4953
2023-11-02 13:29:57 -04:00
dependabot[bot]
eacc969b7d
build(deps): bump the github-actions group with 2 updates ( #5457 )
...
Bumps the github-actions group with 2 updates: [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) and [github/codeql-action](https://github.com/github/codeql-action ).
Updates `ossf/scorecard-action` from 2.3.0 to 2.3.1
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](483ef80eb9...0864cf1902https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](0116bc2df5...74483a38d3
2023-11-02 10:05:53 -04:00
github-actions[bot]
7210d247cd
Roll external/googletest/ 518387203..5b7fd63d6 (1 commit) ( #5454 )
...
* Roll external/googletest/ 518387203..b10fad38c (2 commits)
518387203b...b10fad38c4a0b3bc60c3...24d460a9db
2023-11-02 14:02:47 +00:00
Steven Perron
a08f648c86
Remove references to __FILE__ ( #5462 )
...
* Remove references to __FILE__
Uses of `__FILE__` leak the directory structure of the machine used to
build because it adds a string to the string table with the full path
name. I've removed the uses that show up in the release builds.
Fixes #5416
2023-11-01 15:19:48 -07:00
Spencer Fricke
c87755bb9f
spirv-val: Add WorkgroupMemoryExplicitLayoutKHR check for Block ( #5461 )
2023-11-01 10:48:40 -04:00
github-actions[bot]
4f014aff9c
Roll external/re2/ 601d9ea3e..a0b3bc60c (1 commit) ( #5453 )
...
601d9ea3e6...a0b3bc60c3
2023-10-26 06:40:22 +00:00
github-actions[bot]
33bac51443
Roll external/googletest/ 116b7e552..518387203 (1 commit) ( #5450 )
...
116b7e5528...518387203b
2023-10-25 21:37:34 +00:00
github-actions[bot]
01e851be93
Roll external/re2/ 928a015e6..601d9ea3e (1 commit) ( #5448 )
...
928a015e6e...601d9ea3e6
2023-10-21 07:55:37 +00:00
github-actions[bot]
1928c76cd6
Roll external/googletest/ 2dd1c1319..829c19901 (1 commit) ( #5444 )
...
* Roll external/googletest/ 2dd1c1319..116b7e552 (3 commits)
2dd1c13195...116b7e5528ece4cecab5...928a015e6e4183b260f4...88bc5e321c#384 )
Created with:
roll-dep external/spirv-headers
---------
Co-authored-by: GitHub Actions[bot] <>
2023-10-20 06:07:08 +00:00
Cassandra Beckley
73876defc8
opt: support 64-bit OpAccessChain index in FixStorageClass ( #5446 )
...
The SPIR-V specification allows any scalar integer type as an index. DXC
usually emits indexes as 32-bit integer types, however, in some cases it
is possible to make it emit 64-bit indexes instead (as in
https://github.com/microsoft/DirectXShaderCompiler/issues/5638 ).
2023-10-19 20:02:46 +00:00
dependabot[bot]
5084f58e5d
build(deps): bump the github-actions group with 4 updates ( #5445 )
...
Bumps the github-actions group with 4 updates: [actions/checkout](https://github.com/actions/checkout ), [ossf/scorecard-action](https://github.com/ossf/scorecard-action ), [actions/upload-artifact](https://github.com/actions/upload-artifact ) and [github/codeql-action](https://github.com/github/codeql-action ).
Updates `actions/checkout` from 3.1.0 to 4.1.1
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3.1.0...b4ffde65f46336ab88eb53be808477a3936bae11 )
Updates `ossf/scorecard-action` from 2.1.2 to 2.3.0
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](e38b1902ae...483ef80eb9https://github.com/actions/upload-artifact/releases )
- [Commits](3cea537223...a8a3f3ad30https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](17573ee1cc...0116bc2df5
2023-10-18 14:56:29 -04:00
Fumitoshi Ukai
a9c61d1376
update_build_version.py produce deterministic header. ( #5426 )
...
When building, .git directory may not exist in current
directory (e.g. chromium build), so it will produce
with current timestamp, which becomes non-deterministic build.
Check if repo_path is in git repository and use git info.
Also fix fallback logic when 'git describe' failed.
'git rev-parse HEAD' result was not used because it didn't
update success.
2023-10-18 18:49:51 +02:00
Steven Perron
5bb595091b
Add ComputeDerivativeGroup*NV capabilities to trim capabilities pass. ( #5430 )
...
* Add ComputeDerivativeGroup*NV capabilities to trim capabilities pass.
* Add SPV_NV_compute_shader_derivatives to allow lists
No tests needed for this. The code path is well tested. Just adding new
data.
2023-10-16 19:03:33 +00:00
github-actions[bot]
3985f0da0c
Roll external/spirv-headers/ e867c0663..4183b260f (1 commit) ( #5439 )
...
e867c06631...4183b260f4#377 )
Created with:
roll-dep external/spirv-headers
Co-authored-by: GitHub Actions[bot] <>
2023-10-16 14:43:23 +00:00
github-actions[bot]
661f429b11
Roll external/re2/ b673de358..ece4cecab (2 commits) ( #5437 )
...
b673de3583...ece4cecab5
2023-10-11 19:14:22 +00:00
Nathan Gauër
360d469b9e
Prepare release v2023.5.rc1 ( #5423 )
...
Prepare release v2023.5.rc1
2023-10-11 11:43:50 -04:00
github-actions[bot]
74005dfa67
Roll external/re2/ 35bb195de..b673de358 (2 commits) ( #5433 )
...
35bb195dec...b673de3583
2023-10-10 20:30:48 +00:00
github-actions[bot]
933db564ca
roll deps ( #5432 )
...
* Roll external/googletest/ beb552fb4..2dd1c1319 (1 commit)
beb552fb47...2dd1c1319526f7d889e1...35bb195dec
2023-10-06 10:01:14 +00:00
Joyce
ce995b319e
Hash pin workflows and config dependabot ( #5412 )
...
* Step Security: hash pin and dependabot
Signed-off-by: Joyce Brum <joycebrum@google.com>
* add license to dependabot.yml
Signed-off-by: Joyce <joycebrum@google.com>
---------
Signed-off-by: Joyce Brum <joycebrum@google.com>
Signed-off-by: Joyce <joycebrum@google.com>
2023-10-05 13:18:28 -04:00
dependabot[bot]
df2f2a0313
build(deps): bump get-func-name from 2.0.0 to 2.0.2 in /tools/sva ( #5418 )
...
Bumps [get-func-name](https://github.com/chaijs/get-func-name ) from 2.0.0 to 2.0.2.
- [Release notes](https://github.com/chaijs/get-func-name/releases )
- [Commits](https://github.com/chaijs/get-func-name/commits/v2.0.2 )
---
updated-dependencies:
- dependency-name: get-func-name
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-05 13:16:31 -04:00
github-actions[bot]
866e60defc
Roll external/spirv-headers/ 79743b899..e867c0663 (2 commits) ( #5427 )
...
79743b899f...e867c06631#383 )
2023-10-04 95509728+pradyumans Register Slang Compiler for SPIR-V (#382 )
Created with:
roll-dep external/spirv-headers
Co-authored-by: GitHub Actions[bot] <>
2023-10-05 11:58:05 -04:00
Cassandra Beckley
023a8c79e9
opt: add Float64 capability to trim pass ( #5428 )
2023-10-05 11:12:09 +02:00
github-actions[bot]
4fab7435bf
Roll external/googletest/ e47544ad3..beb552fb4 (2 commits) ( #5424 )
...
e47544ad31...beb552fb47
2023-10-04 01:42:27 -07:00
Jeremy Gebben
847715d6c6
instrument: Ensure linking works even of nothing is changed ( #5419 )
...
spirv-link requires that memory models match between its input files.
Ensure this is the case by always returning SuccessWithChange and
always changing the memory model to match the instrumentation
code in Vulkan-ValidationLayers.
Also, disable the DCE pass in the --inst-* command line options, since
it will only work after linking.
2023-10-02 09:15:39 -06:00
Cassandra Beckley
dc9900967d
Update BUILD.gn to include header for new pass ( #5421 )
...
Fixes #5420
2023-10-02 09:39:31 -04:00
Cassandra Beckley
1bc0e6f59a
Add a new legalization pass to dedupe invocation interlock instructions ( #5409 )
...
Add a new legalization pass to dedupe invocation interlock instructions
DXC will be adding support for HLSL's rasterizer ordered views by using
the SPV_EXT_fragment_shader_interlock_extension. That extension
stipulates that if an entry point has an interlock ordering execution
mode, it must dynamically execute OpBeginInvocationInterlockEXT and
OpEndInvocationInterlockEXT, in that order, exactly once. This would be
difficult to determine in DXC's SPIR-V backend, so instead we will emit
these instructions potentially multiple times, and use this legalization
pass to ensure that the final SPIR-V follows the specification.
This PR uses data-flow analysis to determine where to place begin and
end instructions; in essence, determining whether a block contains or is
preceded by a begin instruction is similar to a specialized case of a
reaching definitions analysis, where we have only a single definition,
such as `bool has_begun = false`. For this simpler case, we can compute
the set of blocks using BFS to determine the reachability of the begin
instruction.
We need to do this for both begin and end instructions, so I have
generalized portions of the code to run both forward and backward over
the CFG for each respective case.
2023-09-27 19:54:10 -04:00
github-actions[bot]
48c97c1311
roll deps ( #5415 )
...
* Roll external/googletest/ adc514538..e47544ad3 (5 commits)
adc5145386...e47544ad3109de536bb7...26f7d889e1fc7d246276...79743b899f#380 )
2023-09-20 40001162+alelenv Add headers for SPV_NV_displacement_micromap. (#374 )
2023-09-20 fwahlster remove additional version "1.0" from SecondaryViewportRelativeNV (#379 )
Created with:
roll-dep external/spirv-headers
---------
Co-authored-by: GitHub Actions[bot] <>
2023-09-27 11:09:18 -04:00
Steven Perron
27673a0544
Remove reviewer from autoroller ( #5414 )
...
For some reason the `gh` command to create a pull request with a team as
the reviewer is not working. That command works when I run it locally. I
don't know what the problem is, but I will just stop adding a reviewer.
Then anyone can look at it.
2023-09-26 12:06:29 -04:00
Jeremy Gebben
ee7598d497
instrument: Use Import linkage for instrumentation functions ( #5355 )
...
These functions are getting far too complicated to code in SPIRV-Tools
C++. Replace them with import stubs so that the real implementations
can live in Vulkan-ValidationLayers where they belong.
VVL will need to define these functions in spirv and link them to the
instrumented version of the user's shader.
From here on out, VVL can redefine the functions and any data they use
without updating SPIRV-Tools. Changing the function declarations will
still require both VVL and SPIRV-Tools to be updated in lock step.
2023-09-20 10:50:30 -06:00
Steven Perron
a40483d313
roll deps ( #5408 )
...
* Roll external/googletest/ 8a6feabf0..adc514538 (7 commits)
8a6feabf04...adc5145386a807e8a3aa...09de536bb7
2023-09-20 04:29:21 +00:00
David Neto
a996591b1c
Update SPIRV-Headers, add cache control operand kinds ( #5406 )
...
* Update SPIRV-Headers, add cache control operand kinds
Adds SPV_OPERAND_TYPE_LOAD_CACHE_CONTROL
and SPV_OPERAND_TYPE_STORE_CACHE_CONTROL,
from SPV_INTEL_cache_controls
Fixes : #5404
* Update tests: remove Kernel from constant sampler enum dependencies
This corresponds to header change
https://github.com/KhronosGroup/SPIRV-Headers/pull/378
2023-09-13 17:43:12 -04:00
Steven Perron
fc54e178e9
Change autoroll pr review id ( #5404 )
...
The autoroll pr reviews add me as the reviewer. I want to change this so
that it requests a reveiw from a team instead.
2023-09-11 17:24:32 -07:00
André Cruz
2d6996f731
Check for git repository before git commands ( #5403 )
...
When we are attempting to fetch the version info from the git
repository, first check if we're actually in one, otherwise
spurious errors messages get printed.
2023-09-11 20:52:31 +00:00
Cassandra Beckley
361638cfd0
Make sure that fragment shader interlock instructions are not removed by DCE ( #5400 )
2023-09-11 15:26:10 -04:00
github-actions[bot]
5e6054c1cb
Roll external/re2/ e0077036c..a807e8a3a (6 commits) ( #5401 )
...
e0077036ca...a807e8a3aa
2023-09-11 18:37:12 +00:00
Nathan Gauër
47b63a4d7d
val: re-add ImageMSArray validation ( #5394 )
...
This has been removed in #4752 , but not added since.
* fixup! val: re-add ImageMSArray validation
clang-format
2023-09-07 09:39:28 -04:00
Steven Perron
d660bb55be
Add SPV_KHR_physical_storage_buffer to allowlists ( #5402 )
...
Fixes #4896
2023-09-06 16:35:57 +00:00
Steven Perron
440f018cc4
Fix AddMemberDecoration variable names. ( #5399 )
...
The prototype does not match the implementation.
Fixes Typo in declaration DecorationManager::AddMemberDecoration #5392
2023-09-05 19:38:49 +00:00
Nathan Gauër
4e0b94ed7a
opt: add ImageMSArray capability to trim pass. ( #5395 )
...
From the Capability's text in the SPIRV spec:
```
An MS operand in OpTypeImage indicates multisampled, used with an
OpTypeImage having Sampled == 2 and Arrayed == 1.
```
Adding this logic to the capability trimming pass.
2023-09-05 18:36:03 +00:00
Cassandra Beckley
d474a07088
Add SPV_EXT_fragment_shader_interlock to allow lists ( #5393 )
2023-09-05 12:10:16 -04:00
Nathan Gauër
1f07f483ef
opt: add raytracing/rayquery to trim pass ( #5397 )
...
Adds the RayTracingKHR and RayQueryKHR capabilities to
the supported capabilities list (this includes the linked extension).
(NV and KHR capabilities/extensions shared the same IDs, so it also
works for NV flavors of those).
2023-09-05 14:36:14 +00:00
github-actions[bot]
158bc7bd6b
Roll external/re2/ 523f9b097..e0077036c (2 commits) ( #5391 )
...
523f9b0971...e0077036ca
2023-09-05 14:32:00 +00:00
Nathan Gauër
1121c23198
opt: add Int64 capability to trim pass ( #5398 )
...
Adds support for Int64 capability trimming.
2023-09-05 09:47:46 -04:00
Nathan Gauër
3cc7e1c4c3
NFC: rename tests using capability as prefix ( #5396 )
2023-09-04 14:32:28 -07:00
Cassandra Beckley
4c16c35b16
opt: add FragmentShader*InterlockEXT to capability trim pass ( #5390 )
...
* opt: add FragmentShader*InterlockEXT to capability trim pass
* move to addInstructionRequirementsForOpcode
2023-09-04 11:27:56 +02:00
Mike Gorchak
9b923f7cc3
QNX has support for ANSI ESC codes, default terminal is QANSI. ( #5387 )
2023-08-30 14:51:03 -04:00
