AuroraMiddleware/SPIRV-Tools
1
0
Fork 0
mirror of https://github.com/KhronosGroup/SPIRV-Tools synced 2024-11-24 04:20:13 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,170 Commits 25 Branches 78 Tags 46 MiB
fb83b6fbb5
Commit Graph

2170 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ryan Harrison
6d20f62570
Refactor webgpu-mode pass ran tests to be parameterized (#2395) 
Fixes #2394
 2019-02-15 11:08:05 -05:00
Steven Perron
78ac954c41
Mark type id of unknown instructions at fully used. (#2399) 2019-02-15 10:49:49 -05:00
greg-lunarg
9540f2d981 Instrumentation: Fix instruction index when multiple functions (#2389) 2019-02-15 09:49:18 -05:00
Steven Perron
1b0047f210
Add pass to remove dead members. (#2379) 
Add a pass that looks for members of structs whose values do not affects
the output of the shader. Those members are then removed and just
treated like padding in the struct.
 2019-02-14 13:42:35 -05:00
Ryan Harrison
0167a20b0a
Move usage detection to after all instructions are registered (#2378) 
This is required to properly handle uses of forward declared ids. Since forward
declared ids were not being properly covered by the validator this uncovered a
bunch of small issues that needed to be resolved to get tests passing again.

Fixes #2373
 2019-02-13 14:06:56 -05:00
Takuto Ikuta
0187c190b5 Fix BUILD.gn (#2381) 
extensions_enum.inc is included from source/table.h.
So spvtools_core_enums_unified1 target should be in public_deps of
spvtools target.

This is for crbug.com/931596
 2019-02-13 10:24:06 -05:00
alan-baker
354205b3dc
Don't merge unreachable blocks (#2375) 
Fixes #2374

* Block merging no longer merges unreachable blocks into their
successors
 * added a test
 2019-02-12 09:24:01 -05:00
Paul Thomson
40a7940e05 Fix merge blocks opportunity to check if still enabled (#2370) 
Fix MergeBlocksReductionOpportunity so it checks whether it is still enabled

Fixes #2369. Added tests.
 2019-02-11 16:26:37 -05:00
Ryan Harrison
12b3d7e9d6 Add strip-debug to webgpu-mode passes (#2368) 
Fixes #2366
 2019-02-08 14:26:17 -05:00
Ryan Harrison
a0ff7c5120
Add better error message to ValidateInstructions (#2365) 
Fixes #2364
 2019-02-08 11:24:02 -05:00
Alastair Donaldson
34c5ac614c
Fixes #2358. Added to the reducer the ability to remove a function t… (#2361) 
* Fixes #2358.  Added to the reducer the ability to remove a function that is not directly called.  Factored out some code from the optimizer to help with this.
 2019-02-08 16:20:29 +00:00
dan sinclair
10a7def6c0
Smoketest should use KhronosGroup glslang (#2363) 2019-02-07 15:32:41 -05:00
dan sinclair
39bfb6b978
Make spvParseTargetEnv public (#2362) 
This CL moves the method to parse the SPIRV environment into the public headers. This will allow other applications to re-use the same parsing logic.
 2019-02-07 14:49:15 -05:00
greg-lunarg
cf21146137 Expand bindless bounds checking to runtime-sized descriptor arrays (#2316) 2019-02-07 14:00:36 -05:00
alan-baker
9b6ba4d1c5
Allow arrayed storage images for NonWritable decoration (#2358) 
Fixes #2354

* Storage image pointer registration allows optional level of arraying
* Added a test
 2019-02-06 15:20:19 -05:00
alan-baker
117a1fd11f
Validate variable pointer related function call rules (#2270) 
Fixes #2105

* Check storage class validity
* Check memory object declaration validity
 2019-02-06 14:10:40 -05:00
Ryan Harrison
0f4bf0720a
Add flatten-decorations flag to webgpu-mode flags (#2348) 
Fixes #2272
 2019-02-05 14:07:53 -05:00
Ryan Harrison
368567bc51
Convert deprecated GoogleTest fixture to the new version (#2357) 
Fixes #2356
 2019-02-05 10:33:55 -05:00
Alastair Donaldson
adbbe20241 Mention the reducer tool and location in the README. (#2341) 
* Mention the reducer tool and location in the README.

* Remark on how to get info on specifying interestingness.
 2019-02-04 09:41:38 -08:00
Dan Ginsburg
e3c64a374b Do not build spirv-reduce on iOS/tvOS/watchOS - it requires std::system which is not available on those platforms (#2355) 2019-02-04 09:39:39 -08:00
Alastair Donaldson
37861ac106
Merge blocks in reducer (#2353) 
Fixes #2120 

Enhanced the reducer so that it can merge blocks together, leveraging the functionality extracted from the block_merge pass in the optimizer.
 2019-02-01 14:56:54 +00:00
Steven Perron
453b7c85c8
Fix up some test (#2351) 
I made a mistake merging a PR, and it contained tests that break with
the latest google test.  I've fixed them up.
 2019-01-31 16:44:15 -05:00
Ryan Harrison
846d12afed
Add whitelist for decorations in WebGPU (#2346) 
Fixes #2273
 2019-01-31 16:25:46 -05:00
alan-baker
63e032f910
Remove unused lambda capture (#2350) 2019-01-31 15:57:45 -05:00
Alastair Donaldson
3b6fee3dae Fixes #2338. Added functionality to remove OpPhi instructions (replacing their uses) when merging blocks (#2339) 
* Fixes #2338.  Added check for phi node before merging blocks.

* Added functionality to merge blocks A and B even when B starts with OpPhi instructions, by replacing uses of the OpPhi results with the definitions coming from A.  Added some tests for this.

* Fixed assertion.
 2019-01-31 09:36:05 -05:00
Ryan Harrison
2acbf488b8
Add WebGPU specific validation for WorkgroupSize BuiltIn decoration (#2334) 
Part of resolving #2276
 2019-01-30 17:01:17 -05:00
Ryan Harrison
e2f4622627
Add WebGPU specific validation for multiple BuiltIn decorations (#2333) 
Covers NumWorkgroups, LocalInvocationId & GlobalInvocationId

Part of resolving #2276
 2019-01-30 17:00:58 -05:00
Ryan Harrison
3d2afb78c2
Add whitelist of allowed BuiltIn decorations for WebGPU (#2337) 
Part of resolving #2276
 2019-01-30 15:46:02 -05:00
Ryan Harrison
d17fcf8abd
Add WebGPU validation for LocalInvocationIndex BuiltIn decoration (#2335) 
Part of resolving #2276
 2019-01-30 15:45:31 -05:00
Ryan Harrison
837153ccdd
Add WebGPU specific validation for FragDepth BuiltIn decoration (#2332) 
Part of resolving #2276
 2019-01-30 15:27:04 -05:00
Ryan Harrison
0c14583f15
Add WebGPU specific validation for FragCoord BuiltIn decoration (#2331) 
Part of resolving #2276
 2019-01-30 14:53:43 -05:00
Ryan Harrison
b6698e0d83
Add WebGPU specific validation for FrontFacing BuiltIn decoration (#2330) 
Part of resolving #2276
 2019-01-30 14:48:43 -05:00
Ryan Harrison
734def1447
Add WebGPU specific validation for InstanceIndex BuiltIn decoration (#2329) 
Part of resolving #2276
 2019-01-30 14:20:55 -05:00
Ryan Harrison
b947ecfe79
Add WebGPU specific validation for VertexIndex BuiltIn decoration (#2328) 
Part of resolving #2276
 2019-01-30 12:22:30 -05:00
Steven Perron
464111eaef
Remove use of deprecated googletest macro (#2286) 
* Remove use of deprecated googletest macro

INSTANTIATE_TEST_CASE_P has been deprecated.  We need to use
INSTANTIATE_TEST_SUITE_P instead.

* Remove extra commas from test suites.
 2019-01-29 18:56:52 -05:00
Jeff Bolz
7f1a020abc Fix test_val_limits MSVC build (#2347) 2019-01-29 13:29:58 -05:00
Ryan Harrison
5d6b4c4b1b
Move CodeGenerator to be accessible by other validation tests (#2343) 
Fixes #2342
 2019-01-29 10:27:11 -05:00
David Neto
cf78346230 Add source/opt/block_merge_util.* to BUILD.gn (#2344) 2019-01-28 21:42:35 -05:00
David Neto
7f3679a8b6
Validate NonWritable decoration (#2263) 
Also permit NonWritable on members of structs used for UBO and SSBO.
(That seems inadvertently removed in recent revisions of the spec.)
 2019-01-28 12:44:13 -08:00
Steven Perron
9ab1c0ddd0
Remove code sinking for -O. (#2340) 
Community feedback says it is not generaly benificial, so we will remove
it from the standard optimization set.
 2019-01-28 11:50:50 -05:00
Alastair Donaldson
98c67d3850 Fixed names in ifdefs and GetName functions that had been forgotten in a previous refactoring. Also shortened names of test files as those files test both the new 'finder' classes introduced in the refactoring, as well as the 'reduction pass' class; the shorter names capture both. (#2336) 2019-01-25 11:37:03 -05:00
Alastair Donaldson
3345fe6a9d
Extracted block merging functionality into its own utility file (#2325) 
* Extracted useful functionality from block merger and exposed it as stand-alone methods.

* Separated these methods into a utility file.
 2019-01-25 10:57:13 +00:00
alan-baker
cf011f9901 More layout check fixes (#2315) 
* check array strides for multidimensional arrays
* check layouts of structs in arrays for multiple indices
* new tests
 2019-01-24 14:24:31 -08:00
Steven Perron
e2279da714
Remove the static maps from CheckDecorationsCompatibility (#2327) 
* Remove the static maps from CheckDecorationsCompatibility

There are a few data structures in the function
`CheckDecorationsCompatibility` that are allocated using `new` and their
address is stored in a static pointer.  This code pattern causes the
MSVC memory leak checker to say there is a memory leak.  Some people
are interested in keeping that clean.

To work around it, I have replaced them with either a function or an
array of POD types.  The array can be kept as a static directly because
it has a trivial destructor, and we don't have to worry about it being
destroyed too early.

Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/2317.
 2019-01-24 14:50:58 -05:00
JasperNV
8915a7c8f1 spirv-val: Emit an error when an OpSwitch target is not an OpLabel (#2298) 
Fixes #1628.

* spirv-val: Emit an error when an OpBranch target is not an OpLabel
 2019-01-24 12:11:49 -05:00
Ryan Harrison
1e3c589a6d
Add WebGPU specific validation for Position BuiltIn decoration (#2309) 
This CL adds in the specific checks required for WebGPU, enables
running the builtin checks for WebGPU, and refactors the existing
testing infrastructure to support testing the new checks.

This PR is part of resolving #2276
 2019-01-24 12:08:25 -05:00
fjhenigman
20b2e2b9f5
Add SpirvTools::IsValid(). (#2326) 
* Add SpirvTools::IsValid().

Add a method to determine if a SpirvTools object was successfully
constructed and can be used.  It might not be depending on the parameter
to the constructor.
This is something a fuzzer wants to know before trying to use an
SpirvTools object constructed with a fuzzed parameter.
 2019-01-24 09:45:09 -05:00
Alastair Donaldson
86d0d9be25 Refactored reducer so that the 'finding' functionality of a reduction pass are separated from the generic functionality for tracking progress of a pass. With this change, we now have a ReductionOpportunityFinder abstract class, with many subclasses for each type of reduction, and just one ReductionPass class, which has an associated finder. (#2321) 
Sounds good.
 2019-01-23 17:07:58 -05:00
Ryan Harrison
b1be6763f6
Add helper for 'is Vulkan or WebGPU' (#2324) 
Fixes #2323
 2019-01-23 13:07:03 -05:00
Alastair Donaldson
3d71024248 Added some documentation about the reducer. (#2318) 2019-01-23 12:29:14 -05:00