mirror of
https://github.com/KhronosGroup/SPIRV-Tools
synced 2024-10-18 11:10:05 +00:00
edaf51038b
* linker: Recalculate interface variables By resolving extern symbols Entry Points might access variables they hadn't declared before. * test/linker: add test to verify linked spir-vs importing functions validate Without the fix Validate will complain about: "ERROR: 9: Interface variable id <5> is used by entry point 'bar' id <1>, but is not listed as an interface\n %5 = OpVariable %_ptr_Input_v3uint Input\n"
152 lines
3.8 KiB
C++
152 lines
3.8 KiB
C++
// Copyright (c) 2017 Pierre Moreau
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include <string>
|
|
|
|
#include "gmock/gmock.h"
|
|
#include "test/link/linker_fixture.h"
|
|
|
|
namespace spvtools {
|
|
namespace {
|
|
|
|
using ::testing::HasSubstr;
|
|
|
|
class EntryPoints : public spvtest::LinkerTest {};
|
|
|
|
TEST_F(EntryPoints, SameModelDifferentName) {
|
|
const std::string body1 = R"(
|
|
OpCapability Shader
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint GLCompute %3 "foo"
|
|
%1 = OpTypeVoid
|
|
%2 = OpTypeFunction %1
|
|
%3 = OpFunction %1 None %2
|
|
OpFunctionEnd
|
|
)";
|
|
const std::string body2 = R"(
|
|
OpCapability Shader
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint GLCompute %3 "bar"
|
|
%1 = OpTypeVoid
|
|
%2 = OpTypeFunction %1
|
|
%3 = OpFunction %1 None %2
|
|
OpFunctionEnd
|
|
)";
|
|
|
|
spvtest::Binary linked_binary;
|
|
ASSERT_EQ(SPV_SUCCESS, AssembleAndLink({body1, body2}, &linked_binary))
|
|
<< GetErrorMessage();
|
|
EXPECT_THAT(GetErrorMessage(), std::string());
|
|
}
|
|
|
|
TEST_F(EntryPoints, DifferentModelSameName) {
|
|
const std::string body1 = R"(
|
|
OpCapability Shader
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint GLCompute %3 "foo"
|
|
%1 = OpTypeVoid
|
|
%2 = OpTypeFunction %1
|
|
%3 = OpFunction %1 None %2
|
|
OpFunctionEnd
|
|
)";
|
|
const std::string body2 = R"(
|
|
OpCapability Shader
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint Vertex %3 "foo"
|
|
%1 = OpTypeVoid
|
|
%2 = OpTypeFunction %1
|
|
%3 = OpFunction %1 None %2
|
|
OpFunctionEnd
|
|
)";
|
|
|
|
spvtest::Binary linked_binary;
|
|
ASSERT_EQ(SPV_SUCCESS, AssembleAndLink({body1, body2}, &linked_binary))
|
|
<< GetErrorMessage();
|
|
EXPECT_THAT(GetErrorMessage(), std::string());
|
|
}
|
|
|
|
TEST_F(EntryPoints, SameModelAndName) {
|
|
const std::string body1 = R"(
|
|
OpCapability Shader
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint GLCompute %3 "foo"
|
|
%1 = OpTypeVoid
|
|
%2 = OpTypeFunction %1
|
|
%3 = OpFunction %1 None %2
|
|
OpFunctionEnd
|
|
)";
|
|
const std::string body2 = R"(
|
|
OpCapability Shader
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint GLCompute %3 "foo"
|
|
%1 = OpTypeVoid
|
|
%2 = OpTypeFunction %1
|
|
%3 = OpFunction %1 None %2
|
|
OpFunctionEnd
|
|
)";
|
|
|
|
spvtest::Binary linked_binary;
|
|
EXPECT_EQ(SPV_ERROR_INTERNAL,
|
|
AssembleAndLink({body1, body2}, &linked_binary));
|
|
EXPECT_THAT(GetErrorMessage(),
|
|
HasSubstr("The entry point \"foo\", with execution model "
|
|
"GLCompute, was already defined."));
|
|
}
|
|
|
|
TEST_F(EntryPoints, LinkedVariables) {
|
|
const std::string body1 = R"(
|
|
OpCapability Addresses
|
|
OpCapability Linkage
|
|
OpCapability Kernel
|
|
OpMemoryModel Physical64 OpenCL
|
|
OpDecorate %7 LinkageAttributes "foo" Export
|
|
%1 = OpTypeInt 32 0
|
|
%2 = OpTypeVector %1 3
|
|
%3 = OpTypePointer Input %2
|
|
%4 = OpVariable %3 Input
|
|
%5 = OpTypeVoid
|
|
%6 = OpTypeFunction %5
|
|
%7 = OpFunction %5 None %6
|
|
%8 = OpLabel
|
|
%9 = OpLoad %2 %4 Aligned 32
|
|
OpReturn
|
|
OpFunctionEnd
|
|
)";
|
|
const std::string body2 = R"(
|
|
OpCapability Linkage
|
|
OpCapability Kernel
|
|
OpMemoryModel Physical64 OpenCL
|
|
OpEntryPoint Kernel %4 "bar"
|
|
OpDecorate %3 LinkageAttributes "foo" Import
|
|
%1 = OpTypeVoid
|
|
%2 = OpTypeFunction %1
|
|
%3 = OpFunction %1 None %2
|
|
OpFunctionEnd
|
|
%4 = OpFunction %1 None %2
|
|
%5 = OpLabel
|
|
%6 = OpFunctionCall %1 %3
|
|
OpReturn
|
|
OpFunctionEnd
|
|
)";
|
|
|
|
spvtest::Binary linked_binary;
|
|
EXPECT_EQ(SPV_SUCCESS, AssembleAndLink({body1, body2}, &linked_binary));
|
|
EXPECT_THAT(GetErrorMessage(), std::string());
|
|
EXPECT_TRUE(Validate(linked_binary));
|
|
EXPECT_THAT(GetErrorMessage(), std::string());
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace spvtools
|