mirror of
https://github.com/KhronosGroup/SPIRV-Tools
synced 2024-10-18 19:20:05 +00:00
8d4261bc44
Some transformations (e.g. TransformationAddFunction) rely on running the validator to decide whether the transformation is applicable. A recent change allowed spirv-fuzz to take validator options, to cater for the case where a module should be considered valid under particular conditions. However, validation during the checking of transformations had no access to these validator options. This change introduced TransformationContext, which currently consists of a fact manager and a set of validator options, but could in the future have other fields corresponding to other objects that it is useful to have access to when applying transformations. Now, instead of checking and applying transformations in the context of a FactManager, a TransformationContext is used. This gives access to the fact manager as before, and also access to the validator options when they are needed.
150 lines
5.5 KiB
C++
150 lines
5.5 KiB
C++
// Copyright (c) 2019 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "source/fuzz/transformation_add_constant_boolean.h"
|
|
#include "test/fuzz/fuzz_test_util.h"
|
|
|
|
namespace spvtools {
|
|
namespace fuzz {
|
|
namespace {
|
|
|
|
TEST(TransformationAddConstantBooleanTest, NeitherPresentInitiallyAddBoth) {
|
|
std::string shader = R"(
|
|
OpCapability Shader
|
|
%1 = OpExtInstImport "GLSL.std.450"
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint Fragment %4 "main"
|
|
OpExecutionMode %4 OriginUpperLeft
|
|
OpSource ESSL 310
|
|
OpName %4 "main"
|
|
%2 = OpTypeVoid
|
|
%6 = OpTypeBool
|
|
%3 = OpTypeFunction %2
|
|
%4 = OpFunction %2 None %3
|
|
%5 = OpLabel
|
|
OpReturn
|
|
OpFunctionEnd
|
|
)";
|
|
|
|
const auto env = SPV_ENV_UNIVERSAL_1_3;
|
|
const auto consumer = nullptr;
|
|
const auto context = BuildModule(env, consumer, shader, kFuzzAssembleOption);
|
|
ASSERT_TRUE(IsValid(env, context.get()));
|
|
|
|
FactManager fact_manager;
|
|
spvtools::ValidatorOptions validator_options;
|
|
TransformationContext transformation_context(&fact_manager,
|
|
validator_options);
|
|
|
|
// True and false can both be added as neither is present.
|
|
ASSERT_TRUE(TransformationAddConstantBoolean(7, true).IsApplicable(
|
|
context.get(), transformation_context));
|
|
ASSERT_TRUE(TransformationAddConstantBoolean(7, false).IsApplicable(
|
|
context.get(), transformation_context));
|
|
|
|
// Id 5 is already taken.
|
|
ASSERT_FALSE(TransformationAddConstantBoolean(5, true).IsApplicable(
|
|
context.get(), transformation_context));
|
|
|
|
auto add_true = TransformationAddConstantBoolean(7, true);
|
|
auto add_false = TransformationAddConstantBoolean(8, false);
|
|
|
|
ASSERT_TRUE(add_true.IsApplicable(context.get(), transformation_context));
|
|
add_true.Apply(context.get(), &transformation_context);
|
|
ASSERT_TRUE(IsValid(env, context.get()));
|
|
|
|
// Having added true, we cannot add it again with the same id.
|
|
ASSERT_FALSE(add_true.IsApplicable(context.get(), transformation_context));
|
|
// But we can add it with a different id.
|
|
auto add_true_again = TransformationAddConstantBoolean(100, true);
|
|
ASSERT_TRUE(
|
|
add_true_again.IsApplicable(context.get(), transformation_context));
|
|
add_true_again.Apply(context.get(), &transformation_context);
|
|
ASSERT_TRUE(IsValid(env, context.get()));
|
|
|
|
ASSERT_TRUE(add_false.IsApplicable(context.get(), transformation_context));
|
|
add_false.Apply(context.get(), &transformation_context);
|
|
ASSERT_TRUE(IsValid(env, context.get()));
|
|
|
|
// Having added false, we cannot add it again with the same id.
|
|
ASSERT_FALSE(add_false.IsApplicable(context.get(), transformation_context));
|
|
// But we can add it with a different id.
|
|
auto add_false_again = TransformationAddConstantBoolean(101, false);
|
|
ASSERT_TRUE(
|
|
add_false_again.IsApplicable(context.get(), transformation_context));
|
|
add_false_again.Apply(context.get(), &transformation_context);
|
|
ASSERT_TRUE(IsValid(env, context.get()));
|
|
|
|
std::string after_transformation = R"(
|
|
OpCapability Shader
|
|
%1 = OpExtInstImport "GLSL.std.450"
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint Fragment %4 "main"
|
|
OpExecutionMode %4 OriginUpperLeft
|
|
OpSource ESSL 310
|
|
OpName %4 "main"
|
|
%2 = OpTypeVoid
|
|
%6 = OpTypeBool
|
|
%3 = OpTypeFunction %2
|
|
%7 = OpConstantTrue %6
|
|
%100 = OpConstantTrue %6
|
|
%8 = OpConstantFalse %6
|
|
%101 = OpConstantFalse %6
|
|
%4 = OpFunction %2 None %3
|
|
%5 = OpLabel
|
|
OpReturn
|
|
OpFunctionEnd
|
|
)";
|
|
|
|
ASSERT_TRUE(IsEqual(env, after_transformation, context.get()));
|
|
}
|
|
|
|
TEST(TransformationAddConstantBooleanTest, NoOpTypeBoolPresent) {
|
|
std::string shader = R"(
|
|
OpCapability Shader
|
|
%1 = OpExtInstImport "GLSL.std.450"
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint Fragment %4 "main"
|
|
OpExecutionMode %4 OriginUpperLeft
|
|
OpSource ESSL 310
|
|
OpName %4 "main"
|
|
%2 = OpTypeVoid
|
|
%3 = OpTypeFunction %2
|
|
%4 = OpFunction %2 None %3
|
|
%5 = OpLabel
|
|
OpReturn
|
|
OpFunctionEnd
|
|
)";
|
|
|
|
const auto env = SPV_ENV_UNIVERSAL_1_3;
|
|
const auto consumer = nullptr;
|
|
const auto context = BuildModule(env, consumer, shader, kFuzzAssembleOption);
|
|
ASSERT_TRUE(IsValid(env, context.get()));
|
|
|
|
FactManager fact_manager;
|
|
spvtools::ValidatorOptions validator_options;
|
|
TransformationContext transformation_context(&fact_manager,
|
|
validator_options);
|
|
|
|
// Neither true nor false can be added as OpTypeBool is not present.
|
|
ASSERT_FALSE(TransformationAddConstantBoolean(6, true).IsApplicable(
|
|
context.get(), transformation_context));
|
|
ASSERT_FALSE(TransformationAddConstantBoolean(6, false).IsApplicable(
|
|
context.get(), transformation_context));
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace fuzz
|
|
} // namespace spvtools
|