mirror of
https://github.com/KhronosGroup/SPIRV-Tools
synced 2024-11-24 04:20:13 +00:00
972788bf23
Previously the opcode table is declared as an global array and we have spvOpcodeTableInitialize() modifying it. That can result in race condition. Now spvOpcodeTabelGet() copies the whole underlying array.
112 lines
3.7 KiB
C++
112 lines
3.7 KiB
C++
// Copyright (c) 2015 The Khronos Group Inc.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and/or associated documentation files (the
|
|
// "Materials"), to deal in the Materials without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Materials, and to
|
|
// permit persons to whom the Materials are furnished to do so, subject to
|
|
// the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Materials.
|
|
//
|
|
// MODIFICATIONS TO THIS FILE MAY MEAN IT NO LONGER ACCURATELY REFLECTS
|
|
// KHRONOS STANDARDS. THE UNMODIFIED, NORMATIVE VERSIONS OF KHRONOS
|
|
// SPECIFICATIONS AND HEADER INFORMATION ARE LOCATED AT
|
|
// https://www.khronos.org/registry/
|
|
//
|
|
// THE MATERIALS ARE PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
// EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
|
|
// IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
|
|
// CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
|
|
// TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
|
|
// MATERIALS OR THE USE OR OTHER DEALINGS IN THE MATERIALS.
|
|
|
|
#include "UnitSPIRV.h"
|
|
|
|
namespace {
|
|
|
|
class Validate : public ::testing::Test {
|
|
public:
|
|
Validate() : context(spvContextCreate()), binary() {}
|
|
~Validate() { spvContextDestroy(context); }
|
|
|
|
virtual void TearDown() { spvBinaryDestroy(binary); }
|
|
spv_const_binary get_const_binary() { return spv_const_binary(binary); }
|
|
|
|
spv_context context;
|
|
spv_binary binary;
|
|
};
|
|
|
|
TEST_F(Validate, DISABLED_Default) {
|
|
char str[] = R"(
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint GLCompute 1 ""
|
|
OpExecutionMode 1 LocalSize 1 1 1
|
|
OpTypeVoid 2
|
|
OpTypeFunction 3 2
|
|
OpFunction 2 1 NoControl 3
|
|
OpLabel 4
|
|
OpReturn
|
|
OpFunctionEnd
|
|
)";
|
|
spv_diagnostic diagnostic = nullptr;
|
|
ASSERT_EQ(SPV_SUCCESS,
|
|
spvTextToBinary(context, str, strlen(str), &binary, &diagnostic));
|
|
ASSERT_EQ(SPV_SUCCESS, spvValidate(context, get_const_binary(),
|
|
SPV_VALIDATE_ALL, &diagnostic));
|
|
if (diagnostic) {
|
|
spvDiagnosticPrint(diagnostic);
|
|
spvDiagnosticDestroy(diagnostic);
|
|
}
|
|
}
|
|
|
|
TEST_F(Validate, DISABLED_InvalidIdUndefined) {
|
|
char str[] = R"(
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint GLCompute 1 ""
|
|
OpExecutionMode 5 LocalSize 1 1 1
|
|
OpTypeVoid 2
|
|
OpTypeFunction 3 2
|
|
OpFunction 2 1 NoControl 3
|
|
OpLabel 4
|
|
OpReturn
|
|
OpFunctionEnd
|
|
)";
|
|
spv_diagnostic diagnostic = nullptr;
|
|
ASSERT_EQ(SPV_SUCCESS,
|
|
spvTextToBinary(context, str, strlen(str), &binary, &diagnostic));
|
|
ASSERT_EQ(SPV_ERROR_INVALID_ID, spvValidate(context, get_const_binary(),
|
|
SPV_VALIDATE_ALL, &diagnostic));
|
|
ASSERT_NE(nullptr, diagnostic);
|
|
spvDiagnosticPrint(diagnostic);
|
|
spvDiagnosticDestroy(diagnostic);
|
|
}
|
|
|
|
TEST_F(Validate, DISABLED_InvalidIdRedefined) {
|
|
char str[] = R"(
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint GLCompute 1 ""
|
|
OpExecutionMode 1 LocalSize 1 1 1
|
|
OpTypeVoid 2
|
|
OpTypeFunction 2 2
|
|
OpFunction 2 1 NoControl 3
|
|
OpLabel 4
|
|
OpReturn
|
|
OpFunctionEnd
|
|
)";
|
|
spv_diagnostic diagnostic = nullptr;
|
|
ASSERT_EQ(SPV_SUCCESS,
|
|
spvTextToBinary(context, str, strlen(str), &binary, &diagnostic));
|
|
// TODO: Fix setting of bound in spvTextTo, then remove this!
|
|
ASSERT_EQ(SPV_ERROR_INVALID_ID, spvValidate(context, get_const_binary(),
|
|
SPV_VALIDATE_ALL, &diagnostic));
|
|
ASSERT_NE(nullptr, diagnostic);
|
|
spvDiagnosticPrint(diagnostic);
|
|
spvDiagnosticDestroy(diagnostic);
|
|
}
|
|
|
|
} // anonymous namespace
|