mirror of
https://github.com/KhronosGroup/SPIRV-Tools
synced 2024-12-01 15:30:06 +00:00
d35a78db57
Fixes #4960 * Switches to using enum classes with an underlying type to avoid undefined behaviour
657 lines
26 KiB
C++
657 lines
26 KiB
C++
// Copyright (c) 2019 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "source/fuzz/transformation_composite_extract.h"
|
|
|
|
#include "gtest/gtest.h"
|
|
#include "source/fuzz/fuzzer_util.h"
|
|
#include "source/fuzz/instruction_descriptor.h"
|
|
#include "test/fuzz/fuzz_test_util.h"
|
|
|
|
namespace spvtools {
|
|
namespace fuzz {
|
|
namespace {
|
|
|
|
TEST(TransformationCompositeExtractTest, BasicTest) {
|
|
std::string shader = R"(
|
|
OpCapability Shader
|
|
%1 = OpExtInstImport "GLSL.std.450"
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint Fragment %4 "main"
|
|
OpExecutionMode %4 OriginUpperLeft
|
|
OpSource ESSL 310
|
|
OpName %4 "main"
|
|
OpName %8 "a"
|
|
OpName %10 "b"
|
|
OpName %17 "FunnyPoint"
|
|
OpMemberName %17 0 "x"
|
|
OpMemberName %17 1 "y"
|
|
OpMemberName %17 2 "z"
|
|
OpName %19 "p"
|
|
%2 = OpTypeVoid
|
|
%3 = OpTypeFunction %2
|
|
%6 = OpTypeInt 32 1
|
|
%7 = OpTypePointer Function %6
|
|
%12 = OpTypeBool
|
|
%16 = OpTypeFloat 32
|
|
%17 = OpTypeStruct %16 %16 %6
|
|
%81 = OpTypeStruct %17 %16
|
|
%18 = OpTypePointer Function %17
|
|
%20 = OpConstant %6 0
|
|
%23 = OpTypePointer Function %16
|
|
%26 = OpConstant %6 1
|
|
%30 = OpConstant %6 2
|
|
%80 = OpUndef %16
|
|
%4 = OpFunction %2 None %3
|
|
%5 = OpLabel
|
|
%8 = OpVariable %7 Function
|
|
%10 = OpVariable %7 Function
|
|
%19 = OpVariable %18 Function
|
|
%9 = OpLoad %6 %8
|
|
%11 = OpLoad %6 %10
|
|
%100 = OpCompositeConstruct %17 %80 %80 %26
|
|
%104 = OpCompositeConstruct %81 %100 %80
|
|
%13 = OpIEqual %12 %9 %11
|
|
OpSelectionMerge %15 None
|
|
OpBranchConditional %13 %14 %25
|
|
%14 = OpLabel
|
|
%21 = OpLoad %6 %8
|
|
%22 = OpConvertSToF %16 %21
|
|
%101 = OpCompositeConstruct %17 %22 %80 %30
|
|
%24 = OpAccessChain %23 %19 %20
|
|
OpStore %24 %22
|
|
OpBranch %15
|
|
%25 = OpLabel
|
|
%27 = OpLoad %6 %10
|
|
%28 = OpConvertSToF %16 %27
|
|
%102 = OpCompositeConstruct %17 %80 %28 %27
|
|
%29 = OpAccessChain %23 %19 %26
|
|
OpStore %29 %28
|
|
OpBranch %15
|
|
%15 = OpLabel
|
|
%31 = OpAccessChain %23 %19 %20
|
|
%32 = OpLoad %16 %31
|
|
%33 = OpAccessChain %23 %19 %26
|
|
%34 = OpLoad %16 %33
|
|
%103 = OpCompositeConstruct %17 %34 %32 %9
|
|
%35 = OpFAdd %16 %32 %34
|
|
%36 = OpConvertFToS %6 %35
|
|
%37 = OpAccessChain %7 %19 %30
|
|
OpStore %37 %36
|
|
OpReturn
|
|
OpFunctionEnd
|
|
)";
|
|
|
|
const auto env = SPV_ENV_UNIVERSAL_1_4;
|
|
const auto consumer = nullptr;
|
|
const auto context = BuildModule(env, consumer, shader, kFuzzAssembleOption);
|
|
spvtools::ValidatorOptions validator_options;
|
|
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
|
|
kConsoleMessageConsumer));
|
|
TransformationContext transformation_context(
|
|
MakeUnique<FactManager>(context.get()), validator_options);
|
|
// Instruction does not exist.
|
|
ASSERT_FALSE(
|
|
TransformationCompositeExtract(
|
|
MakeInstructionDescriptor(36, spv::Op::OpIAdd, 0), 200, 101, {0})
|
|
.IsApplicable(context.get(), transformation_context));
|
|
|
|
// Id for composite is not a composite.
|
|
ASSERT_FALSE(
|
|
TransformationCompositeExtract(
|
|
MakeInstructionDescriptor(37, spv::Op::OpAccessChain, 0), 200, 32, {})
|
|
.IsApplicable(context.get(), transformation_context));
|
|
|
|
// Composite does not dominate instruction being inserted before.
|
|
ASSERT_FALSE(TransformationCompositeExtract(
|
|
MakeInstructionDescriptor(37, spv::Op::OpAccessChain, 0),
|
|
200, 101, {0})
|
|
.IsApplicable(context.get(), transformation_context));
|
|
|
|
// Too many indices for extraction from struct composite.
|
|
ASSERT_FALSE(TransformationCompositeExtract(
|
|
MakeInstructionDescriptor(24, spv::Op::OpAccessChain, 0),
|
|
200, 101, {0, 0})
|
|
.IsApplicable(context.get(), transformation_context));
|
|
|
|
// Too many indices for extraction from struct composite.
|
|
ASSERT_FALSE(TransformationCompositeExtract(
|
|
MakeInstructionDescriptor(13, spv::Op::OpIEqual, 0), 200,
|
|
104, {0, 0, 0})
|
|
.IsApplicable(context.get(), transformation_context));
|
|
|
|
// Out of bounds index for extraction from struct composite.
|
|
ASSERT_FALSE(
|
|
TransformationCompositeExtract(
|
|
MakeInstructionDescriptor(13, spv::Op::OpIEqual, 0), 200, 104, {0, 3})
|
|
.IsApplicable(context.get(), transformation_context));
|
|
|
|
// Result id already used.
|
|
ASSERT_FALSE(
|
|
TransformationCompositeExtract(
|
|
MakeInstructionDescriptor(35, spv::Op::OpFAdd, 0), 80, 103, {0})
|
|
.IsApplicable(context.get(), transformation_context));
|
|
|
|
TransformationCompositeExtract transformation_1(
|
|
MakeInstructionDescriptor(36, spv::Op::OpConvertFToS, 0), 201, 100, {2});
|
|
ASSERT_EQ(nullptr, context->get_def_use_mgr()->GetDef(201));
|
|
ASSERT_EQ(nullptr, context->get_instr_block(201));
|
|
uint32_t num_uses_of_100_before = context->get_def_use_mgr()->NumUses(100);
|
|
ASSERT_TRUE(
|
|
transformation_1.IsApplicable(context.get(), transformation_context));
|
|
ApplyAndCheckFreshIds(transformation_1, context.get(),
|
|
&transformation_context);
|
|
ASSERT_EQ(spv::Op::OpCompositeExtract,
|
|
context->get_def_use_mgr()->GetDef(201)->opcode());
|
|
ASSERT_EQ(15, context->get_instr_block(201)->id());
|
|
ASSERT_EQ(num_uses_of_100_before + 1,
|
|
context->get_def_use_mgr()->NumUses(100));
|
|
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
|
|
kConsoleMessageConsumer));
|
|
|
|
TransformationCompositeExtract transformation_2(
|
|
MakeInstructionDescriptor(37, spv::Op::OpAccessChain, 0), 202, 104,
|
|
{0, 2});
|
|
ASSERT_TRUE(
|
|
transformation_2.IsApplicable(context.get(), transformation_context));
|
|
ApplyAndCheckFreshIds(transformation_2, context.get(),
|
|
&transformation_context);
|
|
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
|
|
kConsoleMessageConsumer));
|
|
|
|
TransformationCompositeExtract transformation_3(
|
|
MakeInstructionDescriptor(29, spv::Op::OpAccessChain, 0), 203, 104, {0});
|
|
ASSERT_TRUE(
|
|
transformation_3.IsApplicable(context.get(), transformation_context));
|
|
ApplyAndCheckFreshIds(transformation_3, context.get(),
|
|
&transformation_context);
|
|
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
|
|
kConsoleMessageConsumer));
|
|
|
|
TransformationCompositeExtract transformation_4(
|
|
MakeInstructionDescriptor(24, spv::Op::OpStore, 0), 204, 101, {0});
|
|
ASSERT_TRUE(
|
|
transformation_4.IsApplicable(context.get(), transformation_context));
|
|
ApplyAndCheckFreshIds(transformation_4, context.get(),
|
|
&transformation_context);
|
|
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
|
|
kConsoleMessageConsumer));
|
|
|
|
TransformationCompositeExtract transformation_5(
|
|
MakeInstructionDescriptor(29, spv::Op::OpBranch, 0), 205, 102, {2});
|
|
ASSERT_TRUE(
|
|
transformation_5.IsApplicable(context.get(), transformation_context));
|
|
ApplyAndCheckFreshIds(transformation_5, context.get(),
|
|
&transformation_context);
|
|
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
|
|
kConsoleMessageConsumer));
|
|
|
|
TransformationCompositeExtract transformation_6(
|
|
MakeInstructionDescriptor(37, spv::Op::OpReturn, 0), 206, 103, {1});
|
|
ASSERT_TRUE(
|
|
transformation_6.IsApplicable(context.get(), transformation_context));
|
|
ApplyAndCheckFreshIds(transformation_6, context.get(),
|
|
&transformation_context);
|
|
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
|
|
kConsoleMessageConsumer));
|
|
|
|
ASSERT_TRUE(transformation_context.GetFactManager()->IsSynonymous(
|
|
MakeDataDescriptor(201, {}), MakeDataDescriptor(100, {2})));
|
|
ASSERT_TRUE(transformation_context.GetFactManager()->IsSynonymous(
|
|
MakeDataDescriptor(202, {}), MakeDataDescriptor(104, {0, 2})));
|
|
ASSERT_TRUE(transformation_context.GetFactManager()->IsSynonymous(
|
|
MakeDataDescriptor(203, {}), MakeDataDescriptor(104, {0})));
|
|
ASSERT_TRUE(transformation_context.GetFactManager()->IsSynonymous(
|
|
MakeDataDescriptor(204, {}), MakeDataDescriptor(101, {0})));
|
|
ASSERT_TRUE(transformation_context.GetFactManager()->IsSynonymous(
|
|
MakeDataDescriptor(205, {}), MakeDataDescriptor(102, {2})));
|
|
ASSERT_TRUE(transformation_context.GetFactManager()->IsSynonymous(
|
|
MakeDataDescriptor(206, {}), MakeDataDescriptor(103, {1})));
|
|
|
|
std::string after_transformation = R"(
|
|
OpCapability Shader
|
|
%1 = OpExtInstImport "GLSL.std.450"
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint Fragment %4 "main"
|
|
OpExecutionMode %4 OriginUpperLeft
|
|
OpSource ESSL 310
|
|
OpName %4 "main"
|
|
OpName %8 "a"
|
|
OpName %10 "b"
|
|
OpName %17 "FunnyPoint"
|
|
OpMemberName %17 0 "x"
|
|
OpMemberName %17 1 "y"
|
|
OpMemberName %17 2 "z"
|
|
OpName %19 "p"
|
|
%2 = OpTypeVoid
|
|
%3 = OpTypeFunction %2
|
|
%6 = OpTypeInt 32 1
|
|
%7 = OpTypePointer Function %6
|
|
%12 = OpTypeBool
|
|
%16 = OpTypeFloat 32
|
|
%17 = OpTypeStruct %16 %16 %6
|
|
%81 = OpTypeStruct %17 %16
|
|
%18 = OpTypePointer Function %17
|
|
%20 = OpConstant %6 0
|
|
%23 = OpTypePointer Function %16
|
|
%26 = OpConstant %6 1
|
|
%30 = OpConstant %6 2
|
|
%80 = OpUndef %16
|
|
%4 = OpFunction %2 None %3
|
|
%5 = OpLabel
|
|
%8 = OpVariable %7 Function
|
|
%10 = OpVariable %7 Function
|
|
%19 = OpVariable %18 Function
|
|
%9 = OpLoad %6 %8
|
|
%11 = OpLoad %6 %10
|
|
%100 = OpCompositeConstruct %17 %80 %80 %26
|
|
%104 = OpCompositeConstruct %81 %100 %80
|
|
%13 = OpIEqual %12 %9 %11
|
|
OpSelectionMerge %15 None
|
|
OpBranchConditional %13 %14 %25
|
|
%14 = OpLabel
|
|
%21 = OpLoad %6 %8
|
|
%22 = OpConvertSToF %16 %21
|
|
%101 = OpCompositeConstruct %17 %22 %80 %30
|
|
%24 = OpAccessChain %23 %19 %20
|
|
%204 = OpCompositeExtract %16 %101 0
|
|
OpStore %24 %22
|
|
OpBranch %15
|
|
%25 = OpLabel
|
|
%27 = OpLoad %6 %10
|
|
%28 = OpConvertSToF %16 %27
|
|
%102 = OpCompositeConstruct %17 %80 %28 %27
|
|
%203 = OpCompositeExtract %17 %104 0
|
|
%29 = OpAccessChain %23 %19 %26
|
|
OpStore %29 %28
|
|
%205 = OpCompositeExtract %6 %102 2
|
|
OpBranch %15
|
|
%15 = OpLabel
|
|
%31 = OpAccessChain %23 %19 %20
|
|
%32 = OpLoad %16 %31
|
|
%33 = OpAccessChain %23 %19 %26
|
|
%34 = OpLoad %16 %33
|
|
%103 = OpCompositeConstruct %17 %34 %32 %9
|
|
%35 = OpFAdd %16 %32 %34
|
|
%201 = OpCompositeExtract %6 %100 2
|
|
%36 = OpConvertFToS %6 %35
|
|
%202 = OpCompositeExtract %6 %104 0 2
|
|
%37 = OpAccessChain %7 %19 %30
|
|
OpStore %37 %36
|
|
%206 = OpCompositeExtract %16 %103 1
|
|
OpReturn
|
|
OpFunctionEnd
|
|
)";
|
|
ASSERT_TRUE(IsEqual(env, after_transformation, context.get()));
|
|
}
|
|
|
|
TEST(TransformationCompositeExtractTest, IllegalInsertionPoints) {
|
|
std::string shader = R"(
|
|
OpCapability Shader
|
|
%1 = OpExtInstImport "GLSL.std.450"
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint Fragment %4 "main" %51 %27
|
|
OpExecutionMode %4 OriginUpperLeft
|
|
OpSource ESSL 310
|
|
OpName %4 "main"
|
|
OpName %25 "buf"
|
|
OpMemberName %25 0 "value"
|
|
OpName %27 ""
|
|
OpName %51 "color"
|
|
OpMemberDecorate %25 0 Offset 0
|
|
OpDecorate %25 Block
|
|
OpDecorate %27 DescriptorSet 0
|
|
OpDecorate %27 Binding 0
|
|
OpDecorate %51 Location 0
|
|
%2 = OpTypeVoid
|
|
%3 = OpTypeFunction %2
|
|
%6 = OpTypeFloat 32
|
|
%7 = OpTypeVector %6 4
|
|
%10 = OpConstant %6 0.300000012
|
|
%11 = OpConstant %6 0.400000006
|
|
%12 = OpConstant %6 0.5
|
|
%13 = OpConstant %6 1
|
|
%14 = OpConstantComposite %7 %10 %11 %12 %13
|
|
%15 = OpTypeInt 32 1
|
|
%18 = OpConstant %15 0
|
|
%25 = OpTypeStruct %6
|
|
%26 = OpTypePointer Uniform %25
|
|
%27 = OpVariable %26 Uniform
|
|
%28 = OpTypePointer Uniform %6
|
|
%32 = OpTypeBool
|
|
%103 = OpConstantTrue %32
|
|
%34 = OpConstant %6 0.100000001
|
|
%48 = OpConstant %15 1
|
|
%50 = OpTypePointer Output %7
|
|
%51 = OpVariable %50 Output
|
|
%100 = OpTypePointer Function %6
|
|
%4 = OpFunction %2 None %3
|
|
%5 = OpLabel
|
|
%101 = OpVariable %100 Function
|
|
%102 = OpVariable %100 Function
|
|
OpBranch %19
|
|
%19 = OpLabel
|
|
%60 = OpPhi %7 %14 %5 %58 %20
|
|
%59 = OpPhi %15 %18 %5 %49 %20
|
|
%29 = OpAccessChain %28 %27 %18
|
|
%30 = OpLoad %6 %29
|
|
%31 = OpConvertFToS %15 %30
|
|
%33 = OpSLessThan %32 %59 %31
|
|
OpLoopMerge %21 %20 None
|
|
OpBranchConditional %33 %20 %21
|
|
%20 = OpLabel
|
|
%39 = OpCompositeExtract %6 %60 0
|
|
%40 = OpFAdd %6 %39 %34
|
|
%55 = OpCompositeInsert %7 %40 %60 0
|
|
%44 = OpCompositeExtract %6 %60 1
|
|
%45 = OpFSub %6 %44 %34
|
|
%58 = OpCompositeInsert %7 %45 %55 1
|
|
%49 = OpIAdd %15 %59 %48
|
|
OpBranch %19
|
|
%21 = OpLabel
|
|
OpStore %51 %60
|
|
OpSelectionMerge %105 None
|
|
OpBranchConditional %103 %104 %105
|
|
%104 = OpLabel
|
|
OpBranch %105
|
|
%105 = OpLabel
|
|
OpReturn
|
|
OpFunctionEnd
|
|
)";
|
|
|
|
const auto env = SPV_ENV_UNIVERSAL_1_4;
|
|
const auto consumer = nullptr;
|
|
const auto context = BuildModule(env, consumer, shader, kFuzzAssembleOption);
|
|
spvtools::ValidatorOptions validator_options;
|
|
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
|
|
kConsoleMessageConsumer));
|
|
TransformationContext transformation_context(
|
|
MakeUnique<FactManager>(context.get()), validator_options);
|
|
// Cannot insert before the OpVariables of a function.
|
|
ASSERT_FALSE(
|
|
TransformationCompositeExtract(
|
|
MakeInstructionDescriptor(101, spv::Op::OpVariable, 0), 200, 14, {0})
|
|
.IsApplicable(context.get(), transformation_context));
|
|
ASSERT_FALSE(
|
|
TransformationCompositeExtract(
|
|
MakeInstructionDescriptor(101, spv::Op::OpVariable, 1), 200, 14, {1})
|
|
.IsApplicable(context.get(), transformation_context));
|
|
ASSERT_FALSE(
|
|
TransformationCompositeExtract(
|
|
MakeInstructionDescriptor(102, spv::Op::OpVariable, 0), 200, 14, {1})
|
|
.IsApplicable(context.get(), transformation_context));
|
|
// OK to insert right after the OpVariables.
|
|
ASSERT_FALSE(
|
|
TransformationCompositeExtract(
|
|
MakeInstructionDescriptor(102, spv::Op::OpBranch, 1), 200, 14, {1})
|
|
.IsApplicable(context.get(), transformation_context));
|
|
|
|
// Cannot insert before the OpPhis of a block.
|
|
ASSERT_FALSE(
|
|
TransformationCompositeExtract(
|
|
MakeInstructionDescriptor(60, spv::Op::OpPhi, 0), 200, 14, {2})
|
|
.IsApplicable(context.get(), transformation_context));
|
|
ASSERT_FALSE(
|
|
TransformationCompositeExtract(
|
|
MakeInstructionDescriptor(59, spv::Op::OpPhi, 0), 200, 14, {3})
|
|
.IsApplicable(context.get(), transformation_context));
|
|
// OK to insert after the OpPhis.
|
|
ASSERT_TRUE(TransformationCompositeExtract(
|
|
MakeInstructionDescriptor(59, spv::Op::OpAccessChain, 0), 200,
|
|
14, {3})
|
|
.IsApplicable(context.get(), transformation_context));
|
|
|
|
// Cannot insert before OpLoopMerge
|
|
ASSERT_FALSE(
|
|
TransformationCompositeExtract(
|
|
MakeInstructionDescriptor(33, spv::Op::OpBranchConditional, 0), 200,
|
|
14, {3})
|
|
.IsApplicable(context.get(), transformation_context));
|
|
|
|
// Cannot insert before OpSelectionMerge
|
|
ASSERT_FALSE(
|
|
TransformationCompositeExtract(
|
|
MakeInstructionDescriptor(21, spv::Op::OpBranchConditional, 0), 200,
|
|
14, {2})
|
|
.IsApplicable(context.get(), transformation_context));
|
|
}
|
|
|
|
TEST(TransformationCompositeExtractTest, AddSynonymsForRelevantIds) {
|
|
std::string shader = R"(
|
|
OpCapability Shader
|
|
%1 = OpExtInstImport "GLSL.std.450"
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint Fragment %4 "main"
|
|
OpExecutionMode %4 OriginUpperLeft
|
|
OpSource ESSL 310
|
|
OpName %4 "main"
|
|
OpName %8 "a"
|
|
OpName %10 "b"
|
|
OpName %17 "FunnyPoint"
|
|
OpMemberName %17 0 "x"
|
|
OpMemberName %17 1 "y"
|
|
OpMemberName %17 2 "z"
|
|
OpName %19 "p"
|
|
%2 = OpTypeVoid
|
|
%3 = OpTypeFunction %2
|
|
%6 = OpTypeInt 32 1
|
|
%7 = OpTypePointer Function %6
|
|
%12 = OpTypeBool
|
|
%16 = OpTypeFloat 32
|
|
%17 = OpTypeStruct %16 %16 %6
|
|
%81 = OpTypeStruct %17 %16
|
|
%18 = OpTypePointer Function %17
|
|
%20 = OpConstant %6 0
|
|
%23 = OpTypePointer Function %16
|
|
%26 = OpConstant %6 1
|
|
%30 = OpConstant %6 2
|
|
%80 = OpUndef %16
|
|
%4 = OpFunction %2 None %3
|
|
%5 = OpLabel
|
|
%8 = OpVariable %7 Function
|
|
%10 = OpVariable %7 Function
|
|
%19 = OpVariable %18 Function
|
|
%9 = OpLoad %6 %8
|
|
%11 = OpLoad %6 %10
|
|
%100 = OpCompositeConstruct %17 %80 %80 %26
|
|
%104 = OpCompositeConstruct %81 %100 %80
|
|
%13 = OpIEqual %12 %9 %11
|
|
OpSelectionMerge %15 None
|
|
OpBranchConditional %13 %14 %25
|
|
%14 = OpLabel
|
|
%21 = OpLoad %6 %8
|
|
%22 = OpConvertSToF %16 %21
|
|
%101 = OpCompositeConstruct %17 %22 %80 %30
|
|
%24 = OpAccessChain %23 %19 %20
|
|
OpStore %24 %22
|
|
OpBranch %15
|
|
%25 = OpLabel
|
|
%27 = OpLoad %6 %10
|
|
%28 = OpConvertSToF %16 %27
|
|
%102 = OpCompositeConstruct %17 %80 %28 %27
|
|
%29 = OpAccessChain %23 %19 %26
|
|
OpStore %29 %28
|
|
OpBranch %15
|
|
%15 = OpLabel
|
|
%31 = OpAccessChain %23 %19 %20
|
|
%32 = OpLoad %16 %31
|
|
%33 = OpAccessChain %23 %19 %26
|
|
%34 = OpLoad %16 %33
|
|
%103 = OpCompositeConstruct %17 %34 %32 %9
|
|
%35 = OpFAdd %16 %32 %34
|
|
%36 = OpConvertFToS %6 %35
|
|
%37 = OpAccessChain %7 %19 %30
|
|
OpStore %37 %36
|
|
OpReturn
|
|
OpFunctionEnd
|
|
)";
|
|
|
|
const auto env = SPV_ENV_UNIVERSAL_1_4;
|
|
const auto consumer = nullptr;
|
|
const auto context = BuildModule(env, consumer, shader, kFuzzAssembleOption);
|
|
spvtools::ValidatorOptions validator_options;
|
|
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
|
|
kConsoleMessageConsumer));
|
|
TransformationContext transformation_context(
|
|
MakeUnique<FactManager>(context.get()), validator_options);
|
|
TransformationCompositeExtract transformation(
|
|
MakeInstructionDescriptor(36, spv::Op::OpConvertFToS, 0), 201, 100, {2});
|
|
ASSERT_TRUE(
|
|
transformation.IsApplicable(context.get(), transformation_context));
|
|
ApplyAndCheckFreshIds(transformation, context.get(), &transformation_context);
|
|
ASSERT_TRUE(transformation_context.GetFactManager()->IsSynonymous(
|
|
MakeDataDescriptor(201, {}), MakeDataDescriptor(100, {2})));
|
|
}
|
|
|
|
TEST(TransformationCompositeExtractTest, DontAddSynonymsForIrrelevantIds) {
|
|
std::string shader = R"(
|
|
OpCapability Shader
|
|
%1 = OpExtInstImport "GLSL.std.450"
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint Fragment %4 "main"
|
|
OpExecutionMode %4 OriginUpperLeft
|
|
OpSource ESSL 310
|
|
OpName %4 "main"
|
|
OpName %8 "a"
|
|
OpName %10 "b"
|
|
OpName %17 "FunnyPoint"
|
|
OpMemberName %17 0 "x"
|
|
OpMemberName %17 1 "y"
|
|
OpMemberName %17 2 "z"
|
|
OpName %19 "p"
|
|
%2 = OpTypeVoid
|
|
%3 = OpTypeFunction %2
|
|
%6 = OpTypeInt 32 1
|
|
%7 = OpTypePointer Function %6
|
|
%12 = OpTypeBool
|
|
%16 = OpTypeFloat 32
|
|
%17 = OpTypeStruct %16 %16 %6
|
|
%81 = OpTypeStruct %17 %16
|
|
%18 = OpTypePointer Function %17
|
|
%20 = OpConstant %6 0
|
|
%23 = OpTypePointer Function %16
|
|
%26 = OpConstant %6 1
|
|
%30 = OpConstant %6 2
|
|
%80 = OpUndef %16
|
|
%4 = OpFunction %2 None %3
|
|
%5 = OpLabel
|
|
%8 = OpVariable %7 Function
|
|
%10 = OpVariable %7 Function
|
|
%19 = OpVariable %18 Function
|
|
%9 = OpLoad %6 %8
|
|
%11 = OpLoad %6 %10
|
|
%100 = OpCompositeConstruct %17 %80 %80 %26
|
|
%104 = OpCompositeConstruct %81 %100 %80
|
|
%13 = OpIEqual %12 %9 %11
|
|
OpSelectionMerge %15 None
|
|
OpBranchConditional %13 %14 %25
|
|
%14 = OpLabel
|
|
%21 = OpLoad %6 %8
|
|
%22 = OpConvertSToF %16 %21
|
|
%101 = OpCompositeConstruct %17 %22 %80 %30
|
|
%24 = OpAccessChain %23 %19 %20
|
|
OpStore %24 %22
|
|
OpBranch %15
|
|
%25 = OpLabel
|
|
%27 = OpLoad %6 %10
|
|
%28 = OpConvertSToF %16 %27
|
|
%102 = OpCompositeConstruct %17 %80 %28 %27
|
|
%29 = OpAccessChain %23 %19 %26
|
|
OpStore %29 %28
|
|
OpBranch %15
|
|
%15 = OpLabel
|
|
%31 = OpAccessChain %23 %19 %20
|
|
%32 = OpLoad %16 %31
|
|
%33 = OpAccessChain %23 %19 %26
|
|
%34 = OpLoad %16 %33
|
|
%103 = OpCompositeConstruct %17 %34 %32 %9
|
|
%35 = OpFAdd %16 %32 %34
|
|
%36 = OpConvertFToS %6 %35
|
|
%37 = OpAccessChain %7 %19 %30
|
|
OpStore %37 %36
|
|
OpReturn
|
|
OpFunctionEnd
|
|
)";
|
|
|
|
const auto env = SPV_ENV_UNIVERSAL_1_4;
|
|
const auto consumer = nullptr;
|
|
const auto context = BuildModule(env, consumer, shader, kFuzzAssembleOption);
|
|
spvtools::ValidatorOptions validator_options;
|
|
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
|
|
kConsoleMessageConsumer));
|
|
TransformationContext transformation_context(
|
|
MakeUnique<FactManager>(context.get()), validator_options);
|
|
transformation_context.GetFactManager()->AddFactIdIsIrrelevant(100);
|
|
TransformationCompositeExtract transformation(
|
|
MakeInstructionDescriptor(36, spv::Op::OpConvertFToS, 0), 201, 100, {2});
|
|
ASSERT_TRUE(
|
|
transformation.IsApplicable(context.get(), transformation_context));
|
|
ApplyAndCheckFreshIds(transformation, context.get(), &transformation_context);
|
|
ASSERT_FALSE(transformation_context.GetFactManager()->IsSynonymous(
|
|
MakeDataDescriptor(201, {}), MakeDataDescriptor(100, {2})));
|
|
}
|
|
|
|
TEST(TransformationCompositeExtractTest, DontAddSynonymInDeadBlock) {
|
|
std::string shader = R"(
|
|
OpCapability Shader
|
|
%1 = OpExtInstImport "GLSL.std.450"
|
|
OpMemoryModel Logical GLSL450
|
|
OpEntryPoint Fragment %4 "main"
|
|
OpExecutionMode %4 OriginUpperLeft
|
|
OpSource ESSL 320
|
|
%2 = OpTypeVoid
|
|
%3 = OpTypeFunction %2
|
|
%6 = OpTypeInt 32 1
|
|
%7 = OpTypeVector %6 2
|
|
%8 = OpTypePointer Function %7
|
|
%10 = OpConstant %6 0
|
|
%11 = OpConstant %6 1
|
|
%12 = OpConstantComposite %7 %10 %11
|
|
%13 = OpTypeBool
|
|
%14 = OpConstantFalse %13
|
|
%4 = OpFunction %2 None %3
|
|
%5 = OpLabel
|
|
%9 = OpVariable %8 Function
|
|
OpStore %9 %12
|
|
OpSelectionMerge %16 None
|
|
OpBranchConditional %14 %15 %16
|
|
%15 = OpLabel
|
|
OpBranch %16
|
|
%16 = OpLabel
|
|
OpReturn
|
|
OpFunctionEnd
|
|
)";
|
|
|
|
const auto env = SPV_ENV_UNIVERSAL_1_4;
|
|
const auto consumer = nullptr;
|
|
const auto context = BuildModule(env, consumer, shader, kFuzzAssembleOption);
|
|
spvtools::ValidatorOptions validator_options;
|
|
ASSERT_TRUE(fuzzerutil::IsValidAndWellFormed(context.get(), validator_options,
|
|
kConsoleMessageConsumer));
|
|
TransformationContext transformation_context(
|
|
MakeUnique<FactManager>(context.get()), validator_options);
|
|
transformation_context.GetFactManager()->AddFactBlockIsDead(15);
|
|
TransformationCompositeExtract transformation(
|
|
MakeInstructionDescriptor(15, spv::Op::OpBranch, 0), 100, 12, {0});
|
|
ASSERT_TRUE(
|
|
transformation.IsApplicable(context.get(), transformation_context));
|
|
ApplyAndCheckFreshIds(transformation, context.get(), &transformation_context);
|
|
ASSERT_FALSE(transformation_context.GetFactManager()->IsSynonymous(
|
|
MakeDataDescriptor(100, {}), MakeDataDescriptor(12, {0})));
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace fuzz
|
|
} // namespace spvtools
|