mirror of
https://github.com/KhronosGroup/SPIRV-Tools
synced 2024-11-26 13:20:05 +00:00
8993f9f52f
We want to be able to apply scalar replacement on variables that have the AliasPointer and RestrictPointer decorations. This exposed a bug that needs to be fixed as well. Scalar replacement sometimes uses the type manager to get the type id for the variables it is creating. The variable type is a pointer to a pointee type. Currently, scalar replacement uses the type manager when only if the pointee type has to be unique in the module. This is done to try to avoid the case where two type hash to the same value in the type manager, and it returns the wrong one. However, this check is not the correct check. Pointer types still have to be unique in the spir-v module. However, two unique pointer types can hash to the same value if their pointee types are isomorphic. For example, %s1 = OpTypeStruct %int %s2 = OpTypeStruct %int ; %p1 and %p2 will hash to the same value even though they are still ; considered "unique". %p1 = OpTypePointer Function %s1 %p2 = OpTypePointer Function %s2 To fix this, we now use FindPointerToType, and we modified TypeManager::IsUnique to refer to the whether or not a type will hash to a unique value and say that pointers are not unique. Fixes #5196
295 lines
12 KiB
C++
295 lines
12 KiB
C++
// Copyright (c) 2017 Google Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef SOURCE_OPT_SCALAR_REPLACEMENT_PASS_H_
|
|
#define SOURCE_OPT_SCALAR_REPLACEMENT_PASS_H_
|
|
|
|
#include <cassert>
|
|
#include <cstdio>
|
|
#include <memory>
|
|
#include <queue>
|
|
#include <unordered_map>
|
|
#include <unordered_set>
|
|
#include <vector>
|
|
|
|
#include "source/opt/function.h"
|
|
#include "source/opt/mem_pass.h"
|
|
#include "source/opt/type_manager.h"
|
|
|
|
namespace spvtools {
|
|
namespace opt {
|
|
|
|
// Documented in optimizer.hpp
|
|
class ScalarReplacementPass : public MemPass {
|
|
private:
|
|
static constexpr uint32_t kDefaultLimit = 100;
|
|
|
|
public:
|
|
ScalarReplacementPass(uint32_t limit = kDefaultLimit)
|
|
: max_num_elements_(limit) {
|
|
const auto num_to_write = snprintf(
|
|
name_, sizeof(name_), "scalar-replacement=%u", max_num_elements_);
|
|
assert(size_t(num_to_write) < sizeof(name_));
|
|
(void)num_to_write; // Mark as unused
|
|
|
|
#ifdef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
|
|
// ClusterFuzz/OSS-Fuzz is likely to yield examples with very large arrays.
|
|
// This can cause timeouts and memouts during fuzzing that
|
|
// are not classed as bugs. To avoid this noise, we set the
|
|
// max_num_elements_ to a smaller value for fuzzing.
|
|
max_num_elements_ =
|
|
(max_num_elements_ > 0 && max_num_elements_ < 100 ? max_num_elements_
|
|
: 100);
|
|
#endif
|
|
}
|
|
|
|
const char* name() const override { return name_; }
|
|
|
|
// Attempts to scalarize all appropriate function scope variables. Returns
|
|
// SuccessWithChange if any change is made.
|
|
Status Process() override;
|
|
|
|
IRContext::Analysis GetPreservedAnalyses() override {
|
|
return IRContext::kAnalysisDefUse |
|
|
IRContext::kAnalysisInstrToBlockMapping |
|
|
IRContext::kAnalysisDecorations | IRContext::kAnalysisCombinators |
|
|
IRContext::kAnalysisCFG | IRContext::kAnalysisNameMap |
|
|
IRContext::kAnalysisConstants | IRContext::kAnalysisTypes;
|
|
}
|
|
|
|
private:
|
|
// Small container for tracking statistics about variables.
|
|
//
|
|
// TODO(alanbaker): Develop some useful heuristics to tune this pass.
|
|
struct VariableStats {
|
|
uint32_t num_partial_accesses;
|
|
uint32_t num_full_accesses;
|
|
};
|
|
|
|
// Attempts to scalarize all appropriate function scope variables in
|
|
// |function|. Returns SuccessWithChange if any changes are mode.
|
|
Status ProcessFunction(Function* function);
|
|
|
|
// Returns true if |varInst| can be scalarized.
|
|
//
|
|
// Examines the use chain of |varInst| to verify all uses are valid for
|
|
// scalarization.
|
|
bool CanReplaceVariable(const Instruction* varInst) const;
|
|
|
|
// Returns true if |typeInst| is an acceptable type to scalarize.
|
|
//
|
|
// Allows all aggregate types except runtime arrays. Additionally, checks the
|
|
// that the number of elements that would be scalarized is within bounds.
|
|
bool CheckType(const Instruction* typeInst) const;
|
|
|
|
// Returns true if all the decorations for |varInst| are acceptable for
|
|
// scalarization.
|
|
bool CheckAnnotations(const Instruction* varInst) const;
|
|
|
|
// Returns true if all the decorations for |typeInst| are acceptable for
|
|
// scalarization.
|
|
bool CheckTypeAnnotations(const Instruction* typeInst) const;
|
|
|
|
// Returns true if the uses of |inst| are acceptable for scalarization.
|
|
//
|
|
// Recursively checks all the uses of |inst|. For |inst| specifically, only
|
|
// allows spv::Op::OpAccessChain, spv::Op::OpInBoundsAccessChain,
|
|
// spv::Op::OpLoad and spv::Op::OpStore. Access chains must have the first
|
|
// index be a compile-time constant. Subsequent uses of access chains
|
|
// (including other access chains) are checked in a more relaxed manner.
|
|
bool CheckUses(const Instruction* inst) const;
|
|
|
|
// Helper function for the above |CheckUses|.
|
|
//
|
|
// This version tracks some stats about the current OpVariable. These stats
|
|
// are used to drive heuristics about when to scalarize.
|
|
bool CheckUses(const Instruction* inst, VariableStats* stats) const;
|
|
|
|
// Relaxed helper function for |CheckUses|.
|
|
bool CheckUsesRelaxed(const Instruction* inst) const;
|
|
|
|
// Transfers appropriate decorations from |source| to |replacements|.
|
|
void TransferAnnotations(const Instruction* source,
|
|
std::vector<Instruction*>* replacements);
|
|
|
|
// Scalarizes |inst| and updates its uses.
|
|
//
|
|
// |inst| must be an OpVariable. It is replaced with an OpVariable for each
|
|
// for element of the composite type. Uses of |inst| are updated as
|
|
// appropriate. If the replacement variables are themselves scalarizable, they
|
|
// get added to |worklist| for further processing. If any replacement
|
|
// variable ends up with no uses it is erased. Returns
|
|
// - Status::SuccessWithoutChange if the variable could not be replaced.
|
|
// - Status::SuccessWithChange if it made replacements.
|
|
// - Status::Failure if it couldn't create replacement variables.
|
|
Pass::Status ReplaceVariable(Instruction* inst,
|
|
std::queue<Instruction*>* worklist);
|
|
|
|
// Returns the underlying storage type for |inst|.
|
|
//
|
|
// |inst| must be an OpVariable. Returns the type that is pointed to by
|
|
// |inst|.
|
|
Instruction* GetStorageType(const Instruction* inst) const;
|
|
|
|
// Returns true if the load can be scalarized.
|
|
//
|
|
// |inst| must be an OpLoad. Returns true if |index| is the pointer operand of
|
|
// |inst| and the load is not from volatile memory.
|
|
bool CheckLoad(const Instruction* inst, uint32_t index) const;
|
|
|
|
// Returns true if the store can be scalarized.
|
|
//
|
|
// |inst| must be an OpStore. Returns true if |index| is the pointer operand
|
|
// of |inst| and the store is not to volatile memory.
|
|
bool CheckStore(const Instruction* inst, uint32_t index) const;
|
|
|
|
// Returns true if the DebugDeclare can be scalarized at |index|.
|
|
bool CheckDebugDeclare(uint32_t index) const;
|
|
|
|
// Returns true if |index| is the pointer operand of an OpImageTexelPointer
|
|
// instruction.
|
|
bool CheckImageTexelPointer(uint32_t index) const;
|
|
|
|
// Creates a variable of type |typeId| from the |index|'th element of
|
|
// |varInst|. The new variable is added to |replacements|. If the variable
|
|
// could not be created, then |nullptr| is appended to |replacements|.
|
|
void CreateVariable(uint32_t typeId, Instruction* varInst, uint32_t index,
|
|
std::vector<Instruction*>* replacements);
|
|
|
|
// Populates |replacements| with a new OpVariable for each element of |inst|.
|
|
// Returns true if the replacement variables were successfully created.
|
|
//
|
|
// |inst| must be an OpVariable of a composite type. New variables are
|
|
// initialized the same as the corresponding index in |inst|. |replacements|
|
|
// will contain a variable for each element of the composite with matching
|
|
// indexes (i.e. the 0'th element of |inst| is the 0'th entry of
|
|
// |replacements|).
|
|
bool CreateReplacementVariables(Instruction* inst,
|
|
std::vector<Instruction*>* replacements);
|
|
|
|
// Returns the array length for |arrayInst|.
|
|
uint64_t GetArrayLength(const Instruction* arrayInst) const;
|
|
|
|
// Returns the number of elements in |type|.
|
|
//
|
|
// |type| must be a vector or matrix type.
|
|
uint64_t GetNumElements(const Instruction* type) const;
|
|
|
|
// Returns true if |id| is a specialization constant.
|
|
//
|
|
// |id| must be registered definition.
|
|
bool IsSpecConstant(uint32_t id) const;
|
|
|
|
// Returns an id for a pointer to |id|.
|
|
uint32_t GetOrCreatePointerType(uint32_t id);
|
|
|
|
// Creates the initial value for the |index| element of |source| in |newVar|.
|
|
//
|
|
// If there is an initial value for |source| for element |index|, it is
|
|
// appended as an operand on |newVar|. If the initial value is OpUndef, no
|
|
// initial value is added to |newVar|.
|
|
void GetOrCreateInitialValue(Instruction* source, uint32_t index,
|
|
Instruction* newVar);
|
|
|
|
// Replaces the load to the entire composite.
|
|
//
|
|
// Generates a load for each replacement variable and then creates a new
|
|
// composite by combining all of the loads.
|
|
//
|
|
// |load| must be a load. Returns true if successful.
|
|
bool ReplaceWholeLoad(Instruction* load,
|
|
const std::vector<Instruction*>& replacements);
|
|
|
|
// Replaces the store to the entire composite.
|
|
//
|
|
// Generates a composite extract and store for each element in the scalarized
|
|
// variable from the original store data input. Returns true if successful.
|
|
bool ReplaceWholeStore(Instruction* store,
|
|
const std::vector<Instruction*>& replacements);
|
|
|
|
// Replaces the DebugDeclare to the entire composite.
|
|
//
|
|
// Generates a DebugValue with Deref operation for each element in the
|
|
// scalarized variable from the original DebugDeclare. Returns true if
|
|
// successful.
|
|
bool ReplaceWholeDebugDeclare(Instruction* dbg_decl,
|
|
const std::vector<Instruction*>& replacements);
|
|
|
|
// Replaces the DebugValue to the entire composite.
|
|
//
|
|
// Generates a DebugValue for each element in the scalarized variable from
|
|
// the original DebugValue. Returns true if successful.
|
|
bool ReplaceWholeDebugValue(Instruction* dbg_value,
|
|
const std::vector<Instruction*>& replacements);
|
|
|
|
// Replaces an access chain to the composite variable with either a direct use
|
|
// of the appropriate replacement variable or another access chain with the
|
|
// replacement variable as the base and one fewer indexes. Returns true if
|
|
// successful.
|
|
bool ReplaceAccessChain(Instruction* chain,
|
|
const std::vector<Instruction*>& replacements);
|
|
|
|
// Returns a set containing the which components of the result of |inst| are
|
|
// potentially used. If the return value is |nullptr|, then every components
|
|
// is possibly used.
|
|
std::unique_ptr<std::unordered_set<int64_t>> GetUsedComponents(
|
|
Instruction* inst);
|
|
|
|
// Returns an instruction defining an undefined value type |type_id|.
|
|
Instruction* GetUndef(uint32_t type_id);
|
|
|
|
// Maps storage type to a pointer type enclosing that type.
|
|
std::unordered_map<uint32_t, uint32_t> pointee_to_pointer_;
|
|
|
|
// Maps type id to OpConstantNull for that type.
|
|
std::unordered_map<uint32_t, uint32_t> type_to_null_;
|
|
|
|
// Returns the number of elements in the variable |var_inst|.
|
|
uint64_t GetMaxLegalIndex(const Instruction* var_inst) const;
|
|
|
|
// Returns true if |length| is larger than limit on the size of the variable
|
|
// that we will be willing to split.
|
|
bool IsLargerThanSizeLimit(uint64_t length) const;
|
|
|
|
// Copies all relevant decorations from `from` to `to`. This includes
|
|
// decorations applied to the variable, and to the members of the type.
|
|
// It is assumed that `to` is a variable that is intended to replace the
|
|
// `member_index`th member of `from`.
|
|
void CopyDecorationsToVariable(Instruction* from, Instruction* to,
|
|
uint32_t member_index);
|
|
|
|
// Copies pointer related decoration from `from` to `to` if they exist.
|
|
void CopyPointerDecorationsToVariable(Instruction* from, Instruction* to);
|
|
|
|
// Copies decorations that are needed from the `member_index` of `from` to
|
|
// `to, if there was one.
|
|
void CopyNecessaryMemberDecorationsToVariable(Instruction* from,
|
|
Instruction* to,
|
|
uint32_t member_index);
|
|
|
|
// Limit on the number of members in an object that will be replaced.
|
|
// 0 means there is no limit.
|
|
uint32_t max_num_elements_;
|
|
|
|
// This has to be big enough to fit "scalar-replacement=" followed by a
|
|
// uint32_t number written in decimal (so 10 digits), and then a
|
|
// terminating nul.
|
|
char name_[30];
|
|
};
|
|
|
|
} // namespace opt
|
|
} // namespace spvtools
|
|
|
|
#endif // SOURCE_OPT_SCALAR_REPLACEMENT_PASS_H_
|