mirror of
https://github.com/KhronosGroup/SPIRV-Tools
synced 2024-10-19 11:30:15 +00:00
07ce16d1e7
Inlining is not setting the parent (function) for each basic block. This can cause problems for later optimizations. The solution is to set the parent for each new block just before it is linked into the function.
84 lines
2.8 KiB
C++
84 lines
2.8 KiB
C++
// Copyright (c) 2017 The Khronos Group Inc.
|
|
// Copyright (c) 2017 Valve Corporation
|
|
// Copyright (c) 2017 LunarG Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "inline_exhaustive_pass.h"
|
|
|
|
namespace spvtools {
|
|
namespace opt {
|
|
|
|
bool InlineExhaustivePass::InlineExhaustive(ir::Function* func) {
|
|
bool modified = false;
|
|
// Using block iterators here because of block erasures and insertions.
|
|
for (auto bi = func->begin(); bi != func->end(); ++bi) {
|
|
for (auto ii = bi->begin(); ii != bi->end();) {
|
|
if (IsInlinableFunctionCall(&*ii)) {
|
|
// Inline call.
|
|
std::vector<std::unique_ptr<ir::BasicBlock>> newBlocks;
|
|
std::vector<std::unique_ptr<ir::Instruction>> newVars;
|
|
GenInlineCode(&newBlocks, &newVars, ii, bi);
|
|
// If call block is replaced with more than one block, point
|
|
// succeeding phis at new last block.
|
|
if (newBlocks.size() > 1) UpdateSucceedingPhis(newBlocks);
|
|
// Replace old calling block with new block(s).
|
|
|
|
// We need to kill the name and decorations for the call, which
|
|
// will be deleted. Other instructions in the block will be moved to
|
|
// newBlocks. We don't need to do anything with those.
|
|
context()->KillNamesAndDecorates(&*ii);
|
|
|
|
bi = bi.Erase();
|
|
|
|
for (auto& bb : newBlocks) {
|
|
bb->SetParent(func);
|
|
}
|
|
bi = bi.InsertBefore(&newBlocks);
|
|
// Insert new function variables.
|
|
if (newVars.size() > 0)
|
|
func->begin()->begin().InsertBefore(std::move(newVars));
|
|
// Restart inlining at beginning of calling block.
|
|
ii = bi->begin();
|
|
modified = true;
|
|
} else {
|
|
++ii;
|
|
}
|
|
}
|
|
}
|
|
return modified;
|
|
}
|
|
|
|
void InlineExhaustivePass::Initialize(ir::IRContext* c) {
|
|
InitializeInline(c);
|
|
};
|
|
|
|
Pass::Status InlineExhaustivePass::ProcessImpl() {
|
|
// Attempt exhaustive inlining on each entry point function in module
|
|
ProcessFunction pfn = [this](ir::Function* fp) {
|
|
return InlineExhaustive(fp);
|
|
};
|
|
bool modified = ProcessEntryPointCallTree(pfn, get_module());
|
|
return modified ? Status::SuccessWithChange : Status::SuccessWithoutChange;
|
|
}
|
|
|
|
InlineExhaustivePass::InlineExhaustivePass() {}
|
|
|
|
Pass::Status InlineExhaustivePass::Process(ir::IRContext* c) {
|
|
Initialize(c);
|
|
return ProcessImpl();
|
|
}
|
|
|
|
} // namespace opt
|
|
} // namespace spvtools
|