mirror of
https://github.com/KhronosGroup/SPIRV-Tools
synced 2024-11-30 06:50:06 +00:00
063dbea0f1
Function static non-POD data causes problems with DLL lifetime. This pull request turns all static info tables into strict POD tables. Specifically, the capabilities/extensions field of opcode/operand/extended-instruction table are turned into two fields, one for the count and the other a pointer to an array of capabilities/extensions. CapabilitySet/EnumSet are not used in the static table anymore, but they are still used for checking inclusion by constructing on the fly, which should be cheap for the majority cases. Also moves all these tables into the global namespace to avoid C++11 function static thread-safe initialization overhead.
78 lines
3.0 KiB
C++
78 lines
3.0 KiB
C++
// Copyright (c) 2015-2016 The Khronos Group Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "unit_spirv.h"
|
|
|
|
#include "enum_set.h"
|
|
|
|
namespace {
|
|
|
|
using libspirv::CapabilitySet;
|
|
using spvtest::ElementsIn;
|
|
|
|
// Capabilities required by an Opcode.
|
|
struct ExpectedOpCodeCapabilities {
|
|
SpvOp opcode;
|
|
CapabilitySet capabilities;
|
|
};
|
|
|
|
using OpcodeTableCapabilitiesTest =
|
|
::testing::TestWithParam<ExpectedOpCodeCapabilities>;
|
|
|
|
TEST_P(OpcodeTableCapabilitiesTest, TableEntryMatchesExpectedCapabilities) {
|
|
spv_opcode_table opcodeTable;
|
|
ASSERT_EQ(SPV_SUCCESS,
|
|
spvOpcodeTableGet(&opcodeTable, SPV_ENV_UNIVERSAL_1_1));
|
|
spv_opcode_desc entry;
|
|
ASSERT_EQ(SPV_SUCCESS,
|
|
spvOpcodeTableValueLookup(opcodeTable, GetParam().opcode, &entry));
|
|
EXPECT_EQ(
|
|
ElementsIn(GetParam().capabilities),
|
|
ElementsIn(CapabilitySet(entry->numCapabilities, entry->capabilities)));
|
|
}
|
|
|
|
INSTANTIATE_TEST_CASE_P(
|
|
TableRowTest, OpcodeTableCapabilitiesTest,
|
|
// Spot-check a few opcodes.
|
|
::testing::Values(
|
|
ExpectedOpCodeCapabilities{
|
|
SpvOpImageQuerySize,
|
|
CapabilitySet{SpvCapabilityKernel, SpvCapabilityImageQuery}},
|
|
ExpectedOpCodeCapabilities{
|
|
SpvOpImageQuerySizeLod,
|
|
CapabilitySet{SpvCapabilityKernel, SpvCapabilityImageQuery}},
|
|
ExpectedOpCodeCapabilities{
|
|
SpvOpImageQueryLevels,
|
|
CapabilitySet{SpvCapabilityKernel, SpvCapabilityImageQuery}},
|
|
ExpectedOpCodeCapabilities{
|
|
SpvOpImageQuerySamples,
|
|
CapabilitySet{SpvCapabilityKernel, SpvCapabilityImageQuery}},
|
|
ExpectedOpCodeCapabilities{SpvOpImageSparseSampleImplicitLod,
|
|
CapabilitySet{SpvCapabilitySparseResidency}},
|
|
ExpectedOpCodeCapabilities{SpvOpCopyMemorySized,
|
|
CapabilitySet{SpvCapabilityAddresses}},
|
|
ExpectedOpCodeCapabilities{SpvOpArrayLength,
|
|
CapabilitySet{SpvCapabilityShader}},
|
|
ExpectedOpCodeCapabilities{SpvOpFunction, CapabilitySet()},
|
|
ExpectedOpCodeCapabilities{SpvOpConvertFToS, CapabilitySet()},
|
|
ExpectedOpCodeCapabilities{SpvOpEmitStreamVertex,
|
|
CapabilitySet{SpvCapabilityGeometryStreams}},
|
|
ExpectedOpCodeCapabilities{SpvOpTypeNamedBarrier,
|
|
CapabilitySet{SpvCapabilityNamedBarrier}},
|
|
ExpectedOpCodeCapabilities{
|
|
SpvOpGetKernelMaxNumSubgroups,
|
|
CapabilitySet{SpvCapabilitySubgroupDispatch}}), );
|
|
|
|
} // anonymous namespace
|