mirror of
https://github.com/KhronosGroup/SPIRV-Tools
synced 2024-11-23 20:20:06 +00:00
57a2441791
CPPreference.com has this description of digits10: “The value of std::numeric_limits<T>::digits10 is the number of base-10 digits that can be represented by the type T without change, that is, any number with this many significant decimal digits can be converted to a value of type T and back to decimal form, without change due to rounding or overflow.” This means that any number with this many digits can be represented accurately in the corresponding type. A change in any digit in a number after that may or may not cause it a different bitwise representation. Therefore this isn’t necessarily enough precision to accurately represent the value in text. Instead we need max_digits10 which has the following description: “The value of std::numeric_limits<T>::max_digits10 is the number of base-10 digits that are necessary to uniquely represent all distinct values of the type T, such as necessary for serialization/deserialization to text.” The patch includes a test case in hex_float_test which tries to do a round-robin conversion of a number that requires more than 6 decimal places to be accurately represented. This would fail without the patch. Sadly this also breaks a bunch of other tests. Some of the tests in hex_float_test use ldexp and then compare it with a value which is not the same as the one returned by ldexp but instead is the value rounded to 6 decimals. Others use values that are not evenly representable as a binary floating fraction but then happened to generate the same value when rounded to 6 decimals. Where the actual value didn’t seem to matter these have been changed with different values that can be represented as a binary fraction.
285 lines
11 KiB
C++
285 lines
11 KiB
C++
// Copyright (c) 2016 Google Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "assembly_builder.h"
|
|
|
|
#include "pass_fixture.h"
|
|
#include "pass_utils.h"
|
|
|
|
namespace {
|
|
|
|
using namespace spvtools;
|
|
using AssemblyBuilderTest = PassTest<::testing::Test>;
|
|
|
|
TEST_F(AssemblyBuilderTest, MinimalShader) {
|
|
AssemblyBuilder builder;
|
|
std::vector<const char*> expected = {
|
|
// clang-format off
|
|
"OpCapability Shader",
|
|
"OpCapability Float64",
|
|
"%1 = OpExtInstImport \"GLSL.std.450\"",
|
|
"OpMemoryModel Logical GLSL450",
|
|
"OpEntryPoint Vertex %main \"main\"",
|
|
"OpName %void \"void\"",
|
|
"OpName %main_func_type \"main_func_type\"",
|
|
"OpName %main \"main\"",
|
|
"OpName %main_func_entry_block \"main_func_entry_block\"",
|
|
"%void = OpTypeVoid",
|
|
"%main_func_type = OpTypeFunction %void",
|
|
"%main = OpFunction %void None %main_func_type",
|
|
"%main_func_entry_block = OpLabel",
|
|
"OpReturn",
|
|
"OpFunctionEnd",
|
|
// clang-format on
|
|
};
|
|
|
|
SinglePassRunAndCheck<opt::NullPass>(builder.GetCode(),
|
|
JoinAllInsts(expected),
|
|
/* skip_nop = */ false);
|
|
}
|
|
|
|
TEST_F(AssemblyBuilderTest, ShaderWithConstants) {
|
|
AssemblyBuilder builder;
|
|
builder
|
|
.AppendTypesConstantsGlobals({
|
|
// clang-format off
|
|
"%bool = OpTypeBool",
|
|
"%_PF_bool = OpTypePointer Function %bool",
|
|
"%bt = OpConstantTrue %bool",
|
|
"%bf = OpConstantFalse %bool",
|
|
"%int = OpTypeInt 32 1",
|
|
"%_PF_int = OpTypePointer Function %int",
|
|
"%si = OpConstant %int 1",
|
|
"%uint = OpTypeInt 32 0",
|
|
"%_PF_uint = OpTypePointer Function %uint",
|
|
"%ui = OpConstant %uint 2",
|
|
"%float = OpTypeFloat 32",
|
|
"%_PF_float = OpTypePointer Function %float",
|
|
"%f = OpConstant %float 3.1415",
|
|
"%double = OpTypeFloat 64",
|
|
"%_PF_double = OpTypePointer Function %double",
|
|
"%d = OpConstant %double 3.14159265358979",
|
|
// clang-format on
|
|
})
|
|
.AppendInMain({
|
|
// clang-format off
|
|
"%btv = OpVariable %_PF_bool Function",
|
|
"%bfv = OpVariable %_PF_bool Function",
|
|
"%iv = OpVariable %_PF_int Function",
|
|
"%uv = OpVariable %_PF_uint Function",
|
|
"%fv = OpVariable %_PF_float Function",
|
|
"%dv = OpVariable %_PF_double Function",
|
|
"OpStore %btv %bt",
|
|
"OpStore %bfv %bf",
|
|
"OpStore %iv %si",
|
|
"OpStore %uv %ui",
|
|
"OpStore %fv %f",
|
|
"OpStore %dv %d",
|
|
// clang-format on
|
|
});
|
|
|
|
std::vector<const char*> expected = {
|
|
// clang-format off
|
|
"OpCapability Shader",
|
|
"OpCapability Float64",
|
|
"%1 = OpExtInstImport \"GLSL.std.450\"",
|
|
"OpMemoryModel Logical GLSL450",
|
|
"OpEntryPoint Vertex %main \"main\"",
|
|
"OpName %void \"void\"",
|
|
"OpName %main_func_type \"main_func_type\"",
|
|
"OpName %main \"main\"",
|
|
"OpName %main_func_entry_block \"main_func_entry_block\"",
|
|
"OpName %bool \"bool\"",
|
|
"OpName %_PF_bool \"_PF_bool\"",
|
|
"OpName %bt \"bt\"",
|
|
"OpName %bf \"bf\"",
|
|
"OpName %int \"int\"",
|
|
"OpName %_PF_int \"_PF_int\"",
|
|
"OpName %si \"si\"",
|
|
"OpName %uint \"uint\"",
|
|
"OpName %_PF_uint \"_PF_uint\"",
|
|
"OpName %ui \"ui\"",
|
|
"OpName %float \"float\"",
|
|
"OpName %_PF_float \"_PF_float\"",
|
|
"OpName %f \"f\"",
|
|
"OpName %double \"double\"",
|
|
"OpName %_PF_double \"_PF_double\"",
|
|
"OpName %d \"d\"",
|
|
"OpName %btv \"btv\"",
|
|
"OpName %bfv \"bfv\"",
|
|
"OpName %iv \"iv\"",
|
|
"OpName %uv \"uv\"",
|
|
"OpName %fv \"fv\"",
|
|
"OpName %dv \"dv\"",
|
|
"%void = OpTypeVoid",
|
|
"%main_func_type = OpTypeFunction %void",
|
|
"%bool = OpTypeBool",
|
|
"%_PF_bool = OpTypePointer Function %bool",
|
|
"%bt = OpConstantTrue %bool",
|
|
"%bf = OpConstantFalse %bool",
|
|
"%int = OpTypeInt 32 1",
|
|
"%_PF_int = OpTypePointer Function %int",
|
|
"%si = OpConstant %int 1",
|
|
"%uint = OpTypeInt 32 0",
|
|
"%_PF_uint = OpTypePointer Function %uint",
|
|
"%ui = OpConstant %uint 2",
|
|
"%float = OpTypeFloat 32",
|
|
"%_PF_float = OpTypePointer Function %float",
|
|
"%f = OpConstant %float 3.1415",
|
|
"%double = OpTypeFloat 64",
|
|
"%_PF_double = OpTypePointer Function %double",
|
|
"%d = OpConstant %double 3.14159265358979",
|
|
"%main = OpFunction %void None %main_func_type",
|
|
"%main_func_entry_block = OpLabel",
|
|
"%btv = OpVariable %_PF_bool Function",
|
|
"%bfv = OpVariable %_PF_bool Function",
|
|
"%iv = OpVariable %_PF_int Function",
|
|
"%uv = OpVariable %_PF_uint Function",
|
|
"%fv = OpVariable %_PF_float Function",
|
|
"%dv = OpVariable %_PF_double Function",
|
|
"OpStore %btv %bt",
|
|
"OpStore %bfv %bf",
|
|
"OpStore %iv %si",
|
|
"OpStore %uv %ui",
|
|
"OpStore %fv %f",
|
|
"OpStore %dv %d",
|
|
"OpReturn",
|
|
"OpFunctionEnd",
|
|
// clang-format on
|
|
};
|
|
SinglePassRunAndCheck<opt::NullPass>(builder.GetCode(),
|
|
JoinAllInsts(expected),
|
|
/* skip_nop = */ false);
|
|
}
|
|
|
|
TEST_F(AssemblyBuilderTest, SpecConstants) {
|
|
AssemblyBuilder builder;
|
|
builder.AppendTypesConstantsGlobals({
|
|
"%bool = OpTypeBool",
|
|
"%uint = OpTypeInt 32 0",
|
|
"%int = OpTypeInt 32 1",
|
|
"%float = OpTypeFloat 32",
|
|
"%double = OpTypeFloat 64",
|
|
"%v2int = OpTypeVector %int 2",
|
|
|
|
"%spec_true = OpSpecConstantTrue %bool",
|
|
"%spec_false = OpSpecConstantFalse %bool",
|
|
"%spec_uint = OpSpecConstant %uint 1",
|
|
"%spec_int = OpSpecConstant %int 1",
|
|
"%spec_float = OpSpecConstant %float 1.25",
|
|
"%spec_double = OpSpecConstant %double 1.2345678",
|
|
|
|
// Spec constants defined below should not have SpecID.
|
|
"%spec_add_op = OpSpecConstantOp %int IAdd %spec_int %spec_int",
|
|
"%spec_vec = OpSpecConstantComposite %v2int %spec_int %spec_int",
|
|
"%spec_vec_x = OpSpecConstantOp %int CompositeExtract %spec_vec 0",
|
|
});
|
|
std::vector<const char*> expected = {
|
|
// clang-format off
|
|
"OpCapability Shader",
|
|
"OpCapability Float64",
|
|
"%1 = OpExtInstImport \"GLSL.std.450\"",
|
|
"OpMemoryModel Logical GLSL450",
|
|
"OpEntryPoint Vertex %main \"main\"",
|
|
"OpName %void \"void\"",
|
|
"OpName %main_func_type \"main_func_type\"",
|
|
"OpName %main \"main\"",
|
|
"OpName %main_func_entry_block \"main_func_entry_block\"",
|
|
"OpName %bool \"bool\"",
|
|
"OpName %uint \"uint\"",
|
|
"OpName %int \"int\"",
|
|
"OpName %float \"float\"",
|
|
"OpName %double \"double\"",
|
|
"OpName %v2int \"v2int\"",
|
|
"OpName %spec_true \"spec_true\"",
|
|
"OpName %spec_false \"spec_false\"",
|
|
"OpName %spec_uint \"spec_uint\"",
|
|
"OpName %spec_int \"spec_int\"",
|
|
"OpName %spec_float \"spec_float\"",
|
|
"OpName %spec_double \"spec_double\"",
|
|
"OpName %spec_add_op \"spec_add_op\"",
|
|
"OpName %spec_vec \"spec_vec\"",
|
|
"OpName %spec_vec_x \"spec_vec_x\"",
|
|
"OpDecorate %spec_true SpecId 200",
|
|
"OpDecorate %spec_false SpecId 201",
|
|
"OpDecorate %spec_uint SpecId 202",
|
|
"OpDecorate %spec_int SpecId 203",
|
|
"OpDecorate %spec_float SpecId 204",
|
|
"OpDecorate %spec_double SpecId 205",
|
|
"%void = OpTypeVoid",
|
|
"%main_func_type = OpTypeFunction %void",
|
|
"%bool = OpTypeBool",
|
|
"%uint = OpTypeInt 32 0",
|
|
"%int = OpTypeInt 32 1",
|
|
"%float = OpTypeFloat 32",
|
|
"%double = OpTypeFloat 64",
|
|
"%v2int = OpTypeVector %int 2",
|
|
"%spec_true = OpSpecConstantTrue %bool",
|
|
"%spec_false = OpSpecConstantFalse %bool",
|
|
"%spec_uint = OpSpecConstant %uint 1",
|
|
"%spec_int = OpSpecConstant %int 1",
|
|
"%spec_float = OpSpecConstant %float 1.25",
|
|
"%spec_double = OpSpecConstant %double 1.2345678",
|
|
"%spec_add_op = OpSpecConstantOp %int IAdd %spec_int %spec_int",
|
|
"%spec_vec = OpSpecConstantComposite %v2int %spec_int %spec_int",
|
|
"%spec_vec_x = OpSpecConstantOp %int CompositeExtract %spec_vec 0",
|
|
"%main = OpFunction %void None %main_func_type",
|
|
"%main_func_entry_block = OpLabel",
|
|
"OpReturn",
|
|
"OpFunctionEnd",
|
|
|
|
// clang-format on
|
|
};
|
|
|
|
SinglePassRunAndCheck<opt::NullPass>(builder.GetCode(),
|
|
JoinAllInsts(expected),
|
|
/* skip_nop = */ false);
|
|
}
|
|
|
|
TEST_F(AssemblyBuilderTest, AppendNames) {
|
|
AssemblyBuilder builder;
|
|
builder.AppendNames({
|
|
"OpName %void \"another_name_for_void\"",
|
|
"I am an invalid OpName instruction and should not be added",
|
|
"OpName %main \"another name for main\"",
|
|
});
|
|
std::vector<const char*> expected = {
|
|
// clang-format off
|
|
"OpCapability Shader",
|
|
"OpCapability Float64",
|
|
"%1 = OpExtInstImport \"GLSL.std.450\"",
|
|
"OpMemoryModel Logical GLSL450",
|
|
"OpEntryPoint Vertex %main \"main\"",
|
|
"OpName %void \"void\"",
|
|
"OpName %main_func_type \"main_func_type\"",
|
|
"OpName %main \"main\"",
|
|
"OpName %main_func_entry_block \"main_func_entry_block\"",
|
|
"OpName %void \"another_name_for_void\"",
|
|
"OpName %main \"another name for main\"",
|
|
"%void = OpTypeVoid",
|
|
"%main_func_type = OpTypeFunction %void",
|
|
"%main = OpFunction %void None %main_func_type",
|
|
"%main_func_entry_block = OpLabel",
|
|
"OpReturn",
|
|
"OpFunctionEnd",
|
|
// clang-format on
|
|
};
|
|
|
|
SinglePassRunAndCheck<opt::NullPass>(builder.GetCode(),
|
|
JoinAllInsts(expected),
|
|
/* skip_nop = */ false);
|
|
}
|
|
|
|
} // anonymous namespace
|