mirror of
https://github.com/KhronosGroup/SPIRV-Tools
synced 2024-11-26 21:30:07 +00:00
2a3cbe7c3f
* Add a check that derivative functions only operate on scalar or vector 32-bit floating point values * Added tests to disallow half derivatives
196 lines
5.9 KiB
C++
196 lines
5.9 KiB
C++
// Copyright (c) 2017 Google Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include <sstream>
|
|
#include <string>
|
|
|
|
#include "gmock/gmock.h"
|
|
#include "test/unit_spirv.h"
|
|
#include "test/val/val_fixtures.h"
|
|
|
|
namespace spvtools {
|
|
namespace val {
|
|
namespace {
|
|
|
|
using ::testing::HasSubstr;
|
|
using ::testing::Not;
|
|
|
|
using ValidateDerivatives = spvtest::ValidateBase<bool>;
|
|
|
|
std::string GenerateShaderCode(
|
|
const std::string& body,
|
|
const std::string& capabilities_and_extensions = "",
|
|
const std::string& execution_model = "Fragment") {
|
|
std::stringstream ss;
|
|
ss << R"(
|
|
OpCapability Shader
|
|
OpCapability DerivativeControl
|
|
)";
|
|
|
|
ss << capabilities_and_extensions;
|
|
ss << "OpMemoryModel Logical GLSL450\n";
|
|
ss << "OpEntryPoint " << execution_model << " %main \"main\""
|
|
<< " %f32_var_input"
|
|
<< " %f32vec4_var_input"
|
|
<< "\n";
|
|
if (execution_model == "Fragment") {
|
|
ss << "OpExecutionMode %main OriginUpperLeft\n";
|
|
}
|
|
|
|
ss << R"(
|
|
%void = OpTypeVoid
|
|
%func = OpTypeFunction %void
|
|
%bool = OpTypeBool
|
|
%f32 = OpTypeFloat 32
|
|
%u32 = OpTypeInt 32 0
|
|
%s32 = OpTypeInt 32 1
|
|
%f32vec4 = OpTypeVector %f32 4
|
|
|
|
%f32_ptr_input = OpTypePointer Input %f32
|
|
%f32_var_input = OpVariable %f32_ptr_input Input
|
|
|
|
%f32vec4_ptr_input = OpTypePointer Input %f32vec4
|
|
%f32vec4_var_input = OpVariable %f32vec4_ptr_input Input
|
|
)";
|
|
|
|
if (capabilities_and_extensions.find("OpCapability Float16") !=
|
|
std::string::npos) {
|
|
ss << "%f16 = OpTypeFloat 16\n"
|
|
<< "%f16vec4 = OpTypeVector %f16 4\n"
|
|
<< "%f16_0 = OpConstantNull %f16\n"
|
|
<< "%f16vec4_0 = OpConstantNull %f16vec4\n";
|
|
}
|
|
|
|
ss << R"(
|
|
%main = OpFunction %void None %func
|
|
%main_entry = OpLabel
|
|
)";
|
|
|
|
ss << body;
|
|
|
|
ss << R"(
|
|
OpReturn
|
|
OpFunctionEnd)";
|
|
|
|
return ss.str();
|
|
}
|
|
|
|
TEST_F(ValidateDerivatives, ScalarSuccess) {
|
|
const std::string body = R"(
|
|
%f32_var = OpLoad %f32 %f32_var_input
|
|
%val1 = OpDPdx %f32 %f32_var
|
|
%val2 = OpDPdy %f32 %f32_var
|
|
%val3 = OpFwidth %f32 %f32_var
|
|
%val4 = OpDPdxFine %f32 %f32_var
|
|
%val5 = OpDPdyFine %f32 %f32_var
|
|
%val6 = OpFwidthFine %f32 %f32_var
|
|
%val7 = OpDPdxCoarse %f32 %f32_var
|
|
%val8 = OpDPdyCoarse %f32 %f32_var
|
|
%val9 = OpFwidthCoarse %f32 %f32_var
|
|
)";
|
|
|
|
CompileSuccessfully(GenerateShaderCode(body).c_str());
|
|
ASSERT_EQ(SPV_SUCCESS, ValidateInstructions());
|
|
}
|
|
|
|
TEST_F(ValidateDerivatives, VectorSuccess) {
|
|
const std::string body = R"(
|
|
%f32vec4_var = OpLoad %f32vec4 %f32vec4_var_input
|
|
%val1 = OpDPdx %f32vec4 %f32vec4_var
|
|
%val2 = OpDPdy %f32vec4 %f32vec4_var
|
|
%val3 = OpFwidth %f32vec4 %f32vec4_var
|
|
%val4 = OpDPdxFine %f32vec4 %f32vec4_var
|
|
%val5 = OpDPdyFine %f32vec4 %f32vec4_var
|
|
%val6 = OpFwidthFine %f32vec4 %f32vec4_var
|
|
%val7 = OpDPdxCoarse %f32vec4 %f32vec4_var
|
|
%val8 = OpDPdyCoarse %f32vec4 %f32vec4_var
|
|
%val9 = OpFwidthCoarse %f32vec4 %f32vec4_var
|
|
)";
|
|
|
|
CompileSuccessfully(GenerateShaderCode(body).c_str());
|
|
ASSERT_EQ(SPV_SUCCESS, ValidateInstructions());
|
|
}
|
|
|
|
TEST_F(ValidateDerivatives, OpDPdxWrongResultType) {
|
|
const std::string body = R"(
|
|
%f32_var = OpLoad %f32 %f32_var_input
|
|
%val1 = OpDPdx %u32 %f32vec4
|
|
)";
|
|
|
|
CompileSuccessfully(GenerateShaderCode(body).c_str());
|
|
ASSERT_EQ(SPV_ERROR_INVALID_ID, ValidateInstructions());
|
|
EXPECT_THAT(getDiagnosticString(), HasSubstr("Operand 10[%v4float] cannot "
|
|
"be a type"));
|
|
}
|
|
|
|
TEST_F(ValidateDerivatives, OpDPdxWrongPType) {
|
|
const std::string body = R"(
|
|
%f32vec4_var = OpLoad %f32vec4 %f32vec4_var_input
|
|
%val1 = OpDPdx %f32 %f32vec4_var
|
|
)";
|
|
|
|
CompileSuccessfully(GenerateShaderCode(body).c_str());
|
|
ASSERT_EQ(SPV_ERROR_INVALID_DATA, ValidateInstructions());
|
|
EXPECT_THAT(getDiagnosticString(),
|
|
HasSubstr("Expected P type and Result Type to be the same: "
|
|
"DPdx"));
|
|
}
|
|
|
|
TEST_F(ValidateDerivatives, OpDPdxWrongExecutionModel) {
|
|
const std::string body = R"(
|
|
%f32vec4_var = OpLoad %f32vec4 %f32vec4_var_input
|
|
%val1 = OpDPdx %f32vec4 %f32vec4_var
|
|
)";
|
|
|
|
CompileSuccessfully(GenerateShaderCode(body, "", "Vertex").c_str());
|
|
ASSERT_EQ(SPV_ERROR_INVALID_ID, ValidateInstructions());
|
|
EXPECT_THAT(getDiagnosticString(),
|
|
HasSubstr("Derivative instructions require Fragment or GLCompute "
|
|
"execution model: DPdx"));
|
|
}
|
|
|
|
using ValidateHalfDerivatives = spvtest::ValidateBase<std::string>;
|
|
|
|
TEST_P(ValidateHalfDerivatives, ScalarFailure) {
|
|
const std::string op = GetParam();
|
|
const std::string body = "%val = " + op + " %f16 %f16_0\n";
|
|
|
|
CompileSuccessfully(
|
|
GenerateShaderCode(body, "OpCapability Float16\n").c_str());
|
|
ASSERT_EQ(SPV_ERROR_INVALID_DATA, ValidateInstructions());
|
|
EXPECT_THAT(getDiagnosticString(),
|
|
HasSubstr("Result type component width must be 32 bits"));
|
|
}
|
|
|
|
TEST_P(ValidateHalfDerivatives, VectorFailure) {
|
|
const std::string op = GetParam();
|
|
const std::string body = "%val = " + op + " %f16vec4 %f16vec4_0\n";
|
|
|
|
CompileSuccessfully(
|
|
GenerateShaderCode(body, "OpCapability Float16\n").c_str());
|
|
ASSERT_EQ(SPV_ERROR_INVALID_DATA, ValidateInstructions());
|
|
EXPECT_THAT(getDiagnosticString(),
|
|
HasSubstr("Result type component width must be 32 bits"));
|
|
}
|
|
|
|
INSTANTIATE_TEST_SUITE_P(HalfDerivatives, ValidateHalfDerivatives,
|
|
::testing::Values("OpDPdx", "OpDPdy", "OpFwidth",
|
|
"OpDPdxFine", "OpDPdyFine",
|
|
"OpFwidthFine", "OpDPdxCoarse",
|
|
"OpDPdyCoarse", "OpFwidthCoarse"));
|
|
|
|
} // namespace
|
|
} // namespace val
|
|
} // namespace spvtools
|