mirror of
https://github.com/KhronosGroup/SPIRV-Tools
synced 2024-10-19 03:20:14 +00:00
93c4c184d5
By using forward pointers, we are able to define a struct that has a pointer to itself. This could be directly or indirectly. The current implementation of the type manager did not handle this case. There are three changes that are made in this commit inorder to handle this case: 1) Change the handling of OpTypeForwardPointer The current handling of OpTypeForwardsPointer is broken if there is a reference to the pointer before the real definition. When build the type that contain the forward delared pointer, the type manager will ask for the type for that ID, and will get a nullptr because it does not exists. This nullptr is not handleded very well. The change is to keep track of the incomplete types the first time through all of the types. An incomplete type is a ForwardPointer or any type that references an incomplete type. Then we implement a second pass through the incomplete types that will complete them. 2) Hashing types. When hashing a type, we want to uses all of the subtypes as part of the hash. However, with types that reference them selves, this creates an infinite recursion. To get around this, we keep track of which types have been seen on the path from the root type. If we have see the current type already then we can stop the recursion. 3) Comparing types. In order to check if two types are the same, we must check that all of their subtypes are the same as well. This also causes an infinit recursion. The solution is to stop comparing the subtypes if we are trying to compare two pointer types that we are already in the middle of comparing. The ideas is that if the two pointer are different, then in progress compare will return false itself. Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/1578. |
||
|---|---|---|
| .. | ||
| dominator_tree | ||
| loop_optimizations | ||
| aggressive_dead_code_elim_test.cpp | ||
| assembly_builder_test.cpp | ||
| assembly_builder.h | ||
| block_merge_test.cpp | ||
| ccp_test.cpp | ||
| cfg_cleanup_test.cpp | ||
| CMakeLists.txt | ||
| common_uniform_elim_test.cpp | ||
| compact_ids_test.cpp | ||
| copy_prop_array_test.cpp | ||
| dead_branch_elim_test.cpp | ||
| dead_insert_elim_test.cpp | ||
| dead_variable_elim_test.cpp | ||
| decoration_manager_test.cpp | ||
| def_use_test.cpp | ||
| eliminate_dead_const_test.cpp | ||
| eliminate_dead_functions_test.cpp | ||
| feature_manager_test.cpp | ||
| flatten_decoration_test.cpp | ||
| fold_spec_const_op_composite_test.cpp | ||
| fold_test.cpp | ||
| freeze_spec_const_test.cpp | ||
| function_utils.h | ||
| if_conversion_test.cpp | ||
| inline_opaque_test.cpp | ||
| inline_test.cpp | ||
| insert_extract_elim_test.cpp | ||
| instruction_list_test.cpp | ||
| instruction_test.cpp | ||
| ir_builder.cpp | ||
| ir_context_test.cpp | ||
| ir_loader_test.cpp | ||
| iterator_test.cpp | ||
| line_debug_info_test.cpp | ||
| local_access_chain_convert_test.cpp | ||
| local_redundancy_elimination_test.cpp | ||
| local_single_block_elim.cpp | ||
| local_single_store_elim_test.cpp | ||
| local_ssa_elim_test.cpp | ||
| module_test.cpp | ||
| module_utils.h | ||
| optimizer_test.cpp | ||
| pass_fixture.h | ||
| pass_manager_test.cpp | ||
| pass_merge_return_test.cpp | ||
| pass_remove_duplicates_test.cpp | ||
| pass_test.cpp | ||
| pass_utils.cpp | ||
| pass_utils.h | ||
| private_to_local_test.cpp | ||
| propagator_test.cpp | ||
| reduce_load_size_test.cpp | ||
| redundancy_elimination_test.cpp | ||
| register_liveness.cpp | ||
| replace_invalid_opc_test.cpp | ||
| scalar_analysis.cpp | ||
| scalar_replacement_test.cpp | ||
| set_spec_const_default_value_test.cpp | ||
| simplification_test.cpp | ||
| strength_reduction_test.cpp | ||
| strip_debug_info_test.cpp | ||
| strip_reflect_info_test.cpp | ||
| type_manager_test.cpp | ||
| types_test.cpp | ||
| unify_const_test.cpp | ||
| utils_test.cpp | ||
| value_table_test.cpp | ||
| vector_dce_test.cpp | ||
| workaround1209_test.cpp | ||