mirror of
https://github.com/KhronosGroup/SPIRV-Tools
synced 2024-11-23 20:20:06 +00:00
7d01643132
When doing if-conversion, we do not currently move code out of the side nodes. The reason for this is that it can increase the number of instructions that get executed because both side nods will have to be executed now. In this commit, we add code to move an instruction, and all of the instructions it depends on, out of a side node and into the header of the selection construct. However to keep the cost down, we only do it when the two values in the OpPhi node compute the same value. This way we have to move only one of the instructions and the other becomes unused most of the time. So no real extra cost. Makes the value number table an alalysis in the ir context. Added more opcodes to list of code motion safe opcodes. Fixes #1526.
90 lines
3.7 KiB
C++
90 lines
3.7 KiB
C++
// Copyright (c) 2018 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef LIBSPIRV_OPT_IF_CONVERSION_H_
|
|
#define LIBSPIRV_OPT_IF_CONVERSION_H_
|
|
|
|
#include "basic_block.h"
|
|
#include "ir_builder.h"
|
|
#include "pass.h"
|
|
#include "types.h"
|
|
|
|
namespace spvtools {
|
|
namespace opt {
|
|
|
|
// See optimizer.hpp for documentation.
|
|
class IfConversion : public Pass {
|
|
public:
|
|
const char* name() const override { return "if-conversion"; }
|
|
Status Process(ir::IRContext* context) override;
|
|
|
|
ir::IRContext::Analysis GetPreservedAnalyses() override {
|
|
return ir::IRContext::kAnalysisDefUse |
|
|
ir::IRContext::kAnalysisDominatorAnalysis |
|
|
ir::IRContext::kAnalysisInstrToBlockMapping |
|
|
ir::IRContext::kAnalysisCFG | ir::IRContext::kAnalysisNameMap;
|
|
}
|
|
|
|
private:
|
|
// Returns true if |id| is a valid type for use with OpSelect. OpSelect only
|
|
// allows scalars, vectors and pointers as valid inputs.
|
|
bool CheckType(uint32_t id);
|
|
|
|
// Returns the basic block containing |id|.
|
|
ir::BasicBlock* GetBlock(uint32_t id);
|
|
|
|
// Returns the basic block for the |predecessor|'th index predecessor of
|
|
// |phi|.
|
|
ir::BasicBlock* GetIncomingBlock(ir::Instruction* phi, uint32_t predecessor);
|
|
|
|
// Returns the instruction defining the |predecessor|'th index of |phi|.
|
|
ir::Instruction* GetIncomingValue(ir::Instruction* phi, uint32_t predecessor);
|
|
|
|
// Returns the id of a OpCompositeConstruct boolean vector. The composite has
|
|
// the same number of elements as |vec_data_ty| and each member is |cond|.
|
|
// |where| indicates the location in |block| to insert the composite
|
|
// construct. If necessary, this function will also construct the necessary
|
|
// type instructions for the boolean vector.
|
|
uint32_t SplatCondition(analysis::Vector* vec_data_ty, uint32_t cond,
|
|
InstructionBuilder* builder);
|
|
|
|
// Returns true if none of |phi|'s users are in |block|.
|
|
bool CheckPhiUsers(ir::Instruction* phi, ir::BasicBlock* block);
|
|
|
|
// Returns |false| if |block| is not appropriate to transform. Only
|
|
// transforms blocks with two predecessors. Neither incoming block can be
|
|
// dominated by |block|. Both predecessors must share a common dominator that
|
|
// is terminated by a conditional branch.
|
|
bool CheckBlock(ir::BasicBlock* block, DominatorAnalysis* dominators,
|
|
ir::BasicBlock** common);
|
|
|
|
// Moves |inst| to |target_block| if it does not already dominate the block.
|
|
// Any instructions that |inst| depends on are move if necessary. It is
|
|
// assumed that |inst| can be hoisted to |target_block| as defined by
|
|
// |CanHoistInstruction|. |dominators| is the dominator analysis for the
|
|
// function that contains |target_block|.
|
|
void HoistInstruction(ir::Instruction* inst, ir::BasicBlock* target_block,
|
|
DominatorAnalysis* dominators);
|
|
|
|
// Returns true if it is legal to move |inst| and the instructions it depends
|
|
// on to |target_block| if they do not already dominate |target_block|.
|
|
bool CanHoistInstruction(ir::Instruction* inst, ir::BasicBlock* target_block,
|
|
DominatorAnalysis* dominators);
|
|
};
|
|
|
|
} // namespace opt
|
|
} // namespace spvtools
|
|
|
|
#endif // LIBSPIRV_OPT_IF_CONVERSION_H_
|