mirror of
https://github.com/KhronosGroup/SPIRV-Tools
synced 2024-11-23 12:10:06 +00:00
63f57d95d6
* SPIR-V 1.4 headers, add SPV_ENV_UNIVERSAL_1_4 * Support --target-env spv1.4 in help for command line tools * Support asm/dis of UniformId decoration * Validate UniformId decoration * Fix version check on instructions and operands Also register decorations used with OpDecorateId * Extension lists can differ between enums that match Example: SubgroupMaskEq vs SubgroupMaskEqKHR * Validate scope value for Uniform decoration, for SPIR-V 1.4 * More unioning of exts * Preserve grammar order within an enum value * 1.4: Validate OpSelect over composites * Tools default to 1.4 * Add asm/dis test for OpCopyLogical * 1.4: asm/dis tests for PtrEqual, PtrNotEqual, PtrDiff * Basic asm/Dis test for OpCopyMemory * Test asm/dis OpCopyMemory with 2-memory access Add asm/dis tests for OpCopyMemorySized Requires grammar update to add second optional memory access operand to OpCopyMemory and OpCopyMemorySized * Validate one or two memory accesses on OpCopyMemory* * Check av/vis on CopyMemory source and target memory access This is a proposed rule. See https://gitlab.khronos.org/spirv/SPIR-V/issues/413 * Validate operation for OpSpecConstantOp * Validate NonWritable decoration Also permit NonWritable on members of UBO and SSBO. * SPIR-V 1.4: NonWrtiable can decorate Function and Private vars * Update optimizer CLI tests for SPIR-V 1.4 * Testing tools: Give expected SPIR-V version in message * SPIR-V 1.4 validation for entry point interfaces * Allow only unique interfaces * Allow all global variables * Check that all statically used global variables are listed * new tests * Add validation fixture CompileFailure * Add 1.4 validation for pointer comparisons * New tests * Validate with image operands SignExtend, ZeroExtend Since we don't actually know the image texel format, we can't fully validate. We need more context. But we can make sure we allow the new image operands in known-good cases. * Validate OpCopyLogical * Recursively checks subtypes * new tests * Add SPIR-V 1.4 tests for NoSignedWrap, NoUnsignedWrap * Allow scalar conditions in 1.4 with OpSelect * Allows scalar conditions with vector operands * new tests * Validate uniform id scope as an execution scope * Validate the values of memory and execution scopes are valid scope values * new test * Remove SPIR-V 1.4 Vulkan 1.0 environment * SPIR-V 1.4 requires Vulkan 1.1 * FIX: include string for spvLog * FIX: validate nonwritable * FIX: test case suite for member decorate string * FIX: test case for hlsl functionality1 * Validation test fixture: ease debugging * Use binary version for SPIR-V 1.4 specific features * Switch checks based on the SPIR-V version from the target environment to instead use the version from the binary * Moved header parsing into the ValidationState_t constructor (where version based features are set) * Added new versions of tests that assemble a 1.3 binary and validate a 1.4 environment * Fix test for update to SPIR-V 1.4 headers * Fix formatting * Ext inst lookup: Add Vulkan 1.1 env with SPIR-V 1.4 * Update spirv-val help * Operand version checks should use module version Use the module version instead of the target environment version. * Fix comment about two-access form of OpCopyMemory
122 lines
3.7 KiB
C++
122 lines
3.7 KiB
C++
// Copyright (c) 2018 Google LLC.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include <algorithm>
|
|
#include <vector>
|
|
|
|
#include "source/diagnostic.h"
|
|
#include "source/spirv_constant.h"
|
|
#include "source/spirv_target_env.h"
|
|
#include "source/val/function.h"
|
|
#include "source/val/instruction.h"
|
|
#include "source/val/validate.h"
|
|
#include "source/val/validation_state.h"
|
|
|
|
namespace spvtools {
|
|
namespace val {
|
|
namespace {
|
|
|
|
// Returns true if \c inst is an input or output variable.
|
|
bool is_interface_variable(const Instruction* inst, bool is_spv_1_4) {
|
|
if (is_spv_1_4) {
|
|
// Starting in SPIR-V 1.4, all global variables are interface variables.
|
|
return inst->opcode() == SpvOpVariable &&
|
|
inst->word(3u) != SpvStorageClassFunction;
|
|
} else {
|
|
return inst->opcode() == SpvOpVariable &&
|
|
(inst->word(3u) == SpvStorageClassInput ||
|
|
inst->word(3u) == SpvStorageClassOutput);
|
|
}
|
|
}
|
|
|
|
// Checks that \c var is listed as an interface in all the entry points that use
|
|
// it.
|
|
spv_result_t check_interface_variable(ValidationState_t& _,
|
|
const Instruction* var) {
|
|
std::vector<const Function*> functions;
|
|
std::vector<const Instruction*> uses;
|
|
for (auto use : var->uses()) {
|
|
uses.push_back(use.first);
|
|
}
|
|
for (uint32_t i = 0; i < uses.size(); ++i) {
|
|
const auto user = uses[i];
|
|
if (const Function* func = user->function()) {
|
|
functions.push_back(func);
|
|
} else {
|
|
// In the rare case that the variable is used by another instruction in
|
|
// the global scope, continue searching for an instruction used in a
|
|
// function.
|
|
for (auto use : user->uses()) {
|
|
uses.push_back(use.first);
|
|
}
|
|
}
|
|
}
|
|
|
|
std::sort(functions.begin(), functions.end(),
|
|
[](const Function* lhs, const Function* rhs) {
|
|
return lhs->id() < rhs->id();
|
|
});
|
|
functions.erase(std::unique(functions.begin(), functions.end()),
|
|
functions.end());
|
|
|
|
std::vector<uint32_t> entry_points;
|
|
for (const auto func : functions) {
|
|
for (auto id : _.FunctionEntryPoints(func->id())) {
|
|
entry_points.push_back(id);
|
|
}
|
|
}
|
|
|
|
std::sort(entry_points.begin(), entry_points.end());
|
|
entry_points.erase(std::unique(entry_points.begin(), entry_points.end()),
|
|
entry_points.end());
|
|
|
|
for (auto id : entry_points) {
|
|
for (const auto& desc : _.entry_point_descriptions(id)) {
|
|
bool found = false;
|
|
for (auto interface : desc.interfaces) {
|
|
if (var->id() == interface) {
|
|
found = true;
|
|
break;
|
|
}
|
|
}
|
|
if (!found) {
|
|
return _.diag(SPV_ERROR_INVALID_ID, var)
|
|
<< "Interface variable id <" << var->id()
|
|
<< "> is used by entry point '" << desc.name << "' id <" << id
|
|
<< ">, but is not listed as an interface";
|
|
}
|
|
}
|
|
}
|
|
|
|
return SPV_SUCCESS;
|
|
}
|
|
|
|
} // namespace
|
|
|
|
spv_result_t ValidateInterfaces(ValidationState_t& _) {
|
|
bool is_spv_1_4 = _.version() >= SPV_SPIRV_VERSION_WORD(1, 4);
|
|
for (auto& inst : _.ordered_instructions()) {
|
|
if (is_interface_variable(&inst, is_spv_1_4)) {
|
|
if (auto error = check_interface_variable(_, &inst)) {
|
|
return error;
|
|
}
|
|
}
|
|
}
|
|
|
|
return SPV_SUCCESS;
|
|
}
|
|
|
|
} // namespace val
|
|
} // namespace spvtools
|