mirror of
https://github.com/KhronosGroup/SPIRV-Tools
synced 2024-10-19 03:20:14 +00:00
57a2441791
CPPreference.com has this description of digits10: “The value of std::numeric_limits<T>::digits10 is the number of base-10 digits that can be represented by the type T without change, that is, any number with this many significant decimal digits can be converted to a value of type T and back to decimal form, without change due to rounding or overflow.” This means that any number with this many digits can be represented accurately in the corresponding type. A change in any digit in a number after that may or may not cause it a different bitwise representation. Therefore this isn’t necessarily enough precision to accurately represent the value in text. Instead we need max_digits10 which has the following description: “The value of std::numeric_limits<T>::max_digits10 is the number of base-10 digits that are necessary to uniquely represent all distinct values of the type T, such as necessary for serialization/deserialization to text.” The patch includes a test case in hex_float_test which tries to do a round-robin conversion of a number that requires more than 6 decimal places to be accurately represented. This would fail without the patch. Sadly this also breaks a bunch of other tests. Some of the tests in hex_float_test use ldexp and then compare it with a value which is not the same as the one returned by ldexp but instead is the value rounded to 6 decimals. Others use values that are not evenly representable as a binary floating fraction but then happened to generate the same value when rounded to 6 decimals. Where the actual value didn’t seem to matter these have been changed with different values that can be represented as a binary fraction.
86 lines
2.5 KiB
C++
86 lines
2.5 KiB
C++
// Copyright (c) 2018 Pierre Moreau
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "gmock/gmock.h"
|
|
#include "linker_fixture.h"
|
|
|
|
namespace {
|
|
|
|
using ::testing::HasSubstr;
|
|
using PartialLinkage = spvtest::LinkerTest;
|
|
|
|
TEST_F(PartialLinkage, Allowed) {
|
|
const std::string body1 = R"(
|
|
OpCapability Linkage
|
|
OpDecorate %1 LinkageAttributes "foo" Import
|
|
OpDecorate %2 LinkageAttributes "bar" Import
|
|
%3 = OpTypeFloat 32
|
|
%1 = OpVariable %3 Uniform
|
|
%2 = OpVariable %3 Uniform
|
|
)";
|
|
const std::string body2 = R"(
|
|
OpCapability Linkage
|
|
OpDecorate %1 LinkageAttributes "bar" Export
|
|
%2 = OpTypeFloat 32
|
|
%3 = OpConstant %2 3.1415
|
|
%1 = OpVariable %2 Uniform %3
|
|
)";
|
|
|
|
spvtest::Binary linked_binary;
|
|
spvtools::LinkerOptions linker_options;
|
|
linker_options.SetAllowPartialLinkage(true);
|
|
ASSERT_EQ(SPV_SUCCESS,
|
|
AssembleAndLink({body1, body2}, &linked_binary, linker_options));
|
|
|
|
const std::string expected_res = R"(OpCapability Linkage
|
|
OpModuleProcessed "Linked by SPIR-V Tools Linker"
|
|
OpDecorate %1 LinkageAttributes "foo" Import
|
|
%2 = OpTypeFloat 32
|
|
%1 = OpVariable %2 Uniform
|
|
%3 = OpConstant %2 3.1415
|
|
%4 = OpVariable %2 Uniform %3
|
|
)";
|
|
std::string res_body;
|
|
SetDisassembleOptions(SPV_BINARY_TO_TEXT_OPTION_NO_HEADER);
|
|
ASSERT_EQ(SPV_SUCCESS, Disassemble(linked_binary, &res_body))
|
|
<< GetErrorMessage();
|
|
EXPECT_EQ(expected_res, res_body);
|
|
}
|
|
|
|
TEST_F(PartialLinkage, Disallowed) {
|
|
const std::string body1 = R"(
|
|
OpCapability Linkage
|
|
OpDecorate %1 LinkageAttributes "foo" Import
|
|
OpDecorate %2 LinkageAttributes "bar" Import
|
|
%3 = OpTypeFloat 32
|
|
%1 = OpVariable %3 Uniform
|
|
%2 = OpVariable %3 Uniform
|
|
)";
|
|
const std::string body2 = R"(
|
|
OpCapability Linkage
|
|
OpDecorate %1 LinkageAttributes "bar" Export
|
|
%2 = OpTypeFloat 32
|
|
%3 = OpConstant %2 3.1415
|
|
%1 = OpVariable %2 Uniform %3
|
|
)";
|
|
|
|
spvtest::Binary linked_binary;
|
|
EXPECT_EQ(SPV_ERROR_INVALID_BINARY,
|
|
AssembleAndLink({body1, body2}, &linked_binary));
|
|
EXPECT_THAT(GetErrorMessage(),
|
|
HasSubstr("Unresolved external reference to \"foo\"."));
|
|
}
|
|
|
|
} // anonymous namespace
|