mirror of
https://github.com/KhronosGroup/SPIRV-Tools
synced 2024-11-23 04:00:05 +00:00
fd3cabd8b5
spvtools::fuzz::MakeIdUseDescriptorFromUse asserts if the id use type is SPV_OPERAND_TYPE_ID. The problem is that not all id types are covered by this condition. The bug was found because the first operand of an OpControlBarrier instruction has SPV_OPERAND_TYPE_SCOPE_ID as type. Therefore, to cover all cases the spvIsInIdType function is used. Fixes #3665.
63 lines
2.1 KiB
C++
63 lines
2.1 KiB
C++
// Copyright (c) 2019 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "source/fuzz/id_use_descriptor.h"
|
|
|
|
#include "source/fuzz/instruction_descriptor.h"
|
|
|
|
namespace spvtools {
|
|
namespace fuzz {
|
|
|
|
opt::Instruction* FindInstructionContainingUse(
|
|
const protobufs::IdUseDescriptor& id_use_descriptor,
|
|
opt::IRContext* context) {
|
|
auto result =
|
|
FindInstruction(id_use_descriptor.enclosing_instruction(), context);
|
|
if (!result) {
|
|
return nullptr;
|
|
}
|
|
if (id_use_descriptor.in_operand_index() >= result->NumInOperands()) {
|
|
return nullptr;
|
|
}
|
|
if (result->GetSingleWordInOperand(id_use_descriptor.in_operand_index()) !=
|
|
id_use_descriptor.id_of_interest()) {
|
|
return nullptr;
|
|
}
|
|
return result;
|
|
}
|
|
|
|
protobufs::IdUseDescriptor MakeIdUseDescriptor(
|
|
uint32_t id_of_interest,
|
|
const protobufs::InstructionDescriptor& enclosing_instruction,
|
|
uint32_t in_operand_index) {
|
|
protobufs::IdUseDescriptor result;
|
|
result.set_id_of_interest(id_of_interest);
|
|
*result.mutable_enclosing_instruction() = enclosing_instruction;
|
|
result.set_in_operand_index(in_operand_index);
|
|
return result;
|
|
}
|
|
|
|
protobufs::IdUseDescriptor MakeIdUseDescriptorFromUse(
|
|
opt::IRContext* context, opt::Instruction* inst,
|
|
uint32_t in_operand_index) {
|
|
const auto& in_operand = inst->GetInOperand(in_operand_index);
|
|
assert(spvIsInIdType(in_operand.type));
|
|
return MakeIdUseDescriptor(in_operand.words[0],
|
|
MakeInstructionDescriptor(context, inst),
|
|
in_operand_index);
|
|
}
|
|
|
|
} // namespace fuzz
|
|
} // namespace spvtools
|