diff --git a/include/fmt/core.h b/include/fmt/core.h index 8f388f55..9e744cae 100644 --- a/include/fmt/core.h +++ b/include/fmt/core.h @@ -835,8 +835,8 @@ inline init, string_type> make_value(const T& val) { return basic_string_view(val); } -// Implicit conversion to std::string is not handled here because it's -// unsafe: https://github.com/fmtlib/fmt/issues/729 +// Implicit conversion to std::string is disallowed because it would be unsafe: +// https://github.com/fmtlib/fmt/issues/729 template < typename C, typename T, typename Char = typename C::char_type, typename U = typename std::remove_volatile::type, @@ -861,8 +861,7 @@ template ::value)> FMT_CONSTEXPR11 init, string_type> make_value(const S& val) { // Handle adapted strings. - static_assert(std::is_same::type>::value, + static_assert(std::is_same>::value, "mismatch between char-types of context and argument"); return to_string_view(val); }