AuroraMiddleware/fmtlegacy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix minor clang-tidy warnings

Browse Source 
using instead of typedef.

climits instead of limits.h

Added missing cast to size_t.
This commit is contained in:
Rosen Penev 2019-08-29 11:23:14 -07:00 committed by Victor Zverovich
parent bcd9b9331a
commit 200ee6f108
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/fmt/format-inl.h
View File

@ -698,7 +698,7 @@ FMT_API bool grisu_format(Double value, buffer<char>& buf, int precision,
buf.push_back('0'); buf.push_back('0');
} else { } else {
exp = -precision; exp = -precision;
buf.resize(precision); buf.resize(to_unsigned(precision));
std::uninitialized_fill_n(buf.data(), precision, '0'); std::uninitialized_fill_n(buf.data(), precision, '0');
} }
return true; return true;

8
src/posix.cc
View File

@ -12,7 +12,7 @@
#include "fmt/posix.h" #include "fmt/posix.h"
#include <limits.h> #include <climits>
#include <sys/stat.h> #include <sys/stat.h>
#include <sys/types.h> #include <sys/types.h>
@ -49,7 +49,7 @@
namespace { namespace {
#ifdef _WIN32 #ifdef _WIN32
// Return type of read and write functions. // Return type of read and write functions.
typedef int RWResult; using RWResult = int;
// On Windows the count argument to read and write is unsigned, so convert // On Windows the count argument to read and write is unsigned, so convert
// it from size_t preventing integer overflow. // it from size_t preventing integer overflow.
@ -58,7 +58,7 @@ inline unsigned convert_rwcount(std::size_t count) {
} }
#else #else
// Return type of read and write functions. // Return type of read and write functions.
typedef ssize_t RWResult; using RWResult = ssize_t;
inline std::size_t convert_rwcount(std::size_t count) { return count; } inline std::size_t convert_rwcount(std::size_t count) { return count; }
#endif #endif
@ -138,7 +138,7 @@ long long file::size() const {
unsigned long long long_size = size_upper; unsigned long long long_size = size_upper;
return (long_size << sizeof(DWORD) * CHAR_BIT) | size_lower; return (long_size << sizeof(DWORD) * CHAR_BIT) | size_lower;
#else #else
typedef struct stat Stat; using Stat = struct stat;
Stat file_stat = Stat(); Stat file_stat = Stat();
if (FMT_POSIX_CALL(fstat(fd_, &file_stat)) == -1) if (FMT_POSIX_CALL(fstat(fd_, &file_stat)) == -1)
FMT_THROW(system_error(errno, "cannot get file attributes")); FMT_THROW(system_error(errno, "cannot get file attributes"));