AuroraMiddleware/fmtlegacy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Test retry on EINTR in close.

Browse Source
This commit is contained in:
Victor Zverovich 2014-05-16 06:25:20 -07:00
parent 41895fdf42
commit 232e5c3a3b
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/gtest-extra.cc
View File

@ -56,7 +56,6 @@ namespace {
#ifdef _WIN32 #ifdef _WIN32
// On Windows the count argument to read and write is unsigned, so convert // On Windows the count argument to read and write is unsigned, so convert
// it from size_t preventing integer overflow. // it from size_t preventing integer overflow.
// TODO: test
inline unsigned ConvertRWCount(std::size_t count) { inline unsigned ConvertRWCount(std::size_t count) {
return count <= UINT_MAX ? static_cast<unsigned>(count) : UINT_MAX; return count <= UINT_MAX ? static_cast<unsigned>(count) : UINT_MAX;
} }

24
test/posix-test.cc
View File

@ -119,4 +119,28 @@ TEST(FileTest, OpenRetry) {
open, "cannot open file CMakeLists.txt"); open, "cannot open file CMakeLists.txt");
} }
TEST(FileTest, CloseNoRetryInDtor) {
File read_end, write_end;
File::pipe(read_end, write_end);
File *f = new File(std::move(read_end));
int saved_close_count = 0;
EXPECT_WRITE(stderr, {
close_count = 1;
delete f;
saved_close_count = close_count;
close_count = 0;
}, FormatSystemErrorMessage(EINTR, "cannot close file") + "\n");
EXPECT_EQ(2, saved_close_count);
}
TEST(FileTest, CloseNoRetry) {
File read_end, write_end;
File::pipe(read_end, write_end);
close_count = 1;
EXPECT_SYSTEM_ERROR(read_end.close(), EINTR, "cannot close file");
EXPECT_EQ(2, close_count);
close_count = 0;
}
// TODO: test retry on EINTR // TODO: test retry on EINTR
// TODO: test ConvertRWCount