AuroraMiddleware/fmtlegacy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix a warning.

Browse Source
This commit is contained in:
Victor Zverovich 2014-08-17 07:53:55 -07:00
parent 366e852f00
commit adce0245dc
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
format.cc
View File

@ -115,6 +115,25 @@ struct IsLongDouble { enum {VALUE = 0}; };
template <> template <>
struct IsLongDouble<long double> { enum {VALUE = 1}; }; struct IsLongDouble<long double> { enum {VALUE = 1}; };
// Checks if a value fits in int - used to avoid warnings about comparing
// signed and unsigned integers.
template <bool IsSigned>
struct IntChecker {
template <typename T>
static bool fits_in_int(T value) {
unsigned max = INT_MAX;
return value <= max;
}
};
template <>
struct IntChecker<true> {
template <typename T>
static bool fits_in_int(T value) {
return value >= INT_MIN && value <= INT_MAX;
}
};
const char RESET_COLOR[] = "\x1b[0m"; const char RESET_COLOR[] = "\x1b[0m";
typedef void (*FormatFunc)(fmt::Writer &, int , fmt::StringRef); typedef void (*FormatFunc)(fmt::Writer &, int , fmt::StringRef);
@ -207,7 +226,7 @@ class PrecisionHandler :
template <typename T> template <typename T>
int visit_any_int(T value) { int visit_any_int(T value) {
if (value < INT_MIN || value > INT_MAX) if (!IntChecker<std::numeric_limits<T>::is_signed>::fits_in_int(value))
throw fmt::FormatError("number is too big in format"); throw fmt::FormatError("number is too big in format");
return static_cast<int>(value); return static_cast<int>(value);
} }