AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-27 07:20:11 +00:00
Code Issues Packages Projects Releases Wiki Activity
06164c6773
glibc/support/Makefile

150 lines
3.6 KiB
Makefile
Raw Normal View History

support: Introduce new subdirectory for test infrastructure The new test driver in <support/test-driver.c> has feature parity with the old one. The main difference is that its hooking mechanism is based on functions and function pointers instead of macros. This commit also implements a new environment variable, TEST_COREDUMPS, which disables the code which disables coredumps (that is, it enables them if the invocation environment has not disabled them). <test-skeleton.c> defines wrapper functions so that it is possible to use existing macros with the new-style hook functionality. This commit changes only a few test cases to the new test driver, to make sure that it works as expected.
2016-12-09 07:18:27 +00:00
# Makefile for support library, used only at build and test time
Update copyright dates with scripts/update-copyrights.
2017-01-01 00:14:16 +00:00
# Copyright (C) 2016-2017 Free Software Foundation, Inc.
support: Introduce new subdirectory for test infrastructure The new test driver in <support/test-driver.c> has feature parity with the old one. The main difference is that its hooking mechanism is based on functions and function pointers instead of macros. This commit also implements a new environment variable, TEST_COREDUMPS, which disables the code which disables coredumps (that is, it enables them if the invocation environment has not disabled them). <test-skeleton.c> defines wrapper functions so that it is possible to use existing macros with the new-style hook functionality. This commit changes only a few test cases to the new test driver, to make sure that it works as expected.
2016-12-09 07:18:27 +00:00
# This file is part of the GNU C Library.
# The GNU C Library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
# License as published by the Free Software Foundation; either
# version 2.1 of the License, or (at your option) any later version.
# The GNU C Library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
# You should have received a copy of the GNU Lesser General Public
# License along with the GNU C Library; if not, see
# <http://www.gnu.org/licenses/>.
subdir := support
include ../Makeconfig
extra-libs := libsupport
extra-libs-others = $(extra-libs)
extra-libs-noinstall := $(extra-libs)
libsupport-routines = \
check \
resolv: Add beginnings of a libresolv test suite
2016-12-31 13:06:16 +00:00
check_addrinfo \
check_dns_packet \
check_hostent \
check_netent \
support: Introduce new subdirectory for test infrastructure The new test driver in <support/test-driver.c> has feature parity with the old one. The main difference is that its hooking mechanism is based on functions and function pointers instead of macros. This commit also implements a new environment variable, TEST_COREDUMPS, which disables the code which disables coredumps (that is, it enables them if the invocation environment has not disabled them). <test-skeleton.c> defines wrapper functions so that it is possible to use existing macros with the new-style hook functionality. This commit changes only a few test cases to the new test driver, to make sure that it works as expected.
2016-12-09 07:18:27 +00:00
delayed_exit \
ignore_stderr \
oom_error \
resolv: Add beginnings of a libresolv test suite
2016-12-31 13:06:16 +00:00
resolv_test \
support: Introduce new subdirectory for test infrastructure The new test driver in <support/test-driver.c> has feature parity with the old one. The main difference is that its hooking mechanism is based on functions and function pointers instead of macros. This commit also implements a new environment variable, TEST_COREDUMPS, which disables the code which disables coredumps (that is, it enables them if the invocation environment has not disabled them). <test-skeleton.c> defines wrapper functions so that it is possible to use existing macros with the new-style hook functionality. This commit changes only a few test cases to the new test driver, to make sure that it works as expected.
2016-12-09 07:18:27 +00:00
set_fortify_handler \
resolv: Tests for various versions of res_init
2017-06-02 13:50:36 +00:00
support-xstat \
support: Helper functions for entering namespaces
2016-12-31 17:51:07 +00:00
support_become_root \
resolv: Tests for various versions of res_init
2017-06-02 13:50:36 +00:00
support_can_chroot \
Add internal facility for dynamic array handling This is intended as a type-safe alternative to obstacks and hand-written realloc constructs. The implementation avoids writing function pointers to the heap.
2017-06-02 09:59:28 +00:00
support_capture_subprocess \
resolv: Tests for various versions of res_init
2017-06-02 13:50:36 +00:00
support_capture_subprocess_check \
support: Add support_chroot_create and support_chroot_free
2017-07-05 13:38:42 +00:00
support_chroot \
support: Helper functions for entering namespaces
2016-12-31 17:51:07 +00:00
support_enter_network_namespace \
resolv: Add beginnings of a libresolv test suite
2016-12-31 13:06:16 +00:00
support_format_address_family \
support_format_addrinfo \
support_format_dns_packet \
support_format_herrno \
support_format_hostent \
support_format_netent \
resolv: Tests for various versions of res_init
2017-06-02 13:50:36 +00:00
support_isolate_in_subprocess \
support: Add support for delayed test failure reporting The new functions support_record_failure records a test failure, but does not terminate the process. The macros TEST_VERIFY and TEST_VERIFY_EXIT check that a condition is true.
2016-12-28 12:37:18 +00:00
support_record_failure \
resolv: Add beginnings of a libresolv test suite
2016-12-31 13:06:16 +00:00
support_run_diff \
resolv: Tests for various versions of res_init
2017-06-02 13:50:36 +00:00
support_shared_allocate \
support_write_file_string \
support: Introduce new subdirectory for test infrastructure The new test driver in <support/test-driver.c> has feature parity with the old one. The main difference is that its hooking mechanism is based on functions and function pointers instead of macros. This commit also implements a new environment variable, TEST_COREDUMPS, which disables the code which disables coredumps (that is, it enables them if the invocation environment has not disabled them). <test-skeleton.c> defines wrapper functions so that it is possible to use existing macros with the new-style hook functionality. This commit changes only a few test cases to the new test driver, to make sure that it works as expected.
2016-12-09 07:18:27 +00:00
support_test_main \
support: Add support for delayed test failure reporting The new functions support_record_failure records a test failure, but does not terminate the process. The macros TEST_VERIFY and TEST_VERIFY_EXIT check that a condition is true.
2016-12-28 12:37:18 +00:00
support_test_verify_impl \
support: Introduce new subdirectory for test infrastructure The new test driver in <support/test-driver.c> has feature parity with the old one. The main difference is that its hooking mechanism is based on functions and function pointers instead of macros. This commit also implements a new environment variable, TEST_COREDUMPS, which disables the code which disables coredumps (that is, it enables them if the invocation environment has not disabled them). <test-skeleton.c> defines wrapper functions so that it is possible to use existing macros with the new-style hook functionality. This commit changes only a few test cases to the new test driver, to make sure that it works as expected.
2016-12-09 07:18:27 +00:00
temp_file \
write_message \
resolv: Add beginnings of a libresolv test suite
2016-12-31 13:06:16 +00:00
xaccept \
Assume that accept4 is always available and works Simplify the Linux accept4 implementation based on the assumption that it is available in some way. __ASSUME_ACCEPT4_SOCKETCALL was previously unused, so remove it. For ia64, the accept4 system call (and socket call) were backported in kernel version 3.2.18. Reflect this in the installation instructions.
2017-04-19 05:44:48 +00:00
xaccept4 \
support: Introduce new subdirectory for test infrastructure The new test driver in <support/test-driver.c> has feature parity with the old one. The main difference is that its hooking mechanism is based on functions and function pointers instead of macros. This commit also implements a new environment variable, TEST_COREDUMPS, which disables the code which disables coredumps (that is, it enables them if the invocation environment has not disabled them). <test-skeleton.c> defines wrapper functions so that it is possible to use existing macros with the new-style hook functionality. This commit changes only a few test cases to the new test driver, to make sure that it works as expected.
2016-12-09 07:18:27 +00:00
xasprintf \
resolv: Add beginnings of a libresolv test suite
2016-12-31 13:06:16 +00:00
xbind \
support: Introduce new subdirectory for test infrastructure The new test driver in <support/test-driver.c> has feature parity with the old one. The main difference is that its hooking mechanism is based on functions and function pointers instead of macros. This commit also implements a new environment variable, TEST_COREDUMPS, which disables the code which disables coredumps (that is, it enables them if the invocation environment has not disabled them). <test-skeleton.c> defines wrapper functions so that it is possible to use existing macros with the new-style hook functionality. This commit changes only a few test cases to the new test driver, to make sure that it works as expected.
2016-12-09 07:18:27 +00:00
xcalloc \
resolv: Tests for various versions of res_init
2017-06-02 13:50:36 +00:00
xchroot \
support: Add error checking to close system calls [BZ #21244]
2017-03-15 12:13:58 +00:00
xclose \
resolv: Add beginnings of a libresolv test suite
2016-12-31 13:06:16 +00:00
xconnect \
Add internal facility for dynamic array handling This is intended as a type-safe alternative to obstacks and hand-written realloc constructs. The implementation avoids writing function pointers to the heap.
2017-06-02 09:59:28 +00:00
xdup2 \
resolv: Add beginnings of a libresolv test suite
2016-12-31 13:06:16 +00:00
xfclose \
xfopen \
support: Add support for delayed test failure reporting The new functions support_record_failure records a test failure, but does not terminate the process. The macros TEST_VERIFY and TEST_VERIFY_EXIT check that a condition is true.
2016-12-28 12:37:18 +00:00
xfork \
resolv: Add beginnings of a libresolv test suite
2016-12-31 13:06:16 +00:00
xgetsockname \
xlisten \
support: Introduce new subdirectory for test infrastructure The new test driver in <support/test-driver.c> has feature parity with the old one. The main difference is that its hooking mechanism is based on functions and function pointers instead of macros. This commit also implements a new environment variable, TEST_COREDUMPS, which disables the code which disables coredumps (that is, it enables them if the invocation environment has not disabled them). <test-skeleton.c> defines wrapper functions so that it is possible to use existing macros with the new-style hook functionality. This commit changes only a few test cases to the new test driver, to make sure that it works as expected.
2016-12-09 07:18:27 +00:00
xmalloc \
resolv: Add beginnings of a libresolv test suite
2016-12-31 13:06:16 +00:00
xmemstream \
resolv: Tests for various versions of res_init
2017-06-02 13:50:36 +00:00
xmkdir \
nptl: Add tst-robust-fork
2017-01-27 05:53:19 +00:00
xmmap \
__inet_pton_length: Implement new internal helper function
2017-06-21 11:09:08 +00:00
xmprotect \
nptl: Add tst-robust-fork
2017-01-27 05:53:19 +00:00
xmunmap \
resolv: Tests for various versions of res_init
2017-06-02 13:50:36 +00:00
xopen \
Add internal facility for dynamic array handling This is intended as a type-safe alternative to obstacks and hand-written realloc constructs. The implementation avoids writing function pointers to the heap.
2017-06-02 09:59:28 +00:00
xpipe \
resolv: Add beginnings of a libresolv test suite
2016-12-31 13:06:16 +00:00
xpoll \
Bug 20116: Fix use after free in pthread_create() The commit documents the ownership rules around 'struct pthread' and when a thread can read or write to the descriptor. With those ownership rules in place it becomes obvious that pd->stopped_start should not be touched in several of the paths during thread startup, particularly so for detached threads. In the case of detached threads, between the time the thread is created by the OS kernel and the creating thread checks pd->stopped_start, the detached thread might have already exited and the memory for pd unmapped. As a regression test we add a simple test which exercises this exact case by quickly creating detached threads with large enough stacks to ensure the thread stack cache is bypassed and the stacks are unmapped. Before the fix the testcase segfaults, after the fix it works correctly and completes without issue. For a detailed discussion see: https://www.sourceware.org/ml/libc-alpha/2017-01/msg00505.html
2017-01-29 00:13:34 +00:00
xpthread_attr_destroy \
xpthread_attr_init \
xpthread_attr_setdetachstate \
xpthread_attr_setstacksize \
nptl: Invert the mmap/mprotect logic on allocated stacks (BZ#18988) Current allocate_stack logic for create stacks is to first mmap all the required memory with the desirable memory and then mprotect the guard area with PROT_NONE if required. Although it works as expected, it pessimizes the allocation because it requires the kernel to actually increase commit charge (it counts against the available physical/swap memory available for the system). The only issue is to actually check this change since side-effects are really Linux specific and to actually account them it would require a kernel specific tests to parse the system wide information. On the kernel I checked /proc/self/statm does not show any meaningful difference for vmm and/or rss before and after thread creation. I could only see really meaningful information checking on system wide /proc/meminfo between thread creation: MemFree, MemAvailable, and Committed_AS shows large difference without the patch. I think trying to use these kind of information on a testcase is fragile. The BZ#18988 reports shows that the commit pages are easily seen with mlockall (MCL_FUTURE) (with lock all pages that become mapped in the process) however a more straighfoward testcase shows that pthread_create could be faster using this patch: -- static const int inner_count = 256; static const int outer_count = 128; static void *thread1(void *arg) { return NULL; } static void *sleeper(void *arg) { pthread_t ts[inner_count]; for (int i = 0; i < inner_count; i++) pthread_create (&ts[i], &a, thread1, NULL); for (int i = 0; i < inner_count; i++) pthread_join (ts[i], NULL); return NULL; } int main(void) { pthread_attr_init(&a); pthread_attr_setguardsize(&a, 1<<20); pthread_attr_setstacksize(&a, 1134592); pthread_t ts[outer_count]; for (int i = 0; i < outer_count; i++) pthread_create(&ts[i], &a, sleeper, NULL); for (int i = 0; i < outer_count; i++) pthread_join(ts[i], NULL); assert(r == 0); } return 0; } -- On x86_64 (4.4.0-45-generic, gcc 5.4.0) running the small benchtests I see: $ time ./test real 0m3.647s user 0m0.080s sys 0m11.836s While with the patch I see: $ time ./test real 0m0.696s user 0m0.040s sys 0m1.152s So I added a pthread_create benchtest (thread_create) which check the thread creation latency. As for the simple benchtests, I saw improvements in thread creation on all architectures I tested the change. Checked on x86_64-linux-gnu, i686-linux-gnu, aarch64-linux-gnu, arm-linux-gnueabihf, powerpc64le-linux-gnu, sparc64-linux-gnu, and sparcv9-linux-gnu. [BZ #18988] * benchtests/thread_create-inputs: New file. * benchtests/thread_create-source.c: Likewise. * support/xpthread_attr_setguardsize.c: Likewise. * support/Makefile (libsupport-routines): Add xpthread_attr_setguardsize object. * support/xthread.h: Add xpthread_attr_setguardsize prototype. * benchtests/Makefile (bench-pthread): Add thread_create. * nptl/allocatestack.c (allocate_stack): Call mmap with PROT_NONE and then mprotect the required area.
2017-01-31 20:01:59 +00:00
xpthread_attr_setguardsize \
support: Introduce new subdirectory for test infrastructure The new test driver in <support/test-driver.c> has feature parity with the old one. The main difference is that its hooking mechanism is based on functions and function pointers instead of macros. This commit also implements a new environment variable, TEST_COREDUMPS, which disables the code which disables coredumps (that is, it enables them if the invocation environment has not disabled them). <test-skeleton.c> defines wrapper functions so that it is possible to use existing macros with the new-style hook functionality. This commit changes only a few test cases to the new test driver, to make sure that it works as expected.
2016-12-09 07:18:27 +00:00
xpthread_barrier_destroy \
xpthread_barrier_init \
xpthread_barrier_wait \
xpthread_cancel \
xpthread_check_return \
xpthread_cond_wait \
xpthread_create \
xpthread_detach \
xpthread_join \
nptl: Add tst-robust-fork
2017-01-27 05:53:19 +00:00
xpthread_mutex_consistent \
xpthread_mutex_destroy \
xpthread_mutex_init \
support: Introduce new subdirectory for test infrastructure The new test driver in <support/test-driver.c> has feature parity with the old one. The main difference is that its hooking mechanism is based on functions and function pointers instead of macros. This commit also implements a new environment variable, TEST_COREDUMPS, which disables the code which disables coredumps (that is, it enables them if the invocation environment has not disabled them). <test-skeleton.c> defines wrapper functions so that it is possible to use existing macros with the new-style hook functionality. This commit changes only a few test cases to the new test driver, to make sure that it works as expected.
2016-12-09 07:18:27 +00:00
xpthread_mutex_lock \
xpthread_mutex_unlock \
nptl: Add tst-robust-fork
2017-01-27 05:53:19 +00:00
xpthread_mutexattr_destroy \
xpthread_mutexattr_init \
xpthread_mutexattr_setprotocol \
xpthread_mutexattr_setpshared \
xpthread_mutexattr_setrobust \
xpthread_mutexattr_settype \
resolv: Add beginnings of a libresolv test suite
2016-12-31 13:06:16 +00:00
xpthread_once \
support: Introduce new subdirectory for test infrastructure The new test driver in <support/test-driver.c> has feature parity with the old one. The main difference is that its hooking mechanism is based on functions and function pointers instead of macros. This commit also implements a new environment variable, TEST_COREDUMPS, which disables the code which disables coredumps (that is, it enables them if the invocation environment has not disabled them). <test-skeleton.c> defines wrapper functions so that it is possible to use existing macros with the new-style hook functionality. This commit changes only a few test cases to the new test driver, to make sure that it works as expected.
2016-12-09 07:18:27 +00:00
xpthread_sigmask \
xpthread_spin_lock \
xpthread_spin_unlock \
xrealloc \
resolv: Add beginnings of a libresolv test suite
2016-12-31 13:06:16 +00:00
xrecvfrom \
xsendto \
xsetsockopt \
support: Helper functions for entering namespaces
2016-12-31 17:51:07 +00:00
xsocket \
resolv: Add beginnings of a libresolv test suite
2016-12-31 13:06:16 +00:00
xstrdup \
support: Add support for delayed test failure reporting The new functions support_record_failure records a test failure, but does not terminate the process. The macros TEST_VERIFY and TEST_VERIFY_EXIT check that a condition is true.
2016-12-28 12:37:18 +00:00
xwaitpid \
resolv: Add beginnings of a libresolv test suite
2016-12-31 13:06:16 +00:00
xwrite \
support: Introduce new subdirectory for test infrastructure The new test driver in <support/test-driver.c> has feature parity with the old one. The main difference is that its hooking mechanism is based on functions and function pointers instead of macros. This commit also implements a new environment variable, TEST_COREDUMPS, which disables the code which disables coredumps (that is, it enables them if the invocation environment has not disabled them). <test-skeleton.c> defines wrapper functions so that it is possible to use existing macros with the new-style hook functionality. This commit changes only a few test cases to the new test driver, to make sure that it works as expected.
2016-12-09 07:18:27 +00:00
libsupport-static-only-routines := $(libsupport-routines)
# Only build one variant of the library.
libsupport-inhibit-o := .os
ifeq ($(build-shared),yes)
libsupport-inhibit-o += .o
endif
support: Add support for delayed test failure reporting The new functions support_record_failure records a test failure, but does not terminate the process. The macros TEST_VERIFY and TEST_VERIFY_EXIT check that a condition is true.
2016-12-28 12:37:18 +00:00
tests = \
README-testing \
support: Helper functions for entering namespaces
2016-12-31 17:51:07 +00:00
tst-support-namespace \
Add internal facility for dynamic array handling This is intended as a type-safe alternative to obstacks and hand-written realloc constructs. The implementation avoids writing function pointers to the heap.
2017-06-02 09:59:28 +00:00
tst-support_capture_subprocess \
support_format_dns_packet: Fix CNAME and multiple RR handling Before this change, the loop iterating over RRs in the answer section stopped at the first CNAME record, never printing them. The CNAME and PTR record contents was extracted from the wrong buffer (whole packet instead RDATA). This desynced the parsing after the first CNAME or PTR record. Also fix the AAAA record parsing by checking their sizes.
2017-03-15 11:57:12 +00:00
tst-support_format_dns_packet \
support: Add support for delayed test failure reporting The new functions support_record_failure records a test failure, but does not terminate the process. The macros TEST_VERIFY and TEST_VERIFY_EXIT check that a condition is true.
2016-12-28 12:37:18 +00:00
tst-support_record_failure \
Fix tst-support_record_failure-2 for run-built-tests = no. The support/tst-support_record_failure-2.out test attempts to run built code even if run-built-tests = no, so failing with build-many-glibcs.py for all architectures whose code cannot be run on the system running the script. This patch disables the test in that case. Tested for x86_64 (native), and for aarch64 with build-many-glibcs.py. * support/Makefile (tests-special): Make definition conditional on [$(run-built-tests) = yes]. ($(objpfx)tst-support_record_failure-2.out): Make rule conditional on [$(run-built-tests) = yes].
2016-12-30 13:01:44 +00:00
ifeq ($(run-built-tests),yes)
support: Add support for delayed test failure reporting The new functions support_record_failure records a test failure, but does not terminate the process. The macros TEST_VERIFY and TEST_VERIFY_EXIT check that a condition is true.
2016-12-28 12:37:18 +00:00
tests-special = \
$(objpfx)tst-support_record_failure-2.out
$(objpfx)tst-support_record_failure-2.out: tst-support_record_failure-2.sh \
$(objpfx)tst-support_record_failure
$(SHELL) $< $(common-objpfx) '$(test-program-prefix-before-env)' \
'$(run-program-env)' '$(test-program-prefix-after-env)' \
> $@; \
$(evaluate-test)
Fix tst-support_record_failure-2 for run-built-tests = no. The support/tst-support_record_failure-2.out test attempts to run built code even if run-built-tests = no, so failing with build-many-glibcs.py for all architectures whose code cannot be run on the system running the script. This patch disables the test in that case. Tested for x86_64 (native), and for aarch64 with build-many-glibcs.py. * support/Makefile (tests-special): Make definition conditional on [$(run-built-tests) = yes]. ($(objpfx)tst-support_record_failure-2.out): Make rule conditional on [$(run-built-tests) = yes].
2016-12-30 13:01:44 +00:00
endif
support: Introduce new subdirectory for test infrastructure The new test driver in <support/test-driver.c> has feature parity with the old one. The main difference is that its hooking mechanism is based on functions and function pointers instead of macros. This commit also implements a new environment variable, TEST_COREDUMPS, which disables the code which disables coredumps (that is, it enables them if the invocation environment has not disabled them). <test-skeleton.c> defines wrapper functions so that it is possible to use existing macros with the new-style hook functionality. This commit changes only a few test cases to the new test driver, to make sure that it works as expected.
2016-12-09 07:18:27 +00:00
support_format_dns_packet: Fix CNAME and multiple RR handling Before this change, the loop iterating over RRs in the answer section stopped at the first CNAME record, never printing them. The CNAME and PTR record contents was extracted from the wrong buffer (whole packet instead RDATA). This desynced the parsing after the first CNAME or PTR record. Also fix the AAAA record parsing by checking their sizes.
2017-03-15 11:57:12 +00:00
$(objpfx)tst-support_format_dns_packet: $(common-objpfx)resolv/libresolv.so
support: Introduce new subdirectory for test infrastructure The new test driver in <support/test-driver.c> has feature parity with the old one. The main difference is that its hooking mechanism is based on functions and function pointers instead of macros. This commit also implements a new environment variable, TEST_COREDUMPS, which disables the code which disables coredumps (that is, it enables them if the invocation environment has not disabled them). <test-skeleton.c> defines wrapper functions so that it is possible to use existing macros with the new-style hook functionality. This commit changes only a few test cases to the new test driver, to make sure that it works as expected.
2016-12-09 07:18:27 +00:00
include ../Rules
Reference in New Issue Copy Permalink