2016-09-16 20:44:50 +00:00
|
|
|
/* Check posix_spawn add file actions.
|
2020-01-01 00:14:33 +00:00
|
|
|
Copyright (C) 2016-2020 Free Software Foundation, Inc.
|
2016-09-16 20:44:50 +00:00
|
|
|
This file is part of the GNU C Library.
|
|
|
|
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
|
|
modify it under the terms of the GNU Lesser General Public
|
|
|
|
License as published by the Free Software Foundation; either
|
|
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
Lesser General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
|
|
License along with the GNU C Library; if not, see
|
Prefer https to http for gnu.org and fsf.org URLs
Also, change sources.redhat.com to sourceware.org.
This patch was automatically generated by running the following shell
script, which uses GNU sed, and which avoids modifying files imported
from upstream:
sed -ri '
s,(http|ftp)(://(.*\.)?(gnu|fsf|sourceware)\.org($|[^.]|\.[^a-z])),https\2,g
s,(http|ftp)(://(.*\.)?)sources\.redhat\.com($|[^.]|\.[^a-z]),https\2sourceware.org\4,g
' \
$(find $(git ls-files) -prune -type f \
! -name '*.po' \
! -name 'ChangeLog*' \
! -path COPYING ! -path COPYING.LIB \
! -path manual/fdl-1.3.texi ! -path manual/lgpl-2.1.texi \
! -path manual/texinfo.tex ! -path scripts/config.guess \
! -path scripts/config.sub ! -path scripts/install-sh \
! -path scripts/mkinstalldirs ! -path scripts/move-if-change \
! -path INSTALL ! -path locale/programs/charmap-kw.h \
! -path po/libc.pot ! -path sysdeps/gnu/errlist.c \
! '(' -name configure \
-execdir test -f configure.ac -o -f configure.in ';' ')' \
! '(' -name preconfigure \
-execdir test -f preconfigure.ac ';' ')' \
-print)
and then by running 'make dist-prepare' to regenerate files built
from the altered files, and then executing the following to cleanup:
chmod a+x sysdeps/unix/sysv/linux/riscv/configure
# Omit irrelevant whitespace and comment-only changes,
# perhaps from a slightly-different Autoconf version.
git checkout -f \
sysdeps/csky/configure \
sysdeps/hppa/configure \
sysdeps/riscv/configure \
sysdeps/unix/sysv/linux/csky/configure
# Omit changes that caused a pre-commit check to fail like this:
# remote: *** error: sysdeps/powerpc/powerpc64/ppc-mcount.S: trailing lines
git checkout -f \
sysdeps/powerpc/powerpc64/ppc-mcount.S \
sysdeps/unix/sysv/linux/s390/s390-64/syscall.S
# Omit change that caused a pre-commit check to fail like this:
# remote: *** error: sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S: last line does not end in newline
git checkout -f sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S
2019-09-07 05:40:42 +00:00
|
|
|
<https://www.gnu.org/licenses/>. */
|
2016-09-16 20:44:50 +00:00
|
|
|
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <spawn.h>
|
|
|
|
#include <error.h>
|
|
|
|
#include <errno.h>
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include <string.h>
|
|
|
|
#include <unistd.h>
|
|
|
|
#include <sys/wait.h>
|
|
|
|
#include <sys/resource.h>
|
2017-04-24 18:48:01 +00:00
|
|
|
#include <fcntl.h>
|
|
|
|
#include <paths.h>
|
2016-09-16 20:44:50 +00:00
|
|
|
|
2017-04-24 18:48:01 +00:00
|
|
|
#include <support/check.h>
|
|
|
|
#include <support/temp_file.h>
|
2016-09-16 20:44:50 +00:00
|
|
|
|
|
|
|
static int
|
|
|
|
do_test (void)
|
|
|
|
{
|
|
|
|
/* The test checks if posix_spawn open file action close the file descriptor
|
|
|
|
before opening a new one in case the input file descriptor is already
|
|
|
|
opened. It does by exhausting all file descriptors on the process before
|
|
|
|
issue posix_spawn. It then issues a posix_spawn for '/bin/sh echo $$'
|
|
|
|
and add two rules:
|
|
|
|
|
|
|
|
1. Redirect stdout to a temporary filepath
|
|
|
|
2. Redirect stderr to stdout
|
|
|
|
|
|
|
|
If the implementation does not close the file 1. will fail with
|
|
|
|
EMFILE. */
|
|
|
|
|
|
|
|
struct rlimit rl;
|
|
|
|
int max_fd = 24;
|
2017-04-24 18:48:01 +00:00
|
|
|
int ret;
|
2016-09-16 20:44:50 +00:00
|
|
|
|
|
|
|
/* Set maximum number of file descriptor to a low value to avoid open
|
|
|
|
too many files in environments where RLIMIT_NOFILE is large and to
|
|
|
|
limit the array size to track the opened file descriptors. */
|
|
|
|
|
|
|
|
if (getrlimit (RLIMIT_NOFILE, &rl) == -1)
|
2017-04-24 18:48:01 +00:00
|
|
|
FAIL_EXIT1 ("getrlimit (RLIMIT_NOFILE): %m");
|
2016-09-16 20:44:50 +00:00
|
|
|
|
|
|
|
max_fd = (rl.rlim_cur < max_fd ? rl.rlim_cur : max_fd);
|
|
|
|
rl.rlim_cur = max_fd;
|
|
|
|
|
|
|
|
if (setrlimit (RLIMIT_NOFILE, &rl) == 1)
|
2017-04-24 18:48:01 +00:00
|
|
|
FAIL_EXIT1 ("setrlimit (RLIMIT_NOFILE): %m");
|
2016-09-16 20:44:50 +00:00
|
|
|
|
|
|
|
/* Exhauste the file descriptor limit with temporary files. */
|
|
|
|
int files[max_fd];
|
|
|
|
int nfiles = 0;
|
|
|
|
for (;;)
|
|
|
|
{
|
|
|
|
int fd = create_temp_file ("tst-spawn3.", NULL);
|
|
|
|
if (fd == -1)
|
|
|
|
{
|
|
|
|
if (errno != EMFILE)
|
2017-04-24 18:48:01 +00:00
|
|
|
FAIL_EXIT1 ("create_temp_file: %m");
|
2016-09-16 20:44:50 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
files[nfiles++] = fd;
|
|
|
|
}
|
|
|
|
|
|
|
|
posix_spawn_file_actions_t a;
|
|
|
|
if (posix_spawn_file_actions_init (&a) != 0)
|
2017-04-24 18:48:01 +00:00
|
|
|
FAIL_EXIT1 ("posix_spawn_file_actions_init");
|
2016-09-16 20:44:50 +00:00
|
|
|
|
Fix hardcoded /tmp paths in testing (bug 13888).
As noted in bug 13888, and as I noted previously in
<https://sourceware.org/ml/libc-alpha/2000-10/msg00111.html>, various
tests used hardcoded paths in /tmp, so posing issues for simultaneous
test runs from different build directories.
This patch fixes such uses of hardcoded file names to put them in the
build directory instead (in the case of stdio-common/bug5 the file
names are changed as well, to avoid a conflict with the name bug5.out
also used for the automatic test output redirection). It also fixes
test-installation.pl likewise (that was using filenames with $$ in
them rather than strictly hardcoded names, but that's still not good
practice for temporary file naming).
Note that my list of files changed is not identical to that in bug
13888. I added tst-spawn3.c and test-installation.pl, and removed
some tests that seem to me (now) to create temporary files securely
(simply using /tmp is not itself a problem if the temporary files are
handled properly with mkstemp; I haven't checked whether those tests
used to do things insecurely). conformtest is not changed because the
makefiles always pass a --tmpdir option so the /tmp default is
irrelevant, and for the same reason there is no actual problem with
nptl/tst-umask1.c because again the makefiles always override the
default.
nptl/sockperf.c is ignored because there is no code to run it;
probably that file should actually be removed.
Some tests use the mktemp function, but I think they all use it in a
way that *is* secure (for generating names for directories / sockets /
fifos / symlinks, where the operation using the name will not follow
symlinks and so there is no potential for a symlink attack on the
account running the testsuite).
Some tests use the tmpnam function to generate temporary file names.
This is in principle insecure, but not addressed by this patch (I
consider it a separate issue from the fully hardcoded paths).
Tested for x86_64.
[BZ #13888]
* posix/Makefile (CFLAGS-tst-spawn3.c): New variable.
* posix/tst-spawn3.c (do_test): Put tst-spwan3.pid in OBJPFX, not
/tmp.
* scripts/test-installation.pl: Put temporary files in build
directory, not /tmp.
* stdio-common/Makefile (CFLAGS-bug3.c): New variable.
(CFLAGS-bug4.c): Likewise.
(CFLAGS-bug5.c): Likewise.
(CFLAGS-test-fseek.c): Likewise.
(CFLAGS-test-popen.c): Likewise.
(CFLAGS-test_rdwr.c): Likewise.
* stdio-common/bug3.c (main): Put temporary file in OBJPFX, not
/tmp.
* stdio-common/bug4.c (main): Likewise.
* stdio-common/bug5.c (main): Likewise.
* stdio-common/test-fseek.c (TESTFILE): Likewise.
* stdio-common/test-popen.c (do_test): Likewise.
* stdio-common/test_rdwr.c (main): Likewise.
2018-06-26 21:48:48 +00:00
|
|
|
/* Executes a /bin/sh echo $$ 2>&1 > ${objpfx}tst-spawn3.pid . */
|
|
|
|
const char pidfile[] = OBJPFX "tst-spawn3.pid";
|
Break some lines before not after operators.
The GNU Coding Standards specify that line breaks in expressions
should go before an operator, not after one. This patch fixes various
code to do this. It only changes code that appears to be mostly
following GNU style anyway, not files and directories with
substantially different formatting. It is not exhaustive even for
files using GNU style (for example, changes to sysdeps files are
deferred for subsequent cleanups). Some files changed are shared with
gnulib, but most are specific to glibc. Changes were made manually,
with places to change found by grep (so some cases, e.g. where the
operator was followed by a comment at end of line, are particularly
liable to have been missed by grep, but I did include cases where the
operator was followed by backslash-newline).
This patch generally does not attempt to address other coding style
issues in the expressions changed (for example, missing spaces before
'(', or lack of parentheses to ensure indentation of continuation
lines properly reflects operator precedence).
Tested for x86_64, and with build-many-glibcs.py.
* benchtests/bench-memmem.c (simple_memmem): Break lines before
rather than after operators.
* benchtests/bench-skeleton.c (TIMESPEC_AFTER): Likewise.
* crypt/md5.c (md5_finish_ctx): Likewise.
* crypt/sha256.c (__sha256_finish_ctx): Likewise.
* crypt/sha512.c (__sha512_finish_ctx): Likewise.
* elf/cache.c (load_aux_cache): Likewise.
* elf/dl-load.c (open_verify): Likewise.
* elf/get-dynamic-info.h (elf_get_dynamic_info): Likewise.
* elf/readelflib.c (process_elf_file): Likewise.
* elf/rtld.c (dl_main): Likewise.
* elf/sprof.c (generate_call_graph): Likewise.
* hurd/ctty-input.c (_hurd_ctty_input): Likewise.
* hurd/ctty-output.c (_hurd_ctty_output): Likewise.
* hurd/dtable.c (reauth_dtable): Likewise.
* hurd/getdport.c (__getdport): Likewise.
* hurd/hurd/signal.h (_hurd_interrupted_rpc_timeout): Likewise.
* hurd/hurd/sigpreempt.h (HURD_PREEMPT_SIGNAL_P): Likewise.
* hurd/hurdfault.c (_hurdsig_fault_catch_exception_raise):
Likewise.
* hurd/hurdioctl.c (fioctl): Likewise.
* hurd/hurdselect.c (_hurd_select): Likewise.
* hurd/hurdsig.c (_hurdsig_abort_rpcs): Likewise.
(STOPSIGS): Likewise.
* hurd/hurdstartup.c (_hurd_startup): Likewise.
* hurd/intr-msg.c (_hurd_intr_rpc_mach_msg): Likewise.
* hurd/lookup-retry.c (__hurd_file_name_lookup_retry): Likewise.
* hurd/msgportdemux.c (msgport_server): Likewise.
* hurd/setauth.c (_hurd_setauth): Likewise.
* include/features.h (__GLIBC_USE_DEPRECATED_SCANF): Likewise.
* libio/libioP.h [IO_DEBUG] (CHECK_FILE): Likewise.
* locale/programs/ld-ctype.c (set_class_defaults): Likewise.
* localedata/tests-mbwc/tst_swscanf.c (tst_swscanf): Likewise.
* login/tst-utmp.c (do_check): Likewise.
(simulate_login): Likewise.
* mach/lowlevellock.h (lll_lock): Likewise.
(lll_trylock): Likewise.
* math/test-fenv.c (ALL_EXC): Likewise.
* math/test-fenvinline.c (ALL_EXC): Likewise.
* misc/sys/cdefs.h (__attribute_deprecated_msg__): Likewise.
* nis/nis_call.c (__do_niscall3): Likewise.
* nis/nis_callback.c (cb_prog_1): Likewise.
* nis/nis_defaults.c (searchaccess): Likewise.
* nis/nis_findserv.c (__nis_findfastest_with_timeout): Likewise.
* nis/nis_ismember.c (internal_ismember): Likewise.
* nis/nis_local_names.c (nis_local_principal): Likewise.
* nis/nss_nis/nis-rpc.c (_nss_nis_getrpcbyname_r): Likewise.
* nis/nss_nisplus/nisplus-netgrp.c (_nss_nisplus_getnetgrent_r):
Likewise.
* nis/ypclnt.c (yp_match): Likewise.
(yp_first): Likewise.
(yp_next): Likewise.
(yp_master): Likewise.
(yp_order): Likewise.
* nscd/hstcache.c (cache_addhst): Likewise.
* nscd/initgrcache.c (addinitgroupsX): Likewise.
* nss/nss_compat/compat-pwd.c (copy_pwd_changes): Likewise.
(internal_getpwuid_r): Likewise.
* nss/nss_compat/compat-spwd.c (copy_spwd_changes): Likewise.
* posix/glob.h (__GLOB_FLAGS): Likewise.
* posix/regcomp.c (peek_token): Likewise.
(peek_token_bracket): Likewise.
(parse_expression): Likewise.
* posix/regexec.c (sift_states_iter_mb): Likewise.
(check_node_accept_bytes): Likewise.
* posix/tst-spawn3.c (do_test): Likewise.
* posix/wordexp-test.c (testit): Likewise.
* posix/wordexp.c (parse_tilde): Likewise.
(exec_comm): Likewise.
* posix/wordexp.h (__WRDE_FLAGS): Likewise.
* resource/vtimes.c (TIMEVAL_TO_VTIMES): Likewise.
* setjmp/sigjmp.c (__sigjmp_save): Likewise.
* stdio-common/printf_fp.c (__printf_fp_l): Likewise.
* stdio-common/tst-fileno.c (do_test): Likewise.
* stdio-common/vfprintf-internal.c (vfprintf): Likewise.
* stdlib/strfmon_l.c (__vstrfmon_l_internal): Likewise.
* stdlib/strtod_l.c (round_and_return): Likewise.
(____STRTOF_INTERNAL): Likewise.
* stdlib/tst-strfrom.h (TEST_STRFROM): Likewise.
* string/strcspn.c (STRCSPN): Likewise.
* string/test-memmem.c (simple_memmem): Likewise.
* termios/tcsetattr.c (tcsetattr): Likewise.
* time/alt_digit.c (_nl_parse_alt_digit): Likewise.
* time/asctime.c (asctime_internal): Likewise.
* time/strptime_l.c (__strptime_internal): Likewise.
* time/sys/time.h (timercmp): Likewise.
* time/tzfile.c (__tzfile_compute): Likewise.
2019-02-22 01:32:36 +00:00
|
|
|
if (posix_spawn_file_actions_addopen (&a, STDOUT_FILENO, pidfile, O_WRONLY
|
|
|
|
| O_CREAT | O_TRUNC, 0644) != 0)
|
2017-04-24 18:48:01 +00:00
|
|
|
FAIL_EXIT1 ("posix_spawn_file_actions_addopen");
|
2016-09-16 20:44:50 +00:00
|
|
|
|
|
|
|
if (posix_spawn_file_actions_adddup2 (&a, STDOUT_FILENO, STDERR_FILENO) != 0)
|
2017-04-24 18:48:01 +00:00
|
|
|
FAIL_EXIT1 ("posix_spawn_file_actions_adddup2");
|
2016-09-16 20:44:50 +00:00
|
|
|
|
|
|
|
/* Since execve (called by posix_spawn) might require to open files to
|
|
|
|
actually execute the shell script, setup to close the temporary file
|
|
|
|
descriptors. */
|
|
|
|
for (int i=0; i<nfiles; i++)
|
|
|
|
{
|
|
|
|
if (posix_spawn_file_actions_addclose (&a, files[i]))
|
2017-04-24 18:48:01 +00:00
|
|
|
FAIL_EXIT1 ("posix_spawn_file_actions_addclose");
|
2016-09-16 20:44:50 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
char *spawn_argv[] = { (char *) _PATH_BSHELL, (char *) "-c",
|
|
|
|
(char *) "echo $$", NULL };
|
|
|
|
pid_t pid;
|
2017-04-24 18:48:01 +00:00
|
|
|
if ((ret = posix_spawn (&pid, _PATH_BSHELL, &a, NULL, spawn_argv, NULL))
|
|
|
|
!= 0)
|
2016-09-16 20:44:50 +00:00
|
|
|
{
|
2017-04-24 18:48:01 +00:00
|
|
|
errno = ret;
|
|
|
|
FAIL_EXIT1 ("posix_spawn: %m");
|
2016-09-16 20:44:50 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
int status;
|
|
|
|
int err = waitpid (pid, &status, 0);
|
|
|
|
if (err != pid)
|
2017-04-24 18:48:01 +00:00
|
|
|
FAIL_EXIT1 ("waitpid: %m");
|
2016-09-16 20:44:50 +00:00
|
|
|
|
|
|
|
/* Close the temporary files descriptor so it can check posix_spawn
|
|
|
|
output. */
|
|
|
|
for (int i=0; i<nfiles; i++)
|
|
|
|
{
|
|
|
|
if (close (files[i]))
|
2017-04-24 18:48:01 +00:00
|
|
|
FAIL_EXIT1 ("close: %m");
|
2016-09-16 20:44:50 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
int pidfd = open (pidfile, O_RDONLY);
|
|
|
|
if (pidfd == -1)
|
2017-04-24 18:48:01 +00:00
|
|
|
FAIL_EXIT1 ("open: %m");
|
2016-09-16 20:44:50 +00:00
|
|
|
|
|
|
|
char buf[64];
|
|
|
|
ssize_t n;
|
|
|
|
if ((n = read (pidfd, buf, sizeof (buf))) < 0)
|
2017-04-24 18:48:01 +00:00
|
|
|
FAIL_EXIT1 ("read: %m");
|
2016-09-16 20:44:50 +00:00
|
|
|
|
|
|
|
unlink (pidfile);
|
|
|
|
|
|
|
|
/* We only expect to read the PID. */
|
|
|
|
char *endp;
|
|
|
|
long int rpid = strtol (buf, &endp, 10);
|
|
|
|
if (*endp != '\n')
|
2017-04-24 18:48:01 +00:00
|
|
|
FAIL_EXIT1 ("*endp != \'n\'");
|
2016-09-16 20:44:50 +00:00
|
|
|
if (endp == buf)
|
2017-04-24 18:48:01 +00:00
|
|
|
FAIL_EXIT1 ("read empty line");
|
2016-09-16 20:44:50 +00:00
|
|
|
|
|
|
|
if (rpid != pid)
|
2017-04-24 18:48:01 +00:00
|
|
|
FAIL_EXIT1 ("found \"%s\", expected pid %ld\n", buf, (long int) pid);
|
2016-09-16 20:44:50 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2017-04-24 18:48:01 +00:00
|
|
|
|
|
|
|
#include <support/test-driver.c>
|