2019-06-07 07:27:01 +00:00
|
|
|
/* Test for reading directories with getdents64.
|
2021-01-02 19:32:25 +00:00
|
|
|
Copyright (C) 2019-2021 Free Software Foundation, Inc.
|
2019-06-07 07:27:01 +00:00
|
|
|
This file is part of the GNU C Library.
|
|
|
|
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
|
|
modify it under the terms of the GNU Lesser General Public
|
|
|
|
License as published by the Free Software Foundation; either
|
|
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
Lesser General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
|
|
License along with the GNU C Library; if not, see
|
Prefer https to http for gnu.org and fsf.org URLs
Also, change sources.redhat.com to sourceware.org.
This patch was automatically generated by running the following shell
script, which uses GNU sed, and which avoids modifying files imported
from upstream:
sed -ri '
s,(http|ftp)(://(.*\.)?(gnu|fsf|sourceware)\.org($|[^.]|\.[^a-z])),https\2,g
s,(http|ftp)(://(.*\.)?)sources\.redhat\.com($|[^.]|\.[^a-z]),https\2sourceware.org\4,g
' \
$(find $(git ls-files) -prune -type f \
! -name '*.po' \
! -name 'ChangeLog*' \
! -path COPYING ! -path COPYING.LIB \
! -path manual/fdl-1.3.texi ! -path manual/lgpl-2.1.texi \
! -path manual/texinfo.tex ! -path scripts/config.guess \
! -path scripts/config.sub ! -path scripts/install-sh \
! -path scripts/mkinstalldirs ! -path scripts/move-if-change \
! -path INSTALL ! -path locale/programs/charmap-kw.h \
! -path po/libc.pot ! -path sysdeps/gnu/errlist.c \
! '(' -name configure \
-execdir test -f configure.ac -o -f configure.in ';' ')' \
! '(' -name preconfigure \
-execdir test -f preconfigure.ac ';' ')' \
-print)
and then by running 'make dist-prepare' to regenerate files built
from the altered files, and then executing the following to cleanup:
chmod a+x sysdeps/unix/sysv/linux/riscv/configure
# Omit irrelevant whitespace and comment-only changes,
# perhaps from a slightly-different Autoconf version.
git checkout -f \
sysdeps/csky/configure \
sysdeps/hppa/configure \
sysdeps/riscv/configure \
sysdeps/unix/sysv/linux/csky/configure
# Omit changes that caused a pre-commit check to fail like this:
# remote: *** error: sysdeps/powerpc/powerpc64/ppc-mcount.S: trailing lines
git checkout -f \
sysdeps/powerpc/powerpc64/ppc-mcount.S \
sysdeps/unix/sysv/linux/s390/s390-64/syscall.S
# Omit change that caused a pre-commit check to fail like this:
# remote: *** error: sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S: last line does not end in newline
git checkout -f sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S
2019-09-07 05:40:42 +00:00
|
|
|
<https://www.gnu.org/licenses/>. */
|
2019-06-07 07:27:01 +00:00
|
|
|
|
|
|
|
#include <dirent.h>
|
|
|
|
#include <errno.h>
|
|
|
|
#include <fcntl.h>
|
2019-06-27 13:08:40 +00:00
|
|
|
#include <limits.h>
|
2019-06-07 07:27:01 +00:00
|
|
|
#include <stdbool.h>
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include <string.h>
|
|
|
|
#include <support/check.h>
|
|
|
|
#include <support/support.h>
|
|
|
|
#include <support/xunistd.h>
|
2019-06-28 08:48:48 +00:00
|
|
|
#include <sys/mman.h>
|
2019-06-07 07:27:01 +00:00
|
|
|
#include <unistd.h>
|
|
|
|
|
2019-06-27 13:08:40 +00:00
|
|
|
/* Called by large_buffer_checks below. */
|
|
|
|
static void
|
|
|
|
large_buffer_check (int fd, char *large_buffer, size_t large_buffer_size)
|
|
|
|
{
|
|
|
|
xlseek (fd, 0, SEEK_SET);
|
|
|
|
ssize_t ret = getdents64 (fd, large_buffer, large_buffer_size);
|
|
|
|
if (ret < 0)
|
|
|
|
FAIL_EXIT1 ("getdents64 for buffer of %zu bytes failed: %m",
|
|
|
|
large_buffer_size);
|
|
|
|
if (ret < offsetof (struct dirent64, d_name))
|
|
|
|
FAIL_EXIT1 ("getdents64 for buffer of %zu returned small value %zd",
|
|
|
|
large_buffer_size, ret);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Bug 24740: Make sure that the system call argument is adjusted
|
|
|
|
properly for the int type. A large value should stay a large
|
|
|
|
value, and not wrap around to something small, causing the system
|
|
|
|
call to fail with EINVAL. */
|
|
|
|
static void
|
|
|
|
large_buffer_checks (int fd)
|
|
|
|
{
|
|
|
|
size_t large_buffer_size;
|
|
|
|
if (!__builtin_add_overflow (UINT_MAX, 2, &large_buffer_size))
|
|
|
|
{
|
2019-06-28 08:48:48 +00:00
|
|
|
int flags = MAP_ANONYMOUS | MAP_PRIVATE;
|
|
|
|
#ifdef MAP_NORESERVE
|
|
|
|
flags |= MAP_NORESERVE;
|
|
|
|
#endif
|
|
|
|
void *large_buffer = mmap (NULL, large_buffer_size,
|
|
|
|
PROT_READ | PROT_WRITE, flags, -1, 0);
|
|
|
|
if (large_buffer == MAP_FAILED)
|
2019-06-27 13:08:40 +00:00
|
|
|
printf ("warning: could not allocate %zu bytes of memory,"
|
|
|
|
" subtests skipped\n", large_buffer_size);
|
|
|
|
else
|
|
|
|
{
|
|
|
|
large_buffer_check (fd, large_buffer, INT_MAX);
|
|
|
|
large_buffer_check (fd, large_buffer, (size_t) INT_MAX + 1);
|
|
|
|
large_buffer_check (fd, large_buffer, (size_t) INT_MAX + 2);
|
|
|
|
large_buffer_check (fd, large_buffer, UINT_MAX);
|
|
|
|
large_buffer_check (fd, large_buffer, (size_t) UINT_MAX + 1);
|
|
|
|
large_buffer_check (fd, large_buffer, (size_t) UINT_MAX + 2);
|
2019-06-28 08:48:48 +00:00
|
|
|
xmunmap (large_buffer, large_buffer_size);
|
2019-06-27 13:08:40 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
linux: mips: Fix getdents64 fallback on mips64-n32
GCC mainline shows the following error:
../sysdeps/unix/sysv/linux/mips/mips64/getdents64.c: In function '__getdents64':
../sysdeps/unix/sysv/linux/mips/mips64/getdents64.c:121:7: error: 'memcpy' forming offset [4, 7] is out of the bounds [0, 4] [-Werror=array-bounds]
121 | memcpy (((char *) dp + offsetof (struct dirent64, d_ino)),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
122 | KDP_MEMBER (kdp, d_ino), sizeof ((struct dirent64){0}.d_ino));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../sysdeps/unix/sysv/linux/mips/mips64/getdents64.c:123:7: error: 'memcpy' forming offset [4, 7] is out of the bounds [0, 4] [-Werror=array-bounds]
123 | memcpy (((char *) dp + offsetof (struct dirent64, d_off)),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
124 | KDP_MEMBER (kdp, d_off), sizeof ((struct dirent64){0}.d_off));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The issue is due both d_ino and d_off fields for mips64-n32
kernel_dirent are 32-bits, while this is using memcpy to copy 64 bits
from it into the glibc dirent64.
The fix is to use a temporary buffer to read the correct type
from kernel_dirent.
Checked with a build-many-glibcs.py for mips64el-linux-gnu and I
also checked the tst-getdents64 on mips64el 4.1.4 kernel with
and without fallback enabled (by manually setting the
getdents64_supported).
2020-11-16 19:52:36 +00:00
|
|
|
static void
|
|
|
|
do_test_large_size (void)
|
|
|
|
{
|
|
|
|
int fd = xopen (".", O_RDONLY | O_DIRECTORY, 0);
|
|
|
|
TEST_VERIFY (fd >= 0);
|
|
|
|
large_buffer_checks (fd);
|
|
|
|
|
|
|
|
xclose (fd);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
do_test_by_size (size_t buffer_size)
|
2019-06-07 07:27:01 +00:00
|
|
|
{
|
|
|
|
/* The test compares the iteration order with readdir64. */
|
|
|
|
DIR *reference = opendir (".");
|
|
|
|
TEST_VERIFY_EXIT (reference != NULL);
|
|
|
|
|
|
|
|
int fd = xopen (".", O_RDONLY | O_DIRECTORY, 0);
|
|
|
|
TEST_VERIFY (fd >= 0);
|
|
|
|
|
|
|
|
/* Perform two passes, with a rewind operating between passes. */
|
|
|
|
for (int pass = 0; pass < 2; ++pass)
|
|
|
|
{
|
|
|
|
/* Check that we need to fill the buffer multiple times. */
|
|
|
|
int read_count = 0;
|
|
|
|
|
|
|
|
while (true)
|
|
|
|
{
|
|
|
|
/* Simple way to make sure that the memcpy below does not read
|
|
|
|
non-existing data. */
|
|
|
|
struct
|
|
|
|
{
|
linux: mips: Fix getdents64 fallback on mips64-n32
GCC mainline shows the following error:
../sysdeps/unix/sysv/linux/mips/mips64/getdents64.c: In function '__getdents64':
../sysdeps/unix/sysv/linux/mips/mips64/getdents64.c:121:7: error: 'memcpy' forming offset [4, 7] is out of the bounds [0, 4] [-Werror=array-bounds]
121 | memcpy (((char *) dp + offsetof (struct dirent64, d_ino)),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
122 | KDP_MEMBER (kdp, d_ino), sizeof ((struct dirent64){0}.d_ino));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../sysdeps/unix/sysv/linux/mips/mips64/getdents64.c:123:7: error: 'memcpy' forming offset [4, 7] is out of the bounds [0, 4] [-Werror=array-bounds]
123 | memcpy (((char *) dp + offsetof (struct dirent64, d_off)),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
124 | KDP_MEMBER (kdp, d_off), sizeof ((struct dirent64){0}.d_off));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The issue is due both d_ino and d_off fields for mips64-n32
kernel_dirent are 32-bits, while this is using memcpy to copy 64 bits
from it into the glibc dirent64.
The fix is to use a temporary buffer to read the correct type
from kernel_dirent.
Checked with a build-many-glibcs.py for mips64el-linux-gnu and I
also checked the tst-getdents64 on mips64el 4.1.4 kernel with
and without fallback enabled (by manually setting the
getdents64_supported).
2020-11-16 19:52:36 +00:00
|
|
|
char buffer[buffer_size];
|
2019-06-07 07:27:01 +00:00
|
|
|
struct dirent64 pad;
|
|
|
|
} data;
|
|
|
|
|
|
|
|
ssize_t ret = getdents64 (fd, &data.buffer, sizeof (data.buffer));
|
|
|
|
if (ret < 0)
|
|
|
|
FAIL_EXIT1 ("getdents64: %m");
|
|
|
|
if (ret == 0)
|
|
|
|
break;
|
|
|
|
++read_count;
|
|
|
|
|
|
|
|
char *current = data.buffer;
|
|
|
|
char *end = data.buffer + ret;
|
|
|
|
while (current != end)
|
|
|
|
{
|
|
|
|
struct dirent64 entry;
|
|
|
|
memcpy (&entry, current, sizeof (entry));
|
|
|
|
/* Truncate overlong strings. */
|
|
|
|
entry.d_name[sizeof (entry.d_name) - 1] = '\0';
|
|
|
|
TEST_VERIFY (strlen (entry.d_name) < sizeof (entry.d_name) - 1);
|
|
|
|
|
|
|
|
errno = 0;
|
|
|
|
struct dirent64 *refentry = readdir64 (reference);
|
|
|
|
if (refentry == NULL && errno == 0)
|
|
|
|
FAIL_EXIT1 ("readdir64 failed too early, at: %s",
|
|
|
|
entry.d_name);
|
|
|
|
else if (refentry == NULL)
|
|
|
|
FAIL_EXIT1 ("readdir64: %m");
|
|
|
|
|
|
|
|
TEST_COMPARE_STRING (entry.d_name, refentry->d_name);
|
|
|
|
TEST_COMPARE (entry.d_ino, refentry->d_ino);
|
|
|
|
TEST_COMPARE (entry.d_off, refentry->d_off);
|
|
|
|
TEST_COMPARE (entry.d_type, refentry->d_type);
|
|
|
|
|
|
|
|
/* Offset zero is reserved for the first entry. */
|
|
|
|
TEST_VERIFY (entry.d_off != 0);
|
|
|
|
|
|
|
|
TEST_VERIFY_EXIT (entry.d_reclen <= end - current);
|
|
|
|
current += entry.d_reclen;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* We expect to have reached the end of the stream. */
|
|
|
|
errno = 0;
|
|
|
|
TEST_VERIFY (readdir64 (reference) == NULL);
|
|
|
|
TEST_COMPARE (errno, 0);
|
|
|
|
|
|
|
|
/* direntries_read has been called more than once. */
|
|
|
|
TEST_VERIFY (read_count > 0);
|
|
|
|
|
|
|
|
/* Rewind both directory streams. */
|
|
|
|
xlseek (fd, 0, SEEK_SET);
|
|
|
|
rewinddir (reference);
|
|
|
|
}
|
|
|
|
|
|
|
|
xclose (fd);
|
|
|
|
closedir (reference);
|
linux: mips: Fix getdents64 fallback on mips64-n32
GCC mainline shows the following error:
../sysdeps/unix/sysv/linux/mips/mips64/getdents64.c: In function '__getdents64':
../sysdeps/unix/sysv/linux/mips/mips64/getdents64.c:121:7: error: 'memcpy' forming offset [4, 7] is out of the bounds [0, 4] [-Werror=array-bounds]
121 | memcpy (((char *) dp + offsetof (struct dirent64, d_ino)),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
122 | KDP_MEMBER (kdp, d_ino), sizeof ((struct dirent64){0}.d_ino));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../sysdeps/unix/sysv/linux/mips/mips64/getdents64.c:123:7: error: 'memcpy' forming offset [4, 7] is out of the bounds [0, 4] [-Werror=array-bounds]
123 | memcpy (((char *) dp + offsetof (struct dirent64, d_off)),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
124 | KDP_MEMBER (kdp, d_off), sizeof ((struct dirent64){0}.d_off));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The issue is due both d_ino and d_off fields for mips64-n32
kernel_dirent are 32-bits, while this is using memcpy to copy 64 bits
from it into the glibc dirent64.
The fix is to use a temporary buffer to read the correct type
from kernel_dirent.
Checked with a build-many-glibcs.py for mips64el-linux-gnu and I
also checked the tst-getdents64 on mips64el 4.1.4 kernel with
and without fallback enabled (by manually setting the
getdents64_supported).
2020-11-16 19:52:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
do_test (void)
|
|
|
|
{
|
|
|
|
do_test_by_size (512);
|
|
|
|
do_test_by_size (1024);
|
|
|
|
do_test_by_size (4096);
|
|
|
|
|
|
|
|
do_test_large_size ();
|
|
|
|
|
2019-06-07 07:27:01 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
#include <support/test-driver.c>
|