Suppress internal declarations for most of the testsuite.
This patch adds a new build module called 'testsuite'.
IS_IN (testsuite) implies _ISOMAC, as do IS_IN_build and __cplusplus
(which means several ad-hoc tests for __cplusplus can go away).
libc-symbols.h now suppresses almost all of *itself* when _ISOMAC is
defined; in particular, _ISOMAC mode does not get config.h
automatically anymore.
There are still quite a few tests that need to see internal gunk of
one variety or another. For them, we now have 'tests-internal' and
'test-internal-extras'; files in this category will still be compiled
with MODULE_NAME=nonlib, and everything proceeds as it always has.
The bulk of this patch is moving tests from 'tests' to
'tests-internal'. There is also 'tests-static-internal', which has
the same effect on files in 'tests-static', and 'modules-names-tests',
which has the *inverse* effect on files in 'modules-names' (it's
inverted because most of the things in modules-names are *not* tests).
For both of these, the file must appear in *both* the new variable and
the old one.
There is also now a special case for when libc-symbols.h is included
without MODULE_NAME being defined at all. (This happens during the
creation of libc-modules.h, and also when preprocessing Versions
files.) When this happens, IS_IN is set to be always false and
_ISOMAC is *not* defined, which was the status quo, but now it's
explicit.
The remaining changes to C source files in this patch seemed likely to
cause problems in the absence of the main change. They should be
relatively self-explanatory. In a few cases I duplicated a definition
from an internal header rather than move the test to tests-internal;
this was a judgement call each time and I'm happy to change those
however reviewers feel is more appropriate.
* Makerules: New subdir configuration variables 'tests-internal'
and 'test-internal-extras'. Test files in these categories will
still be compiled with MODULE_NAME=nonlib. Test files in the
existing categories (tests, xtests, test-srcs, test-extras) are
now compiled with MODULE_NAME=testsuite.
New subdir configuration variable 'modules-names-tests'. Files
which are in both 'modules-names' and 'modules-names-tests' will
be compiled with MODULE_NAME=testsuite instead of
MODULE_NAME=extramodules.
(gen-as-const-headers): Move to tests-internal.
(do-tests-clean, common-mostlyclean): Support tests-internal.
* Makeconfig (built-modules): Add testsuite.
* Makefile: Change libof-check-installed-headers-c and
libof-check-installed-headers-cxx to 'testsuite'.
* Rules: Likewise. Support tests-internal.
* benchtests/strcoll-inputs/filelist#en_US.UTF-8:
Remove extra-modules.mk.
* config.h.in: Don't check for __OPTIMIZE__ or __FAST_MATH__ here.
* include/libc-symbols.h: Move definitions of _GNU_SOURCE,
PASTE_NAME, PASTE_NAME1, IN_MODULE, IS_IN, and IS_IN_LIB to the
very top of the file and rationalize their order.
If MODULE_NAME is not defined at all, define IS_IN to always be
false, and don't define _ISOMAC.
If any of IS_IN (testsuite), IS_IN_build, or __cplusplus are
true, define _ISOMAC and suppress everything else in this file,
starting with the inclusion of config.h.
Do check for inappropriate definitions of __OPTIMIZE__ and
__FAST_MATH__ here, but only if _ISOMAC is not defined.
Correct some out-of-date commentary.
* include/math.h: If _ISOMAC is defined, undefine NO_LONG_DOUBLE
and _Mlong_double_ before including math.h.
* include/string.h: If _ISOMAC is defined, don't expose
_STRING_ARCH_unaligned. Move a comment to a more appropriate
location.
* include/errno.h, include/stdio.h, include/stdlib.h, include/string.h
* include/time.h, include/unistd.h, include/wchar.h: No need to
check __cplusplus nor use __BEGIN_DECLS/__END_DECLS.
* misc/sys/cdefs.h (__NTHNL): New macro.
* sysdeps/m68k/m680x0/fpu/bits/mathinline.h
(__m81_defun): Use __NTHNL to avoid errors with GCC 6.
* elf/tst-env-setuid-tunables.c: Include config.h with _LIBC
defined, for HAVE_TUNABLES.
* inet/tst-checks-posix.c: No need to define _ISOMAC.
* intl/tst-gettext2.c: Provide own definition of N_.
* math/test-signgam-finite-c99.c: No need to define _ISOMAC.
* math/test-signgam-main.c: No need to define _ISOMAC.
* stdlib/tst-strtod.c: Convert to test-driver. Split locale_test to...
* stdlib/tst-strtod1i.c: ...this new file.
* stdlib/tst-strtod5.c: Convert to test-driver and add copyright notice.
Split tests of __strtod_internal to...
* stdlib/tst-strtod5i.c: ...this new file.
* string/test-string.h: Include stdint.h. Duplicate definition of
inhibit_loop_to_libcall here (from libc-symbols.h).
* string/test-strstr.c: Provide dummy definition of
libc_hidden_builtin_def when including strstr.c.
* sysdeps/ia64/fpu/libm-symbols.h: Suppress entire file in _ISOMAC
mode; no need to test __STRICT_ANSI__ nor __cplusplus as well.
* sysdeps/x86_64/fpu/math-tests-arch.h: Include cpu-features.h.
Don't include init-arch.h.
* sysdeps/x86_64/multiarch/test-multiarch.h: Include cpu-features.h.
Don't include init-arch.h.
* elf/Makefile: Move tst-ptrguard1-static, tst-stackguard1-static,
tst-tls1-static, tst-tls2-static, tst-tls3-static, loadtest,
unload, unload2, circleload1, neededtest, neededtest2,
neededtest3, neededtest4, tst-tls1, tst-tls2, tst-tls3,
tst-tls6, tst-tls7, tst-tls8, tst-dlmopen2, tst-ptrguard1,
tst-stackguard1, tst-_dl_addr_inside_object, and all of the
ifunc tests to tests-internal.
Don't add $(modules-names) to test-extras.
* inet/Makefile: Move tst-inet6_scopeid_pton to tests-internal.
Add tst-deadline to tests-static-internal.
* malloc/Makefile: Move tst-mallocstate and tst-scratch_buffer to
tests-internal.
* misc/Makefile: Move tst-atomic and tst-atomic-long to tests-internal.
* nptl/Makefile: Move tst-typesizes, tst-rwlock19, tst-sem11,
tst-sem12, tst-sem13, tst-barrier5, tst-signal7, tst-tls3,
tst-tls3-malloc, tst-tls5, tst-stackguard1, tst-sem11-static,
tst-sem12-static, and tst-stackguard1-static to tests-internal.
Link tests-internal with libpthread also.
Don't add $(modules-names) to test-extras.
* nss/Makefile: Move tst-field to tests-internal.
* posix/Makefile: Move bug-regex5, bug-regex20, bug-regex33,
tst-rfc3484, tst-rfc3484-2, and tst-rfc3484-3 to tests-internal.
* stdlib/Makefile: Move tst-strtod1i, tst-strtod3, tst-strtod4,
tst-strtod5i, tst-tls-atexit, and tst-tls-atexit-nodelete to
tests-internal.
* sunrpc/Makefile: Move tst-svc_register to tests-internal.
* sysdeps/powerpc/Makefile: Move test-get_hwcap and
test-get_hwcap-static to tests-internal.
* sysdeps/unix/sysv/linux/Makefile: Move tst-setgetname to
tests-internal.
* sysdeps/x86_64/fpu/Makefile: Add all libmvec test modules to
modules-names-tests.
2016-11-21 01:46:30 +00:00
|
|
|
#ifndef _ISOMAC
|
2016-11-28 23:12:49 +00:00
|
|
|
# include <sysdep.h>
|
|
|
|
|
# undef ret /* get rid of the stupid "ret" macro; it breaks br.ret */
|
2012-04-17 02:02:27 +00:00
|
|
|
|
2017-11-29 17:38:35 +00:00
|
|
|
# include <libm-alias-float.h>
|
2017-11-29 01:23:23 +00:00
|
|
|
# include <libm-alias-double.h>
|
2017-11-23 23:34:54 +00:00
|
|
|
# include <libm-alias-ldouble.h>
|
Add narrowing square root functions
This patch adds the narrowing square root functions from TS 18661-1 /
TS 18661-3 / C2X to glibc's libm: fsqrt, fsqrtl, dsqrtl, f32sqrtf64,
f32sqrtf32x, f32xsqrtf64 for all configurations; f32sqrtf64x,
f32sqrtf128, f64sqrtf64x, f64sqrtf128, f32xsqrtf64x, f32xsqrtf128,
f64xsqrtf128 for configurations with _Float64x and _Float128;
__f32sqrtieee128 and __f64sqrtieee128 aliases in the powerpc64le case
(for calls to fsqrtl and dsqrtl when long double is IEEE binary128).
Corresponding tgmath.h macro support is also added.
The changes are mostly similar to those for the other narrowing
functions previously added, so the description of those generally
applies to this patch as well. However, the not-actually-narrowing
cases (where the two types involved in the function have the same
floating-point format) are aliased to sqrt, sqrtl or sqrtf128 rather
than needing a separately built not-actually-narrowing function such
as was needed for add / sub / mul / div. Thus, there is no
__nldbl_dsqrtl name for ldbl-opt because no such name was needed
(whereas the other functions needed such a name since the only other
name for that entry point was e.g. f32xaddf64, not reserved by TS
18661-1); the headers are made to arrange for sqrt to be called in
that case instead.
The DIAG_* calls in sysdeps/ieee754/soft-fp/s_dsqrtl.c are because
they were observed to be needed in GCC 7 testing of
riscv32-linux-gnu-rv32imac-ilp32. The other sysdeps/ieee754/soft-fp/
files added didn't need such DIAG_* in any configuration I tested with
build-many-glibcs.py, but if they do turn out to be needed in more
files with some other configuration / GCC version, they can always be
added there.
I reused the same test inputs in auto-libm-test-in as for
non-narrowing sqrt rather than adding extra or separate inputs for
narrowing sqrt. The tests in libm-test-narrow-sqrt.inc also follow
those for non-narrowing sqrt.
Tested as followed: natively with the full glibc testsuite for x86_64
(GCC 11, 7, 6) and x86 (GCC 11); with build-many-glibcs.py with GCC
11, 7 and 6; cross testing of math/ tests for powerpc64le, powerpc32
hard float, mips64 (all three ABIs, both hard and soft float). The
different GCC versions are to cover the different cases in tgmath.h
and tgmath.h tests properly (GCC 6 has _Float* only as typedefs in
glibc headers, GCC 7 has proper _Float* support, GCC 8 adds
__builtin_tgmath).
2021-09-10 20:56:22 +00:00
|
|
|
# include <math-narrow-alias.h>
|
2017-11-23 23:34:54 +00:00
|
|
|
|
2012-04-17 02:02:27 +00:00
|
|
|
/* Support for compatible assembler handling. */
|
|
|
|
|
|
2016-11-28 23:12:49 +00:00
|
|
|
# define ASM_SIZE_DIRECTIVE(name) .size name,.-name
|
2012-04-17 02:02:27 +00:00
|
|
|
|
2016-11-28 23:12:49 +00:00
|
|
|
# define LOCAL_LIBM_ENTRY(name) \
|
2012-04-17 02:02:27 +00:00
|
|
|
.proc name; \
|
|
|
|
|
name:
|
|
|
|
|
|
2016-11-28 23:12:49 +00:00
|
|
|
# define LOCAL_LIBM_END(name) \
|
2012-04-17 02:02:27 +00:00
|
|
|
.endp name; \
|
|
|
|
|
ASM_SIZE_DIRECTIVE(name)
|
|
|
|
|
|
|
|
|
|
|
2016-11-28 23:12:49 +00:00
|
|
|
# define RODATA .rodata
|
|
|
|
|
# define LOCAL_OBJECT_START(name) \
|
2012-04-17 02:02:27 +00:00
|
|
|
name:; \
|
2012-08-12 18:44:36 +00:00
|
|
|
.type name, @object
|
2016-11-28 23:12:49 +00:00
|
|
|
# define LOCAL_OBJECT_END(name) \
|
2012-04-17 02:02:27 +00:00
|
|
|
ASM_SIZE_DIRECTIVE(name)
|
|
|
|
|
|
2016-11-28 23:12:49 +00:00
|
|
|
# define GLOBAL_LIBM_ENTRY(name) \
|
2012-04-17 02:02:27 +00:00
|
|
|
LOCAL_LIBM_ENTRY(name); \
|
|
|
|
|
.global name
|
2016-11-28 23:12:49 +00:00
|
|
|
# define GLOBAL_LIBM_END(name) LOCAL_LIBM_END(name)
|
2012-04-17 02:02:27 +00:00
|
|
|
|
2016-11-28 23:12:49 +00:00
|
|
|
# define INTERNAL_LIBM_ENTRY(name) \
|
2012-04-17 02:02:27 +00:00
|
|
|
GLOBAL_LIBM_ENTRY(__libm_##name); \
|
|
|
|
|
.global __libm_##name
|
2016-11-28 23:12:49 +00:00
|
|
|
# define INTERNAL_LIBM_END(name) GLOBAL_LIBM_END(__libm_##name)
|
2012-04-17 02:02:27 +00:00
|
|
|
|
2016-11-28 23:12:49 +00:00
|
|
|
# define WEAK_LIBM_ENTRY(name) \
|
2012-04-17 02:02:27 +00:00
|
|
|
.align 32; \
|
|
|
|
|
LOCAL_LIBM_ENTRY(__##name); \
|
|
|
|
|
.global __##name; \
|
|
|
|
|
__##name:
|
2016-11-28 23:12:49 +00:00
|
|
|
# define WEAK_LIBM_END(name) \
|
2012-04-17 02:02:27 +00:00
|
|
|
weak_alias (__##name, name); \
|
|
|
|
|
.hidden __##name; \
|
|
|
|
|
LOCAL_LIBM_END(__##name); \
|
|
|
|
|
ASM_SIZE_DIRECTIVE(__##name); \
|
2012-08-12 18:44:36 +00:00
|
|
|
.type __##name, @function
|
2012-04-17 02:02:27 +00:00
|
|
|
|
2016-11-28 23:12:49 +00:00
|
|
|
# define GLOBAL_IEEE754_ENTRY(name) \
|
2012-04-17 02:02:27 +00:00
|
|
|
WEAK_LIBM_ENTRY(name); \
|
|
|
|
|
.global __ieee754_##name; \
|
|
|
|
|
.hidden __ieee754_##name; \
|
|
|
|
|
__ieee754_##name:
|
2016-11-28 23:12:49 +00:00
|
|
|
# define GLOBAL_IEEE754_END(name) \
|
2012-04-17 02:02:27 +00:00
|
|
|
WEAK_LIBM_END(name); \
|
|
|
|
|
ASM_SIZE_DIRECTIVE(__ieee754_##name); \
|
2012-08-12 18:44:36 +00:00
|
|
|
.type __ieee754_##name, @function
|
2012-04-17 02:02:27 +00:00
|
|
|
|
2016-11-28 23:12:49 +00:00
|
|
|
# if defined ASSEMBLER && IS_IN (libc)
|
|
|
|
|
# define __libm_error_support HIDDEN_JUMPTARGET(__libm_error_support)
|
|
|
|
|
# endif
|
2012-04-17 02:02:27 +00:00
|
|
|
#endif
|
